From: Mike Rapoport <rppt@kernel.org>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@redhat.com>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>, Zi Yan <ziy@nvidia.com>,
Juan Yescas <jyescas@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: Kconfig: Use verb *use* in plural form in description
Date: Tue, 3 Jun 2025 09:31:48 +0300 [thread overview]
Message-ID: <aD6W1JRDbUKt0m7j@kernel.org> (raw)
In-Reply-To: <20250603061303.479551-2-pmenzel@molgen.mpg.de>
On Tue, Jun 03, 2025 at 08:13:03AM +0200, Paul Menzel wrote:
> *workloads* is plural requiring the verb *use* in plural form.
>
> Fixes: e13e7922d034 ("mm: add CONFIG_PAGE_BLOCK_ORDER to select page block order")
> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
Acked-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
> ---
> Reading the sentence it feels like, something is missing before the
> *please*, but I am no native speaker.
>
> mm/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/Kconfig b/mm/Kconfig
> index f8bb8f070d0d..e3a07687ed0b 100644
> --- a/mm/Kconfig
> +++ b/mm/Kconfig
> @@ -1022,7 +1022,7 @@ config PAGE_BLOCK_ORDER
> or MAX_PAGE_ORDER.
>
> Reducing pageblock order can negatively impact THP generation
> - success rate. If your workloads uses THP heavily, please use this
> + success rate. If your workloads use THP heavily, please use this
> option with caution.
>
> Don't change if unsure.
> --
> 2.49.0
>
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2025-06-03 6:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-03 6:13 Paul Menzel
2025-06-03 6:31 ` Mike Rapoport [this message]
2025-06-03 9:31 ` Lorenzo Stoakes
2025-06-03 9:38 ` David Hildenbrand
2025-06-03 9:43 ` Lorenzo Stoakes
2025-06-03 12:13 ` Zi Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aD6W1JRDbUKt0m7j@kernel.org \
--to=rppt@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=jyescas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=pmenzel@molgen.mpg.de \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox