From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AA0CC5AE59 for ; Tue, 3 Jun 2025 05:28:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F29AF6B03A7; Tue, 3 Jun 2025 01:28:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EDA446B03A8; Tue, 3 Jun 2025 01:28:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC8416B03A9; Tue, 3 Jun 2025 01:28:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BB91A6B03A7 for ; Tue, 3 Jun 2025 01:28:25 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5B1A1C0217 for ; Tue, 3 Jun 2025 05:28:25 +0000 (UTC) X-FDA: 83512958970.03.A3DB5D7 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf20.hostedemail.com (Postfix) with ESMTP id 35B9C1C0004 for ; Tue, 3 Jun 2025 05:28:22 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=DiJwKGSJ; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Se4xwMfd; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=DiJwKGSJ; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Se4xwMfd; spf=pass (imf20.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748928503; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1hN3/bwsM+kQFOPK0LZummJGWGR9dunUQ2aWjPdto+0=; b=gYbohmcSREj1nBH1MdOyPdTCcJ8H8ip1hbH0YXNHn9wlnNf5Lnyt3ePcH9Z73YTbuLXlcD iLZHnw5yWiUC7xA9DS93Kd+LuwQO88sLRb8dnzb9rRHPByEEvaeI21j4aJh4KzhbgXXT0e wYPp8F841FGB9EfSlgBo7MuKqP57ZEk= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=DiJwKGSJ; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Se4xwMfd; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=DiJwKGSJ; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Se4xwMfd; spf=pass (imf20.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748928503; a=rsa-sha256; cv=none; b=taOFiBwFgCu6E7Nc0805ypZAkgDLxVkyj22eVl7Ql9JhjYzFG9n6vL90QknQ8XgNFIE2mi yAyyaJBk59YLN4O0pUpyJGm6s+p/4sAVjdsaQPRLOZ3h66U8lJLC5UFUYhvsTaUlgX2RtH WQ8tA2AtdHSjvam39f7ZonUKSJuPSuM= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 75CFF1F38D; Tue, 3 Jun 2025 05:28:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1748928501; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1hN3/bwsM+kQFOPK0LZummJGWGR9dunUQ2aWjPdto+0=; b=DiJwKGSJv82ZIEuOm7Wl2hUsrpFFB1xDlRMLoJ36ovUn2jqPP33MZmfWCkRqQq/osMt2gu KHMVgvgEJunf3hjSY6yo7A81r/NPNmSDuvCBcCcOqmIUDRW1RxbSVhMmvaUVMBsJGb0e/g i7uXBeOmThUuHplH00poz2/ocIa8CIE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1748928501; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1hN3/bwsM+kQFOPK0LZummJGWGR9dunUQ2aWjPdto+0=; b=Se4xwMfd/d4d8prnYYQpuLgb5JIqd7+4sM7yrMlRkcphx0sl88ZobCRPwGcTCDNYh914wC hyCxNFBw4ZcvoZCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1748928501; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1hN3/bwsM+kQFOPK0LZummJGWGR9dunUQ2aWjPdto+0=; b=DiJwKGSJv82ZIEuOm7Wl2hUsrpFFB1xDlRMLoJ36ovUn2jqPP33MZmfWCkRqQq/osMt2gu KHMVgvgEJunf3hjSY6yo7A81r/NPNmSDuvCBcCcOqmIUDRW1RxbSVhMmvaUVMBsJGb0e/g i7uXBeOmThUuHplH00poz2/ocIa8CIE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1748928501; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1hN3/bwsM+kQFOPK0LZummJGWGR9dunUQ2aWjPdto+0=; b=Se4xwMfd/d4d8prnYYQpuLgb5JIqd7+4sM7yrMlRkcphx0sl88ZobCRPwGcTCDNYh914wC hyCxNFBw4ZcvoZCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 14F0A13700; Tue, 3 Jun 2025 05:28:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 2NlIAvWHPmi9aQAAD6G6ig (envelope-from ); Tue, 03 Jun 2025 05:28:21 +0000 Date: Tue, 3 Jun 2025 07:28:15 +0200 From: Oscar Salvador To: Sidhartha Kumar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, willy@infradead.org, muchun.song@linux.dev Subject: Re: [PATCH] mm/hugetlb: convert hugetlb_change_protection() to folios Message-ID: References: <20250528192013.91130-1-sidhartha.kumar@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250528192013.91130-1-sidhartha.kumar@oracle.com> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 35B9C1C0004 X-Stat-Signature: cx9rquzc9bs19odcxz6f3of3r54qc5w3 X-Rspam-User: X-HE-Tag: 1748928502-993089 X-HE-Meta: U2FsdGVkX1/DNFDqoHwS+emTeE/sgpqRe8NFM8KSvJUTRgVlnW7VSE6/sevAg2qn8ShNJwn6+qiVugbTxnPw3gvIltNoiYE4f5meiHpuEdFUJy0Z4MNZIl3jDJRZFL12qNl1+yhUUCdBxJeAQCQvheuc7v6htW2VvZFTUNBdh76affS9qVjQXH+Ok7jNbVV1fMKlGMwhkL3obpThb8522IyFKShEAc3kBXVn8XEHowO4Ib5Js9CoJHtzoF5/horzbyU6a8eRIC8D5bz/tVn1Tnn9ZSCIY6FRifgsWARMXhDCiuSzJFYAG68T0LG96nKsWGT1iw2tku/08B15repPyTVsmGwruSR46F7jWLx+2FK1h113M4Csq52kHwK7SuSsSzLZFu68qzPHHeysmkQquSAUMglA/3ciizUFAuBDDKijLm2ONyqwTe8hqYIiB3U+/dtBmZuLJxCVBdZ/vmbW/AcSCbIYP2257/oV8c5POQMmaEJcVxRFh8IP8015UU3wqA5nCzeiWhRhoABjurx3nAsk9gTr/gHnFQHnazRdo+O0saE8VNX5aDC0pwCqsfhxI/sO/jVkmjwCJJJb/tEok8DKW3BfGL6cBBeby833pDGfXt5npg53UCW/Juf1qkwNZKxoqVfLSa1XefzFyB0sFxx+a9pjgtjhG9r4CkcU5qJhhGnHoBXFWLVd2AGGomESKo08w5s4rUmpr+CycwLQvsQwQmPV2WQbRiI3IJH4U27+8/S6MxL7gsbrqgDPeIJbgjF7EeK7xr0YWscfCUlTOTAOyZa/4HLnufpcC/cg92c0ShskRxUOHcItKTunafx603bmI0sUTr2KgSU3nYl+OTAkJcMLkDxsGzKgm04hp0RteWipkv5xfvndC7nlTsx7+1qlHi4f187sn6l1FwWkyNAbges3KZ84yhcdm29+K8hbHEEq4qNOQMLQ9WJYK2JpjTsld3fWqbmGI1E/4c5 f8+eM5Wg sechLCXR+lWBma1nu/nKueXJh9BjWaw8GjXBaPyOH4Y2maeq/12EZlRQ8/YhxjaWJy2Djx8EK5oMpgj38l2DQgDSUfQbjVsnE73NQjy+URd+XNBTTftlNBTDUhv2RiJ88hDTMcOHX253ictB0Lh9yLUfUHk1nPRCtk7m0XDsVqfP0cZSJzOzHCk3JCWDDMO2Uim4BVc2awt/OnAKkaWAQGiJq6itNATq3Yn5ZP0tFaki0BBM6XTTMX2A+SUcf3uKFN2vILhvwa52kmXHuZlIuHh2segTHseaJCFdRQ+HrRJZHdTeuTqE0SlZPHaeQk+yYcFjUECVDQpdLAq0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 28, 2025 at 03:20:13PM -0400, Sidhartha Kumar wrote: > The for loop inside hugetlb_change_protection() increments by the huge > page size: > > psize = huge_page_size(h); > for (; address < end; address += psize) > > so we are operating on the head page of the huge pages between address > and end. We can safely convert the struct page usage to struct folio. > > Signed-off-by: Sidhartha Kumar Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs