From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C33E8C5AD49 for ; Tue, 3 Jun 2025 09:14:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E0E426B03DF; Tue, 3 Jun 2025 05:14:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DBECE6B03E0; Tue, 3 Jun 2025 05:14:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CAD5B6B03E1; Tue, 3 Jun 2025 05:14:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id AAD216B03DF for ; Tue, 3 Jun 2025 05:14:22 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0095C80BC4 for ; Tue, 3 Jun 2025 09:14:21 +0000 (UTC) X-FDA: 83513528364.06.F46490E Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf18.hostedemail.com (Postfix) with ESMTP id B8B591C0004 for ; Tue, 3 Jun 2025 09:14:19 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=UaKBoU+8; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=vHCmXQgR; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=UaKBoU+8; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=vHCmXQgR; spf=pass (imf18.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748942060; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FbA0e9GDhuLELcDxxAWKeQuIzyYscoH3Gi2NgunVPl0=; b=j8hc403U+P8+ibDC53VdQQwCTGp51ZTO/6c8ZvN9hjireyhOEpHaC0F2LkOBGF+2ANWyXU YlXFRhrjejASQCk5FHaaBPkVfynB9FIBhsyJ8AS/SX45I+ey6etrrN10yIU7Dkud3P3iiw CvI+qq/04DYIReymEWKEAsLR5g7nRH8= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=UaKBoU+8; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=vHCmXQgR; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=UaKBoU+8; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=vHCmXQgR; spf=pass (imf18.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748942060; a=rsa-sha256; cv=none; b=zt0/lW8JQB4wEEHNod4B2vZWsH5CiUvNHEP5yzPhHaIKcJYf1t4BsQpFlccSoU5viMPAMk Fjv7+GX4pWERRvPdd3FWqKXbGiPF8NBv7qIXEY9MRxinegfHJfbjaLH6719JGNlj9OKJx/ 55UhRE57FMmDAN4xxIe7tv4GVpKxh2k= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BAD8221286; Tue, 3 Jun 2025 09:14:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1748942057; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FbA0e9GDhuLELcDxxAWKeQuIzyYscoH3Gi2NgunVPl0=; b=UaKBoU+8dBFAQ6ayk9+iOW4CmDj2qF7gWJMplyXNLulooxqO3Bc9EXu9XGwNH5lOnl8d00 IextmIVD3gYtXNCH5w5K5lo1WoNIAgDLDMT4zjrVjDX0IOecxN52T60Y3MhNrk1SvHU9Ca nO+RdtHWwciPjSzwZHAeyf56YSWUk3E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1748942057; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FbA0e9GDhuLELcDxxAWKeQuIzyYscoH3Gi2NgunVPl0=; b=vHCmXQgRPny02YyX1TtuchySYFIbiUdT99ZJX7CmoYpJSbBae13k6ERFPgZCq/21Nuw7Yx 3tbSTNaQmL3CuvDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1748942057; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FbA0e9GDhuLELcDxxAWKeQuIzyYscoH3Gi2NgunVPl0=; b=UaKBoU+8dBFAQ6ayk9+iOW4CmDj2qF7gWJMplyXNLulooxqO3Bc9EXu9XGwNH5lOnl8d00 IextmIVD3gYtXNCH5w5K5lo1WoNIAgDLDMT4zjrVjDX0IOecxN52T60Y3MhNrk1SvHU9Ca nO+RdtHWwciPjSzwZHAeyf56YSWUk3E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1748942057; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FbA0e9GDhuLELcDxxAWKeQuIzyYscoH3Gi2NgunVPl0=; b=vHCmXQgRPny02YyX1TtuchySYFIbiUdT99ZJX7CmoYpJSbBae13k6ERFPgZCq/21Nuw7Yx 3tbSTNaQmL3CuvDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 0D6C313A1D; Tue, 3 Jun 2025 09:14:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ixtvAOm8PmiaNwAAD6G6ig (envelope-from ); Tue, 03 Jun 2025 09:14:17 +0000 Date: Tue, 3 Jun 2025 11:14:07 +0200 From: Oscar Salvador To: Honggyu Kim Cc: Gregory Price , kernel_team@skhynix.com, Andrew Morton , David Hildenbrand , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vlastimil Babka , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Jonathan Cameron , Rakie Kim , Harry Yoo , dan.carpenter@linaro.org Subject: Re: [PATCH v3 2/3] mm,memory_hotplug: Implement numa node notifier Message-ID: References: <20250502083624.49849-1-osalvador@suse.de> <20250502083624.49849-3-osalvador@suse.de> <3ad3bcba-b8b6-4e30-8ad9-adba5761e923@sk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3ad3bcba-b8b6-4e30-8ad9-adba5761e923@sk.com> X-Rspamd-Action: no action X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: B8B591C0004 X-Stat-Signature: 13whbfyxush71okguithxc9w4fwk8kdz X-Rspam-User: X-HE-Tag: 1748942059-608882 X-HE-Meta: U2FsdGVkX1+feAAtTZ0geWVHg2X5DIgeS822R++cIpFuIF+SymKw3g3CedFN6PF6Ny06O14GtQUF5GOjcqYHYylOJ2XLwM7kQVrRC/l+Fk+ZlH1qOd0t+P4xugoq54u8eiOVPpeei1G2+WT75oNTLrHhcxapT/ia5AUvGR/kfd9x4UaBFF7QLEXo7adKi73NlHc7Pr2pXcwwfGJaPMNch087zmmLSQPsNtZ4xiTYDh/WJxmF6sLD9V/5Qt4gauJ77t+ERS0Tt+BsrhNAqo0JdaqwaPef3Ah5hKNUxeHe5P//YPRyOMDj4W042z+rmcTcmasGQaeEmHdJX7cn7u+7SGbUzhdjjc45PNFoTQ9giiibe5JFDG2Zb+pnfHtx395Ec7FgmOYndrF9YWUIONyznU6bwm+8Ogt78jf4mQin+TISy2eo4/RMHGHJwjyag48n9iSrz5hulEXHBBLlL1WgPOL3eGFZqLyXVLHe96fZuShp6OeS9TUrCQ1NkbR8Y6iQTppCzfgYeQ8II4UUNsk4Fp+LriZvWgV2H7Ybb5wFXUImZ8LTuwyzaL3vtmCmmW8R/5r6AQX98ZrAz1u8sKe7R77l4z5MXfz6JdDPRiVX6ntlTpOkHmw2t1fgG7NtzRYN90RvWgfPYyCG/1PZm65c+rJuUG9eKBS8XCOY0Pc8eKWJOW9Nujjw0Gw///2gnk0HRoiHTrtFs9GgZcNpbhGcZJARV6F18W9cOO1XMf+azB0OyJEBlHtpYzA+NLvMmTOXeI+0L1b31lS8YS20cbRxZAajPv9t/JT2qm03IO5NmHu8/SNjEWhPqCFNlsltYHbTM5XaIifBcYczgEKFUrnYGZ7iyQnE1wyxWCs1YLmV0yv+hRAVS3OR/k5oIWVzSmJExZe2ScYtdX0s1cbIozigbgf/tV0vxGF1IhJxrJGAZ3DmLIapFNW+t2vVE5xshWS0iYuuEcCyNMmx3LUKjUA /euLEzfq HI0qX3kKSaPIlJbwZlArPnsz4RkfMcEf2KRjuJQwnX0FqsjNqHfPrVamh2Ov5/U2NRxoImdJK45pENtNK69YST340/qUBqkarnjZJOKv7XsQe0eVmiQuhSc3aQwX0BWg9DC7mqYLp1QJuu3DSzKF4ANnSbLtZGomQqipr00Ale4hdipc80cKziegIwnsT4eo9InOJM6KfRliaP+RZWPTAbptLgX4j50LzhGRmMM1o1Hu9t2ZRKzxxJV07PNLplRYng/RqeiIvJJRnx7YkG2eE9L4j39dnqpvpM2lqjMfv/mUPmMCWRyD+A/YJFmKjMgRMRbC2nybteEQM1+tAEYw7fAXTjFKQaOyd3F4SU/Ucju5WXfrerSAI+hDTTEyKfj8es5lYa1Y6iEamdqHWT7tWLsmmxUd7ztwkXB36dD58FYG78Yu5f+hrhSFmng== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 28, 2025 at 11:23:53AM +0900, Honggyu Kim wrote: > The 'err' of sysfs_wi_node_add() wasn't propagated to its caller before > this change as discussed with David at the following. > https://lore.kernel.org/198f2cbe-b1cb-4239-833e-9aac33d978fa@redhat.com > > But as Gregory mentioned, we can pass 'err' now with this numa node notifier > so for this hunk, shouldn't we add the following change on top of this? > > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index 3a7717e09506..3073ebd4e7ee 100644 > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c > @@ -3792,7 +3792,7 @@ static int sysfs_wi_node_add(int nid) > static int wi_node_notifier(struct notifier_block *nb, > unsigned long action, void *data) > { > - int err; > + int err = 0; > struct node_notify *arg = data; > int nid = arg->status_change_nid; > > @@ -3811,7 +3811,7 @@ static int wi_node_notifier(struct notifier_block *nb, > break; > } > > - return NOTIFY_OK; > + return notifier_from_errno(err); I do not think so. NODE_BECAME_MEM_AWARE is already too late to react. We only tell the system that __now__ we are in this state, so there is no rollback possible from this point forward. -- Oscar Salvador SUSE Labs