From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19A6BC3DA6D for ; Tue, 20 May 2025 18:59:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A867D6B009A; Tue, 20 May 2025 14:59:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A5E786B009C; Tue, 20 May 2025 14:59:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9745B6B009D; Tue, 20 May 2025 14:59:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6E0AF6B009A for ; Tue, 20 May 2025 14:59:15 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D6A2C80EBA for ; Tue, 20 May 2025 18:59:14 +0000 (UTC) X-FDA: 83464199028.15.5841B48 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) by imf19.hostedemail.com (Postfix) with ESMTP id D87561A0005 for ; Tue, 20 May 2025 18:59:12 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HUH5Rr5r; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.43 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747767553; a=rsa-sha256; cv=none; b=uAeNUFI2CDvv4eFoiMVaxLX/B8FzEmDRW6Skkc79QnmP7DgtqFeNl8ADMHukedzXuGCpLa ZpkwUrXiZZsK/oV6lJcco9R2ywvYIpVV+K/MbcXTOl5E+I+PVmyM631kRrHPE/0iXcjE+/ axMVMB3hh1v1HnwHsbwjgGE9OVG0UOA= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HUH5Rr5r; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.43 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747767553; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AQkQjJt9kU+uPyL7lP3eEXiloE0ae6R3M6xCgJ/0rus=; b=O6YS6P8ixLBTjnmOfgunx8jZ2keneSmGd6+X2/xVLCN2DELi/aDptYZq5bRRN5JNYD4Bfp /7zfh7+x6jv8+Ga+SM8cT06pkwzqlNInl0Dm+FzXIlw3wHIzAJistHnAO0HF6yrjpvRciq onOxNnZdSxQKkKjFm6wUiTKSyGuQIvk= Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-54e816aeca6so8350434e87.2 for ; Tue, 20 May 2025 11:59:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747767551; x=1748372351; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=AQkQjJt9kU+uPyL7lP3eEXiloE0ae6R3M6xCgJ/0rus=; b=HUH5Rr5r3rcDpY08q+TZS+ldnf8F+OyGHdDsEg5RBIS42QiP4OVCCS/IBFGExvNZn3 v9zWgkbodDtRQ7zf1myO209+P9dVJk1QQhwQKygmoOXr61VpdvRIp6lreR68AI6u7ebK pcgPMKKUPDj/54b1Im4BQHn5JRMmNcsIHAVF/NEIWTnWK1nl8iOfMkNvqdEgleytR++m 8wqfm8viqVQlgqszBNRTTS2W+y3FB61RqXklHwCl3NHDm5RZDSe4Y8NGCFM1LKNMfUFK jSifuYKfC0nSbK7uUaTLTn74BSyWRDDnhgat7NyYiqxgSPSOOCGWGY8MdcBi61dhxhmb 99Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747767551; x=1748372351; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AQkQjJt9kU+uPyL7lP3eEXiloE0ae6R3M6xCgJ/0rus=; b=J+9DNByYTww8QgqbqWKXnA7Lk6idud41MGgnhQ/7UYT9XlQ4KdWeEGalrlxxV9sG5e lgHxhyaa1FgbKBXtT8ni0kPobLnyb5mhhDRlHMiVzNouYqWWorAO4q+3rleytxV0EB9O q1D/ZZxQnp16F+ADKR/yrbe3+SvXongvdMFeKhzN1ECnPNE+vyCoDIr6p792kvAej6+P 2aJGsHK09zUR6Vb4t78ivax+JzVSE9QvwMAEriqc/rZQWwoQksfEeF7EidJYNSINg1FO AIphFO88/Sa2Gtmg7AiEzsj7wnGYf8LqPWs6B47c9a19nT5Vq/30PptsmnOwSEmKvGyL qXIw== X-Forwarded-Encrypted: i=1; AJvYcCUYHPFdxCVCo9Z1J8zWTnAH1OX8KvZFtj0YEtCFilWSih7/QDymeioA2YUfE9ivVW5f8mLnMlVDjg==@kvack.org X-Gm-Message-State: AOJu0Yy/OZ9pojCVbDumwW0SiOqsIifO01eFxha+GD0/CFsaW7v+svLM QB1YSQUbZqxHUTVHG1WTH91cSYoVtANQCDY9/dYWTwrQNWqbL/dz4AGO X-Gm-Gg: ASbGnctCKrh6cdAxRry93YtWdjfAlLAAteRnkJOtG6HZs4dNB7d7hVJagTYXcKQu+Ue 8aLcvOBCZPOIorc2kQxRdipVyTWMDzsCCLapOpqNjQiCuvkj0tWIg+TBEvezw31UwzXBxijRfcO YV596b3XmNzhWy5/iQVLEH+kkhN8IMiGWrMAPXpRBey32PULIbtXwJRNj4h3d16eiEUAZezRK9t bJ6SAxkReWbWQvRhXf/uYw/I3GEk462tNEZBFgSa8d68+K9uvou+69/Vqu3usa7wUuBtXiQC+fF eQQdnQ9qpncVRyoWYw== X-Google-Smtp-Source: AGHT+IG9aC8N0QQsz41YVmle4vSQ3Luf0WbY4OtJcMJGGaty6QGbyUBQVNJ+DSdkKfSdcQTc+lmpsw== X-Received: by 2002:a05:6512:460c:b0:549:8e5e:9d8e with SMTP id 2adb3069b0e04-550e70fcc0cmr4791136e87.0.1747767550611; Tue, 20 May 2025 11:59:10 -0700 (PDT) Received: from pc636 ([2001:9b1:d5a0:a500::800]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-550e703e7a6sm2481344e87.218.2025.05.20.11.59.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 May 2025 11:59:09 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 20 May 2025 20:59:08 +0200 To: Kent Overstreet Cc: Uladzislau Rezki , Shakeel Butt , Usama Arif , Andrew Morton , surenb@google.com, hannes@cmpxchg.org, vlad.wing@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH 1/2] mm: slub: allocate slab object extensions non-contiguously Message-ID: References: <20250520122547.1317050-1-usamaarif642@gmail.com> <3divtzm4iapcxwbzxlmfmg3gus75n3rqh43vkjnog456jm2k34@f3rpzvcfk3p6> <6d015d91-e74c-48b3-8bc3-480980a74f9b@gmail.com> <22oihuvcrh5sg3urocw6wbop2v5yni7zinuhywbz7glsee4yoa@gzi5v5fcggdl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: ndoandcpgc6jokani3tz1poadctq98de X-Rspam-User: X-Rspamd-Queue-Id: D87561A0005 X-Rspamd-Server: rspam06 X-HE-Tag: 1747767552-319332 X-HE-Meta: U2FsdGVkX19/Vj/nT79j4vZ37svCpX76JWwgkgo5RlAPcHk0cdDI59R9YPWiJsF7BMNBThqNucENY1JCFm1ChwUwsU1HgJsRcaylJYLbFgIkJ52wrob+hpmtGqhhoiWONSUaU3jWkoTMK4Tf/zhosBonH9LB9eQiHyOxnyuCZGk0GmST6cJcBf1CFbrfB1l7q/Sdbu0dEdvv/jIdoeMFmOfRFCFZYclq3Zy7rXTl1xtCad8/uAq96xNakPdOD9ODagudaWMvDsP2r7voY8PWIGhyU7ubpvJmN3vPSC66jAKQu/GQDafXXEPrZD1c3AV3P+llQiBLdAXaP9zh1QseH2Vu+OJY7C/yR9CXcwB7ANb/2np3SLDpu+HyVt1a+v21cgQFizWpY9s8Qa+uL3Gnscg0+Gr2YV/NorvMLVtH/8wfLuWZXZ+MQ9iaBBKSb14AqRCecvmYvr+TceEzn8uPUPV71lyyw9y1fJPuNKNwskJBJyzJvltAGPual7IruacwzklFcJeIvvrP61mdaODNDFwXSiAPBrTaubPNUdPdD1Zga26lThMraqg8uxAXLZA4MJ6Kd8+I/oHNOrMs5oWs8S4xPIQM0yN6a/I7UyQ/qdvbuO5/vOtg2hzIftiApTe5Fxx7V94udE4ZwRRLvBP1tHYxPyi1eREEoeTLZQaoSpe6JnG/NhLlvto25TCCkLyKYxRtLxIdAu5JSeEb9iQZlilSSG9si6UUi6XIHcQRJ9MltWsNAwVrwRYCl5WjDroGXZPmwyENP726ei+a0p+eunoGbHOrpwBTCxAOorohvEco0ZlcIT54jngxKnGfL8j4qIHLoBO18TtW5Owxrx4wXYerJqjlJMBn2VBuquyClmMcO2tS99OoHE6gCQtAAN1SuJ5s7r4TlKDwtYWBMntFUbqpjjL3eds0QhZcqkFv07FbO3Ko3pHn4Fn8zid4nlxrtbdT3Mm620JloqEqB7z EzVrRgyv lP4+3Ox1USsIZYwI5A9CZYgunpFiT82oznRrF67BOqWCfnE6c2s/Oii7m0Ph1xQD73NJEqJgRiWY+78mqGQh0DskMFt7ktunQfW7IUHX+gvJbCWnqoJzwsWezua52VIxTFt4y+RoQKxzMTn42iuv0OdnrOG7EWqJa0/y+vWOhM4S5hn2bp55yQ27dWs5AWPZdukXwEOaTFSJX3BW3sXjzaKemz9Q9NuBhIsqi+6/CXF9zFxENMyWugmvDmSKOuvRkLxg3MAw7V9A+87fSiCwdpLbELVVtlhlcdpyI3EE+L0ZidMJ8Egrz3bUofZY8eeeD6f+UvCDnhBxXaRw5Pen0XPpY3tjQUnRQ9/iwWe2i20vL8hWRHfPHC75A8XN192BNb/OqbLmgyGuHAxUJ/XhnPQbxbLq7TtOLUySVDYGhE2PAGD4Yi18eNPGVRzPSzMJsFjkZLRrgMq5nEXQwfXuFl45h3GO5x1BtP9SHLX445E58BgsQhxKkcZPIARwVifKhn91LOKdoTJ6yl0s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 20, 2025 at 01:58:25PM -0400, Kent Overstreet wrote: > On Tue, May 20, 2025 at 07:57:10PM +0200, Uladzislau Rezki wrote: > > On Tue, May 20, 2025 at 01:47:54PM -0400, Kent Overstreet wrote: > > > On Tue, May 20, 2025 at 07:44:49PM +0200, Uladzislau Rezki wrote: > > > > On Tue, May 20, 2025 at 10:28:06AM -0400, Kent Overstreet wrote: > > > > > On Tue, May 20, 2025 at 07:24:40AM -0700, Shakeel Butt wrote: > > > > > > On Tue, May 20, 2025 at 10:01:27AM -0400, Kent Overstreet wrote: > > > > > > > On Tue, May 20, 2025 at 02:46:14PM +0100, Usama Arif wrote: > > > > > > > > > > > > > > > > > > > > > > > > On 20/05/2025 14:44, Kent Overstreet wrote: > > > > > > > > > On Tue, May 20, 2025 at 01:25:46PM +0100, Usama Arif wrote: > > > > > > > > >> When memory allocation profiling is running on memory bound services, > > > > > > > > >> allocations greater than order 0 for slab object extensions can fail, > > > > > > > > >> for e.g. zs_handle zswap slab which will be 512 objsperslab x 16 bytes > > > > > > > > >> per slabobj_ext (order 1 allocation). Use kvcalloc to improve chances > > > > > > > > >> of the allocation being successful. > > > > > > > > >> > > > > > > > > >> Signed-off-by: Usama Arif > > > > > > > > >> Reported-by: Vlad Poenaru > > > > > > > > >> Closes: https://lore.kernel.org/all/17fab2d6-5a74-4573-bcc3-b75951508f0a@gmail.com/ > > > > > > > > >> --- > > > > > > > > >> mm/slub.c | 2 +- > > > > > > > > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > >> > > > > > > > > >> diff --git a/mm/slub.c b/mm/slub.c > > > > > > > > >> index dc9e729e1d26..bf43c403ead2 100644 > > > > > > > > >> --- a/mm/slub.c > > > > > > > > >> +++ b/mm/slub.c > > > > > > > > >> @@ -1989,7 +1989,7 @@ int alloc_slab_obj_exts(struct slab *slab, struct kmem_cache *s, > > > > > > > > >> gfp &= ~OBJCGS_CLEAR_MASK; > > > > > > > > >> /* Prevent recursive extension vector allocation */ > > > > > > > > >> gfp |= __GFP_NO_OBJ_EXT; > > > > > > > > >> - vec = kcalloc_node(objects, sizeof(struct slabobj_ext), gfp, > > > > > > > > >> + vec = kvcalloc_node(objects, sizeof(struct slabobj_ext), gfp, > > > > > > > > >> slab_nid(slab)); > > > > > > > > > > > > > > > > > > And what's the latency going to be on a vmalloc() allocation when we're > > > > > > > > > low on memory? > > > > > > > > > > > > > > > > Would it not be better to get the allocation slighly slower than to not get > > > > > > > > it at all? > > > > > > > > > > > > > > Our behaviour when thrashing sucks, we don't want to do anything to make > > > > > > > that worse. > > > > > > > > > > > > > > There's also the fact that vmalloc doesn't correctly respect gfp flags, > > > > > > > so until that gets fixed this doesn't work at all. > > > > > > > > > > > > Which gfp flags vmalloc is not respecting today? > > > > > > > > > > GFP_NOWAIT. > > > > > > > > > > As to why, you'd better ask Michal Hocko... > > > > > > > > > It is mainly due to pte_alloc_one_kernel(), it uses the GFP_KERNEL > > > > > > > > #define GFP_PGTABLE_KERNEL (GFP_KERNEL | __GFP_ZERO) > > > > > > > > to get a new pte entry. > > > > > > > > I think we can fix it. For example if we populate some region and allocate > > > > there for NOWAIT. But there are of course can be other hidden problems. > > > > > > No, PF_MEMALLOC flags allow for passing most of gfp flags for pte > > > allocation. > > > > > It is hard-coded: > > > > static inline pte_t *__pte_alloc_one_kernel_noprof(struct mm_struct *mm) > > { > > struct ptdesc *ptdesc = pagetable_alloc_noprof(GFP_PGTABLE_KERNEL & > > ~__GFP_HIGHMEM, 0); > > > > if (!ptdesc) > > return NULL; > > return ptdesc_address(ptdesc); > > } > > I suggest you read the code around PF_MEMALLOC flags. > To wrap the allocation context by the PF_MEMALLOC to prevent entering into direct reclaim and no sleeping, looks like another approach, i can think about. One concern is depleting of memory reserves. Populating PTEs would not require this but i tend to say it is ugly approach which i mentioned above. -- Uladzislau Rezki