From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA2BAC3DA6D for ; Tue, 20 May 2025 14:56:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 30FD36B009A; Tue, 20 May 2025 10:56:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E7996B009B; Tue, 20 May 2025 10:56:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 224CD6B009C; Tue, 20 May 2025 10:56:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0378B6B009A for ; Tue, 20 May 2025 10:56:04 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 9B6C0E34E4 for ; Tue, 20 May 2025 14:56:04 +0000 (UTC) X-FDA: 83463586248.11.B706319 Received: from out-185.mta0.migadu.com (out-185.mta0.migadu.com [91.218.175.185]) by imf15.hostedemail.com (Postfix) with ESMTP id AF74DA000E for ; Tue, 20 May 2025 14:56:02 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ougTOzs8; spf=pass (imf15.hostedemail.com: domain of oliver.upton@linux.dev designates 91.218.175.185 as permitted sender) smtp.mailfrom=oliver.upton@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747752963; a=rsa-sha256; cv=none; b=J89jDg3hv0GtZPFXCqFt2p42LLX5RMtZBU1br8RvsPhEZhIK1vDMRrDZXPETHJKul1tfQw aAYGxUzXJ/BQRh/K0kZPaSdnNVq6Rt5F/WDvaFlDzbsjZQdOgE6xozEkVAxcznERTk5+hF xDWcK90l16k7vuFVyJUQEAyrmq81JjY= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ougTOzs8; spf=pass (imf15.hostedemail.com: domain of oliver.upton@linux.dev designates 91.218.175.185 as permitted sender) smtp.mailfrom=oliver.upton@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747752963; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Zj+ANRRCM3elfcsUYTWPFAAqMrBVEKBDUe1b3TfKqtc=; b=6FfUOgNjOlpFGARcFmmt/XHu7h4wueqlhqDTpRyfYpC9+7DuUCYP2NM9R9erdQIHpJt/Rx 0ZknuF284TulMoj9+Bk7vdY1dVVIaIR3QE5NkXYZpwNXbUqp25f660StUUFZFLB3ChkEoY muZUIsorQ7LZdTdiIPcsdz/Eb2rWCSk= Date: Tue, 20 May 2025 07:55:22 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1747752959; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Zj+ANRRCM3elfcsUYTWPFAAqMrBVEKBDUe1b3TfKqtc=; b=ougTOzs8lk/ovza5YLoy9N0ZdDaLIty8216yrXX/PTHRFPrYWOAr39Ky7KXAitDyEwpSI7 VdxjjfIwFeqk5Ta8Zp2V99dfZWbxov+vnaXJih+KqhKG4yJlyfF5YYhmqXLQZVtbYtqcNv VuRBvCtO4RA5O6IBzs2Ndd4/VnqHjIw= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: ankita@nvidia.com Cc: jgg@nvidia.com, maz@kernel.org, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, ryan.roberts@arm.com, shahuang@redhat.com, lpieralisi@kernel.org, david@redhat.com, aniketa@nvidia.com, cjia@nvidia.com, kwankhede@nvidia.com, kjaju@nvidia.com, targupta@nvidia.com, vsethi@nvidia.com, acurrid@nvidia.com, apopple@nvidia.com, jhubbard@nvidia.com, danw@nvidia.com, zhiw@nvidia.com, mochs@nvidia.com, udhoke@nvidia.com, dnigam@nvidia.com, alex.williamson@redhat.com, sebastianene@google.com, coltonlewis@google.com, kevin.tian@intel.com, yi.l.liu@intel.com, ardb@kernel.org, akpm@linux-foundation.org, gshan@redhat.com, linux-mm@kvack.org, ddutile@redhat.com, tabba@google.com, qperret@google.com, seanjc@google.com, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, maobibo@loongson.cn Subject: Re: [PATCH v4 2/5] KVM: arm64: Make stage2_has_fwb global scope Message-ID: References: <20250518054754.5345-1-ankita@nvidia.com> <20250518054754.5345-3-ankita@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250518054754.5345-3-ankita@nvidia.com> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: AF74DA000E X-Stat-Signature: r55gf9zds6m9mgmiaw6djp459apzdeys X-HE-Tag: 1747752962-548101 X-HE-Meta: U2FsdGVkX18VlBdOOrZ8+GFlrc1PUsLim4eGHSaT9ULnqP9smZ2hZsdlbpXYqx5SiHL7JU+2xIRThASV4QVRZZvipTPuc00fd2xrtxUhnhvmRSrVFf4VEd+dJR2zilmbH6UIKRj+6u6UxmnNs2Yttd8kElBgIa+t1lpWtPcRWZmzNNzfbCOl3if1DZu9eN93IiT/eRhrMD9Ju0RHCK+2c0ZKqwjEYmEofV9htTiI+b+OawR6yLYa27jtFar/wST4lDg63wUjsl0KEfg71NDuCiGsVipaaYT3z1puHiAkk855BUftYsRgDkP0Namw6bnUFpP5l9GwUvdome4wi2cG3k0aLSvoMLd7oMvEzGiqwTJMaNuI8X/UEIzelYY7tPKuF0wiXqmKqiM4D4gOVshapmQmnxHC23BfC+hq43ybtoK7T7w9/rT/LUm4ndiZlb94ITo9H9HcAEMZW71ibPw+c8dLzgat8yxbJJsGFdhv2VSxJizy/N2pTuK8ZCiW1m9qehhBr9Sphf7uTRI6/woWPvOS5J/xdlsGJeBG/k2+/DlGtQMXnq+CENOrD3VAakWFDowhA3TycSXdmsTInp8PJvnISbCzslCCknuIZ297+Ukz1bvj4076GeQWfLxiaBXAzdX12B4tJ+2sqO0DTeQ2VzWI6/WxZ3e5PKHJEoEpqfOdPJNZyoP1c/lVta+zJukpEeWgOeUPuW+YU/4wXlK7Osg2Ll3aNPM/+RXWohQzsB9zIaZsM7xwtUAm/raYNzHuRpiCVSrO1ntANlxGSs3kZQpMrKB3FumI3DnXLLTDMA2lLlcawcV1b0EHD1Vk5XPaWcWsGvRU2UuLDD8RPJPomx9yD0ruZ5x5BbPWraosbyM/MZWBMA+kF9cV6TKPOambOnX0ITJA6X6T6gXCWqgvIt9+p9tRdTG/2PoVN9EpuPIFUm3wsd1Qwbfp1LRuqL5yYhlOGrhzft39dqTpwGs 49fhwbaP 04BkLqgy5H6WldLZFEdxPgxZ/BjbP4AbDramI/pzEEW6FKQ8n+fPRdGozmXksjkMRoBfQ3dhINZBszSNxSEtvPPlmXgacFmI8TwT8A0lrOWplpxNXSwP7vGDcVwZwGBLdRTZ01UEMMa0GVLg2HAPaTUA5RX7PInHjBs6+D4yaiWcDt1z8U1F7lbAVHWE6e7xqAQiDgukIvBWOBIGa5LerwmAhfRsT3nSM7Y8qT+QLc9hUvIcC0PJgbIUSUvYhJ/PDfcmAdaqqHuzqhgw6tWh11DVd/k5tNlzQFXf0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Ankit, On Sun, May 18, 2025 at 05:47:51AM +0000, ankita@nvidia.com wrote: > From: Ankit Agrawal > > Change the scope of stage2_has_fwb as it will be used in > broader KVM code to determine whether the FWB feature is > supported by the hardware. Please just use the cpucap directly outside of the page table code. The only non-FWB stage-2 that KVM maintains on a FEAT_S2FWB machine is for the host when using protected mode. I don't anticipate that changing any time soon. Thanks, Oliver > --- > arch/arm64/include/asm/kvm_pgtable.h | 8 ++++++++ > arch/arm64/kvm/hyp/pgtable.c | 2 +- > 2 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/include/asm/kvm_pgtable.h b/arch/arm64/include/asm/kvm_pgtable.h > index 6b9d274052c7..f21e2fae2bfe 100644 > --- a/arch/arm64/include/asm/kvm_pgtable.h > +++ b/arch/arm64/include/asm/kvm_pgtable.h > @@ -507,6 +507,14 @@ u64 kvm_pgtable_hyp_unmap(struct kvm_pgtable *pgt, u64 addr, u64 size); > */ > u64 kvm_get_vtcr(u64 mmfr0, u64 mmfr1, u32 phys_shift); > > +/** > + * stage2_has_fwb() - Determine whether FWB is supported > + * @pgt: Page-table structure initialised by kvm_pgtable_stage2_init*() > + * > + * Return: True if FWB is supported. > + */ > +bool stage2_has_fwb(struct kvm_pgtable *pgt); > + > /** > * kvm_pgtable_stage2_pgd_size() - Helper to compute size of a stage-2 PGD > * @vtcr: Content of the VTCR register. > diff --git a/arch/arm64/kvm/hyp/pgtable.c b/arch/arm64/kvm/hyp/pgtable.c > index df5cc74a7dd0..ee6b98fefd61 100644 > --- a/arch/arm64/kvm/hyp/pgtable.c > +++ b/arch/arm64/kvm/hyp/pgtable.c > @@ -637,7 +637,7 @@ u64 kvm_get_vtcr(u64 mmfr0, u64 mmfr1, u32 phys_shift) > return vtcr; > } > > -static bool stage2_has_fwb(struct kvm_pgtable *pgt) > +bool stage2_has_fwb(struct kvm_pgtable *pgt) > { > if (!cpus_have_final_cap(ARM64_HAS_STAGE2_FWB)) > return false; > -- > 2.34.1 >