From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C86F2C3ABDD for ; Tue, 20 May 2025 17:09:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2D9D86B0089; Tue, 20 May 2025 13:09:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 28A6E6B008A; Tue, 20 May 2025 13:09:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A0406B0092; Tue, 20 May 2025 13:09:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id EBFAC6B0089 for ; Tue, 20 May 2025 13:09:28 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A2BD11A0AE1 for ; Tue, 20 May 2025 17:09:28 +0000 (UTC) X-FDA: 83463922416.15.AAFA4A6 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf23.hostedemail.com (Postfix) with ESMTP id E5CE2140007 for ; Tue, 20 May 2025 17:09:26 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747760967; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+Upxs0eolX3bE6dRsPWc13CKdlnx9VgCXOXIrYLb1tE=; b=FFouCWF1asexaf274LG9by0L1qemn5e6kWLhg+/7O9SnjWZmDkGKjQsmJ5ALOVGPShnLf+ OqjqrFfyVKunik9MF3c5IPdEtbXyapH4QE01rcZgE9KR/tN9iDy1n3s5PVsuAwFtckKrST m50aXqRuV8pQ93b39bqYUGHYr2nt0iQ= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747760967; a=rsa-sha256; cv=none; b=MaBx9KEkaR4tz6iLCZDwOzfym1Cg4hDVt9ZM7Y7qEumR6AF2EcPXljXw8wNkceu0YIByBR nvN5rZktP0kzbenuuDC9XvBhcMrDcoSCrqnhUdVtI5ugEg6TlJnEh4L636JRiCrzEeO9uC FfyrXH9ZVOrApBPxEpdqsdWcFygx2GM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id AA7B15C596D; Tue, 20 May 2025 17:07:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82013C4CEE9; Tue, 20 May 2025 17:09:18 +0000 (UTC) Date: Tue, 20 May 2025 18:09:15 +0100 From: Catalin Marinas To: ankita@nvidia.com Cc: jgg@nvidia.com, maz@kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, will@kernel.org, ryan.roberts@arm.com, shahuang@redhat.com, lpieralisi@kernel.org, david@redhat.com, aniketa@nvidia.com, cjia@nvidia.com, kwankhede@nvidia.com, kjaju@nvidia.com, targupta@nvidia.com, vsethi@nvidia.com, acurrid@nvidia.com, apopple@nvidia.com, jhubbard@nvidia.com, danw@nvidia.com, zhiw@nvidia.com, mochs@nvidia.com, udhoke@nvidia.com, dnigam@nvidia.com, alex.williamson@redhat.com, sebastianene@google.com, coltonlewis@google.com, kevin.tian@intel.com, yi.l.liu@intel.com, ardb@kernel.org, akpm@linux-foundation.org, gshan@redhat.com, linux-mm@kvack.org, ddutile@redhat.com, tabba@google.com, qperret@google.com, seanjc@google.com, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, maobibo@loongson.cn Subject: Re: [PATCH v4 1/5] KVM: arm64: Block cacheable PFNMAP mapping Message-ID: References: <20250518054754.5345-1-ankita@nvidia.com> <20250518054754.5345-2-ankita@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250518054754.5345-2-ankita@nvidia.com> X-Rspam-User: X-Rspamd-Queue-Id: E5CE2140007 X-Rspamd-Server: rspam09 X-Stat-Signature: zhidtwg1iuhzzmniddfjkxf841k4hyk6 X-HE-Tag: 1747760966-165183 X-HE-Meta: U2FsdGVkX18S/OkklZNtiUysah4aBMJ76YrqSPxszObKD1HkvEghuycUehG5gYy27ZEkB3AsBfJUGF8sLk3FaSzY8NEr5bL2Gi0L/X+vMLxQLcF044FGLuRlJrijlPGIzN4MW7HDc9myrr0h412sXpxBNTT6P423pLXXt5h7emBLIy6A8T3XRULLz/GCXTbaf0wy6/vD6BT05TcJ4uDyN9a4N+TZbwIzOxt1EPCGTty/M5s3AgjnWMhbQmXMVsIwIgddUUBlnHwrTB5J27a3ZYXH6KJlJBJ8wq4v+x6mRBR0YX5Z13u7S80LCKCj6pApIXd90i32oDi0Tlq9jVMrhAWgMlRcW5a3MaR4Z1JTA4+myLMdvWD/xShqayFny3rpScbmCPpsasEyzjMkvt9Q0kcobWnfBN8+ZQaGKwrQ9bpB28qte9ffZhtJf30C2qLJ9/Aj1/YtqdTGBRokA8R6iVKYr1xqr+I4Qp+gZBI0A6BuuTYEVfMf7KIn9gKhi59rEqVkmf4jUIuK7INWV30ta0omLBZwZwqyjHSJHS4Pl2EEGKmMoRjR+TDBrYnrrEf7PYyaBjdk9YEv5mnd0Ug+V2FE3Bm/sr5mpyGD1qUodz3Ge7SMu3smBu74719isN0PRXfLFLO8tJNLj65iH0pR4ABuhWMbkY/0oWaYc2Kigj62kxC40wMT6cLDC53ZrU0oXh2TWJVk8l/w9EbjTYcd41ONxxMAJ5QL1Lr+WVwVUgqfMD8AlL0KwoRIZXn8FrFLqVAYhviwdvNu2iHmKE4w42tviZ5AK6qwhPtGZNSvbrN4liOPKXTFZPFlK1rBg2fLeoSwfExixrF1y0zigkY75qbGMxrum7NaDrXaWq1fGpHiJeoLOFIeHkRJTp0vuF5oqfViQmzoYpU5wquFh01IDWe+7b9IWUy0bcEA0r2KkGubtiQEBOi7F7GNR09Y0gDx7cSyFHvYVexX33tTAXK m4amYW4D CH0aRsN1TbDn2lmMcW1p1wDi4MiCAW0B7W4flpTRq85mZLEnMpB+Da06ms95Uhlb6F3wlMn3cDY5wXx5GHmzUZBTYUZNdm4mlK8hm/YUOSo9VcYrtrh+GA/bo2XuaV6CBg1AjGHHFL5UeXAPW+K4ihNmdDKKHU+cQmrm4HzsQ1jCBNJ8Af9Z460nVmes6+3q1n45PDCS6mOT21MQ304D3GD66aRtY0CFU7J6cq/CB+XVoKXwtgs/dhcJp1F2Pp8MYesrcI9TznhhtHRBC04MnLbTtogKrloPD7GwKh6xer1M0yjpUc69jLHJO2S3h5X58xD+8cavNoKkXJlq6AkjSu95sXJSK8B+SyMQ79Q7h9bFh1+GIv57tbfGMQQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, May 18, 2025 at 05:47:50AM +0000, ankita@nvidia.com wrote: > diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c > index 2feb6c6b63af..eaac4db61828 100644 > --- a/arch/arm64/kvm/mmu.c > +++ b/arch/arm64/kvm/mmu.c > @@ -1466,6 +1466,15 @@ static bool kvm_vma_mte_allowed(struct vm_area_struct *vma) > return vma->vm_flags & VM_MTE_ALLOWED; > } > > +/* > + * Determine the memory region cacheability from VMA's pgprot. This > + * is used to set the stage 2 PTEs. > + */ > +static unsigned long mapping_type(pgprot_t page_prot) > +{ > + return FIELD_GET(PTE_ATTRINDX_MASK, pgprot_val(page_prot)); > +} > + > static int user_mem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa, > struct kvm_s2_trans *nested, > struct kvm_memory_slot *memslot, unsigned long hva, > @@ -1612,6 +1621,10 @@ static int user_mem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa, > > vfio_allow_any_uc = vma->vm_flags & VM_ALLOW_ANY_UNCACHED; > > + if ((vma->vm_flags & VM_PFNMAP) && > + mapping_type(vma->vm_page_prot) == MT_NORMAL) > + return -EINVAL; > + > /* Don't use the VMA after the unlock -- it may have vanished */ > vma = NULL; > > @@ -2207,6 +2220,12 @@ int kvm_arch_prepare_memory_region(struct kvm *kvm, > ret = -EINVAL; > break; > } > + > + /* Cacheable PFNMAP is not allowed */ > + if (mapping_type(vma->vm_page_prot) == MT_NORMAL) { > + ret = -EINVAL; > + break; > + } Should we capture MT_NORMAL_TAGGED as well? Presumably no driver sets VM_MTE_ALLOWED but the same could be set about MT_NORMAL in the vm_page_prot. That said, we might as well invert the check, allow if MT_DEVICE_* or MT_NORMAL_NC (the latter based on VM_ALLOW_ANY_UNCACHED). -- Catalin