From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4981CC3DA6D for ; Tue, 20 May 2025 10:07:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DD7826B0095; Tue, 20 May 2025 06:07:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D87E86B0096; Tue, 20 May 2025 06:07:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C77476B0098; Tue, 20 May 2025 06:07:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A0F0B6B0095 for ; Tue, 20 May 2025 06:07:01 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2899BE4ACE for ; Tue, 20 May 2025 10:07:01 +0000 (UTC) X-FDA: 83462857842.19.9D8C66C Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf18.hostedemail.com (Postfix) with ESMTP id C99BA1C000F for ; Tue, 20 May 2025 10:06:58 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=YIS0P4dA; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Cc0pvFfw; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=aR5cvymK; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=KfKhLc5a; spf=pass (imf18.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747735619; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Tpz57TXxtU+O8+oCaPdenftOt3C5hmAKhHhmQxyyito=; b=uGPLYNOglZSsgFJcvZXo+k2aHclwEXNUGQpuLnyMSlJG7n0Q/QDWDYNTpgHm2T/fXSl7L1 dL9WLXHzNgWDjNR1vQ9AfTUULhIVOj4TCRQradwdlxl+WVbGma/4NdadsfhzhlM5x5CMON GmAaSbHEq/kda3cM+aegodfU53MyQ30= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747735619; a=rsa-sha256; cv=none; b=2jbO2TZRsT+5kUBxirSKBBPWWMdzPfTKCCtf7wd2um5y45drMfKKcioOCjw9Kg7qrGIpq3 uX3XBAug0mvPhHYr04vey511MbcWchUEL+VUevfClkt70PtPgurNAVXkeWI1vfVQCIY2IN cSUG+taoXTEyGc1cMDLhu723nEx5zHk= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=YIS0P4dA; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Cc0pvFfw; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=aR5cvymK; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=KfKhLc5a; spf=pass (imf18.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2C7A422412; Tue, 20 May 2025 10:06:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1747735617; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Tpz57TXxtU+O8+oCaPdenftOt3C5hmAKhHhmQxyyito=; b=YIS0P4dAKvX0tjphPWsDKcsfg9S77sb1CT63nHGk0DBNmV9azcxv8GbWUO86T/Nn9f6b2O yHcjTVawPLe6vi8gwGdoaUV11mPJJoIwD2Vk8r/C/15q6ATSvd4CkcD/Bhk7kRI0vu2L5G Bm6Rawy6Dr7Csxz5jg8aeLIoqA6bj0Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1747735617; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Tpz57TXxtU+O8+oCaPdenftOt3C5hmAKhHhmQxyyito=; b=Cc0pvFfwMLWc/6+hC4m9X2I09KNf5ioz61hoZfUcVoBpgkfX11EakUe6Dh4SIqiyOEOchI 9vJRx/a/x8fCJdAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1747735616; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Tpz57TXxtU+O8+oCaPdenftOt3C5hmAKhHhmQxyyito=; b=aR5cvymK2TtL7CUpCDCDaAdr2oaUxpEfj+dXsmjcWvxrVMQ9Lb+FACpReXxQsHfPpIbpyb KY5ZAcGh3Ivfn2S2NJryhBxMHjm20wGIDA2fXrlO2e21e+qy7gB2VKWVaD19VU24wt0FrB wAnFrjbchIiNS/OBPSedkkk2hLnbeYY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1747735616; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Tpz57TXxtU+O8+oCaPdenftOt3C5hmAKhHhmQxyyito=; b=KfKhLc5a/ZO5ZoJfQEP1zHU0nMzglAk5/TzEHeyumNoHkWjiXV0nuNMR/5yHYPYK6N0qvw +qGO6W0YXS7xTpAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E392113A3F; Tue, 20 May 2025 10:06:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id QbXENj9ULGj7ZAAAD6G6ig (envelope-from ); Tue, 20 May 2025 10:06:55 +0000 Date: Tue, 20 May 2025 12:06:54 +0200 From: Oscar Salvador To: Donet Tom Cc: David Hildenbrand , Andrew Morton , Mike Rapoport , Zi Yan , Ritesh Harjani , rafael@kernel.org, Danilo Krummrich , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Jonathan Cameron , Alison Schofield , Yury Norov , Dave Jiang Subject: Re: [PATCH v4 3/4] Remove register_memory_blocks_under_node() function call from register_one_node Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spamd-Bar: / X-Rspamd-Action: no action X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: C99BA1C000F X-Stat-Signature: 5ud7oac9rf1oqpfcoemn5j9m19cr8mkr X-Rspam-User: X-HE-Tag: 1747735618-169241 X-HE-Meta: U2FsdGVkX18SQWS7uTeCvwJMC90DvGHgg8s8cglnF5X94J4Nls8Vf/Nl/M67ARl4LlbX2VpEV4yOGFrZODqeKLBprR4gUQQLxJS0qIKa05HVi8Al+bL/kp93Ll9D7KPyOHa1g8mXwiY0n1fXQO5f///XvSv4Yo/vfSKf4n3PL943g7oSPjWKDC6HE1belJzvQJ86nhJI0KQ/piOPrnbEsEAVinQZlgCtSmkZosW6hN7guthkKKzIsTMZAxKhBLNc3dXsgTx3kT14tpwDUQm2+UPdQFhwVdStfyoZSUKpbszOsvOo8o86ZSHIojkiqvUB3hPQiWC+u+L8QPEtIwQQkMHEktqh/XrmdKse1rj7Nrqm/mWlD6z4B5ExrjKNvTfb/lyWlrGAeY+nrqQjC10250SutsIuUhjI7k7hT3gJldDFAR+EIJnNacR6OlGzhRiJSM7b5yX6LRwzRCNfE31telW4Qat+taA/IKdOIq/W/nQPTHKOZMuH0wrAqYVr3w/Mjn/ssPhJsuRKuu3yxrUJo1hCd6jytTw+2zyZfRvpb+UfsPHSlqJy75ywR/aSoCit2CMoZM/zEd4QdgOZqHd5mnzrS1pM98+uz0KmRYWx/3n6KBQmRE7RIeR9S7hziKxWCD264EnPkdLWZw7ETREp8RZt6paQG8+8JnziacSmh6HauymerNS1oJWvgKFDbujocL2Wkl6w1dQvmys6kk9Dnv8Vl3XxLOHp1H/oEZ/WsoKmsFSBUIuclrbS3tHEm0PIB1w7nflOOFs7S1uOc4X/QBslBMlrbqkJc9dEHiLGRklCy+UvlW1pZ5t/0kMsXthX9IdwX4IVPgTMcXmSiTsYng8L7TJxMdrXohzH6AY72WDua/wHieAOtvOhVn4fv7TOdgfr6c5S5Y3rtbEOLoYBKEMYLx/KI8icavq/4WWMHhKne4cLVQUR8zQvjuNCtC3Fmvhxvellr2drNqX+uar fxNEUZMQ XXbwpYRykApM9TqnLOEsImRVA/PlbZiEdo3EtWXaWB+twdW57bM51/YcYauXeQNB6KxO+k2bwscFg09R9UgGbeGJC7UCBWcT8VaTrvq5+8zWXyi/BplvA1Y18cTn8U5XAnKqdNKCgafpNwUmjUqEiGfZMvY7vhKOU1aTKWB5dYpLJZ3pHAgs6ZWsSQHmPCMuSFBiLJBQpI5gr0u3buK2sMJ30+g3y7cwUqjprLyvG/ixcldQvfL3AW77VsqYgJzrCKt2VvAkCNcqwG9xE2N/1ckNXJ6xmQrlYiy6LqjACoIcAYuB2eqV14FCF/QRS10PI/ET2shGYlvCMt2MKR45OOxne3SoUgezy7MjRa2UF7hIBZwYL/f6d8HwYcIXzlt7/U3/NMuX8PGdxEgRuwfCkRSWPX0v6f6xr7sDy9rXpwR0eX30NYO6mG0mBjA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 16, 2025 at 03:19:53AM -0500, Donet Tom wrote: > register_one_node() is now only called via cpu_up() → __try_online_node() > during CPU hotplug operations to online a node. At this stage, the node has > not yet had any memory added. As a result, there are no memory blocks to > walk or register, so calling register_memory_blocks_under_node() is > unnecessary. Therefore, the call to register_memory_blocks_under_node() > has been removed from register_one_node(). > > Signed-off-by: Donet Tom With the comments raised by David addressed: Acked-by: Oscar Salvador -- Oscar Salvador SUSE Labs