From: Oscar Salvador <osalvador@suse.de>
To: Donet Tom <donettom@linux.ibm.com>
Cc: David Hildenbrand <david@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mike Rapoport <rppt@kernel.org>, Zi Yan <ziy@nvidia.com>,
Ritesh Harjani <ritesh.list@gmail.com>,
rafael@kernel.org, Danilo Krummrich <dakr@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Alison Schofield <alison.schofield@intel.com>,
Yury Norov <yury.norov@gmail.com>,
Dave Jiang <dave.jiang@intel.com>
Subject: Re: [PATCH v4 3/4] Remove register_memory_blocks_under_node() function call from register_one_node
Date: Tue, 20 May 2025 12:06:54 +0200 [thread overview]
Message-ID: <aCxUPoW9J_C5_gm4@localhost.localdomain> (raw)
In-Reply-To: <e0ef6ae9348f46bcc135f0e6cb7663d763e40b72.1747376551.git.donettom@linux.ibm.com>
On Fri, May 16, 2025 at 03:19:53AM -0500, Donet Tom wrote:
> register_one_node() is now only called via cpu_up() → __try_online_node()
> during CPU hotplug operations to online a node. At this stage, the node has
> not yet had any memory added. As a result, there are no memory blocks to
> walk or register, so calling register_memory_blocks_under_node() is
> unnecessary. Therefore, the call to register_memory_blocks_under_node()
> has been removed from register_one_node().
>
> Signed-off-by: Donet Tom <donettom@linux.ibm.com>
With the comments raised by David addressed:
Acked-by: Oscar Salvador <osalvador@suse.de>
--
Oscar Salvador
SUSE Labs
next prev parent reply other threads:[~2025-05-20 10:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-16 8:19 [PATCH v4 1/4] driver/base: Optimize memory block registration to reduce boot time Donet Tom
2025-05-16 8:19 ` [PATCH v4 2/4] driver/base: remove register_mem_block_under_node_early() Donet Tom
2025-05-16 10:10 ` Mike Rapoport
2025-05-20 10:05 ` Oscar Salvador
2025-05-16 8:19 ` [PATCH v4 3/4] Remove register_memory_blocks_under_node() function call from register_one_node Donet Tom
2025-05-16 9:18 ` David Hildenbrand
2025-05-16 10:58 ` Donet Tom
2025-05-16 10:10 ` Mike Rapoport
2025-05-20 10:06 ` Oscar Salvador [this message]
2025-05-16 8:19 ` [PATCH v4 4/4] drivers/base : Rename register_memory_blocks_under_node() and remove context argument Donet Tom
2025-05-16 9:18 ` David Hildenbrand
2025-05-16 10:11 ` Mike Rapoport
2025-05-20 10:07 ` Oscar Salvador
2025-05-16 9:15 ` [PATCH v4 1/4] driver/base: Optimize memory block registration to reduce boot time David Hildenbrand
2025-05-16 10:09 ` Mike Rapoport
2025-05-16 10:12 ` David Hildenbrand
2025-05-16 11:00 ` Donet Tom
2025-05-16 11:00 ` Donet Tom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCxUPoW9J_C5_gm4@localhost.localdomain \
--to=osalvador@suse.de \
--cc=Jonathan.Cameron@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=alison.schofield@intel.com \
--cc=dakr@kernel.org \
--cc=dave.jiang@intel.com \
--cc=david@redhat.com \
--cc=donettom@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rafael@kernel.org \
--cc=ritesh.list@gmail.com \
--cc=rppt@kernel.org \
--cc=yury.norov@gmail.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox