From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 533E2C3ABDD for ; Tue, 20 May 2025 08:33:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CCA5E6B0095; Tue, 20 May 2025 04:33:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C7AFD6B0096; Tue, 20 May 2025 04:33:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B91306B0098; Tue, 20 May 2025 04:33:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9B05B6B0095 for ; Tue, 20 May 2025 04:33:21 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 5E8331408F8 for ; Tue, 20 May 2025 08:33:21 +0000 (UTC) X-FDA: 83462621802.09.A9B6051 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf04.hostedemail.com (Postfix) with ESMTP id 39D7D40005 for ; Tue, 20 May 2025 08:33:19 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=YgkV93AW; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=46djWSt1; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=pLOmC0iK; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=fM59v9qA; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf04.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747729999; a=rsa-sha256; cv=none; b=5P8sZiP0mbEEDxE8PVwK/wUf4OSHoCGC3JP2A66vm4lBBkR+xpYgg82kh5CeI3BrvQOxB0 cx8Ulz0SLQhW27dd5jUszM0YzCIpUzORbL24mee+ghEVGGI4kKx2lFaMNr7Jl5McAP6v+Z s9urDF1dMHWWEM8122PUv1owbXT4OlE= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=YgkV93AW; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=46djWSt1; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=pLOmC0iK; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=fM59v9qA; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf04.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747729999; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LpHAVQCkyfQV4gQBT/q8vfa5AfukF+uSKRXPvXO1Lv8=; b=AzvSUqf45xXhEIkPHTmqDseP9S/ZU26SzVWGy1wqgZhisd9J7VkwDH2oawTQF3ybnVuD0a 8oCf3uWi6u7ZtLmxHrexfKk1cIydfRFaGKn8R2K3vUV3V/y0Rn82yMcKAFBeALEKFrPc1S DteDF1T0pzvn8flw7O+Tv05rLpwA/G4= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8B1F520634; Tue, 20 May 2025 08:33:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1747729997; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LpHAVQCkyfQV4gQBT/q8vfa5AfukF+uSKRXPvXO1Lv8=; b=YgkV93AWk6oYNSn25eCgMYDr8t1OCQ4txtEZ2sKqcECD/u9pVVpVbCgK5TcyYFIp2Jue87 AOt8wHWCvU4adEg8yo761/iB+DZD7iU2wiet0ctnoYazU9IkU94Bb1edgbdzVmY5qFUtDm FsRKpiNStVf09B/RzgvyfMYAh+/REuI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1747729997; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LpHAVQCkyfQV4gQBT/q8vfa5AfukF+uSKRXPvXO1Lv8=; b=46djWSt1BoTOT6Cv0KTWEL/4WlR2fmp/LmDL89W20itXHCjvfRUmHdgoF7rYbJbKKto+oc VzIcPPfETmVJGDAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1747729996; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LpHAVQCkyfQV4gQBT/q8vfa5AfukF+uSKRXPvXO1Lv8=; b=pLOmC0iKY2mRPJQI1/PeDaLdNWGpD5FSB+G3N/EQV4r12Y0Ys3gIH4x3Wi7Q1kw2rIDhgj 17Y+wTZSpycakeX0Y6vUjMZqlMqq0aQtoFqPAbRKMFLxSWFPBlUoVAbdeGvBASNGsD5CFl tlyMOnN++hpQC89Pfg/Vvksw8GkUiPA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1747729996; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LpHAVQCkyfQV4gQBT/q8vfa5AfukF+uSKRXPvXO1Lv8=; b=fM59v9qAb/+UTZ9o2j0slAPoTnvUK96heiGHwn7fGjj+02VfMjLTLdaKgE8vMQGg1/9KmV TxJYIsvdJPNU+KAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4C66013888; Tue, 20 May 2025 08:33:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 8T36EUw+LGihSwAAD6G6ig (envelope-from ); Tue, 20 May 2025 08:33:16 +0000 Date: Tue, 20 May 2025 10:33:15 +0200 From: Oscar Salvador To: Lorenzo Stoakes Cc: Andrew Morton , James Houghton , Christian Borntraeger , Ignacio Moreno Gonzalez , Yang Shi , David Hildenbrand , "Liam R . Howlett" , Matthew Wilcox , Janosch Frank , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Sven Schnelle , pbonzini@redhat.com, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH] KVM: s390: rename PROT_NONE to PROT_TYPE_DUMMY Message-ID: References: <20250519145657.178365-1-lorenzo.stoakes@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250519145657.178365-1-lorenzo.stoakes@oracle.com> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 39D7D40005 X-Rspam-User: X-Stat-Signature: gqcmdh89won555pi5efhqf44upqms65n X-HE-Tag: 1747729998-668795 X-HE-Meta: U2FsdGVkX198wI3UOI5aoAg3Jmyr6OEYhQDpdSrIMo12mbTMfz/MAC5TZGbPCGG8rHRHUULw0xnIoGMfXr2kuqBjCQvJ/0CZvvslFxX/C16mkaDyvrKCpW9+Evpcgb2ZzhblHMgumb8S2kdgBRqi4GCtqyaTnMkYqrr7ItECTx/qqRHW/hWxCAQcQrW3qMgdjknBb1Diy64QYdzRfDh7F6PGc5kTe2Ni0VbaDB7jBvOR2YMixEEQjY1llZhx6nvhckMfCNdMMzyFY2s7DW29Yiud+zwFveHZPNIg9WYJcSoLCQLpn9zl3f12ud9Jd0EhgaboSo0dvhROvpDBHyuTsHDw/ikx4NYTflFeFLPfrGR9vgexTWQ59lMgSNzt673j/nrQYlFptuuOi7mdKJeARnOtmnhHgN6aloLgGoNQ1APXRd4CFStb7HwLs8elgsSfgxXCid1WiWeuEqkg90ecJHqtPzfmibC11T2umLnbAbeNkN954X2JBM3huDxzqbUBVdydRTx/eBRa7FFxmf2kX+o1DvDdb7eHCLKwZS7oWkil3YcKGZUbOXDx1XmphJ/PV0SkCImUMayRa3uR8j8fu/HylSvBLw52cthWnJXxCRPIkok479x+bbyX/GqFYOzMLi20HhOjquPQ0Dfe1x4V6tYKnsM3n7D4b1GG9JaSB3sUK+cF2AX0VBLoxuQHe3Yjivkn8UVDq9wii0lIMR2dY6Wwu5hPj6nipOGX9QyY+bbVVSrJjOxfrsE5S8+S50uD5BZIfqOD/Y2FwL4yXxoHMv2fBfxHuiaWfprhBviELPcISdf654rZboZbbLK+VOD6NmyUnNgcU2BfVmzLDmx5Ii6gJXh5jenMofgqbef90aBnoYks2nXKm27zKqHRbYY6TcuJrSxgv3KZOpb0QOIy0KwuaoV9Phru6/ptJxvNQ+T1xdjC4sU1gShzMXYVJM7Fi3qAkXkwY3EnxOijp1w zTHN5ljc yeevYMlQNOeKi/e0cpbK/P6007aRrX/9LVNt+hdpBj1vuJZqIaPuziRpwVm6IAXGAWw+Xcz2D1IhYuGhnxR0DUlDhWLUNOSxoNDd8boJWOMTyIwk0VuwJbB9nx5YD2lvaHZRu5yo+190kKcirNVOcA8dcC1HiRHeObHBAfx0H07ZFZG7LXR/NUnkClNmKSYCM9SmK71rAFmRi8FSEcrUQrtc7r/8mPaT54lolHLUvJP/if9wPEw2uiyAwOpflovKDy+1n3oI2oe7AAeiuTR7Qp5dQx57TtY/6CDGLv7zdLwM4/jkc4m54/VhAuzIWKo+x+w3drlLrHU0mB9LVKvxtam/cUqaB7IdatOUSQ07Z2i8/zhLHlEJwUvp/ksD/3QgSlClV5/HME5iF/EmcpbZN158l1Rb8O1vygRqc+HLAIae7BOyRMS2Ox7qa4We7qEglp1AuZt4xsAyShftKsefif4HIBRiULtE1s8pqVdRwBueZqbcyuLWpvrbSWgRfeXwURXEQ6xpUY1ykStUchvDM78EgdvhVUrJH103A X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, May 19, 2025 at 03:56:57PM +0100, Lorenzo Stoakes wrote: > The enum type prot_type declared in arch/s390/kvm/gaccess.c declares an > unfortunate identifier within it - PROT_NONE. > > This clashes with the protection bit define from the uapi for mmap() > declared in include/uapi/asm-generic/mman-common.h, which is indeed what > those casually reading this code would assume this to refer to. > > This means that any changes which subsequently alter headers in any way > which results in the uapi header being imported here will cause build > errors. > > Resolve the issue by renaming PROT_NONE to PROT_TYPE_DUMMY. > > Signed-off-by: Lorenzo Stoakes > Suggested-by: Ignacio Moreno Gonzalez > Fixes: b3cefd6bf16e ("KVM: s390: Pass initialized arg even if unused") > Cc: stable@vger.kernel.org > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202505140943.IgHDa9s7-lkp@intel.com/ > Acked-by: Christian Borntraeger > Acked-by: Ignacio Moreno Gonzalez > Acked-by: Yang Shi > Reviewed-by: David Hildenbrand > Acked-by: Liam R. Howlett Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs