From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95AF0C3ABDD for ; Mon, 19 May 2025 21:39:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 633956B007B; Mon, 19 May 2025 17:39:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 60BEF6B0082; Mon, 19 May 2025 17:39:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 547E66B0085; Mon, 19 May 2025 17:39:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 36DAE6B007B for ; Mon, 19 May 2025 17:39:37 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2EC6ABE865 for ; Mon, 19 May 2025 20:20:53 +0000 (UTC) X-FDA: 83460775986.17.B114AD6 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf07.hostedemail.com (Postfix) with ESMTP id 9A4B340013 for ; Mon, 19 May 2025 20:20:51 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="cHo/aTj1"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of tj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=tj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747686051; a=rsa-sha256; cv=none; b=WOzuTF5bpL1S9TSjSdwT8fmZ53ljvCtW7AlHZn3P+upTqi6TxiVr20HDfGtHdqIHjEEuV9 +j4v6AZnDuY0yJKy/Agq1MtKpbxbb7TD427VwXDQ+QMa8LDFqIIOZhtyejYxa31kgkGRWp 2J2KMtFPLUThiUFaCRFe4j4BziI6gys= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="cHo/aTj1"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of tj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=tj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747686051; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Q2wPB4T3RXgdwQwLquwY66jow/8xj2131jXwsKhe+XU=; b=u0KNBYylL6sKhqrwpLWIgQdXWRC/zh3TqdbeynnelPOLguT2I2XRjmdxLgX/xy3vreszL1 q4+yEYwHwGAa4U9x08ctb8E0M6YpFlSZWi4In0w2iNU7WqXz4EI6RIYIkOFseOtpSmLZMq 1QjQ2Yd7F9Ke2GpUmc+FZA9U7EOvFys= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id E4B4AA4DC5D; Mon, 19 May 2025 20:20:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68652C4CEE4; Mon, 19 May 2025 20:20:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747686050; bh=WL5FzNf1Az/Ya8//sQ6NFIjPyS7N43R3QxawkzN6FX4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cHo/aTj1NJlsWyjBDxdwI+WmfIiwrEFgBB8Ol85PBnNriBfsaVt0ev88ihjLwh8Iv IAlWWBBPuAWgbcCybPlfefxk1RIZQbm6SvlG0AgC+JzzoTC1hrf+z5dDWqSijhPpSc t+lqMMjNUZMhBIW1COmmzxTKQnOQs8O8cw+M4y4/WlRsA7ks7DxO4D0pz/0C8dcWm8 d+iFqV91F42IeA9OGU7QHIYmCk6KlqHbKlSlosJjckRfSVZu36WJYp0H8kBWLRI3SS b8Ba71OV21T65SlRtQDYuY/PBqLQ8DyX2YichdTNhsLKWRjDQfbB9zPobYiQmLucOx 6/lCmgqQgwzhw== Date: Mon, 19 May 2025 10:20:49 -1000 From: Tejun Heo To: JP Kobryn Cc: shakeel.butt@linux.dev, yosryahmed@google.com, mkoutny@suse.com, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH v6 1/6] cgroup: warn on rstat usage by early init subsystems Message-ID: References: <20250515001937.219505-1-inwardvessel@gmail.com> <20250515001937.219505-2-inwardvessel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9A4B340013 X-Stat-Signature: p6t1hjequxnq4uw71uab61zdn6wartcz X-HE-Tag: 1747686051-934627 X-HE-Meta: U2FsdGVkX1+CqXFbUeXrEbNl7KQ0bYm6ZdHXP6spCmU4Av1c7gT2Gt+MSFHtNqfih8o5n4qe/iSMPYXHOqVOHKoKNchAAk79qIQw+k1H+VuuPljYwIxx7ZmYLStzitJXecHpsXyMLQoNUUIfUCrGkakYNXPwcYaD1x7wsnGgJYOW1pzGZMqD3N0qntOS9UCnvx1j5WtF5D+LTacijjiyxV/RuM2M83kUB/ZJFIkQU+KcunD9P9AkKvGPg2TOQrCDzTXp57czN023KiGsp2Pam8RayH3QL3C3Y6F7dIgPTaVnfG+XZqpJIXs6H6ONQVgNVWrZh6dJpu6UBs/AaTdhprB5MOFTUnNHGkfEYCKHxlKK4srogfMmAqav7fifTfpSs6/kaiHNnF2WeJ7mYv0UOeOPytZlabMv5EHtHmyDqKK/ZogufDHL2VDBWKvHK0u1itKDeD69iG8sJBj+vChbWFWFMyeXhuu9Zv0dE4I9suzZUzNqPEhE9UmUC1jP9+gU0zuKHONNVid3j/KRFf3P30r+pvruMfn6uSCtHmd43GG6YToiFhoEGJtTWGVKW5PO+PZDkSUJ1Y6SZtP9j+d3RWsR5Sy7HWlI7ScCwD5yjBKhtV4KhquerVhl3Ht5VpdOMjxBFBwcL+Hvh5/C6Hz1UG+8tbUWMvra3am0T492l7aGNBLJtjcKCJqy1EPb+dwh+SseFCHpGvlGWj8xpl4E+zNzSv82xA3X2tCVjcPVwMqi8LbMz7BaRemnF/Nj1kOsDUV8+7oKZ6Qs9iRrL6febCZWj1yYhE+/FQAJ6EvD/r9Vswy2P5llVnQJBmrvRoKcWdH2H09Qk21LWCF8giENt8YFB0RpTENVGDpuq3hynpXQGaXDqZqMQLyjdWixtGXuUHd8KvdtLBtqpJZ/a8r3wlVzmBwdHwLyzRD6OdQsNifnezvPSsLBtln2gTOItPQ9z36aPBZDGZFVimX2ijF C3Xs56F2 OEq38WIDu6ttDMkT2FJZFWgeeevFLQ3NyZE0EJczcg8KYWuwYBLm95gUUjHw1e6QCqoeSXFO5+rQs12HQolQM6QA4ZupKzI8pkagiPo3Z4IjtxEvL1FekmXBBPwpkPaX6Nw8AmxYOGJr+Z4oD7Jc5j2hjaBJjnuTmQ9/ZaMWjFsBsExOhbHcit97WlFWlFvliRq+HZugS/wpjMTfGnAK45ReccQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, May 19, 2025 at 10:18:03AM -1000, Tejun Heo wrote: > On Wed, May 14, 2025 at 05:19:32PM -0700, JP Kobryn wrote: ... > > Since we are in the early init phase, the rstat fields cannot be > > initialized because they require per-cpu allocations. So it's not possible > > to have css_rstat_init() called early enough (before online_css()). This > > patch treats the combination of early init and rstat the same as as other > > invalid conditions. ... > Applied to cgroup/for-6.16. Applied this but we might want to WARN on actual flushing and skip flushing rather than disallowing early_init + rstat wholesale if any subsys wants to limp along between early_init and percpu allocator being up. Thanks. -- tejun