Re: [PATCH] mm: Rename try_alloc_pages() to alloc_pages_nolock()

[Harry Yoo <harry.yoo@oracle.com>]

On Fri, May 16, 2025 at 05:34:46PM -0700, Alexei Starovoitov wrote:
> From: Alexei Starovoitov <ast@kernel.org>
> 
> The "try_" prefix is confusing, since it made people believe
> that try_alloc_pages() is analogous to spin_trylock() and
> NULL return means EAGAIN. This is not the case. If it returns
> NULL there is no reason to call it again. It will most likely
> return NULL again. Hence rename it to alloc_pages_nolock()
> to make it symmetrical to free_pages_nolock() and document that
> NULL means ENOMEM.
> 
> Acked-by: Vlastimil Babka <vbabka@suse.cz>
> Signed-off-by: Alexei Starovoitov <ast@kernel.org>
> ---

Acked-by: Harry Yoo <harry.yoo@oracle.com>

>  include/linux/gfp.h  |  8 ++++----
>  kernel/bpf/syscall.c |  2 +-
>  mm/page_alloc.c      | 15 ++++++++-------
>  mm/page_owner.c      |  2 +-
>  4 files changed, 14 insertions(+), 13 deletions(-)

-- 
Cheers,
Harry / Hyeonggon