From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38B8AC2D0CD for ; Sat, 17 May 2025 08:45:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 13BFC6B0082; Sat, 17 May 2025 04:44:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0EC2F6B0083; Sat, 17 May 2025 04:44:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EF5EB6B0085; Sat, 17 May 2025 04:44:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C58D46B0082 for ; Sat, 17 May 2025 04:44:58 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id BC3311217E8 for ; Sat, 17 May 2025 08:44:58 +0000 (UTC) X-FDA: 83451764676.11.D04AF0B Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf27.hostedemail.com (Postfix) with ESMTP id E7C9340009 for ; Sat, 17 May 2025 08:44:56 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=qCqIQM+a; spf=pass (imf27.hostedemail.com: domain of mingo@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=mingo@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747471497; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TLgofqnm88qVWPFgjlm6YGvGmjOK97JslUnE05XGZRw=; b=KXCsiJ2yx241SiihkLTZuvDHO5/1G42Ffye55aHN4j/fM+F3+2O6L7tvkSwevquWJUdB0+ IYQSHD+XmJp0CR5sS2CxUd4WC+1MFgKZ31hutyZ1ZU9umREWNyeVeALXzMb+e+9JgSEUwg ExLPkUnUC0b2cvr3oOmlbYgKSdmuYNs= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=qCqIQM+a; spf=pass (imf27.hostedemail.com: domain of mingo@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=mingo@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747471497; a=rsa-sha256; cv=none; b=fTcKuwlqA11ut7YfA0OvlS+KuCuok/t/2JkvKO0V5jSix6jIp3vnhf4l/sTAh9G4GP09mV KadN121vTayZHJxfYROKH+ztIs6zCFycTq84Jd7gmvW0WD7JC5sHXiyWS5KUqEXGb/6MsA y3Wpu/GfYhjnwX+Wl/fGuVYvL5ZxEKg= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 7F8A744A90; Sat, 17 May 2025 08:44:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7AFACC4CEE3; Sat, 17 May 2025 08:44:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747471495; bh=j0LTn1lN+WcSRX3JpuiuLhB0VN18irvMtE1JbmGibaI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qCqIQM+awYF3higFIfsJGgfizWdYEJdayAkA+d2TShUU0oMsxxZRgrHH0g1eDbHBQ ERsS+e2UX6tqWy0p3lR6z23HSpgvepSSEKxs+BAyuSZ0AtHjIhwmh+YyKuMIjdvc/d uX7+aXjk9b/uVYfMIAUZgZp1brr+mVwTZemVp7+1xt0kPHvSa6jyL0XAvdwaC16E7+ OM+LlO8k3cSSmJM9gytA2HC0+1/wxYMnpc60pVzN2h6HgEtqzHhXSyPvEJX1ivhkF9 N7MlamtfHWzPiuXGImzRIMv8pDm6eNmclio7fP+lf/FcV9oXm+N4dFv7lpGHSdDXnd edUPPspMWxvPg== Date: Sat, 17 May 2025 10:44:47 +0200 From: Ingo Molnar To: Borislav Petkov Cc: "Kirill A. Shutemov" , Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Jonathan Corbet , Andy Lutomirski , Peter Zijlstra , Ard Biesheuvel , Jan Kiszka , Kieran Bingham , Michael Roth , Rick Edgecombe , Brijesh Singh , Sandipan Das , Juergen Gross , Tom Lendacky , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-efi@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv2 3/3] x86/64/mm: Make 5-level paging support unconditional Message-ID: References: <20250516091534.3414310-1-kirill.shutemov@linux.intel.com> <20250516091534.3414310-4-kirill.shutemov@linux.intel.com> <20250516153009.GEaCdaAdhCVpjaViSx@fat_crate.local> <20250516155649.GFaCdgQa7sX75vOLSm@fat_crate.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250516155649.GFaCdgQa7sX75vOLSm@fat_crate.local> X-Rspamd-Queue-Id: E7C9340009 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 5rskx6abukthkat7d51idt71hix16y65 X-HE-Tag: 1747471496-221510 X-HE-Meta: U2FsdGVkX1/cvT2CcfeZ56PPqP6OBDSud3B2SoZzuBMTlwivGXBAw0ITEZVNRRjqRY8StpZShtFeqfZ98rN/MSvVCvqnyBFJfe+Nrg+XF4qkGI+C8wK2Yg+MRRhWLB46FsMtWWlw73dbCXgvEY3/hiVV/dCoLHVzpXvmGjvvIyooCnARm4RY8tcVC2K1iNb4t30L+PQmQVE8xzkTb3AuSRLnKX+2tgkkYxrfNjrygJSsZMVnpVn7wkUsDEVIpsz8iPztafghgkjICcCeY4S3xBXZNFcRUWv3C1G4ATMThvUw6ExcTLV4TEV+tTPhQ5rMe0G9rUNgh2f5Q9VjtSXO07r/RLInV57Zhh5aUCQIOx8CRJ1f4HCF4jaL8ZB/uiH3ZVsXUnBb4x7VxjJwTquJrTTjWr/dqvQAfXYgBM9gDFnlOV08WELOEWMi5oCtqEJdq1n2kNEcX419C8oXK4Odo4bixpqbBJfDhnLNH1tXMunNnql3FtSx83fXQsvWpXDrAkcv3bMitOrVpq96VYEOa1IfSWemFncKCkYwchRwNrVe6Y9JPn2tDc3AXMF6Pd7OwEunMH0KRA37Rf4/5SzncutIFieyq7cmKx6s98g9NOc2IGvgJCKhdjzkaRc3qrW2eela/bK4RKftxg11s6bJWgarZaPbSaqpLtuI1CIkamcFGwXWxk8kGzJHCzykKBi3eMxnt4RehyYn7Yb0PZHik1aQiQ3pR9b941+xhfCRIcr0jOttgPDOvDZphQwZKnygKBFEAc4KiqxdnPCu1o9gF7nTtu8F6o+5Gu6eDUX/f0sjjlaYCqGtXOcZBYPa/2cgIWE6wOfd+P9VPVVJxPwz741rO7CHOWweDOczmYilcWlWsyLyLUCMK9r+r2O05xSo7YP03mgFcFxscOipB2sTD07tVWiHZrD+t5QeUTd9DF8uwGnkl+/IzOH1RsKRLxwtqUOrK5GwJFLo+o0VNlA l77pJFRy ++sSJRUj67Ssd7s9ajZo33UL8JAvKgYCYZHRM5YFtfLsYhk6qlpDnlGYo/H9INSIp/hVVf7FqqliQPWmbtyLgTCA4UlGBxbnfnzud9ACrn7gAoOj8G/oLq03z57KxYXVGaoDQpHOuwVsCzrnYb3LrK2ZEeOjM7b4D/QO+VF65uo+6zbWj02XX41mB4edktmMMKDfAc6+wvP+Ao9X1sQ4F8i058t/W8YmiCVcM4Ue/2K/CR2Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Borislav Petkov wrote: > On Fri, May 16, 2025 at 05:46:51PM +0200, Ingo Molnar wrote: > > > > * Borislav Petkov wrote: > > > > > On Fri, May 16, 2025 at 12:15:33PM +0300, Kirill A. Shutemov wrote: > > > > @@ -173,10 +173,10 @@ For example, when an old kernel is running on new hardware. > > > > The kernel disabled support for it at compile-time > > > > -------------------------------------------------- > > > > > > > > -For example, if 5-level-paging is not enabled when building (i.e., > > > > -CONFIG_X86_5LEVEL is not selected) the flag "la57" will not show up [#f1]_. > > > > +For example, if Linear Address Masking (LAM) is not enabled when building (i.e., > > > > +CONFIG_ADDRESS_MASKING is not selected) the flag "lam" will not show up. > > > > Even though the feature will still be detected via CPUID, the kernel disables > > > > -it by clearing via setup_clear_cpu_cap(X86_FEATURE_LA57). > > > > +it by clearing via setup_clear_cpu_cap(X86_FEATURE_LAM). > > > > > > LOL, good one. > > > > > > The rest looks nice and good to me. And FWIW, it boots fine on my Zen5 with > > > 5lvl enabled. > > > > > > Reviewed-by: Borislav Petkov (AMD) > > Bah, and I thought I'm replying to v3. :-\ > > Anyway... > > > What's your preference on timing? v6.17 or v6.16? > > Right, here's what I'm thinking: > > * Kirill's patches would simplify Ard's cleanup a bit Yeah. > * The 4th one: Kirill A. Shutemov ( : 85|) ├─>[PATCHv3 4/4] x86/paravirt: Restrict PARAVIRT_XXL to 64-bit only > > looks ok too. Yeah, and now has an Ack from Jürgen too. > So, I don't see anything speaking against queueing them *now* for the > upcoming merge window, I am testing the tip lineup on a daily basis > this and next week and if it all looks good, we could probably send > them. Cool! > If not, we delay. > > And if there's other issues which get detected later, during the > 6.16-rc phase, we revert. > > So we have an exit route from each scenario. > > So I guess let's... > > Unless I'm missing an aspect. I think that's a good plan. I've queued up Kirill's latest in tip:x86/core, with tags updated, and it boots fine on my testsystems as well. Knock on wood. :) Thanks, Ingo