From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BE7AC3ABC9 for ; Fri, 16 May 2025 15:47:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A6CB6B01F5; Fri, 16 May 2025 11:47:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 72E3F6B01F7; Fri, 16 May 2025 11:47:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F8856B01F8; Fri, 16 May 2025 11:47:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3AFA86B01F5 for ; Fri, 16 May 2025 11:47:00 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 141F2160B07 for ; Fri, 16 May 2025 15:47:01 +0000 (UTC) X-FDA: 83449199442.25.FB3D1FF Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf01.hostedemail.com (Postfix) with ESMTP id 7DBEF4000A for ; Fri, 16 May 2025 15:46:59 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Li3qHaSS; spf=pass (imf01.hostedemail.com: domain of mingo@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=mingo@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747410419; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hCIs0ET6lIMCXZQ9bc839ah7GPuSipFxcF8s7HSSF54=; b=GbarsGL8AyNgCsHTqJLNCS1IpIJOTWV9KmttWQ9Nd8tCxdd0ktXifwjLV39ONxQzmSp1f9 o33q0fa0u0iNTCOu494ibRAukBGgWnyfy2bUMElJaBU6sXVBKPlZJJPx1DUpZWAXJ+NN+B ReeIL2KQs2Gn7pXZXNKXIFtWTGDzyXY= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Li3qHaSS; spf=pass (imf01.hostedemail.com: domain of mingo@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=mingo@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747410419; a=rsa-sha256; cv=none; b=vnELlA8vHFJjUPGAiPR8wnBX2erDI1p8PYu0BC1bn8MoNCGR26+2zqDoYMus/aJeGqsGtk 4B7XXybuzXPIiT1UokQqQgNpFOZX+CdtMRLAV9LUvJpwcMhHfyUA3a7lQsH3q/xiCtXtDh wvYJ3P9R//8IPF9his5etiIkkQFUR2g= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id C1D0962A6C; Fri, 16 May 2025 15:46:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE0B6C4CEE4; Fri, 16 May 2025 15:46:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747410418; bh=mUg2KCJM3nZNLfgyNFElxT8URgyqRgXL21LFChPENMc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Li3qHaSS9TkT6mLcLhYB4VIBNnt5ObMy+G1liN+Z4gP4Um6ezhoLyAkbM7NmhXDuE 9sg+oqlMSzZsRHs55D8CJy/r4o7z6OIaBvbdCcqUJ8qQ34ywTMJZiFD6+MftlFCl6E y/vfvpe+iJshxbogh5k5OOyss2nRXIBmZxwy/QbnFaJyMe13nvmGWoa8NKwKJs4rxs I0MdFbc3/aYparPnNkgh7VN+MENRkCV46inZ9awjeaSCR6Xn8BI2fea7uhusvq/fIa nvO9+zMlKfPg5feoQCTowKyz72zrTfGTaQvRO8LfVG6sYROEeGE+Q16uKGOKC29CxE 3yUjgXprxS7rw== Date: Fri, 16 May 2025 17:46:51 +0200 From: Ingo Molnar To: Borislav Petkov Cc: "Kirill A. Shutemov" , Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Jonathan Corbet , Andy Lutomirski , Peter Zijlstra , Ard Biesheuvel , Jan Kiszka , Kieran Bingham , Michael Roth , Rick Edgecombe , Brijesh Singh , Sandipan Das , Juergen Gross , Tom Lendacky , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-efi@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv2 3/3] x86/64/mm: Make 5-level paging support unconditional Message-ID: References: <20250516091534.3414310-1-kirill.shutemov@linux.intel.com> <20250516091534.3414310-4-kirill.shutemov@linux.intel.com> <20250516153009.GEaCdaAdhCVpjaViSx@fat_crate.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250516153009.GEaCdaAdhCVpjaViSx@fat_crate.local> X-Rspamd-Queue-Id: 7DBEF4000A X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: rt3u7ssue7cc8am4ekj9tdtb4o1w7bge X-HE-Tag: 1747410419-985499 X-HE-Meta: U2FsdGVkX18Du88k4a1svuyWytzncZxEXqkFK56y+MrGAEHg1QotNsSeL91ScfC/Bdjk9KT0+2Nr6H10e5RtPRfBPkqpAgFCnl2MYDhXlyR/qlqvQ04HhpzpLPyNzBkaDyEuIepykKtNnFk5eeisXJZpbRxcSVQRGaqSZ3locJs3Hzuc4hu7dKlFyImp9JGRUKbCvB5u/cCDVSVIbhH/AUe0aSGYj30Sy9+fLfoY5q5dagj2d13yv2Bq/5C9sqRcdSUkJgq8SkT1XtIsbSMDzLXZSASr0oJFs/pKK4C7Qx5TfTvvlalOV135tOWth1HTM6KVJcc6qmP09zRYXCoVGWxrrcZFIgYHWpN+GpbyoySdqT4+VSCHi7qEbLBv3kBMd38KIF13bFJyXbYhdsuUR55XeQdcvlthskSMcBSTJarKQn6C7omBbFlkPNj/S+x2/prv1QZeraMLELQmnypub0APOs2FH0rbgtLF+YkyKYW1TkwQcK5ZSP+Uo/zJ8jfD6QI5bTArbbn7e4yQUNq7jXgl65GvIrPThojNLzFGifDkVxP035m+WpHj9wmFQDNpBHb0h1J2Fwiu66sVXVRrQP/BfuHwtzbQsiska8RlhlbYZVmnIoQLgW6iXQgufS2uWYuXlm/6Zyh7ljsIJQzQaGAxD5ycLfr3r8u9ARTDVqesV+tcAZkIaDj5g/V+Xs3+TaaXrZBfaUxzy5turZpW9pjdnZQt7rgOUJAyN1v2czeReFqpnBgsT7DlTE7hd97+FQjNngIYoEWvTuIKRvWL3BYytCYyMFx3NSfbP1xInoYF+7kZDWlVY7u3tmhZWfOBqezmBxjtthGnAeSuDsnnzU/Ea0UxiPU7ANg2jjeQqzrZPCuzQYYaPu4XkGvGzOZszlJ9JEsXNDRSZjHhA7oaG36ldi9HExPb3Obxy2Rt1QyCToEW8jwvv4Z2eFEOsPFBFoB2rYTa4I8oXacb5gV 8zMjkFKQ /ecvKyfbjXAfmdaEuo96LID5iHWt6Z6Tof473GFzQC4FBcpE0xJjKQIUHYpTaASbTjHJWZlBBTH3UxkDiMu71tOKYhH0QoVaa/TXMpwAbnqw/a4y/kWPpSmxZsl4l1pGglNbNDGcUqrIl3r7pa9hbDQMVZWUcslcyBbYBinTiLwIdz9fcNtlmde3NIzGSBl32mWcJBMwsHNeN/eO2JsTAz4SaUg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Borislav Petkov wrote: > On Fri, May 16, 2025 at 12:15:33PM +0300, Kirill A. Shutemov wrote: > > @@ -173,10 +173,10 @@ For example, when an old kernel is running on new hardware. > > The kernel disabled support for it at compile-time > > -------------------------------------------------- > > > > -For example, if 5-level-paging is not enabled when building (i.e., > > -CONFIG_X86_5LEVEL is not selected) the flag "la57" will not show up [#f1]_. > > +For example, if Linear Address Masking (LAM) is not enabled when building (i.e., > > +CONFIG_ADDRESS_MASKING is not selected) the flag "lam" will not show up. > > Even though the feature will still be detected via CPUID, the kernel disables > > -it by clearing via setup_clear_cpu_cap(X86_FEATURE_LA57). > > +it by clearing via setup_clear_cpu_cap(X86_FEATURE_LAM). > > LOL, good one. > > The rest looks nice and good to me. And FWIW, it boots fine on my Zen5 with > 5lvl enabled. > > Reviewed-by: Borislav Petkov (AMD) What's your preference on timing? v6.17 or v6.16? Thanks, Ingo