From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38E9FC3ABC9 for ; Fri, 16 May 2025 18:07:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 95E4E6B0251; Fri, 16 May 2025 14:07:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 90D706B0252; Fri, 16 May 2025 14:07:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D5696B0253; Fri, 16 May 2025 14:07:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5E7686B0251 for ; Fri, 16 May 2025 14:07:52 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id BF520160F9E for ; Fri, 16 May 2025 18:07:52 +0000 (UTC) X-FDA: 83449554384.08.E8BC62F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf22.hostedemail.com (Postfix) with ESMTP id 08276C0005 for ; Fri, 16 May 2025 18:07:50 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Nsiu26Qy; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf22.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747418871; a=rsa-sha256; cv=none; b=y4FhdMmeeaATCHE4nXKUWhKBdmfo7V0XstpPq5UFJDOaFcfHlJ08Z2Mf9VJ5y/2fBrRxWX abK/ZJBHyt3X0eh/hEq0SctOfmwWbEhxoluy+2I02W8hHnKWwYT+8dlsz4o2dD0NnCegu5 wJbAdfFbey+tEzx7+X0iSEbzrnKIf2s= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Nsiu26Qy; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf22.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747418871; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DzfFzSADVFvofd09h/uvxYQJY0eh4FwKlThoLNstdp8=; b=0DcA38Ry4DDsnrg+aPL24XnCZHkNa0u10WllRF6rjFt1OYi55Ayh03RMRAn3tGESdJxNom oTkA07JKVBhQTGxfUa0YCau0HtbdAR2TN6AZfjvuLlSji7piMoEC7h8Razg+4dDQpQhPAp R6zipNdBNJvho4WW2FkUhyyjFnZoejQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 9C3F65C5642; Fri, 16 May 2025 18:05:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F24ECC4CEE4; Fri, 16 May 2025 18:07:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747418869; bh=NDQ3oIAK81gY0XPqiwX0d/dvGcwzYLnE7nxbmPCbTY8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Nsiu26QyPbRgf5TPznJIJOzpQVrbSTQCNVVmXUO2pDu4VVs+n/+Qe22sAVXpTMy6j WBMLzciw4Te+AsPPcBApI/0IKX7LT3BffjFhTegMYG6W6AlL8+3ZjUe+ibjBOqNPfj zQfqZh1/a6j2rIvQr3SToofPTZ8Oq7KA9b6qhiFWpdFLBldDPF0rUw43Qo1xwvaTeQ PUZ8ZV5AFX1kHeYP1IoZ5OHtMQURg4oKW04Vspj0SdcD0XBSPaMNlOaHS4wZMr71B9 stVbSD0z+TfaWA0Vv/UJHgyC9tvIiHdFbJPZbxCRZgmZxxWdxdU0FLcKuAJOHZPq0J MWaCTb7kHwbCQ== Date: Fri, 16 May 2025 19:07:46 +0100 From: Mark Brown To: David Hildenbrand Cc: Andrew Morton , Shuah Khan , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests/mm: Fix test result reporting in gup_longterm Message-ID: References: <20250515-selftests-mm-gup-longterm-dups-v1-1-05f8f731cf63@kernel.org> <58dbef73-6e37-46de-9092-365456306b27@redhat.com> <46d151d7-c04b-4538-9725-dc4f46ac8ac1@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="F0Ea/dgySH8XhVmb" Content-Disposition: inline In-Reply-To: <46d151d7-c04b-4538-9725-dc4f46ac8ac1@redhat.com> X-Cookie: Well begun is half done. X-Rspam-User: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 08276C0005 X-Stat-Signature: zcpmsuk66ej31w87itgryjdmoffmkq4z X-HE-Tag: 1747418870-557198 X-HE-Meta: U2FsdGVkX18Bu6LkbMOJpK/oIdJB84SPv/lkZwoDftaFKXa4ERKnTxG1ynVMxT/DYsPrUhSH8Y3UTL0ri+QPYMgkdgBFmcrFFaYlRvWjhpeh9JykET54STVWctCNoxixwq+v+ffoiFW/I4MjClcn5ZbtCYTYYcH+6ttIXbqrOmFJbT9jpJca3MxHATlQz5w/OV1o4KNAxybzLDmkhgZB7NCsb1k61e2dQUogSWt8chnAmuIKKdePWYs2HKYgP615T+N9sipczaMCSPpfWc1/G5LHO8MgcaPaPGHgVbLEByBVjYnInlUDm45XJXnlJFD5IeFmZQRTmXIE481d0BmIVZK5SLfMvHZTDWk/K+T4xMiso9KCKuvSCufTsEk5uATKFgBxr8IqvIZbD2kN3wbPqmMJuxr6DOjiJZF7CbKQV2piaJc4XD3tRCDou5pvT4InLnVXYhcTAzS1pyTvjnmIqAhxDtUTqi35B8yMQSSrz8yEZ/SClQ7oj/ot7hjPNFU6sjjOSMt4IENQ4gmn8MFsF/ZVrpgVRjlFJD1Hmw7cG4wUDW9DNkVLKByJBr356I33FwLcyy26T7+6jAwo2DKFwXrf63R2IFcxnrf9nuRCf60JsPnZ9GWAiVFdeQe81rsrQpBZ/GiCMlO2unBrBfVa6qr7BB5KDzjAnIDUKpDt52ziPCP5bdk3rPMKmyEZVBxt7hM5EZyTfXY4DQfLnoVgRImge+0v3BuQyhPl5EePZvz/5j8T+d8bUvnaywXvjSLVb5pQ7L5hJDCjUFvCcGkyyAYeJxRGGxqGoTXmuFOCLq4UUdicaSGkfQeMwQBqPqubg3U8BzLFy5n+Pri4rHkVkYNOoZAdMxG4A2JRV3nP6WVfSCsa3LWVBe44pW1EN+pl3ngPlN2iIUrhLKKJD9al6JiYRpfVKqfIymgMTuD+W0N7rKqtp5IDocsg05Ohpy/sC8KKHdQFk+v+3nuTOHR 4amg8sq7 jDVu+0HJj+kK+O9oPUehXg5tEd41j8ZRFKBCaTLpioNTd3727iZpV8+hAEWS1z7jb5qmx6OIrpyO94JUG0FqOpgo4c3n2Bymi5Q54fFN2Lxc8DMgKqSmpIIyLq1e3wAGnuSdvmjjqz4gl3a6z0fOvNLUvR4/+oSVH+1Fo382zxtgw5soz6KPUIzNXZ873UkJIKR1QlszalPGOj4k9qFmnT5Uo1nMEvfWGdbMupAo1znAQ3KrWwUjakVARetgctIk0yfcW4Jyub34FIO+jtfVHyHZSeikkOS8aeYrxFApjCR1+VCYHGIyuL6XckXxnaqJ1qVmG3bubdR3fFctOwTSwR7jy77lh/RFJGzx1GUwdUhgZuFU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --F0Ea/dgySH8XhVmb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 16, 2025 at 04:12:08PM +0200, David Hildenbrand wrote: > On 16.05.25 15:09, Mark Brown wrote: > > > I'm afraid we have other such tests that report duplicate conditions.= cow.c > > > is likely another candidate (written by me ;) ). > > That one's not come up for me (this was one of four different patches > > for mm selftests I sent the other day cleaning up duplicate test names). > $ sudo ./cow =2E.. > 1..778 > # [INFO] Anonymous memory tests in private mappings > # [RUN] Basic COW after fork() ... with base page > ok 1 No leak from parent into child > # [RUN] Basic COW after fork() ... with swapped out base page > ok 2 No leak from parent into child > Aren't the duplicate "No leak from parent into child" the problematic bit= s? > But maybe I am getting it wrong, what needs to be "unique" :) Ah, yes - that's got the same issue. I'm not running that program one way or another, it's not immediately clear to me why not - I can't see any sign of it being invoked by the runner script but I also can't see anything that I'd expect to stop that happening. I'll have to have a poke at it, thanks for flagging that. [Converting to kselftet_harness] > > That'd certainly work, though doing that is more surgery on the test > > than I personally have the time/enthusiasm for right now. > Same over here. > But probably if we touch it, we should just clean it up right away. Well, > if we decide that that is the right cleanup. (you mention something like = that > in your patch description :)=20 OTOH there's something to be said for just making incremental improvements in the tests where we can, they tend not to get huge amounts of love in general which means perfect can very much be the enemy of good. If there's some immediate prospect of someone doing a bigger refactoring then that'd be amazing, but if not then it seems useful to make things play better with the automation for now. --F0Ea/dgySH8XhVmb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmgnfuwACgkQJNaLcl1U h9C+1Qf/RpnzjkDNIVJbiN4XdRsp/uDYe3/nV7RLlL/fbTisY3dHyhvFom59dhod 1Ii/9OxAP4NDn5QeNPrvPN+mS4G1qhwz9EMIkqGKZVT+LhZnHoIWOv2XrpK0nzSV EavRh5bwqqkANX4d1ArzLTbNaF9Y7jehxFp9AkxKUfR20NgIC7fSZUVBtOCteOoK J0plCu8UuZECzL79JZ9PB3FMlm81yNFCczCMQP2XjFs+ECFuFYZef+Jv06lI2M7m FY1Q5l7ILhEprXZJXrL4MKbgWZxRpe8s9uv/JQ3NRDeiXORWV8AyFMXZYSNTurwK xhdCIS1qJRYcDjecpJE5vGMlk3xi4A== =67hP -----END PGP SIGNATURE----- --F0Ea/dgySH8XhVmb--