From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE137C3ABD8 for ; Fri, 16 May 2025 10:10:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 683386B0124; Fri, 16 May 2025 06:10:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 632656B0126; Fri, 16 May 2025 06:10:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F9B56B0127; Fri, 16 May 2025 06:10:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 309CA6B0124 for ; Fri, 16 May 2025 06:10:50 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id EA9131A1C13 for ; Fri, 16 May 2025 10:10:50 +0000 (UTC) X-FDA: 83448352260.06.8749EF7 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf29.hostedemail.com (Postfix) with ESMTP id 5B82812000F for ; Fri, 16 May 2025 10:10:49 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="Uhny24M/"; spf=pass (imf29.hostedemail.com: domain of rppt@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747390249; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zWReOAzZuyndFXz89FglVfk6SAOnEHyvrJAiI++EEKU=; b=cNGT49sD+vRgiGyLPevts8gogXpasf8XTQnOcweKgWaOlk7CcSy/VllOkw6otJqbzoTLQo vWs+GWzVInqJzVSQN8rg/oDwsoJpsqzxbbvt8ZZKfA+Ndh0RYuQC6stWL8D7yrWxDwM2rp 80S/R1afE0XGCQHNi47faURJLl9SihI= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="Uhny24M/"; spf=pass (imf29.hostedemail.com: domain of rppt@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747390249; a=rsa-sha256; cv=none; b=lZVtMfdpbgax+uybnBKfeJNZ3WMJbFMEdytb8Itbs1PnLFrW7lEe7rElGUf63uUPICew9H iUiVbrhkXIN2rTlHKXwcg1uvqFM+k6hIAK9gwt9f7myXRxMH3gpDjT3oA0j5xbdr6+toLL CN1UlHzjtj/hhhxVHdGd/ZwEbdUcQSA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id D05A0629FC; Fri, 16 May 2025 10:10:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 718C4C4CEE4; Fri, 16 May 2025 10:10:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747390248; bh=nJMnMk864bD0yjxvNLVC5z9JnUPyx+NfeeAg3CAITUU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Uhny24M/hraIhlTWniNLaGqBksLnOLG9/E8mftFMioFIReKD6VIcq8NbuEErbZlgR XGb77Exg3Dg+jXzyuc0IFJrr2y8MQh44Ct+QvDbpVKadJMo+GXJac5rdyp0WMd35p1 6dc12fNI+zEEuIgIDOen4ev67dv1l1SpuRniHjtAELOzfbOP3w3z0qreEtFiqJ5Abw mddI58Raui5aPsWwTsA1VqB7E8e5d3jWpiisVH+lw+iUP7s4pYcT3/Wpl7qBXNY1Zn mhMy5sCvhWg9MS/4c1wM0xxOMAAwE6QrDADIW2zsD/MRAxXaOZWNZl7uleWGC9d4Rf YuluXlK8Wi69g== Date: Fri, 16 May 2025 13:10:39 +0300 From: Mike Rapoport To: Donet Tom Cc: David Hildenbrand , Andrew Morton , Oscar Salvador , Zi Yan , Ritesh Harjani , rafael@kernel.org, Danilo Krummrich , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Jonathan Cameron , Alison Schofield , Yury Norov , Dave Jiang Subject: Re: [PATCH v4 3/4] Remove register_memory_blocks_under_node() function call from register_one_node Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 5B82812000F X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: go6hrqi7qxtewtumme6f7oicsb4fdsh7 X-HE-Tag: 1747390249-769813 X-HE-Meta: U2FsdGVkX19BbnQRcvRWwFIlmIlVxeOcyUNuT6QoBF7Ys3Mw6UNI3XdpMAeKE4ruvHdjxZtLWuicll6zbaohBdDCnouNgH4KusOui/N9nRTnt/TLfoJAfNPyVkglTVigMOM8bJeSpLMKXAwX1L5XQ+zNcrPjEj8Z1AlNYG3pgU0or0O1hVjnLooUKyq47WxUYXqJaCMwYVVQd4FyCeB5HO5+DZHzRDkGTCE7k64VupvWMKtS1E++fp2hHSnPPw9RQNsg12h0Y4PDPs7N3rO8OLClG/I18+RmlP4Tj8veXqOdbdS5JGmzvEDvlwb+1in+7K82X4ZZjJidDjjxTxN/MKFZvqI2O1Up5JphbqeAPuPD/tNbmcJV8bTvTg8dDMFmMfWw4oTsrDucqC1/ni8uIyCg+yP6JYPhg4MjpQ6mE4P0JYep/8Kwem+OGmQ0HQZtBfn+oiSqCOfM9bozD9xrIfVBBC0Hb9O9hs7AD8rH5sQFUZfPG2dOufyqYPrsT9P6nv1iUR5HECwfkKHm0RrOIfpuiEACPZV5eZXldUOxwO50XBhKfBbfL7baPIxjOQ/lXgApdljAaZtng5sgmkauIGS9AMIWCR742dSHL5SHDnFsVcPWeZTve/sFdrBjZISG8uNFXkiHV7KKk/Bz7XD9bIM7UmLjLLprYZtftC+SvFIlFrOCd7HcyYVh0jNGePjxTTtj7sPh8uPtwJAJqx7b+CQvJmi4dl6qFpBn0V7t+zk9aJmkDiAOlp2VPk4ZeQMxm5e/78611KYBYLE5isQsNTvrU69vOriHlB9ZWHT1JLKWqhcGr2mpK/bHoGS7QvLyUeRpKhM39F2WeAb8Aul/11BxKn+nHm+BWVqnvu+f+Oxq6MmOi2V6X+MfSqAo+yIVhX1f72Q1ZLLrwKHiZ4QFNu6mEGdLjOZZ+xAWrV3fXP55Cr5ocBJ9rMPTT2AQdzU/5fm8Qyg0Lh1dmLaxcp+ yr2btMSN +WIQG0/wJuhfojtS0KcIxnjL2nSBQYpV0OtbN3iyf984qf6IodFQVVx2TWuOWixbQEH+nPc8XWX5mGHlZQV305Vn7MFiVvjEo6Ky9Hrc812yzTQUsJyJDQXbP7WspTmFVrqEJVTisIrxr4ZFXRt+Z4BJxIVR6v0dsX/xC5VSXwc4yyTtItM5TQlkNEaUEUhCvWWx374higSrgOeo48ZSSaIjVVTmgTMhhiExvm1YggjGlOQwiLeEwmDw/zu8Ywn/fH06+fbbCAIFo+9Ix+6S73tNl0l3WQpVZa7hmD3x69hR7KlE/8TMkx/84mFjUSwPKy31BltGZImMywFcYTNzx1jfWX7YzPKOBXpxiXtXfhFFKv3t8pBhURgb3oPStChZV9DVMAcUNem9rNuY1GLjtbD6xpMhBTHhKB6Y7KSOPjA3sRLdyTwGhKJ4maJGe/tx+mEYx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 16, 2025 at 03:19:53AM -0500, Donet Tom wrote: > register_one_node() is now only called via cpu_up() → __try_online_node() > during CPU hotplug operations to online a node. At this stage, the node has > not yet had any memory added. As a result, there are no memory blocks to > walk or register, so calling register_memory_blocks_under_node() is > unnecessary. Therefore, the call to register_memory_blocks_under_node() > has been removed from register_one_node(). > > Signed-off-by: Donet Tom Acked-by: Mike Rapoport (Microsoft) > --- > v3->v4 > > Addressed Mike's comment by dropping the call to > register_memory_blocks_under_node() from register_one_node() > > v3 - https://lore.kernel.org/all/b49ed289096643ff5b5fbedcf1d1c1be42845a74.1746250339.git.donettom@linux.ibm.com/ > v2 - https://lore.kernel.org/all/fbe1e0c7d91bf3fa9a64ff5d84b53ded1d0d5ac7.1745852397.git.donettom@linux.ibm.com/ > v1 - https://lore.kernel.org/all/50142a29010463f436dc5c4feb540e5de3bb09df.1744175097.git.donettom@linux.ibm.com/ > --- > include/linux/node.h | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/include/linux/node.h b/include/linux/node.h > index 806e62638cbe..8b8f96ca5b06 100644 > --- a/include/linux/node.h > +++ b/include/linux/node.h > @@ -137,15 +137,9 @@ static inline int register_one_node(int nid) > int error = 0; > > if (node_online(nid)) { > - struct pglist_data *pgdat = NODE_DATA(nid); > - unsigned long start_pfn = pgdat->node_start_pfn; > - unsigned long end_pfn = start_pfn + pgdat->node_spanned_pages; > - > error = __register_one_node(nid); > if (error) > return error; > - register_memory_blocks_under_node(nid, start_pfn, end_pfn, > - MEMINIT_EARLY); > } > > return error; > -- > 2.43.5 > -- Sincerely yours, Mike.