From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51438C3ABD8 for ; Fri, 16 May 2025 10:10:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B0AF36B0123; Fri, 16 May 2025 06:10:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A92C86B0124; Fri, 16 May 2025 06:10:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 934DA6B0125; Fri, 16 May 2025 06:10:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6EF1F6B0123 for ; Fri, 16 May 2025 06:10:20 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 16BF2801EB for ; Fri, 16 May 2025 10:10:21 +0000 (UTC) X-FDA: 83448351042.09.E8D244B Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf24.hostedemail.com (Postfix) with ESMTP id 82EFA18000F for ; Fri, 16 May 2025 10:10:19 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=M5HmBz+v; spf=pass (imf24.hostedemail.com: domain of rppt@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747390219; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Dtl4ZoEvnb/s9/s2Zy5MBv6RSnAKIc+YQzOm1RgaANk=; b=HMQz2l/4zDpO7O4p5q4akhpYfODr2PqKsp1E5v+K+w6GhERLqwBsHQhkWWsLBFQNt8eATH FyIzLj2wYWd+KMTjGjNyA7beaYchmjO/9ZoLAYRUd0QIIac0VjkeqanyqarM5zqPuHMBgQ 7JCGtobncNOIj4xDktGifH5f/ytDvNk= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=M5HmBz+v; spf=pass (imf24.hostedemail.com: domain of rppt@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747390219; a=rsa-sha256; cv=none; b=0Nnrk5y8zIzdIs2OZ0hLlGFDczx4Y3K+G8zaDanpk9y2KUpUDKn6c4nV3PqQZfVa6N2vml zRe5F/cibXsNMqWJg1h/hLfeLOIeKeWakVIfu75SZwaFSSpli8eStVnGUIdTrtBdPX2GzC riqT28fUcp0eEh5C86P2U3ar2Q+nUZc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id B569B629FA; Fri, 16 May 2025 10:10:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A3C3FC4CEE4; Fri, 16 May 2025 10:10:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747390218; bh=l3hkmccqskrkSc27azrjBvj9XafJps7LIFqdo5AwIX0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=M5HmBz+vL9djoC56PsTH6z7K4FAy6zAPV1unkebkHnypAe1gjuS/lCMwEMWA/D4er vzdEvmounJjoZaP1JCmBj71FA7tcM5iOX3nRQ7/IsHbHFF3VIz0mV7Giy5WITO6uV+ TzEQnfdrKl5EskAuRaqIyo26EVzjwlnKNt8Xkd0kOI2jCK9fQSDGJzrwMa/dOVw+3S YGDYLXYs/nWDRYDcCEImaWZDBRexgrlXF38viCs1UKkBjoVIx28d7bDVRhxweSSlsj z047FO04gSIh4QORqSAFwzLofXdRE9FaEJ5QnQsUgfKHqLqqXP/9CUv6+GztcihDgb Ckm+y2hWi5Kyg== Date: Fri, 16 May 2025 13:10:09 +0300 From: Mike Rapoport To: Donet Tom Cc: David Hildenbrand , Andrew Morton , Oscar Salvador , Zi Yan , Ritesh Harjani , rafael@kernel.org, Danilo Krummrich , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Jonathan Cameron , Alison Schofield , Yury Norov , Dave Jiang Subject: Re: [PATCH v4 2/4] driver/base: remove register_mem_block_under_node_early() Message-ID: References: <1b516adb43371fad2dbc69c83a2ed2a224219688.1747376551.git.donettom@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1b516adb43371fad2dbc69c83a2ed2a224219688.1747376551.git.donettom@linux.ibm.com> X-Stat-Signature: hm5noopfppjuwqy9yia1q3njbyrxm1hh X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 82EFA18000F X-HE-Tag: 1747390219-511970 X-HE-Meta: U2FsdGVkX1+bgbeSFnCw8n5jhsNm1quimJ0yypDlSPF5DvhWuHBW4XewgfaXd90zUGTfgrfVtXlothzah1vStN1rO/9JhshOKctRkn2bTH7WPt67++RfDMnRSfTXEyUilpxL2/c6OLeUFXGK6DwNqqyke9rjp76AkACl7jSS7Tyvp7sXLticymXTl1YQ5T49an01Nsaaq6MhTNZWzkE+M0SjJoEz1Zo3u0WG6H5F3ApKyKfLP8464LcVnCHet3b2aNJpzkbZRvjmAsVx4o+J1kDffZAWJZKtTaHvzSgX77ipVIv2X3Y4J3kfXjHYgnN8BVxb4hKEphmOz52F0CZ/Cz/DBe86fQ/Zm/qVZ/CSuAjYPTE86VOMmUADUv2Pxxb7Y9nbCoy9QAHi7jLecdfKrgYWqb9vQinOhpqtFLC+28942MYEKgDFEbX7s3xFGRRoTn4G9qiijacoP6Gf2VCxGiwowhrPS7vnbqg49Z0oH9D7gbVo4/f4fbRZyVHsd0SaGGnq4eu3IxqnR4AdYp4FyGRTi8I7a1hPzYaUKEztGruYcofn6EH9Fj1TpDWpUMjibpd1NZfOBPLF5t8dZPqqyy+tGk5sMioMWZTjENvIMcrwukd4DoEB21+eCdDmaBv1ykiH02R2r9BmIwYZ2WAeyqQR9/V2G0CmaK+0EV81swsXfzg9+JYEc+t6UO/rCGr8J2vAykTdFfRX+uEPPj/LQ0Pgcq8oMuqRuQjGWbNHTgkdUXlFFjQJ/n4xS4zk6hEBvDsIVXbO0K5+ONjKu4STSfJE13FupBXdG90FwoDZ368oShGmVcdxmnhhxPiN3SWcVupiwUHG98emwjRIDTZnycZt3z4baNNk1iPwzIvHwgsuUkMk2JYvtKYPA6SHcxx4AwhHxnzm5ybthNNdaTOaJ15+9HhPcoOmCSpMHDvuJLQ1RLVIJZBkSS5CKRMDLa0OcvcPUY0QuA+3AQQ89VH qbzR2q/F 1juk7v19OKkZVXRRIEHVA1gPXZYSxD898uBr4yPvl6gaaE6n+uH1fGPuJfYhxCCH6WFaZuAbl0nIELd5Z24X70L3PvkS+oyxN6siH1ISCav8beWI1ZjRWV7H4+1+Ej0A43QdWxtv1W1hggiBusj4msDDQ9EDMl1+o5FQi559/K83Oe42ZKY4ir2voh4BDZ3MpyunKwrxSGVj/1Mv+JrnyyRZYm86xtTWD9BAdu/vkbVVqlTbBDRxYYSjv9UnGTsF/y033uCUYPZlOUe2Dbf+6WxvnnNj6IcBsKG1s+SkdM3i3+eCsRH4CTc+5RYOw4rPPTfY105idC7IlQVR3WldKp2TT3CqpqGyxUgAMh2/+EV9aSEi+ANc5xfUmPiG1GhRnM19LJIAGxb+gc01RH7KULAO+dN9OpVGwP0ezMfytXwKSRIWpo+kiDAyn9b1+xpeY1Fe8XE+UHTCxvVc96rSj/Uj10g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 16, 2025 at 03:19:52AM -0500, Donet Tom wrote: > The function register_mem_block_under_node_early() is no longer used, > as register_memory_blocks_under_node_early() now handles memory block > registration during early boot. > > Removed register_mem_block_under_node_early() and get_nid_for_pfn(), > the latter was only used by the former. > > Acked-by: David Hildenbrand > Acked-by: Zi Yan > Signed-off-by: Donet Tom Acked-by: Mike Rapoport (Microsoft) > --- > v3->v4 > > Added Acked-by tag > > v3 - https://lore.kernel.org/all/b49ed289096643ff5b5fbedcf1d1c1be42845a74.1746250339.git.donettom@linux.ibm.com/ > v2 - https://lore.kernel.org/all/fbe1e0c7d91bf3fa9a64ff5d84b53ded1d0d5ac7.1745852397.git.donettom@linux.ibm.com/ > v1 - https://lore.kernel.org/all/50142a29010463f436dc5c4feb540e5de3bb09df.1744175097.git.donettom@linux.ibm.com/ > --- > drivers/base/node.c | 58 +-------------------------------------------- > 1 file changed, 1 insertion(+), 57 deletions(-) > > diff --git a/drivers/base/node.c b/drivers/base/node.c > index f8cafd8c8fb1..8a14ebcae3b9 100644 > --- a/drivers/base/node.c > +++ b/drivers/base/node.c > @@ -748,15 +748,6 @@ int unregister_cpu_under_node(unsigned int cpu, unsigned int nid) > } > > #ifdef CONFIG_MEMORY_HOTPLUG > -static int __ref get_nid_for_pfn(unsigned long pfn) > -{ > -#ifdef CONFIG_DEFERRED_STRUCT_PAGE_INIT > - if (system_state < SYSTEM_RUNNING) > - return early_pfn_to_nid(pfn); > -#endif > - return pfn_to_nid(pfn); > -} > - > static void do_register_memory_block_under_node(int nid, > struct memory_block *mem_blk, > enum meminit_context context) > @@ -783,46 +774,6 @@ static void do_register_memory_block_under_node(int nid, > ret); > } > > -/* register memory section under specified node if it spans that node */ > -static int register_mem_block_under_node_early(struct memory_block *mem_blk, > - void *arg) > -{ > - unsigned long memory_block_pfns = memory_block_size_bytes() / PAGE_SIZE; > - unsigned long start_pfn = section_nr_to_pfn(mem_blk->start_section_nr); > - unsigned long end_pfn = start_pfn + memory_block_pfns - 1; > - int nid = *(int *)arg; > - unsigned long pfn; > - > - for (pfn = start_pfn; pfn <= end_pfn; pfn++) { > - int page_nid; > - > - /* > - * memory block could have several absent sections from start. > - * skip pfn range from absent section > - */ > - if (!pfn_in_present_section(pfn)) { > - pfn = round_down(pfn + PAGES_PER_SECTION, > - PAGES_PER_SECTION) - 1; > - continue; > - } > - > - /* > - * We need to check if page belongs to nid only at the boot > - * case because node's ranges can be interleaved. > - */ > - page_nid = get_nid_for_pfn(pfn); > - if (page_nid < 0) > - continue; > - if (page_nid != nid) > - continue; > - > - do_register_memory_block_under_node(nid, mem_blk, MEMINIT_EARLY); > - return 0; > - } > - /* mem section does not span the specified node */ > - return 0; > -} > - > /* > * During hotplug we know that all pages in the memory block belong to the same > * node. > @@ -892,15 +843,8 @@ void register_memory_blocks_under_node(int nid, unsigned long start_pfn, > unsigned long end_pfn, > enum meminit_context context) > { > - walk_memory_blocks_func_t func; > - > - if (context == MEMINIT_HOTPLUG) > - func = register_mem_block_under_node_hotplug; > - else > - func = register_mem_block_under_node_early; > - > walk_memory_blocks(PFN_PHYS(start_pfn), PFN_PHYS(end_pfn - start_pfn), > - (void *)&nid, func); > + (void *)&nid, register_mem_block_under_node_hotplug); > return; > } > #endif /* CONFIG_MEMORY_HOTPLUG */ > -- > 2.43.5 > -- Sincerely yours, Mike.