From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A57FC2D0CD for ; Thu, 15 May 2025 09:41:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EF3EE6B00CA; Thu, 15 May 2025 05:41:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EA2496B00CB; Thu, 15 May 2025 05:41:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D93636B00CD; Thu, 15 May 2025 05:41:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B9D346B00CA for ; Thu, 15 May 2025 05:41:41 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9557514163B for ; Thu, 15 May 2025 09:41:42 +0000 (UTC) X-FDA: 83444650044.24.0461C35 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf13.hostedemail.com (Postfix) with ESMTP id DB11E2000E for ; Thu, 15 May 2025 09:41:40 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=dIBOxKPU; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf13.hostedemail.com: domain of broonie@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=broonie@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747302100; a=rsa-sha256; cv=none; b=oKc58z7z9SU6cKf/gewc1Xsq8S1CVbioJBdulYANTRqRuNpN3p6bUp7vvDAm7Ax3raqmIS 7DYXK3O1SGNONQXtLGL7lS9etjslPqbkFcJzokcSyDbF7M81c5MFhSWD+b+NSjbn+htvcZ NSKd7TOwARjOs4L+ENLK0EGmKqat+5c= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=dIBOxKPU; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf13.hostedemail.com: domain of broonie@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=broonie@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747302100; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SrO+0BTh5EuCE/oceeG3rmAxQOe0dai3f5R+LwLxzCo=; b=bfHhyfjldS8q20B9diLvvRdwhAmEDYF810NO8F7ZNTe+LtwgArsSunb+kOkzkbQiMwXblZ Jw/YsznneUwgLhxkKavivv45Dq0LBvWo7H/7nYLEnM9ieMxv7i4KoXz3I5CVmpPjL5Ime6 FlyTSpPCJFiIoj8+XO5MZ7zzcrt9VJc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 17D3C614B3; Thu, 15 May 2025 09:41:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 12223C4CEE7; Thu, 15 May 2025 09:41:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747302099; bh=PIH1LGWKL6DuoGRpzEA9ADgg6CsrjMR1p7WJhzMXFog=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dIBOxKPUosvxTGo7zvwAYrVpak/WWZcEtSSgpVZKI+6fdjyDVrkPsnJWV+lS0FIuJ NJZBOheaWjg/f9RuifkwjQmOTcCUi/w67Tbnxuh/4bylf87PeW5smQfFRuGJ02dXac qyfNrnuZ5VNgmovGP2SIDeJBOAdEB3J3Qce9/w37HtCgDfXs6PLSLlOM0JOBm9AizQ Qi5fWPDjL2DkVKsZnL7ogWHvBoFCj0NTR+YjvWHejtOy+43hz9wZu43TXGGUq65idi 92/dGlG+ot6g6sLN9/ak7Vz4rNAsht1Rci5Uh9XQUWoW6mG4fSUIX8qb65KowLr9LU pBV4r3EX7Iq5w== Date: Thu, 15 May 2025 11:41:35 +0200 From: Mark Brown To: Dev Jain Cc: Andrew Morton , Shuah Khan , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests/mm: Fix test result reporting in gup_longterm Message-ID: References: <20250515-selftests-mm-gup-longterm-dups-v1-1-05f8f731cf63@kernel.org> <7c2f66f9-a928-4fda-bf3e-4180c7525fef@arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="8DHGkHaHDjdXa2H3" Content-Disposition: inline In-Reply-To: <7c2f66f9-a928-4fda-bf3e-4180c7525fef@arm.com> X-Cookie: Well begun is half done. X-Stat-Signature: m3fckhog5y37odrq856as6d3gu8fxwz1 X-Rspam-User: X-Rspamd-Queue-Id: DB11E2000E X-Rspamd-Server: rspam06 X-HE-Tag: 1747302100-424530 X-HE-Meta: U2FsdGVkX18w6ZFfrbi+87B94DojHKNBr95oraOWO9nAwRsyn2iuB7hqYC3QtO1X2/DHo7JSj0ChLTnfbWRTLiohkFDNVM0u6kxVOmI45TyrhxZlTrVg+88EH4aplp1JxQ4ChnYrfP5HFqlsoKU/bzPKlmtj6jodpYqMZBEoUO9UOp1BMraP1iB8jMaMUHvJykG1D083epTpVDeSlPKNURtJWtzxdur/ChvQtfIJYppDIRiVUF8u99kLpQeKwvJLhot8Qt/GKX0lg/dHLkc8Mf0v9GC/P32uciShbz0lVfiOIkzjM48cNRiAyjIkXR5r6JcDZJlQNvwIRwll0eXUZvIcvAwNt+wGQdbrPfXiEDEgL4Vpn1G7xY/WEyVbUhJUKnlBX/OkSvPLi172YZv8o2XTq+PXgVbrom8J92QMQzwjsaCxDXGcZcl2/tRatCdM9GWtgRP9g3awhT8BiKgX2/ACie5g2L5x2tYhhPlK+Pf9PS8fLEus7VyZcxGluzSrs5sZftlrTYqQWtsET/6EJG/hUet2LlXf3gzifIRkDOSirbYCPJjh7KvP8xji+pdDocAu7qZsdZm46P4wkING0VMoqaYhEB+0BzewVetGYrLdvtqLVMWXG//X4tmPzQGRYK2ke/o11NgEhY1q9V1eiVSNW55MDJp17wdVpNH4ZQFZrQp9Rnhx8OPf7ScFnx4ufCtGFZ6XJGC9C/08CLWNVwsgEY/WNGotNPO7Vx/fbC6G12Zcrwpcz88dGHSyl5KmvEHiaHv7NbfMuEqnGjXCrmg/prMIROK7EOz+fCARCp7tuzDVjx6pJ2H14+I891Shqk1kO+5qjc2JFDuk2/36sbADDmcJFK7s5Cs6Ul3Wv9jZKLPql/XdoZ+7xf29g3STj1YV6m22j3G16TjotMBF9m9U6D9wGY0HlMtN9d93FtV99GhGP7DmmA/y0wmSWK9NzGnw7f6Vk2FJM5xUV3h UjyMwsrR DXCx/1GLkEhq3wfWKOFfZnQf6g6YDoFPHAtAUBcZCjsPZwfM+BGdzB2DIGwP8zxLXpaU71Fq9YBfF8WKjX8N3HyJ+no/aPSTBh2fgVQFjWV3eX4jEVPZnLoLrAoQPt05Nvp910gcXzVVWcJUbHYUA6To/we1v+l3JmIkdVJxO9lCatOnpZoT/YKWziAZSvn9hGTb3EjQLJjLYU0XvLy5k4Jt8JWuG6yfcD41K8bgcUmf5vVP8UpvK0Fphfs8vO+k7BAd/GMl+sHDuUyDwwOTM2GIwTiLvAi9JYAmk33XBzl2efq6xaGOem35nA5wqhNFmRrxeiXT8DkFXBN+FR0oIJ4TKsLmMf/tyzk20 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --8DHGkHaHDjdXa2H3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, May 15, 2025 at 03:05:07PM +0530, Dev Jain wrote: > On 15/05/25 2:27 pm, Mark Brown wrote: > > @@ -189,7 +214,10 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) > > * some previously unsupported filesystems, we might want to > > * perform some additional tests for possible data corruptions. > > */ > > - ksft_test_result(should_work, "Should have worked\n"); > > + if (should_work) > > + result = KSFT_PASS; > Missed printing "Should have worked" here. I didn't think that output was particularly useful separate to the overall test result (which is logged on exit from the function), it's just the test result more than diagnostic information. Please delete unneeded context from mails when replying. Doing this makes it much easier to find your reply in the message, helping ensure it won't be missed by people scrolling through the irrelevant quoted material. --8DHGkHaHDjdXa2H3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmglts8ACgkQJNaLcl1U h9CmZgf/XQ9gLqG3rTeITwi7S9ASTdrZXNQxRJm5U+NDtqflavxs4pMGP7dqZAFA QVHwi6RFrDVXvEP9vpHKnpWRLe2H2PMnCKjKFaXqt/ozLE7fK3Hp55NoFqpIoBsZ XIbQdS/Ii31ZSH5LMvucIWOYj8asDPzaznzeQpwbyGuoalEHChxE4ZwjQhuXGU2Y B1FCREt6aVrtBVo0U8jHG6HHxTseVCTEHS3D5EAt3CEzszxq+lqSsjCU8olUnIhh N4GKGeuOmrEGe38BqWm6DOu5tDkGBaZaYUT82mASYvru9bpW+lJb+XzdYBGi3rjE ZovQGpYdh1AfeWIjpIRHFivijv4wIw== =K6Ke -----END PGP SIGNATURE----- --8DHGkHaHDjdXa2H3--