From: Herbert Xu <herbert@gondor.apana.org.au>
To: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: Zaslonko Mikhail <zaslonko@linux.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Minchan Kim <minchan@kernel.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Heiko Carstens <hca@linux.ibm.com>,
Ilya Leoshkevich <iii@linux.ibm.com>
Subject: Re: [PATCH 2/2] zram: support deflate-specific params
Date: Thu, 15 May 2025 11:38:23 +0800 [thread overview]
Message-ID: <aCVhr6fKFnZklcM1@gondor.apana.org.au> (raw)
In-Reply-To: <qddzdpkjsi6plu7jih5vau3xq5kjucnocoeoz7ewqbrzoiwgt6@zio43bbj5r2z>
On Thu, May 15, 2025 at 12:32:39PM +0900, Sergey Senozhatsky wrote:
>
> This is not exported yet.
>
> I lean toward not filtering/limiting anything and just permit
> what include/linux/zlib.h promises [1]. Would that be OK for
> Crypto API?
I don't have a problem with that.
It just makes the hardware implementor's job a little bit harder,
because the Crypto API requires every implementation of a given
algorithm to be equivalent. So if the software zlib supports
a full level specification, then so must the s390 version of zlib.
If it cannot support a parameter, then it must provide a software
fallback.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2025-05-15 3:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-14 2:47 [PATCH 0/2] zram: support algorithm-specific parameters Sergey Senozhatsky
2025-05-14 2:47 ` [PATCH 1/2] zram: rename ZCOMP_PARAM_NO_LEVEL Sergey Senozhatsky
2025-05-14 10:56 ` Zaslonko Mikhail
2025-05-14 2:47 ` [PATCH 2/2] zram: support deflate-specific params Sergey Senozhatsky
2025-05-14 10:58 ` Zaslonko Mikhail
2025-05-15 3:14 ` Sergey Senozhatsky
2025-05-15 3:17 ` Herbert Xu
2025-05-15 3:19 ` Sergey Senozhatsky
2025-05-15 3:24 ` Herbert Xu
2025-05-15 3:32 ` Sergey Senozhatsky
2025-05-15 3:38 ` Herbert Xu [this message]
2025-05-19 12:09 ` Zaslonko Mikhail
2025-05-23 12:22 ` Zaslonko Mikhail
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCVhr6fKFnZklcM1@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=akpm@linux-foundation.org \
--cc=hca@linux.ibm.com \
--cc=iii@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=senozhatsky@chromium.org \
--cc=zaslonko@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox