From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A029C3ABC9 for ; Thu, 15 May 2025 03:24:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C03E66B00EE; Wed, 14 May 2025 23:24:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BB2456B0111; Wed, 14 May 2025 23:24:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A519D6B0112; Wed, 14 May 2025 23:24:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 863D56B00EE for ; Wed, 14 May 2025 23:24:57 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 775251CF6AC for ; Thu, 15 May 2025 03:24:58 +0000 (UTC) X-FDA: 83443700676.25.1F45548 Received: from abb.hmeau.com (abb.hmeau.com [144.6.53.87]) by imf14.hostedemail.com (Postfix) with ESMTP id 503E410000E for ; Thu, 15 May 2025 03:24:55 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=hmeau.com header.s=formenos header.b=TPX8JyRh; dmarc=pass (policy=quarantine) header.from=apana.org.au; spf=pass (imf14.hostedemail.com: domain of herbert@gondor.apana.org.au designates 144.6.53.87 as permitted sender) smtp.mailfrom=herbert@gondor.apana.org.au ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747279496; a=rsa-sha256; cv=none; b=SONoRJKewTgRFeqDlC41tUhmGqpksWA7IAs/3/OzNZ6mrcUB/bxjzehC8jTtOA3UsWy9ol PeDDNRB31UguwW91ZMLzQ6VW/oo9vmajwYQI0peTsLCz/knCg0Q6m4pgq5XMNP9ZdH9ldP FtLfsdk3d94Tbk4Py44TDS86gsDPt8A= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=hmeau.com header.s=formenos header.b=TPX8JyRh; dmarc=pass (policy=quarantine) header.from=apana.org.au; spf=pass (imf14.hostedemail.com: domain of herbert@gondor.apana.org.au designates 144.6.53.87 as permitted sender) smtp.mailfrom=herbert@gondor.apana.org.au ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747279496; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7R6K/ai1nrk//L6Z8X0cid/jGJ8XHuu3DWVDwEsYrjI=; b=NU3O3IhAzr8fFkiapOYKklG5ISu2ucx80UKxez3qt+RQ094RcVKnBx4mwf4TvRz/G5FJDF X3O/TzDEci7zeJd3j3DkaWHogEYCiXOtNSBovyYfrNOh0M+Obig5NNULb1gFx6Tk1A4iFL S+wVuM3vRjtZrPrcPkGti3S6SgEDFL0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hmeau.com; s=formenos; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=7R6K/ai1nrk//L6Z8X0cid/jGJ8XHuu3DWVDwEsYrjI=; b=TPX8JyRhccw1Yck8Khwaqz42LI p0+ff/qqlhvHdjU0Nor6TZ7qNL5JaKMRIoOCLL9ASTCQhME02GtH2nrhsJUv8m1Kuf9S2X/7GYRpP AYRbzYDFxJaYXJbgu2m72rpctDlRioxONAIJSWmLGoFW8YqDKtCAz4zsjPShxQsYSNQlwWxgq8y+g J8qD11tLAlbUOfJKZQ1yoXw1zJIMaHdVwgpl6XoGCYQlTCap6SKDQXhdaxvBG0QmwvqBE/8LloExM UoYapu3Q/vt9CHezo72Xb3GRU2SZUijxSMaeqZCFfWYpP94IPnkRUgqel3cbqAbvYfgEb6PBX25/f 8BhVe8Uw==; Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.96 #2 (Debian)) id 1uFPD7-006DL4-2e; Thu, 15 May 2025 11:24:42 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Thu, 15 May 2025 11:24:41 +0800 Date: Thu, 15 May 2025 11:24:41 +0800 From: Herbert Xu To: Sergey Senozhatsky Cc: Zaslonko Mikhail , Andrew Morton , Minchan Kim , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Heiko Carstens , Ilya Leoshkevich Subject: Re: [PATCH 2/2] zram: support deflate-specific params Message-ID: References: <20250514024825.1745489-1-senozhatsky@chromium.org> <20250514024825.1745489-3-senozhatsky@chromium.org> <2bnnkkwhqor73ls7dvsxlt57tp2u3xf2o27opkveuqwgh3xf2j@5kzgq4eej3cw> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2bnnkkwhqor73ls7dvsxlt57tp2u3xf2o27opkveuqwgh3xf2j@5kzgq4eej3cw> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 503E410000E X-Rspam-User: X-Stat-Signature: qch78mwwnh5ocdm7i1qxti59eko4jtop X-HE-Tag: 1747279495-720271 X-HE-Meta: U2FsdGVkX18EZSbmo8V6k9mBbtESSvepSH52TvJ/8GbGi7fdwSyFcfg3/LGEoeR8EG0Cg8/kjCIYRWZ0HJYfR+Px/GrCdpjtgm2vhfCsctlhoBzZgCi44UBk7AQ/tK+idh6t+GKhLGkfBz/P1VEAU/Cnkw7W8WC14Wr51t22ozzzW+J6KBSdUOD51mW/7Mu2srpHY/2OKto3/eeIyCq3DlgRX2hHIp7SRIErqaiNQO+eKlf7qraX7XdjfvuMwIVmJbAreYn10KG/lKW0nHdAkmvKs8SdppQRkBgeZZTJy98E2VGRuupLEaukrts+/nuJWrFqqTENe3WLN1/f5IxAYpdr+ddfm7UcUthq813T2XtIiLFkjT4b59wQeEQ6rZdIuAXRZyy7TQFmDO3lkBx8RVxQlTW16m5ixFUeALZFIZ3Dg84kCGSjtywSsWPJhsrfqaGiY+21Phk9sy4WRM+pbcFGJgLs/kkJEqfBqWBEPUSZEDYWGTYgLZBn0I0Vuq4tNbRyUJ+U89CV0NGqYY6lEk20o8AN1WmeNbheI0ztyCLUskzEXAp5dx29L5AxM7e9vNuosAV8DQ7zgauRdgWb0nWkhZYnJ8zeeJ5xVKve2UsmVo4FKCgXnfqyoUzHtwZcsnhGnmLbnPaQbDF2+aQ0BcqhDuAebNj9BPPMy55zdYkYuMPlwqtbMePuTe55sMsp2D+vD0ujUqtVw5p8eFeYsTUVA4deAMvoDEjWGn1g02OYaMir5+PBAD8YGplXLnG+M3iqc/vw/haF/3375U6SBbAfNrxecuitPuPCPqxPO7EcRJt4pSCAaIicDLaGVzT7MfdkD/pL+bSsD4ETji/q+Lif2TguB2RKykDX0BrNZEvOZcCvbY6RM3rm2hdPdfyjpHSkdzaYMkKdZWw9pr0mJoMtKWeTMRmhkOVysbY1F/7w/i/UDEdyp9O4ppQydDUMv3DbTou4NSCO/VVQ13o URv0M6uV hlI3HQmM4b+ruoTLBBzhEDNrPz8rzeDIy8bH7E6FcJM8j5HRrMqxON3mWletMfLqftn4jpa22eqjbhKxVW5g8nL5wK3hC6DNIskGH2GfPMXkily/PY1kfUgoQEuoxdCV4A0m8+5suhrNT41jPF+XbjhYHsS4VBqmHGGuA2kf6nT4osfC8hnL+qn4NpyY1LG9pyg9cAfX3Yc8pKCk9JZkjJMOoq+QLKr9gThfDcysbL4HZI6rc1xCUQmqt2wPBCfbdd/qZvHb8WsX2ZD4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 15, 2025 at 12:19:25PM +0900, Sergey Senozhatsky wrote: > > OK, so do we want to limit user-space and permit only "raw deflate" > winbits values. that is only negative ones (either explicitly or > implicitly (by negating the value before zlib API calls))? I would suggest that we stick with the zlib values, but filter out the ones that we don't support/use currently. If you've already exported this to user-space then obviously you'll need to decide on how to maintain compatibility but that should be specific to zram. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt