From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF344C3ABD8 for ; Wed, 14 May 2025 17:21:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 518966B01A5; Wed, 14 May 2025 13:21:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 452DA6B01A7; Wed, 14 May 2025 13:21:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 209A96B01A8; Wed, 14 May 2025 13:21:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DFE096B01A5 for ; Wed, 14 May 2025 13:21:30 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D3AF35E8E0 for ; Wed, 14 May 2025 17:21:31 +0000 (UTC) X-FDA: 83442179982.05.C7EE007 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 56D85C0019 for ; Wed, 14 May 2025 17:21:29 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=K89yV6R0; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747243289; a=rsa-sha256; cv=none; b=Uf0EwG0o0bkhukBRndcMT54zcq/nBXoVIDkcJ7B7XrNB8AE7kL/JTcBhrC3x5Gx4+TUBAP BxoRLQpAsuGH1czZTRTPLW0ABPq4G0opE48LOvBleVwK6uzCV14DAtwEjs3F/KmCoPftaZ pIPY82M8I0e9U1bOREiJZpgb7nJnA4A= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=K89yV6R0; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747243289; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XrntOKw058pFaozmugo5yCPQxOrKWoF9hOsnY8/r2Kg=; b=EJgJpzB2yaRN/TqV2oKDBUpAvA9LLrRtTLXVNGf4QByx4Zvduo5O8UQwKSpiIbGeGub/4+ LPqySWKk4k9e+pdImN/gSA9mOpm06wTIeXrTrdEUJK2U9kFRvgCGIREtyCe0yyoK71+0Ub 74J02MJK6FiukRvtyhlCq0MjY9jWDW4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747243283; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XrntOKw058pFaozmugo5yCPQxOrKWoF9hOsnY8/r2Kg=; b=K89yV6R0mC8ZhJ4x1hpqYxrxtaPzB4jcwFinXFMO5cdLpPW381UoDuU8bjvPJ26gWpOJcB nwJ1viWXzNmrnGS5GpGcC5BNCsJl2sxwesq8HYYntg/wn7ty9U/TT3NiabRjl1LVhhgP2b zk/U7v0qfSxU6tBH2g5U2saWTdFLEvw= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-589-z9dmj1YDPdyK7YrWMidocw-1; Wed, 14 May 2025 13:21:22 -0400 X-MC-Unique: z9dmj1YDPdyK7YrWMidocw-1 X-Mimecast-MFC-AGG-ID: z9dmj1YDPdyK7YrWMidocw_1747243282 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7c5f3b94827so12785a.0 for ; Wed, 14 May 2025 10:21:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747243282; x=1747848082; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XrntOKw058pFaozmugo5yCPQxOrKWoF9hOsnY8/r2Kg=; b=d+rqM1o1RH0Q6O/Ofc25KtxI4G036tE2D/9TRPkGBpu86OG2V57qPIvDaWS0Cg2kkX NU/dUouXL1bIBSnLJKHIqRo49p0rq1KYyQZrLXjIL+Q8XDZ01MtpS6XaqO+fajX631Aj qo5wOwgijwSvfq6NQc1R3xfr9aldpjUqWzTg/x7PmyLbr/OtxgSTeQpAiMfQRlFZCg7i fR5V8eIYxcLe30VDH4skHfzgrlXBfuYE3dt0MFomeNsR41XYwCAH4oE26FRqDFfC5TA+ YA4QaJ+qlod9Iq+WCYVrTl8BrA341P8Q29mijA5ABfDBeay317XxUJaEhRzxwcqTL0yj 94dg== X-Forwarded-Encrypted: i=1; AJvYcCVRM07G4qKG0DUQ1ZPNjYWtBEs/qLrQa5rl1+xhLsccrpmGP3RevlPS1d9wk1dyd+stDk2/+SrwuQ==@kvack.org X-Gm-Message-State: AOJu0YybZ090L8lfCxW2YFCGBY0XumMgnSYPc6Nlu51DxFug4FyWDhHV 93XLz/IqwhmNsbXFQ0k7jMWJ3P6R3r1TeO0/8n+6s0Pu/cuz5g2rLJZjR2R+I3wajCFUTuSiqel JGaHvLcDudU2xEcV9wn4vlsZKyeSv/0+BcG6iwb4VEWlB0o9D X-Gm-Gg: ASbGncsVWPinJMObzwXTOCzlj0/mWYGk6iwvVRGdGjY7YxUh6ubPOargol8iVeBZjOZ sqC4+LfkNVNAouM2IeeieiCsMu6bZuwd1Khd//NlpUoNTKg73sGOoRE/OeH1n6i/PkZJR8HveoY J1t6tFqCh/HRb6fejXqnDE9jlp+OuxS3Um+MKSIj63xfpkE8AztDbYCVWZYRr81x8BcYJ9I1z8C 3aYFUi5U3czmiphMS0IdM/gBbvl/LcFuwnmSKygTXBg8ep7cNbNzs4Oqa5Ad95NP2Ov8qfhjrAQ tlg= X-Received: by 2002:a05:620a:3902:b0:7c5:94e0:cafb with SMTP id af79cd13be357-7cd2885ce98mr656490785a.48.1747243281677; Wed, 14 May 2025 10:21:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHlRhej31PFKXT+uomnSZgUi1MBJW96d3uyGJIRGzzt4n9pb6pmzr2pMVVfkmYyry22hZPjdQ== X-Received: by 2002:a05:620a:3902:b0:7c5:94e0:cafb with SMTP id af79cd13be357-7cd2885ce98mr656487685a.48.1747243281342; Wed, 14 May 2025 10:21:21 -0700 (PDT) Received: from x1.local ([85.131.185.92]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7cd00fe77c6sm874667585a.108.2025.05.14.10.21.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 May 2025 10:21:20 -0700 (PDT) Date: Wed, 14 May 2025 13:21:17 -0400 From: Peter Xu To: Alejandro Colomar Cc: linux-man@vger.kernel.org, linux-kernel@vger.kernel.org, Andrea Arcangeli , Mike Rapoport , Axel Rasmussen , Kyle Huey , linux-mm@kvack.org, Robert O'Callahan , Suren Baghdasaryan Subject: Re: [PATCH 1/2] UFFDIO_API.2const: Update userfaultfd handshake and feature probe Message-ID: References: <20250512171922.356408-1-peterx@redhat.com> <20250512171922.356408-2-peterx@redhat.com> <6eobuzkwm6xhpis4s52dtit55fws37elv5d7zygaf64czcjag6@brz2nrc6qptu> MIME-Version: 1.0 In-Reply-To: <6eobuzkwm6xhpis4s52dtit55fws37elv5d7zygaf64czcjag6@brz2nrc6qptu> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: DqEgN9t16ObjAKfwW9N6QmpOkPdn0SSM4xjqu7zo7i4_1747243282 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 56D85C0019 X-Rspam-User: X-Stat-Signature: xrfox8bu6b4bycung79tiync19rca911 X-HE-Tag: 1747243289-263495 X-HE-Meta: U2FsdGVkX1/iWaqpuTTpeivCFdl3enUO98ei1TpltA4YdIMyNov+QobyaIWRqzWS6OO26TUWhygt47fTDXkwRN41rnI+3inxRVSbjTo//cfwKkdB7rKMA6qp5AOa+uHmzY8iQQWTH0ofd4RS34haYjct346bgTuorqePmVBTm7444pmn03OEPSZQAuOxxuG2OqjSi2CUKvKC/Xsv1wo1zka8z1JKD2bYQzJKKeKaVjeBTHjjBSJiDvCNsekdNKh+Q+b0LViNsMLm/XIDITH5IaRQgypdB3ifbuR0HLGoz+uoUMEtkX0r8QVbrdoRSxbg1g3eYhIeyhda7uHxSLp+NsO0RArDR8jcI9Bqk+fYVpnY6EpGzvFiXTL3H5aMvt18gljJsgzfmo+SNNuV8AIlKKof0mY6viyECa5AgU0S8Zy+vahifEJM5xCwcAJ48/LjPZqa6YVInfJxvzctp9w+a7Li9h18BKvvjWMUpUtO0QD4uC6Ddo9CtaHRMLvTGeHL26YizDSWVvA10x6cw3LY0n+RzGu7iubDRDa6kjfsbWp/X/0XD5eGagPznfSur0G6IREBQ00pcSifhXGM8Oj7esi4C0APmiTTlwbVhAGdWuMQmbuDuIL//VHHSfKiff0RNbudxgI4cYQ6YfZ98Ej/6yUZebSb301KuW7omD3tPXSfpQL/f0AluThGS3+zDVyowBFXo/OD3zFZG9NEoK2rffyw5FGKjIzWaUb9F1IWl4zwJIMIvnxN6k2s10DhqW6LGX2Hf+WHLxdGNqA90J8BXTSMYySE943I8QZiD6TxH8vuoItntb+1QxxcwG/8SVuf0oQNDASKQAVlbSTGkSCCQ1MWkvMZhn/fih5j2iTbZYbvQzaYjY4bdZW05nCeUOeQcJgHSkkhGvfL0Bl3oejcwHVqtNiyBv652PQ7GEiBZpTJzqGhb3sh1ZO8H7ifdLY9TYRtTElDH0avtPxef9j yfjULir2 +Cw32Vt0OhBGkAMf3b6QTmVCLJNAp8nBvYDbplebvg93XQZC59Rgkwgwj9RdMwiH4cCBI5oMgKR25dKDGAyGvl51AujpX/N7pQcv8fZnQHR56TldneOT4GEMh8+S3N4thXdd2LtPsKCgbNxbR1CZGDPpfM3X8S438yTV8SxfmFQQB9LMUSvZyT+eEBmr3tUp8l1GZ1cJKQSdhq3F1GmGmzB1DIWMb4A6a7ct4kEEK1BvDzPmoa9L8av45XJT5vsYeNAydc4k730/+hEWhp+ybyhms20hrek6gG6PU+nXuqCaRbZJZSgGV2u2kFpIzD7ojXGY60iC6fArPcdXc0EX1Igqf7TVahL85naBrKnh8L0BsnWGjiTWYPV/PnEZac08VPpywY6jClT9tXk8X7MNqMEUbR59r5XagnIgBvyZUlCfuq46Os/BFvuYQLZnrxApYNQhmMR05eN7OcKzlpr6gb3FOjqQHE3wmgtr9MS/EcqKAs7Djuxs42UbytucsYawbfKhvtAdQmkQ5v9l7kX0CPWEtEz3wwigi/5ym X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 14, 2025 at 05:59:48PM +0200, Alejandro Colomar wrote: > > +.P > > +For historical reasons, > > +a temporary userfaultfd is needed to probe > > +what userfaultfd features the kernel supports. > > +The application needs to create a temporary userfaultfd, > > +issue an > > +.B UFFDIO_API > > +ioctl with > > +.I features > > +set to 0. After the > > Please use semantic newlines. Break the line after the '.'. This one was overlooked indeed, will fix it. > > $ MANWIDTH=72 man man-pages | sed -n '/Use semantic newlines/,/^$/p' > Use semantic newlines > In the source of a manual page, new sentences should be started > on new lines, long sentences should be split into lines at > clause breaks (commas, semicolons, colons, and so on), and long > clauses should be split at phrase boundaries. This convention, > sometimes known as "semantic newlines", makes it easier to see > the effect of patches, which often operate at the level of indi‐ > vidual sentences, clauses, or phrases. > > Also, please say "zero" instead of "0", as was in the old paragraph. > That will allow git-diff(1) --color-moved to detect some movement of > text. This was not part of the old text, but sure, will do. Thanks, -- Peter Xu