From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23574C3ABC9 for ; Tue, 13 May 2025 06:33:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E336B6B000A; Tue, 13 May 2025 02:33:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DE1D36B0083; Tue, 13 May 2025 02:33:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CD1466B0085; Tue, 13 May 2025 02:33:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B3E446B000A for ; Tue, 13 May 2025 02:33:40 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id AFF15C1931 for ; Tue, 13 May 2025 06:33:40 +0000 (UTC) X-FDA: 83436918600.27.5F5561C Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf09.hostedemail.com (Postfix) with ESMTP id 2B249140007 for ; Tue, 13 May 2025 06:33:39 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=J84i2i9s; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf09.hostedemail.com: domain of rppt@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747118019; a=rsa-sha256; cv=none; b=3C2t8QKIJiwy6Q2h97RD1UN4gCnX3eUvUx4edX96oy27YhoZF/SBNv7GbgFdkYxNXXqsHP 2TPBNhSlLMjTJ51Rrte8G1EgYVbfnxkGAlIrke0pNgY3stX9UA7weSqsXtQNSCabcHz/n9 PvoXr3HgWyS7/THNF+5M41neyEkNt0I= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=J84i2i9s; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf09.hostedemail.com: domain of rppt@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747118019; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lp8R2kWxreO5X2E/FTk1nZ9n4PddvC2/HJN1ozE4TRs=; b=D+ci4UZvwnWkeDZoxpxBeeqyKH5E5SKYJmTp3cdY3FGDdj1sildWrHaPBcFI4WDVHrJPa0 aPia9+kSmPBWv4qv3isb7y9Mu+/5KyUyimZXcHevQWw9UmQJnbp/0TepPemTCa7+WxEEXn gK3JhNvWLSseufInB/tG4bCQfsY7Wfw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 9CAEA614C0; Tue, 13 May 2025 06:33:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2901C4CEE4; Tue, 13 May 2025 06:33:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747118018; bh=qZoTA3gBmO5gZK9zEzzhzSKtJhMXJMUIFPp0GHsvvYQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=J84i2i9s9DZJvveDWOpy47GEOkdgxyVOjsC3PqsLV99zmj74mGszb32iTMLyI0K7m BRfwTNMuatJlExVHJ0OvrJS86xYLxvLx8hDlTJGa6Tpasz/Gbu96N1bEN4floFiVap Dj7Wd8n9hulUXjAJg2Brndu9wTg5AV9fTFAFCej8o0UIp8wo+Bw7bEsNqFZCVO5PcX x++7e0fgDa3099mcq2+RZI60H0f2Ty00q9D0v0R5De2PLFEQbrGqxBl16PojuHS80e 7ktLemFyMxa6c/inaVqc1SFdxm5liKwqn0wQccoVpyvBBxgOQ8CHMI46m/STjcgKWd /ixoIs64wu3Sw== Date: Tue, 13 May 2025 09:33:33 +0300 From: Mike Rapoport To: Linus Walleij Cc: Andrew Morton , linux-mm@kvack.org, Pasha Tatashin Subject: Re: [PATCH v2 2/5] fork: Clean-up naming of vm_stack/vm_struct variables in vmap stacks code Message-ID: References: <20250507-fork-fixes-v2-0-82ab1e42cde3@linaro.org> <20250507-fork-fixes-v2-2-82ab1e42cde3@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250507-fork-fixes-v2-2-82ab1e42cde3@linaro.org> X-Rspamd-Queue-Id: 2B249140007 X-Stat-Signature: 9g9gdfxspa3ynog31jrpqwo97ujgjas1 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1747118019-504212 X-HE-Meta: U2FsdGVkX1+XyA++DUn/QLLm7VBNO1qCfOiDJlHtqV5KEY1ODX+G+slOYf2sZ78qrTAbKPkbCMkhGi2oLcoalITcF4zRz7XLpm+vPF3ZSIBxPv0LhCCIs1QDmWKqlKMpe7C3VyGgaX9RD+LobUlKeyJOGb2I96sKnQDrtw0qLtYLLVp1U38POKZE4ZBI9a3SIOWIsaufrBQvkxwSfRx10bKqpahgqOUxsogZhKAOo9nBe28Ff3CI71cP11QgGoZz1fxc4oBHKsw5mJ7O61D83Hn6M7VeSXgI4M/e6R3ZJ6ad2Rb9YAYaCMdhxsoFpzpOSWN95tUDL4UUk4YUXGVlQTJAefnsC/kDM/7eoQRLDDl+i9GXeCAhFG1ulVL2x62psHsc7ntkq3dbrDLuq/A1G0DbL91ppDLllZD8UcKQl5NQ2/JwBLcjabmgHldTjkvmS8TuvfdEWZHJYC/GwdX9XipQYWktYh499Bb7WBsNjQc6Q9XOc09w0ZQEbctN8yEs/byUHFPIx4WzrGhyqzT/pHLU7DA/fczp64Q1sTSfuCzjMgR3dfDbsc10yvfixFqVGL6+kY+BVyxO4ZVo7w0qfFKI/cCXyOHIUxAQPKYctSB74U4IAUmXkLruYDayggpfsa+NEo253RrgvVrtI8HydZHb4hafiF2oAVYfeJJOAWro2AJBCZxoA465PzzD6wOvY37g6YKxjQ5BdJEW969CuD35OsQdobgpxraNnnvL3SqwSSrWiEFz6CKL1xVdWYXH5XnIhnWXcUT+YY2DjQ5MlJU00BxYaoeMI/iMLW7YcNP8lG+cKupbLigbTwNXzKUUZjkWvjPa3qjCr3VNuUYKQ7XClXVxW8GlUNylYDbfyfkQwt2PVw6u7APyQM78Kn4EkURMZByk3oioR5KQZZ2iWGzfD7zOZEOIz5xxjb82mU1tCMjkMxH6CVrjSVgoUC0/BTxhLDYziBZNK6WRxO0 55kbQ+Eo WcIQeYLDDk/QSCni8S97VsXchysPOtSAeQa10A4kYVuKI+rEWQ7tyreRZpBAHIWkB0rHuUvPftYZy2efqtQWWnzdgnOnqn0w4A/A91VgU70wX5Ls18ouBDzClCvg5vH7GV9GEocgzLJnCAGwZU15x9LCiXL1OZ5v5cFHO/uBwk6oPKUtG9w7/xnyNdLfdS9CyzEtM5O/hvtsqWBg2kj0AgEa6e7Gd4umc1AuzyHQCcwXUXkRGz6T+sug+e2b0yVOKEHUKAhf7GDWPq3+ZX2TgimJ1TdI4KOGarOQqnOPuq+R/EEJEUZYQocGetyAQ4QbaCR/vCOW1av0Bxv8TGGtBIEoedXC2Tc3fFECH0rkLHBKu/ZGeY1BXqem7KBzbMx0xySRD6tfX9qWxDrofySgav+6VXpj06Q0s7dMYObbffddMJQLQGZW3bp2s+A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 07, 2025 at 02:46:28PM +0200, Linus Walleij wrote: > From: Pasha Tatashin > > There are two data types: "struct vm_struct" and "struct vm_stack" that > have the same local variable names: vm_stack, or vm, or s, which makes > the code confusing to read. > > Change the code so the naming is consistent: > > struct vm_struct is always called vm_area > struct vm_stack is always called vm_stack > > One change altering vfree(vm_stack) to vfree(vm_area->addr) may look > like a semantic change but it is not: vm_area->addr points to the > vm_stack. This was done to improve readability. > > Signed-off-by: Pasha Tatashin > Link: https://lore.kernel.org/20240311164638.2015063-4-pasha.tatashin@soleen.com > [linus.walleij@linaro.org: Rebased and added new users of the variable names, address review comments] > Signed-off-by: Linus Walleij Acked-by: Mike Rapoport (Microsoft) > --- > kernel/fork.c | 60 +++++++++++++++++++++++++++++------------------------------ > 1 file changed, 29 insertions(+), 31 deletions(-) -- Sincerely yours, Mike.