From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCDE7C3ABC3 for ; Tue, 13 May 2025 08:01:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E9126B000A; Tue, 13 May 2025 04:01:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4712F6B0083; Tue, 13 May 2025 04:01:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 339186B0085; Tue, 13 May 2025 04:01:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1544F6B000A for ; Tue, 13 May 2025 04:01:53 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id AA411C1B52 for ; Tue, 13 May 2025 08:01:53 +0000 (UTC) X-FDA: 83437140906.14.C1F82D1 Received: from abb.hmeau.com (abb.hmeau.com [144.6.53.87]) by imf24.hostedemail.com (Postfix) with ESMTP id 0E10D180015 for ; Tue, 13 May 2025 08:01:50 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=hmeau.com header.s=formenos header.b=QE38+k6H; spf=pass (imf24.hostedemail.com: domain of herbert@gondor.apana.org.au designates 144.6.53.87 as permitted sender) smtp.mailfrom=herbert@gondor.apana.org.au; dmarc=pass (policy=quarantine) header.from=apana.org.au ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747123312; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=udPvSCRSnS0pLMv4b2XH86HcPTSJhkrdLImmvkdv1Ag=; b=BVppgX51TV2y683/tgRgSfehXrGGfJ3hxk80qyLY2urnI6VRMTQ773FexBM7smbuF9HzPV cceIr/em7qqrv877vyyCPgHoZy3Um9yDF0Phq7/Ssaq57OGUal8UDqLcme07AZ739ZpukA 7l4l+gHG1gQVFqdatml/C4LZvUnTLhs= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=hmeau.com header.s=formenos header.b=QE38+k6H; spf=pass (imf24.hostedemail.com: domain of herbert@gondor.apana.org.au designates 144.6.53.87 as permitted sender) smtp.mailfrom=herbert@gondor.apana.org.au; dmarc=pass (policy=quarantine) header.from=apana.org.au ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747123312; a=rsa-sha256; cv=none; b=ZkSet60CpDniz94jasMYcuYw6qYRTd5qBC8fGpfsQSCIFFqvD3O4aqPg+QsCxhf0Uyz4DQ OlZZ8s04C6q7v/g8lkzVExxQ4x1UBX8dkaagzjwrW9OkFkV0yQh/hoYmlGtcL8eWpmAWuf qRYoualigPX2CAeqz134FOHFen/dRAU= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hmeau.com; s=formenos; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=udPvSCRSnS0pLMv4b2XH86HcPTSJhkrdLImmvkdv1Ag=; b=QE38+k6H+mGxa3TKMTxlicJh9M 0vMBdCSj6ehOIwHSwWiwZcVQCSMkZVlkQ2yloLbJq3AFvXIffUrm7I6drOxQ5sej9lbUGStQLyLXL xZL361GdJNngh+v+4igmgCNtZkuetRUkNEcv0GNUcFBB4inkfHg+fUaT97+M4anLYfXQOA/wUi88s Som+95F4ndpWdL2WvX1le7NGCH5/S2nnQFOUHRcbwqO2cidhwD4XeXU/tGCucS7Le/m9Pm2pUJdgp 7tFYigMgn/VXX0bUiQKo5fx/eUD36Ioj9DBqGKoJCzu6vijpHR88NJnYuOoDQRhObCBm5B+KTbvVy aFdAsLpA==; Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.96 #2 (Debian)) id 1uEka7-005hLH-11; Tue, 13 May 2025 16:01:44 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Tue, 13 May 2025 16:01:43 +0800 Date: Tue, 13 May 2025 16:01:43 +0800 From: Herbert Xu To: Kanchana P Sridhar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, yosry.ahmed@linux.dev, nphamcs@gmail.com, chengming.zhou@linux.dev, usamaarif642@gmail.com, ryan.roberts@arm.com, 21cnbao@gmail.com, ying.huang@linux.alibaba.com, akpm@linux-foundation.org, senozhatsky@chromium.org, linux-crypto@vger.kernel.org, davem@davemloft.net, clabbe@baylibre.com, ardb@kernel.org, ebiggers@google.com, surenb@google.com, kristen.c.accardi@intel.com, vinicius.gomes@intel.com, wajdi.k.feghali@intel.com, vinodh.gopal@intel.com Subject: Re: [PATCH v9 02/19] crypto: acomp - Reinstate non-chained crypto_acomp_[de]compress(). Message-ID: References: <20250508194134.28392-1-kanchana.p.sridhar@intel.com> <20250508194134.28392-3-kanchana.p.sridhar@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250508194134.28392-3-kanchana.p.sridhar@intel.com> X-Rspamd-Server: rspam10 X-Stat-Signature: zdda1ocqccsgdb8mjecoj8zengsdmoq3 X-Rspamd-Queue-Id: 0E10D180015 X-Rspam-User: X-HE-Tag: 1747123310-155202 X-HE-Meta: U2FsdGVkX1+Q7Ts3/7TPYqavQBIQsAqlTiVg3X1qSbLCaJFXf5fAmnOxlHxmQ6QF108JBGGsJwitdfwra1en/DltzWSATf0XLmbWx51N4XH6D/qfvZ5gpECiUsJsuzIdaSDHDSsDq0ENG8AmTZt8lNsMs5Tc59E+oRQk0xdECFBxFJDkzdNfUwayKzrMODLaWnmvYLBRx5FoXRWilkTMOlTrOXKzzN05pRgahGx24oDgTPy4Uh9qmgNNH6Cft6WQ0+rfrURKrcX6DNH3tczvVDiwRzMhCdkSMUNvbygu2HsiTQIrYz2N3hyikSbSvVZQIwcmzY02EDU5Qv8QN8KEG27ZT6630WJh9QckrLN8Mwt8FB1zB3LGxaAUayq4CPBFOBN1h0leSBTWx4v5gaRbkuQpYnHoHQCoNZx6xR0CngMpzH3ax4ZWiMM8zYDJ3wte4UN6Dabb6w7u3B41YAWsMen3nRAMD3DDuogAi76LNAy/a5M5L7/UUVCpjVdbfrgfy1IahzXS4aRxxL62Um8Pg4/Mjt7SMc0Jz9sY5Pon/kESmf58suElxU3ZXJd7sg3VNq04kwuH+be4wi76IgibNzbPtLYxDxvlrZX+pUCulMWDrvr+RpstIWWIY+rxN0vCXvSCBkoJRNe09ggNkcKKCbs21fqSsPiZvTz7Q+obP+CsZPTLsvmQnMFk+ajB4KxTsq4N3IrAbNTWmmk2vdR1BQbI00RHsEdseNjnxlA01+vCAqzc4JaK5+Yp70/m6NPWo/gHKyIL67GcJqEu9kTrJgNLF92zo9b52SDGjVA4OaeJqX0PrNvFhpCK57BcFPf/q4uSYcYVFBr7UvlbDG/HK9zmo3jPhDEkaRoSRnNhtD6/T4KooojZNSAk6eL4+V6YIW8/U8ml+Cqm33s/DIl5CnulDpOj8L00np8HxkVpOjh/N90NuSCsGGuq7RhumZY2aAR0JhtZ4P0Vo7qc4nF O8WqQeuV XvCJgA4iVM69kEBI8DQKC3AZSepD7UyDkxa53E1YFbVgcQIDofxiObdPcTD8Ep98lVxdITRIfV9j/Fztyjikq8giScaXCYi5RIT+nWjh66HrBDNZlDJaGRq2f1bIuGZgmW2VgWcc94KgZiTRBECByfkei83AUgVPvgj0fWHqBDoF32lBCnvVooUWZ+9a/uc4OFJ/M41bKBaEQHNrklfzx5bEdJo2aAAcWz6EpLSmd0F13F+XF8uRDhkWEZBiziQucDmQpGng0IFqRQrTOVZV+g1Q82rX7ISOfMV48cHykA/3d+D4DrvlapD3lTXD0t9bas6Qy X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 08, 2025 at 12:41:17PM -0700, Kanchana P Sridhar wrote: > > diff --git a/crypto/acompress.c b/crypto/acompress.c > index 82fb3c04e68f..d08e0fe8cd9e 100644 > --- a/crypto/acompress.c > +++ b/crypto/acompress.c > @@ -310,21 +310,13 @@ static int acomp_do_req_chain(struct acomp_req *req, bool comp) > > int crypto_acomp_compress(struct acomp_req *req) > { > - struct crypto_acomp *tfm = crypto_acomp_reqtfm(req); > - > - if (crypto_acomp_req_chain(tfm) || acomp_request_issg(req)) > - crypto_acomp_reqtfm(req)->compress(req); > - return acomp_do_req_chain(req, true); > + return crypto_acomp_reqtfm(req)->compress(req); That's not right. Request chaining has already been removed. What remains is linear address support which you've just removed with this patch. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt