From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6972AC3ABC5 for ; Sun, 11 May 2025 05:40:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D87B6B000A; Sun, 11 May 2025 01:40:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 188436B0082; Sun, 11 May 2025 01:40:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 075DA6B0083; Sun, 11 May 2025 01:40:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DE9BA6B000A for ; Sun, 11 May 2025 01:40:03 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 0B6FB16193C for ; Sun, 11 May 2025 05:40:04 +0000 (UTC) X-FDA: 83429525928.12.775CA88 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf10.hostedemail.com (Postfix) with ESMTP id 778B8C0005 for ; Sun, 11 May 2025 05:40:02 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=YsLrTAsR; spf=pass (imf10.hostedemail.com: domain of rppt@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746942002; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TmQkfMwfhBLnd7ksmTAewOXaIgct6a4t08VO6GQOhxA=; b=FeUDCd3Nl/f5fhX43SYGN+FUqN5GGYCanHIYt61w/XOAO/0gJ+sNFUm4873r7r59SFhd9Q OUBWXjqDfi09LUElVyVmEfaDpKJHJXoM/Oorq5VPpkYNP/CdTILHVoZdJFShZb5KaY9A+x btS4bGaVCVfeXpInQBy0VqdpqEXAmeg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746942002; a=rsa-sha256; cv=none; b=xvOgpBoHZuiCv22Dqw+EC1ol4nw5rq3uUYAN2XSqAKxgaHMO1h0k84oLcduCBKxbyhD1Jo Gklz6ijYOg5QBIngUgP4fVD9r1Q7B495lym5OwFf3J9nRs9R0IQOVr3HvFr0fT++PKQnkz ISg9ncfwMVN0p6ho+J8vfKS8vM6mADU= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=YsLrTAsR; spf=pass (imf10.hostedemail.com: domain of rppt@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id BBFFB614BA; Sun, 11 May 2025 05:40:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B10DC4CEE4; Sun, 11 May 2025 05:39:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746942001; bh=/N5CODU6Gsfb6Dk5IjnCx91l7Y0VcrZ6LX2ESsYDagk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YsLrTAsRjADvsjWuPdOwtaEEqm/fLWWywPz7XwD5TA6CBSkF8+dQCGrBvqlFCC1YF iaQK4nMKCwcBsxV6oi1Y0ATTCZJwkLAwF4jTx9vhjXA7PdI9EobmDfUsa0q9CKgork cSpTopxVxIZI6fVrChIgi9QkHNXZKxRohZrYdgWs6/up8vdU9P1FojTmh/5maAAIBq kucWox0X/ixQktxVrrlOm4TUqoASgOLWqvpZ5JYWk0dBZ4lWUGz3A4H9hVH1KMRCJw lZJRSE+7YLDq+/j6cwlGL0K1f/IRbQkxBdeMtfnnmpoEMTm1Fo1KmrV0CX1owR8cHR HJBpm4NIvQFMg== Date: Sun, 11 May 2025 08:39:52 +0300 From: Mike Rapoport To: Donet Tom Cc: Andrew Morton , Oscar Salvador , Zi Yan , Greg Kroah-Hartman , rafael@kernel.org, Danilo Krummrich , Ritesh Harjani , Jonathan Cameron , Alison Schofield , Yury Norov , Dave Jiang , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/3] driver/base: Optimize memory block registration to reduce boot time Message-ID: References: <188fbfba-afb4-4db7-bbba-7689a96be931@redhat.com> <74c500dd-8d1c-4177-96c7-ddd51ca77306@redhat.com> <8180a50d-eebe-4f9b-9ce8-d886654a992d@redhat.com> <78bc6a1b-164e-4925-a624-a271a4499364@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Stat-Signature: 6bq4a67rs1nden6e9ih67jcsjr6pa1fk X-Rspamd-Queue-Id: 778B8C0005 X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1746942002-612060 X-HE-Meta: U2FsdGVkX18/xTrjw2UO23+zczMiz6nDbYaBVdko8F5MWY/MH15quKL4TJO9BDBrVStaQgOr3u/Oc0agOOKrLNgBepUFjAXMbzKX+dAgxZHuECeyISaUImC1u1XdCkLgS8/vx+WmtIyskPH+/WRPMcCQXz69PlkBH3re1QA0p5CYpvBS2FLCeA26vKaa4Je5XQDrTAgIhUEZcoY5vZGnmaZ1k84LiXI8bps46CWhgberQ8BLs/v8LRVMKTC8Ix5GafpfdwV2Lta6r7a6112MsqMxsft/3Y3yg3cIpC5KmAtNcTk4QdGVgBS6N7iccFw/Ey7ejzH5azbRFXoAKWEWEzCSm1NoysmbNZr1Ir1ebbyNuvjtrvNE7IbPLg/U5lYBJD28IqWA7bERaHkEvOt+SmbuzpFfkDriqiM0JOOYxhDmfQL3Z9aMZ7g1o/OXv+vTX9sMmPeva/LO3pysikyAEY+ajYlVjLj2NoQNkM0yE18mya733eNN6hNQRAcdkn/TaK1I7bztgPJbRaTMDc2jsQmHVwFcVi42eN2exSori7EmBx65P5y6dEA1uycMY4RxnRiNXQSmS9PjQhjSfetddEx9bnRm5bOrV3hRhNA9wFNKCDsgNslNx1lMrT9zDUB2cokgDKzcZVPB0io+ZOqDFwtLOU8F8WIR6Jb/leUKf5yZyODrSU/QPmYHXnGsrFGAVJi+P/jb5FGA3bKwOPJzcm0FqNMhqjTkW3l+ju9ws9XvgeFTFyIegK4LGzftOkP76QIGqWYvJvzsavAlOc99ktVrkZMPvVLq2Bo/xWW8NIxwMAOBpyuKRGZ/aD6n02DBnUIskp0RVSKn3BAZubK7569OROspJHk+glSyVT/R4fUnuGsriygHfu41p6HdsVUFKcvLhFCvz9Ziv4uwiaQa/qAZuxmDoTZYlLQxy7XUT+Eo8pbeMkp1PJ3MgFiHlPhequN3c+8w5x9B+0k0Afs UJf5GWNM xN9lqbsqJqVxzqPz4Gm6TUfpGN+ubzsu+HsA/gptVMOBoDt9fT+WWotq3ZhT6rEuEgRi1SQ9mQ326ZgD94pT6PyK2Qq0AsZ9+xQaqy4koDyghNv30yWaZixlCfVoXmGf6uIv8D0xtJl0LXUNuecMVDCBFWhemxdZkQknP1KThx5HOg9uq6Tsdv/W2mUD6rJgGS4GYPLPX8AkEWDnziHPgLzvDAsrtop9BqS878RivPPINZKgN28VnQhK4ccPF+4QmNND0dsZnmJWvj3NBntJTVA0F//bFwipqwoPnMdq3w9Lllgv4D1P8XJSlI1hL0KqjvOgQ6yfsB1VxJE2tTPP51N3fbvgbsnLuh/az X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Donet, On Fri, May 09, 2025 at 09:10:34PM +0530, Donet Tom wrote: > > > > > > Then we can drop the call to register_memory_blocks_under_node() from > > > register_one_node() and add creation of memory blocks to > > > node_dev_init(), > > > i.e. > > > > > > node_dev_init() > > >    for_each_node(nid) > > >      __register_one_node(nid) > > >        for_each_mem_region() > > >          /* create memory block if node matches */ > > > > Yes exactly, that makes sense. > > Hi Andrew and Mike > > Based on the discussion so far, it is clear that the patch will work in all cases, > including when CONFIG_ARCH_KEEP_MEMBLOCK  is disabled. Just checking — > would you prefer to take this version, or should I send a v4? During the discussion we concluded that the right thing to do seems to drop the call to register_memory_blocks_under_node() from register_one_node() and make node_dev_init() call __register_one_node() and then create memory blocks for each memblock region. Can you please make v4 along those lines? > Thanks > Donet -- Sincerely yours, Mike.