From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BFEAC54E90 for ; Thu, 22 May 2025 10:14:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A3656B0082; Thu, 22 May 2025 06:14:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 353A76B0083; Thu, 22 May 2025 06:14:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2695D6B0085; Thu, 22 May 2025 06:14:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0DC796B0082 for ; Thu, 22 May 2025 06:14:03 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B7FBEE7119 for ; Thu, 22 May 2025 10:14:02 +0000 (UTC) X-FDA: 83470133124.25.BC7D167 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf07.hostedemail.com (Postfix) with ESMTP id 803694000F for ; Thu, 22 May 2025 10:14:00 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=svP685j2; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="8l/rmVdx"; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=CQk9PPjZ; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=13aXx17F; spf=pass (imf07.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747908840; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TTj530S0+pt4TB23fjg5olxByY/4NarPybW7KGHkyhc=; b=I2vQtcQf5iON1a9Ol3/kzZRAkdQ3S1Bw8aFudefhHB/3C9iFoBlp/aEVH4Zg4S0oWo3dnA u79jcyVcSAJBm68BegSftCsukZowCI+lcqIu+9zsFdtDlFIWP8kV4ChxIBzb5R0YoJKb+H Ghos8QtGYWWn6zFm/YGcqts3NO/OyNg= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=svP685j2; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="8l/rmVdx"; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=CQk9PPjZ; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=13aXx17F; spf=pass (imf07.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747908840; a=rsa-sha256; cv=none; b=I0LJ5TXxseEagOatTEKrewodkQljHwoi4i0XGjRnjQIaDsodmt3yOonFqdGbIuNvchieA8 LheRtQQcdMl6QJ//JY4up5yyLrszQMbK6wXRvP79PPTne/ny8mjnXRP6FDcK5l5hGQ9x0z o4/qxYXxC2k0LsQgESZhAGJz06upBOw= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E4C64219AF; Thu, 22 May 2025 10:13:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1747908839; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TTj530S0+pt4TB23fjg5olxByY/4NarPybW7KGHkyhc=; b=svP685j2KPgsEpvtXT51KJY5WgnxyyO+0y1IG00r8tOBeCBFrcTJdWQJx9PeMBaYFl31ic JWLFLU+Hrlau5TgTIWfO7ymgliTXfxy6eB0VZ0UtjwEAI90zICTxxkWrvBt3MLMho9Qe1h cwTL9TiFTEPoQ9ARW91GP6+TdEGCXJw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1747908839; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TTj530S0+pt4TB23fjg5olxByY/4NarPybW7KGHkyhc=; b=8l/rmVdxqLqueF90g4p+EwikrOPcb1Y/TGbkPU80Tlvfgzo4NCjkURkda/+8hLceyXhMXw ArfTvlGtz8e+4zDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1747908838; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TTj530S0+pt4TB23fjg5olxByY/4NarPybW7KGHkyhc=; b=CQk9PPjZlFADxCr7gK9SEIWJiU+uc1WV6fdhK3OD3y/ufSpu1cAEcbe71na17dMBBZZ2q2 UUBF0DBNvVXfxMcEzS1ISCbGnfGQvKv/o6lmVlcfklx08GKmM8gcNIc/ztPKMIqbzmrcE5 MGeuNfW6YemilOI2ZceRmyB2Fxn4MoE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1747908838; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TTj530S0+pt4TB23fjg5olxByY/4NarPybW7KGHkyhc=; b=13aXx17FFBz1wfQvf8jdKLSxkc/F4/CE32sBzuuseWCidgW3Y0yEwwOQrquIczXobEx7Br hZHWF93PHkHdmHBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A7F50137B8; Thu, 22 May 2025 10:13:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id gxzxJ+b4LmhAPwAAD6G6ig (envelope-from ); Thu, 22 May 2025 10:13:58 +0000 Date: Thu, 22 May 2025 12:13:57 +0200 From: Oscar Salvador To: Muchun Song Cc: yangge1116@126.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, 21cnbao@gmail.com, david@redhat.com, baolin.wang@linux.alibaba.com, liuzixing@hygon.cn Subject: Re: [PATCH] mm/hugetlb: fix kernel NULL pointer dereference when replacing free hugetlb folios Message-ID: References: <1747884137-26685-1-git-send-email-yangge1116@126.com> <644FF836-9DC7-42B4-BACE-C433E637B885@linux.dev> <065093C4-3599-456F-84B7-EDCC1A3E8AFC@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <065093C4-3599-456F-84B7-EDCC1A3E8AFC@linux.dev> X-Rspamd-Action: no action X-Rspam-User: X-Stat-Signature: skwergirfkszrn3w1jij8m1tprhkno7g X-Rspamd-Queue-Id: 803694000F X-Rspamd-Server: rspam11 X-HE-Tag: 1747908840-121054 X-HE-Meta: U2FsdGVkX19pLWpzxz/4lFGhg1seRL9ErPGyTt5MZwJReHC1lzD+JsqhihHKeF4+uuqtAkKFc8kVqutfF7Tzq49mooZ3mwXZ5Zuig+DkLO+UE1Eh08EBLOhSEX3fuqvVjn3KmUoui2//tNRmPOHB+ULa0iIUihFgCsRYimoSDpoX227H9c3pwyn3C+GWbg0846sKhaRkoRpur4XHhHxHgSIBJnKoaBGcKf+gR5SLnMigAWL/1KH2kDOO5GeHLFgHUZK5y6kzFj6T9R6JMJlji3/234BSzZvna3LdZ0JMzHE2QcEsIuEnNf9ZjpO09ElTHpi8fbq0dcgJCeHTTt8cIBxLFICNnYbf2+VOPudI6EOE2oOetBlAtmqRMzVoOKng6qjqqEvCEgVNKPuN5tMOJxydfu7T8trwEhYKc/dtp4UjY1SIyaH/uSFF1Ahn+S3phuMIh6FFkp7r03+1pryo8Ti3Xhq626/2J6HaddmlKUeS1JvSFQXaFFW1EjTUSOF3W6L03XVptoXVPdv7gckpeWlaVd3k/wlwJW34l4JePccMXqDZ+1jJcuy+JzzBv7jnJyC2xeOQ6usd8LrL8XjTV1EJs+3ToOzCw8ErtMIbOtxg47BJq0W82McBnqkyVLCIqHS6Mht0XDYX4AnxQVDc3TQU9Of3ZdBYymzTJIPEaZwhoz+A3DoZaJJsPkceioJsVZWedOq8WJ8ZpcrljEHATC19jOaZMo247+aakVK5LkKQ9Ax9q78btl2muE4Xo2eSxFqKnObnpSGwJ7TJGD7sFpKF8iX3HHm/DWUq0bp3vYZ+CcNV+G5OY8vznCiDutId8E9gtHc9BGc/Tvk0ldsmX53gbaH9QqWUR0NOYLlth119mLs2VrccPLUsexnRwuk4VKcWRM7e75dsaVl58vj4A/oS7C8A60QOGaI8/Pzc1U3TrIgF1r/YrjuDdmrDLQ4eoHD0W/MsZ64tX+vVW1D BM51iBMF LvR9KGMIwbSCdG3+m9o8XZ3oQO83LmUChbr0k6Q0BVvaLKAqzQtHCfU0kT74aPL0Xs9OPRt3UyW8uOUgoq4QRa5dX+DCwst79QMoCb6HXWRGTQiGDmBN/MYku6tatGVP8i6d9+y1mDuSyAPYF7nTJjjaOC20eo0NyPuvHAfaRNdUqGwoBIFlnAvcHfHTDRfwwu92POhMzpjnJJtpibKZpqDPy2WZLls5QcqghjBG+JCS8YhdtJqpRBhue33hNvmtwvUks5DFOLTfIAME= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 22, 2025 at 03:13:31PM +0800, Muchun Song wrote: > > > > On May 22, 2025, at 13:34, Oscar Salvador wrote: > > > > On Thu, May 22, 2025 at 11:47:05AM +0800, Muchun Song wrote: > >> Thanks for fixing this problem. BTW, in order to catch future similar problem, > >> it is better to add WARN_ON into folio_hstate() to assert if hugetlb_lock > >> is not held when folio's reference count is zero. For this fix, LGTM. > > > > Why cannot we put all the burden in alloc_and_dissolve_hugetlb_folio(), > > which will again check things under the lock? > > I've also considered about this choice, because there is another similar > case in isolate_or_dissolve_huge_page() which could benefit from this > change. I am fine with both approaches. Anyway, adding an assertion into > folio_hstate() is an improvement for capturing invalid users in the future. > Because any user of folio_hstate() should hold a reference to folio or > hold the hugetlb_lock to make sure it returns a valid hstate for a hugetlb > folio. Yes, I am not arguing about that, it makes perfect sense to me, but I am just kinda against these micro-optimizations for taking the lock to check things when we are calling in a function that will again the lock to check things. Actually, I think that the folio_test_hugetlb() check in replace_free_hugepage_folios() was put there to try tro be smart and save cycles in case we were not dealing with a hugetlb page (so freed under us). Now that we learnt that we cannot do that without 1) taking a refcount 2) or holding the lock, that becomes superfluos, so I would just wipe that out. -- Oscar Salvador SUSE Labs