From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A581C54E90 for ; Thu, 22 May 2025 10:06:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0D59D6B0085; Thu, 22 May 2025 06:06:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0ACF56B0088; Thu, 22 May 2025 06:06:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F05416B0089; Thu, 22 May 2025 06:06:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D47A26B0085 for ; Thu, 22 May 2025 06:06:11 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 934A0140DB6 for ; Thu, 22 May 2025 10:06:11 +0000 (UTC) X-FDA: 83470113342.23.E229F1D Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf10.hostedemail.com (Postfix) with ESMTP id 65CFAC0004 for ; Thu, 22 May 2025 10:06:09 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=jZ8L8mhu; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=OdnzB7To; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=jZ8L8mhu; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=OdnzB7To; spf=pass (imf10.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747908369; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mJfxvIGADykpV/3Aru4pEGNYo+FCqumWO2IR3zGTS1U=; b=gJdRVlYAXwuCyjIoT2emmfHXy4FCV1AYaJiIrCC01uQ3IIfoMXwZ8twWWoae3W5hJt3IK7 0pbjQJNwFasbuR93yBSNo98uLKOcG9lUt+35pt7hRlRNeZE68BF/TuWcujFObIJ7eZNhqa iZJeo+Gg/R5n32LiYam72ZmrUTmwXsg= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=jZ8L8mhu; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=OdnzB7To; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=jZ8L8mhu; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=OdnzB7To; spf=pass (imf10.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747908369; a=rsa-sha256; cv=none; b=h4VwXAVjK71mcM7f0On8KJpOlCcdbjxhJ6iuBAVUBBuupEaOnHV1l9CKZFXFzOhP3SEDqM y6bSroSNzQ7TIXonFkoGSjV6PtmemsvgQfdtFssLJc0YOEzWwVAXqbb+zWrU3e4olErSDH PA9PYto5wFExT7O6pXLzLJZTZdWh/ME= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BDA3B211E8; Thu, 22 May 2025 10:06:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1747908367; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mJfxvIGADykpV/3Aru4pEGNYo+FCqumWO2IR3zGTS1U=; b=jZ8L8mhuCvRJ5aztPiKxC4pHZSoPxuHeZui96DeRNoB3+KIYeXkxUuTfKm/YaAjF2JGeiu GoExPf/qVPSaojW28ljqh7eWiCwrarWW+S248sXh6JNMHLx8J3u0+sIoB8LlLT5XGTgbLI IQwPIKzVW2/PJdKXMMIndmwjXt37kzs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1747908367; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mJfxvIGADykpV/3Aru4pEGNYo+FCqumWO2IR3zGTS1U=; b=OdnzB7Tod9A6HmzzvvEUMejqQMWVmYwRrloo4lIJmSXnAKI6sWuacKzE70kMwNGr/3eRzz 1Me07idBo3n6BXAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1747908367; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mJfxvIGADykpV/3Aru4pEGNYo+FCqumWO2IR3zGTS1U=; b=jZ8L8mhuCvRJ5aztPiKxC4pHZSoPxuHeZui96DeRNoB3+KIYeXkxUuTfKm/YaAjF2JGeiu GoExPf/qVPSaojW28ljqh7eWiCwrarWW+S248sXh6JNMHLx8J3u0+sIoB8LlLT5XGTgbLI IQwPIKzVW2/PJdKXMMIndmwjXt37kzs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1747908367; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mJfxvIGADykpV/3Aru4pEGNYo+FCqumWO2IR3zGTS1U=; b=OdnzB7Tod9A6HmzzvvEUMejqQMWVmYwRrloo4lIJmSXnAKI6sWuacKzE70kMwNGr/3eRzz 1Me07idBo3n6BXAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7CC3A137B8; Thu, 22 May 2025 10:06:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id WqrnHQ/3LmiGOwAAD6G6ig (envelope-from ); Thu, 22 May 2025 10:06:07 +0000 Date: Thu, 22 May 2025 12:06:06 +0200 From: Oscar Salvador To: Donet Tom Cc: David Hildenbrand , Andrew Morton , Mike Rapoport , Zi Yan , Greg Kroah-Hartman , Ritesh Harjani , linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Rafael J . Wysocki" , Danilo Krummrich , Jonathan Cameron , Alison Schofield , Yury Norov , Dave Jiang Subject: Re: [PATCH v5 3/4] drivers/base/node: Remove register_memory_blocks_under_node() function call from register_one_node Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: 59oaaigntnj8on59fdqizxqtd89or4z5 X-Rspamd-Queue-Id: 65CFAC0004 X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1747908369-408138 X-HE-Meta: U2FsdGVkX1/TLyUywRXD7IJw1BT7n5dt9Dkcl/83nZ6Vj4yLIOky6+KCkbZs0YZ1aVTcQbWtbuADLEkElaVvrC2eke6t10XtTtXiD3G2qk1tUvvHzQUqkB1wyilRJBV+8JenQZUJSgpqk9hlAVN6ppRlt0JV5I4HdSEP2WKmrh//ug14WR5SzaENnJGNO+kkXgsbebLp1BveMg6W35M+f4uKUod5yu0YfiuGMp6Jys9lg9qkjITNqbzaznzGKcAjKfyl+S9GUbUgkMkAMT8RoajH36WkDq8BUESd+73uUn3sojA9P5r5+rjcLftI64uArXVBbQX68NvJwEfqm7tQWQD89bm1TNCPd8B27nKArB1q4muugi0GhOWr/n51dd/Fxg2dqaTWwtFWuN8aOpPs22l7rV5FxlKPD6W38K+kYwpPrauyH189cOz/FFeAsHR5boOm0jubN0NyrfCPdjVwCemouY74YnWiU93I92vPwu/Pj58CxZx8qwkliGgSxn5dGQHhqh5xaLTfXhuuaKi83tSw18t1m5lA5to73pPqS5puEYXjwkkGYLF3gtru+UdeVN0HYV08j7UFpuxFu7zlZxt1Sz9ctWSjGjldUhJrFJYGlG5b1SF7U5OKzYUpAZvVIBDc3V4wiFRruCjYeSLefD5TGNJWWyKimJg023OmZcKtDIw2ZDcgnPQh9RPJuGUGrYVtQwBF8yBfOwVqf01SSqbIl4ASMxX+OjIkQGMqShX3QrY2xNUiDTpmnPUNE3GBNEfPLg5g1aHb9kF5+494nMKOKMPKEz24YuGybI2J6fVQZ92FB8uitpByKFeitshodGRinAWDNxXkMag7GgZasD9uWnlLS9PxRCVNreS3yMS91eKSVoUi6oJRb5KFKiP4rMm+fhePk8BxX02kQIZ2FOABTPsPUFf/O+MqFNQyIydTWlBIBGnld5ZESIjz1xgCYk3nhcNR3zCmw9FM5Iv f78+av95 zTRGAzxQr2f5yyljLNSuKSq7y9l3zdwSmVeWYJePcZqZmUXJLSUTxVZ+rP3dNAgVzlxLnPNra7hCHFY1vfGJ3IXEEJD+PVD02nLmjoF1rTHZymrmsLcIlyXOvP7gdUYPRcToQW9ST8BNhl7lR1C7T5EsRxElZhcd39zql3jDehVbxh+5CNhNT83TfPbdrKftWzc1+2n4WMjxepoveCIGURphwyrWhhoz7NxlAd5mrx0U6ojFcfjHL1dhtX0CY7YZnoysedcxlRWc7ypQS3Sx/jEpK60lB1coh0aXjuBlDqSpPFQOnhxTgkQijDWj+JzSXn5Hm4jESkwlG+WcdWwNvcTlD+x1bGFbuzaO54RRibPAT4mCXJv+bbg+UR4z1nfStxUqS X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 22, 2025 at 04:17:30AM -0500, Donet Tom wrote: > diff --git a/include/linux/node.h b/include/linux/node.h > index 5c763253c42c..6cf349c26780 100644 > --- a/include/linux/node.h > +++ b/include/linux/node.h > @@ -136,18 +136,8 @@ static inline int register_one_node(int nid) > { > int error = 0; > > - if (node_online(nid)) { > - struct pglist_data *pgdat = NODE_DATA(nid); > - unsigned long start_pfn = pgdat->node_start_pfn; > - unsigned long end_pfn = start_pfn + pgdat->node_spanned_pages; > - > + if (node_online(nid)) > error = __register_one_node(nid); Heh, remembering this code always brings me joy. After this patch, register_one_node() is only called from try_online_node(), right? Which, before calling in, explicitly sets the node online, so... we can get rid of the node_online() check unless I am missing something. -- Oscar Salvador SUSE Labs