From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50E5EC54E65 for ; Wed, 21 May 2025 22:29:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C3F86B0085; Wed, 21 May 2025 18:29:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 975126B0088; Wed, 21 May 2025 18:29:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 88AEC6B0089; Wed, 21 May 2025 18:29:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6A3E06B0085 for ; Wed, 21 May 2025 18:29:33 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E7981121686 for ; Wed, 21 May 2025 22:29:32 +0000 (UTC) X-FDA: 83468357784.01.076472E Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf27.hostedemail.com (Postfix) with ESMTP id 52A5B4000E for ; Wed, 21 May 2025 22:29:31 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Us1NdNuG; spf=pass (imf27.hostedemail.com: domain of tj@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=tj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747866571; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Fpxr/iObw3390So6cC2JlgMOSg2tPPVr6/4T4aRHddM=; b=T1a+pOpDDCrlvB8c295IhKGuacCrjClZlCjxyQLAMeSkW1L6XPNw3L4qiwzzPgj94xUBy+ 8xF04qR14VMmENoZdsTTk6k0bPdH5F1fb1o9XvYhA+XJTiwnrv9NpKDtK6jKwVtrWTuj7E HzuhfyTKUzEnCA/FGkYOW1OQ+EhVTjM= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Us1NdNuG; spf=pass (imf27.hostedemail.com: domain of tj@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=tj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747866571; a=rsa-sha256; cv=none; b=oFykvJQyTsnte/vQAk6tLZqggYhUt1Nycpwe+AgqCQmct1LKq0oVOey1Bzl53MEMWIM6lt 5L4yMRt8mDepmqwWL3rf+rO9nb+Dk1i/2iPpHaGepoXy9IAdgUCXAqC8w+HAXgybRscz86 hPAkLtykzC4UcOUWnT3cZ5h4BDJWzdo= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 4F2BF629C7; Wed, 21 May 2025 22:29:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7901C4CEE4; Wed, 21 May 2025 22:29:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747866569; bh=irtON5WVDbBr8vPwyUpf52o7P4PNK2U+tXDUgO9fTeI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Us1NdNuGllr1erLQCBtBkuiCS/5KRytN1mL91L27ybi0x6d2g4ZbP7AVldzrVqPbV vZZzBVk+ovgqODZudOn+uG800PKGUnjMvgPVVBB5RibrMVZSSg0Xyz/XqiFPXq6HsO 59t9IuyqVXfg5fJTwGM7iZJxjyHKjmNinDFeIcSfekp5JSOBTZb/TS2yogmVtLQOzg kO+yBt6U1duXCa+DdjsDVtIGV7B3hFyx15TPAHxFlNxrT93yAvZTw1VUPyZ8FdY5SP 5OX/gF+C7nsolxkrdEJ7sbZz2oQZ+RzOxmVDq0/vT2AWMoFlWcrNUEr4PvGRQV6PZb sEyc8ZU+FOC1Q== Date: Wed, 21 May 2025 12:29:28 -1000 From: Tejun Heo To: Klara Modin Cc: Shakeel Butt , Andrew Morton , Alexei Starovoitov , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Yosry Ahmed , Michal =?iso-8859-1?Q?Koutn=FD?= , Vlastimil Babka , Sebastian Andrzej Siewior , JP Kobryn , bpf@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team Subject: Re: [OFFLIST PATCH 2/2] cgroup: use subsystem-specific rstat locks to avoid contention Message-ID: References: <20250428174943.69803-1-inwardvessel@gmail.com> <20250428174943.69803-2-inwardvessel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Stat-Signature: q6naahcht3ice93iwstm658msb44btcf X-Rspamd-Queue-Id: 52A5B4000E X-Rspamd-Server: rspam11 X-HE-Tag: 1747866571-895104 X-HE-Meta: U2FsdGVkX1/8hNwRI/IurxQRL0Y9nN0uGMpwZezUzty5aOkLsDWsofU8DQmJHNEDS1ea/r5/NFXDfxLD3Q6KjyLHGY5UsHbwjH/WIYyYdOwM/kNyT9knMo7RfVOG/XsN7PqlWPTr1EFz7pCuklJLbLryge4Z3QwJHRhrinab4OHzg7VZ+GGDp/B9o5pi5z/f44pMW8k2h5jHz4dip+k4BAK1kUUIiOs7sfXfZhD9qddgr/JBMLTgHBf0FLdmLc0VS1OvzUIeKs0WpNm88HbW85XTvjNqUbAjCxuGu/CjvBNE8vcM4zVtQrjDSxg5pDnkO9Jly28Vy+9kLihklTPo4OO508YwwZGECVYXR79PNqCIuTa3wH6hp9E7Ap2O4brTw/f9BtlCG6LRstxpp91w+XzfK+cqAFediYNkw4BZrbt+6Ha2wRXphtnAQcmih77Fxmqd9zkwLa6T20EhM72OAaSagQnhKBYhy4tDeV6cMAgW3qs1TO0XRGfyC1dG2Dp++1bqetsoj5bThcTLA5fs6rUOYuh4rbAY87iKjl+I6g5lZn15kJ+A2znfSsreo6pt9eIulxztvS2ZFoWYacdgmcmALt9jI/7xngKEsPdjpTtjFAR2UgOv0up/vk5yzO7a2wttZsa0rMM3IPiXqT24uvtnS/uUTM4mBqCMYb/HcaN6U6507cTh4gbM6u89IwpKB/EB5GP+1JaTwb9ZPKYLZGFYPytI2oyWceeZSEWeiQMs/xol20cwRg7rEW7j0yo9m+nv/h2m1ZulD81kwgRUCSfkBzsis7/AakR/J/4OpALOjDU2Z+9twy3c1vjaj+eAxRSP7yuQ5uFs8C1CMxThvm7fx9ESG9Ph7N6xbiVfQLQopp6+UGZWbF1i3fxxphzXqbmxy8KZbARUcJS7yBHa78bLrolR82NTpbxROV/ZbtPoCnz8e6mrBv4GLtqG7DGxb0d5fcNGQ0mdhYyZUaf 2rW0YXMf x6o48TPJhJ1UFcOyN0ZmgyUwaDH5gZM6gB+M4KlyYYUSZO0SgQPQ8dwiwr3FGvrLFg7jwUbAyEJkbY9/UDiV87Vdfc1a1t9iq1NziaHK3/bHtFIjHf/TVTYxb7i9fAiDY4Fe9EulC1Kpgd2l1F241yyUnxj8M23+JzlA3oAm2qzRmUlFvLWYgsdv+ppVcALpO8sO/SZqKz3QyfwALXpJ5Nu6ZJg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 22, 2025 at 12:23:44AM +0200, Klara Modin wrote: > Hi, > > On 2025-04-28 23:15:58 -0700, Shakeel Butt wrote: > > Please ignore this patch as it was sent by mistake. > > This seems to have made it into next: > > 748922dcfabd ("cgroup: use subsystem-specific rstat locks to avoid contention") > > It causes a BUG and eventually a panic on my Raspberry Pi 1: > > WARNING: CPU: 0 PID: 0 at mm/percpu.c:1766 pcpu_alloc_noprof (mm/percpu.c:1766 (discriminator 2)) > illegal size (0) or align (4) for percpu allocation > CPU: 0 UID: 0 PID: 0 Comm: swapper Not tainted 6.15.0-rc7-next-20250521-00086-ga9fb18e56aad #263 NONE > Hardware name: BCM2835 > Call trace: > unwind_backtrace from show_stack (arch/arm/kernel/traps.c:259) > show_stack from dump_stack_lvl (lib/dump_stack.c:122) > dump_stack_lvl from __warn (kernel/panic.c:729 kernel/panic.c:784) > __warn from warn_slowpath_fmt (kernel/panic.c:815) > warn_slowpath_fmt from pcpu_alloc_noprof (mm/percpu.c:1766 (discriminator 2)) > pcpu_alloc_noprof from ss_rstat_init (kernel/cgroup/rstat.c:515) > ss_rstat_init from cgroup_init_subsys (kernel/cgroup/cgroup.c:6134 (discriminator 2)) > cgroup_init_subsys from cgroup_init (kernel/cgroup/cgroup.c:6240) > cgroup_init from start_kernel (init/main.c:1093) > start_kernel from 0x0 > ... > kernel BUG at kernel/cgroup/cgroup.c:6134! > Internal error: Oops - BUG: 0 [#1] ARM > > Reverting resolved it for me. This posting was a mistake but direct postings from JP weren't. This being pretty close to the merge window, unless the problem is trivial, the right thing to do probalby is reverting the series. JP, what do you think? Thanks. -- tejun