From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 466A9C54E71 for ; Wed, 21 May 2025 15:27:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BFE8D6B0082; Wed, 21 May 2025 11:27:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BD6BB6B0083; Wed, 21 May 2025 11:27:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B15C36B0085; Wed, 21 May 2025 11:27:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 91A8A6B0082 for ; Wed, 21 May 2025 11:27:16 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 14B465B7BE for ; Wed, 21 May 2025 15:27:16 +0000 (UTC) X-FDA: 83467293672.28.79C3368 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf02.hostedemail.com (Postfix) with ESMTP id 68A7680015 for ; Wed, 21 May 2025 15:27:14 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=k7XUweCK; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747841234; a=rsa-sha256; cv=none; b=bGUPGm6A089TtJ9/JLUCDeDsHZD2RT9H98WrOZejiqVfOkXkUAvxYX73jWyNRBDBcb+f7Q yKxmhATRhIdGjoybBeBu72kTMGf5PeIKMzK0HTCdf1FVHdRxwPlIL5Qn4+e/NThNYk5Rid TT1d1mNYd1doecPCQB17Oi3GY5bO1Go= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=k7XUweCK; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747841234; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LmS9BG/WjvqdoUcCV5RL/LLQy64Bdl84uNtFTecAxbA=; b=PSEWFKvguQ6+PtnhsIYdUIV4okG/GDpwheS36AtZdGtN6Kf7GUgAqbugg3hRhLYTpoaoSH iCEeL5B+HsH9rhtnbgVdIpfMYXGFcqAAgav5o9nvldoYT8T3VmCs9GXV9juFUOr6E7KGWm AwPWVEwOG3liD0S/PdGgYoyRW/L/rOI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 91E72A4F0C8; Wed, 21 May 2025 15:27:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CB653C4CEE4; Wed, 21 May 2025 15:27:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747841233; bh=OREQHZGYo3NvKNR+PKTA7t1MGjIJnrFFdGtkjwEU9qU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=k7XUweCKpFKWJICYq76TfDISsYXAaRG/WO7DIzj+Cd0xOXyA60iZLJ0nhdVjPAlly DHAxo+naXWo5rjJKLYvRjYRNIuFlNWx6Np0Bjk/QmmBGn3fIBYGOGaN2nqb6J9rEFS j1ig1OlpBj19WT6pGkVxfX/ulXl1n+DGlfkYUIyv29inAlFODqP4QixgOauwg2sgR2 2zDkroPW/xH/d0oH02ugkePbiLo3nZ2vd2AkDkHSA18F21NR00eHQhzq1DBhwbH+3W m81rhzkUK57nHLPAUmDn53ZolxhVNtIxFC9E+Nl234NAw8PG3veRASeFl77u4YBOJK tkUG3kF0BMtKg== Date: Wed, 21 May 2025 18:27:03 +0300 From: Mike Rapoport To: Oscar Salvador Cc: Changyuan Lyu , akpm@linux-foundation.org, bhe@redhat.com, chrisl@kernel.org, graf@amazon.com, jasonmiu@google.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, pasha.tatashin@soleen.com Subject: Re: [PATCH 1/2] memblock: show a warning if allocation in KHO scratch fails Message-ID: References: <20250521070310.2478491-1-changyuanl@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 68A7680015 X-Stat-Signature: mt19obcaud4u56w1ie9g1bgtr1k5pesk X-HE-Tag: 1747841234-971188 X-HE-Meta: U2FsdGVkX18fR/oA1PE9GOT6pZsumvPLxDX5fA8d8x6JW8RpXa2ZNSv6fju6McI3LKmTDMG0OPyqxZWahfNneMQGPSsuwK7GOEA6Nh44ExlqGuvwix/vouqGGWkY4bj0E745yaPilTrpf8m+hmjBMDrF1WgadWj+uWAgh9O0U18/hpmSzUvXLPHeUPbadSJcRo/5vvHgGlYs9YLQkqyhT+hhQsBebfyXy1wSa3RhWtkAXND03ubc6HMHKJESL+HScjp/n/mNrdgh5Tqjn0oGGsH7kY6fziRtPmxPw0kq6Ta4yi6PBMTp8C7szOUf5oy6FGNT6AZV9uZjU82d1uuISVWLIwe7fTBoEhAnzi13fZQBBRG61yJiD6wzMMrSsjOGkce7t5MBYAkGWxfMjOOswQzY+fdIIqFhuGrW6PKUqvtj5VeIVuVWWDOkSmzWyMpxoK2J1QU4bfkoZznIe/zXHyWWAbfJPF9SSLsNbgou3A1mWTnQ8MshT647uq0A2zV/JTJslj5RxQrq+mF2bzyZfS+9Mw6O2EW0HemEGCApYxDw8S7EdJfox0duS2740x4Znuql5J0GDMWnon3H6m6XUmpbgyug8Wkl3IsVq2LR/Iqgx5EGNDNZcOpkB/IpJ8ZJ0aYcKemAi9HigTQ27QDnIKzr6/SY8u8Emu+sSlPhyT0xE/mSWRgVprOenGA2HNF1Tz5jnMWWtaeKB838vZEA75W5k82wD/vc8Qsd+MrSfUtv7ZT+sgY57rShPpuq5XJ+yVWrVkcSlOq+yM7xibsBtQGFO1Zo/Cm8ldNfqHVdz9C66d/6+xQ75z3OGXjU4ia9eBXXCkG/QnGUgWSOGr4R/5q4tTchZInTQ5BksS2Nlq94lpUi0kBfcdKdw4RN7kQnwco6tK0j+w+rRIawkV9plpE4o0xmrpSRfMg/XeEL/z1yjooCzMZpVLjZfuERfNdQ1uLYxzn01mKM/7eYeSf hITOw00K 8Fc/osTre2YBVk8XK8WNjyssZ9gNu3HgfYPHEJszs77+7SMDoqjQLPenesRcMARRIM4zbT2buvXWYDnw2Vk0z89XsQFn6Ts552k9BifTnULqxcsK67I5LMwQW/iXv5W8p0stnFP/mjkD45dZ49RP+/EMbIn0lOzm2pKYwknBwIfcetf11ZW9YsVPnNOZ98lqPUMsXpk63EVmnb+nyig9V8D4EbACcxeG3g8+dQUBLheliv8xvHJ1AH7ZEZvqtug+1V2aa X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 21, 2025 at 10:48:55AM +0200, Oscar Salvador wrote: > On Wed, May 21, 2025 at 10:43:15AM +0300, Mike Rapoport wrote: > > I think we should just make sparse_init_nid() panic or at least change > > "sparse_init_nid: node[0] memory map backing failed. Some memory will not be available." > > to something more visible and clear. > > Panicking the system seems a bit too harsh. > Those sections will not be initialized, and sure you will lose some memory, > but still. > > I think that making sure that subsection_map_init() does not access > non-initialized values is enough. It's not only subsection_map_init(), next failing one is memmap_init_range() and maybe there's more, but we can audit and fix them. I believe all those accesses are at init time because after system is booted we are careful to avoid accessing absent sections. > Because wrt. error message, I am not sure it can get more clear that we > failed we allocate memory to back the section and so that section will > not be activated :-) Add a dump_stack()? ;-) > -- > Oscar Salvador > SUSE Labs > -- Sincerely yours, Mike.