From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65C92C54E65 for ; Wed, 21 May 2025 08:49:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D11F06B007B; Wed, 21 May 2025 04:49:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CEA556B0082; Wed, 21 May 2025 04:49:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C007C6B0085; Wed, 21 May 2025 04:49:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A30296B007B for ; Wed, 21 May 2025 04:49:02 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4DC83140A74 for ; Wed, 21 May 2025 08:49:02 +0000 (UTC) X-FDA: 83466290124.25.64CDD92 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf07.hostedemail.com (Postfix) with ESMTP id 12FC140005 for ; Wed, 21 May 2025 08:48:59 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=IYnp7blK; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=kHeRh3wj; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="0CkkL/cY"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=GRdrTkGa; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf07.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747817340; a=rsa-sha256; cv=none; b=M1DwJetKuPTgyjcsu9AUARrkZGae5cgDEbOsQEe+J1ovKOx+JZbP0neELCfGfZwDm6HPeS AM6TBj4Vg+V3V4uKVX3+jVPP7iDfsK2JTGDN0WiPu+MUvb2WHyay4QU9L3nhWkXJLR4zhP hv/fL1Sz5+pibulikQHuaZrNOWSNATg= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=IYnp7blK; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=kHeRh3wj; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="0CkkL/cY"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=GRdrTkGa; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf07.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747817340; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PYJxRSWIj9WyqHxSTfPZjOkXna9NizDI98LlLiwmMyk=; b=QgRbyqnRwnmsEooZdzgwdz2p1ty5GJN+Awe13J6mesffuDT+v7vVd1BrlSgJfp120kQPNC 0R/XpJNcRzRHYx+8mndC8JwkeT8vCZmmuaQVxgeAV8mPGhLGPv1KXcfPyrcSrsOjaE03hi sWVNoRxMq4xGS6nHgDfd9D0cOokyRZw= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 192BC2125A; Wed, 21 May 2025 08:48:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1747817338; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PYJxRSWIj9WyqHxSTfPZjOkXna9NizDI98LlLiwmMyk=; b=IYnp7blKnCEQ+CSBUy3sB7zTf5bnWzcKXg4aN4TVqNIJKNGa1Z8gm3PwojSDjrnhIBfWpU xRc5vSw66F3bgraR1EQIQEOnhPCZXl3hsFIbjYbE/ymetaSBJW6yfwppvEMXOgbgHlTsEQ TcTrEI495qNPL4GxRfIAjfqUPNVskHI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1747817338; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PYJxRSWIj9WyqHxSTfPZjOkXna9NizDI98LlLiwmMyk=; b=kHeRh3wjbPyBx/6GhLlOhp239jRDYDZADrBbDO/OCDUNXOPZkjYavcQbBr2ko6WBcYaZUf mK4tolpeDKljPABg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1747817337; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PYJxRSWIj9WyqHxSTfPZjOkXna9NizDI98LlLiwmMyk=; b=0CkkL/cYNyrA1hH6nyhrkHau7b3GUDvRZMnQgV/g+FIX9VoPpfTjJ8TY9vK9qvVC9bxwB6 q75U7fjqLvmb79pWzZv+CabAf9FTT3VkS9CPShLlGqdPZmehKnsE3FH/DguDE3Sg037Qlj B/pBG3CkIb+Eyn7Qm3BWNVxZQrgG1bs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1747817337; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PYJxRSWIj9WyqHxSTfPZjOkXna9NizDI98LlLiwmMyk=; b=GRdrTkGaRD8RwdohSA6XOzmHEwc0n7KQtZBuXkisP9h9J3W/Mg/a/BsVH0u3iwi4q3MwxI R+JAt3pGVkBdtoBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E23AE13AA0; Wed, 21 May 2025 08:48:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id P1uLNniTLWiaNAAAD6G6ig (envelope-from ); Wed, 21 May 2025 08:48:56 +0000 Date: Wed, 21 May 2025 10:48:55 +0200 From: Oscar Salvador To: Mike Rapoport Cc: Changyuan Lyu , akpm@linux-foundation.org, bhe@redhat.com, chrisl@kernel.org, graf@amazon.com, jasonmiu@google.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, pasha.tatashin@soleen.com Subject: Re: [PATCH 1/2] memblock: show a warning if allocation in KHO scratch fails Message-ID: References: <20250521070310.2478491-1-changyuanl@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Action: no action X-Stat-Signature: s4x71fj1wzh4yweocuy7irnn6opx7was X-Rspam-User: X-Rspamd-Queue-Id: 12FC140005 X-Rspamd-Server: rspam06 X-HE-Tag: 1747817339-154570 X-HE-Meta: U2FsdGVkX18vI2e61GaDZPehg1AiKuYYebWWsZLEoMsyhed1MKQ/dBDAv50GlqjF9fFsnR9s8nRcN8qbiILaniPTziNWXANRpNRj4HAQCp4KZ+cT4orWSW/vfjQhUMJFzGcm6SYVdkRM6dAQYcnXTQ23SwpMqd4rCLjJe3DFJjs/SADlg282CWIxmvaavYAXKQ0bPhVvq3Wf9577TjKJOrknEC70W8k0kIgOs/WVpbKWu2vmexTLnUIY9jnqs9Lyx96Hv53QLBY+h6J8PadvgW4ppbgvvsyjwgFltfL4T3r8/nz+JL85hk3osb8SYnTBFL4bDkjLfntf6h04xNGYURP5bJpMPlVJEKLljJcY5hDzvtt7ix+rK9YxGdiCt0ogJue5u6PFYS9zEwVg9zSaKVkVkWn2/pY2BdnSTGjdGrkBLGw/lKiGOyd14zFi8PAQxDb8LC+v15ovTNkZsIlTlxZM9JVhnOBkPSVT23U838wENAmUy0VcIwlN/ccjTFeHHDNb92ykTDr8lkJMHGH8OnFyVxApBGxhCRT3tYRAt1Il76jeZvy4iBvAzrngrvOZxoq/oVaJyJeUBnLdOeIG61QGsxHWZAIWEvyL0hAvrhPvDuDKyA+YSfEfmMmtcS99G3LJG4GK9BIA4y00g8ikHs7IvG2eZ8vRxvWTJLItgYtMO2QC79vB/sMB9fhQKteKGT/r/xr9pKvSyBL8GpUTLj3iWFeflzCYDtiK4kvax8V+I61GIPcJnLBNXwDLK5jrJSFhYmYKkBFLcVbyiji2NcrhrZCp6ItUJEntC+ICTK7S3wVNeZe4+r894YhzaGd0hJfOEcd5tpz7NsNWvLoxc2TfN9CazrgXvV4BfNl0Uvl+cXPEItYykXBhKoVTiAOcxeSeXPO+UKuV7R+AyP7wm6KDsLZ9SxEYOmlA2fTEkMQTvjh4ewfJM9U97aShm/utbHC08NhRvV0wJvifF0Y odckYlap pWamzykhL3OqtrPUg+sxYRPkcOYA/XhBXFiAK/8HLfUqI5BAecu/yimrimo5YIQF22T7on1yvx1pr05cdhyv953dJLHFGw0QWtaWqYcZ3P/J3NhOiaLTegRApL9p2U+7xzZVWbdWpUD9hJKXXI83S0rrG7QUbkJBpw7OKhglEs9rAxJoXS56R2T9l6bir2XU/7vxsEH3gTn56oaSB7Xh8R+gYE6j22y7qpG3YXtBGrtwUM/flW3K7MRNU9VApEihxvjZMHI6n9UszpZufcLcQdQDjT7Tjw4Qi+ln4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 21, 2025 at 10:43:15AM +0300, Mike Rapoport wrote: > I think we should just make sparse_init_nid() panic or at least change > "sparse_init_nid: node[0] memory map backing failed. Some memory will not be available." > to something more visible and clear. Panicking the system seems a bit too harsh. Those sections will not be initialized, and sure you will lose some memory, but still. I think that making sure that subsection_map_init() does not access non-initialized values is enough. Because wrt. error message, I am not sure it can get more clear that we failed we allocate memory to back the section and so that section will not be activated :-) -- Oscar Salvador SUSE Labs