From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CF4FC3ABBE for ; Thu, 8 May 2025 17:46:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8088B6B00A0; Thu, 8 May 2025 13:46:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7BA336B00A1; Thu, 8 May 2025 13:46:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 657C86B00A2; Thu, 8 May 2025 13:46:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 486576B00A0 for ; Thu, 8 May 2025 13:46:11 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id EB66FBCE6D for ; Thu, 8 May 2025 17:46:11 +0000 (UTC) X-FDA: 83420469342.10.ABE7D03 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by imf24.hostedemail.com (Postfix) with ESMTP id E016618000C for ; Thu, 8 May 2025 17:46:09 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=aaJT715b; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746726370; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fqmk4M3DrF29I/qbtB8U0fpJdgAdiiMTLbwwOsWf1q8=; b=KpH5VnFH5kKLkbRLmUBp6d7aUrdrYEKwHQI1kPmhV5nwJO067M9VKCbaTmmsGRabKuTZYf AEvU6HKHazp3Q9hCPl+twhh8VUFk7q43kr6HmqokDtOrWhN7kvP82gGZeey7QayF7vsmvf 1Qs1EN+xXzfqtCb3wjexUnJDyXiBegs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746726370; a=rsa-sha256; cv=none; b=xlcrNOnmH9TvyJ5yUV36AwwLP10MVsz/CM2uJC8KthDxDZ7iCgrYx8vsWrhxw2F34WObdb 6wWsAugpfN7BGI2lYT3+FXt8sE8aik3PwY7IDcpSrQ9UzsUQxWRmR2kNAqfnVRwn0L4yKT +RobhMK0r6v2QRflVe1cmpipxKANRJw= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=aaJT715b; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=urezki@gmail.com Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-54998f865b8so1399834e87.3 for ; Thu, 08 May 2025 10:46:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746726368; x=1747331168; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=fqmk4M3DrF29I/qbtB8U0fpJdgAdiiMTLbwwOsWf1q8=; b=aaJT715bmoUsYpXkRATlqi432vZ8bKAqictfewusFRVUkk+8RIIPe2chTF60KfkENM ByQk3KnAzpWS683OWeMkYJv7ZvBNB6lOD4NcML7ucMPyFv+5ejrmL5yodaxsmDtopSNf UZBAoAQhaxMrc+R9HVcrcJGboHrVOx4/rlsvPCUUEDFUpGAgbQcMNm4xexvyLrThBDCv TE0WEoKt5mnVT5YlRoiomMRChgZXM55JPPTSwC5yLK/ddJKVvv262hi4AUIxarUOPSI1 6MAxwa5OahbDZ6+xsUzMosfCVRKc2iDs8ovmb66GiFr5B2stvPlsF8AS/76dfZhQuZ8j RXOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746726368; x=1747331168; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fqmk4M3DrF29I/qbtB8U0fpJdgAdiiMTLbwwOsWf1q8=; b=jqMkGTuc4UyWVIoF+tirU4/75CZdVZJztv6GKLGBJlf9HTD+WpLhYKZ5r1wPhpSSVr MWm/PTd0zG7pzWsP+134eu+k9wjdwVW0ZRLDio4VZnxCn1w7hcQr8Mzrhp3ZhBudxH+E t9Ifcrb7MPbGQlld380QMe7SnJloG0Ns3N8lV3Nf1WyGslpGoWhVSHP9DMQtEkCwc9M0 lcxUWykwWuxYAETa/UP1OXXT+Ig0HwlBbUuaV51wBMEjJ1UeJkpVji1/+6jicqZmjb+v 89KDuLF+aRHx+qZs92Lt0E6uES+eS6inH8f7H+1n0oKzmBI8iHq0cTDsn6cQ6FcLQLY4 k7JQ== X-Forwarded-Encrypted: i=1; AJvYcCWWj/U3E+Qg21yuvbKgmfmzauBiBTs4uiocN1UOzzgEiHcqmgrTryR9etCD8UJWY+9nfBQUUabJJg==@kvack.org X-Gm-Message-State: AOJu0Yxs9PQQQkuKGzBDKpbEQyWmhfbJcFNphYMjojObkWkU3wIZrkIl +pAALmGtjy4wvH5Gqk7GeI22EdCQTexLpoP5xpvVactqo9ZuuM5r X-Gm-Gg: ASbGncvI2Vj6CydJSMaHz6MMgWiu5i82VL4Oz0ReSBtNCIygl6KEaz/ovnJE5Lv9NkR JIjAn3S9bWofM/XRUgRMEw8M1h3cv39uC6cA9Pb2laEAlRbtCQIB4zlNzst13bDOS2+Eoul/vWH Uv4S2ZXVpWLM4etjeB/kyg1B8wfWMIcBoiVZjlYRjGxM8MBcCpDd4NVUgNolpuoMbPubpmRU3zE h4Uaojo6KrOiEQ3urFepxwxOofmDJW840h7SbqYQZ6nHeQGslBJpNQrvWH7D2v6mldvuWQGpSwS 9gwCXBhPB9gciFaJAP9xwrJrlVw6rm/hy4Z31M3poCZZgdKaWUp6QBbS4/XuOwiABbVr X-Google-Smtp-Source: AGHT+IEetBMwa2XQqElClYSAZkQrSQPEeaYWrS2+mPR7Nmlj2u5AbpPdRYI1FaaPTaalk7//cfpSMQ== X-Received: by 2002:a05:6512:6401:b0:54a:c4af:18 with SMTP id 2adb3069b0e04-54fc67c5defmr30643e87.22.1746726367583; Thu, 08 May 2025 10:46:07 -0700 (PDT) Received: from pc636 (host-95-203-26-194.mobileonline.telia.com. [95.203.26.194]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54fc64c6dfasm30043e87.210.2025.05.08.10.46.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 May 2025 10:46:07 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Thu, 8 May 2025 19:46:04 +0200 To: Jeongjun Park Cc: Uladzislau Rezki , akpm@linux-foundation.org, edumazet@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5] mm/vmalloc: fix data race in show_numa_info() Message-ID: References: <20250508160800.12540-1-aha310510@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: E016618000C X-Rspam-User: X-Stat-Signature: cs9b58uhfng3yghjrysfzz8jdcjwd8ch X-HE-Tag: 1746726369-16204 X-HE-Meta: U2FsdGVkX199SKW1qA0N6EuIAbaE6WMBLN9Zd8L90ZIP9pf2WRggnHrU47YVlgqhOLAinwB6/+5Hw7IokEAX9+AhbPgFg/6NHRMCDGVwsL5OrLzevcOSyH1zDaNK5FIMKeKhIgqlCEXVVSItJAkDzdSfbdkV6ZD24JRcRitbVB5cHMvPZIaa7dJIqqEHMk2IUOruofsJMVjvbotpJDHL57KvCmSzPrko0XMvlJqQcuCaBaWOZUaeK3Ktm+MUuSUJl+RuNF+BLjp/3idpEyxWf+VEe8tKEc77ntT8Fiip+RnGKLp7UX3POmfTSj+w0UBGvMdpuIu1iChbs7BGyqHt5LzqT3GQV8EWew/9nH1x+xDg/gGdJ0qw78capFs/NlOiTaLtfmtR6q2LxxZ9xY6vqqaXdRY8PmLIwqYTCU5ppnLTNRkrILU0rHeNpYIYptC9+vcRbSvYfFjtGO2FmVIQ+U7K7QQZIPXEKyKUqQDevom++LWGFWDnOKYX6tLJIgDHcbz/uRRDhCVXl7GOGQOa9ELnra8PRhW2tESzqXLSY1uyENgv0tFjnYciJztnmPiMFhDvW72IqTZpMIsYqpcdqzNSuhI5gLaVHIQL+dGWQFejnvgf5kbKFabTZnSLfywpq6dwVhGt3rCV+C7VcxrxCT5KsXlTxQb1AtzIROvcjJAHYsZR4CFXCDqRaeczWwyOD0wk48KNTvKIxsvvzxz5G9aGYeokbwzjWZHpSBcQ0mKJ/LUa/4hGTZKGtVu6u/OgmZmYe7Fz5eFfd59AmOMks68CqFlW3Ki3DILHiXH1qcol0EQ/fOGm4rw82VWrPLcJ/NODL1HIcuFJkk9LtUOhwIWFoB1OtaDJfnRok4x+2t0qvoL3N7qFJ7AXCJ66vOdQDS9R946Sn2JGaBSXyk9oKEZ38NrhM7EVPsE3XTUqf+zlWhrWcSrmNu5jRBU/Viv2R/C9SoyNy980z1+MnIC KNjM4jOz siwtTXYzD5gNN2FMsRv+3dHzSopTjtxoVoUkVp0MhluOAuqcMOBRPCLv4mt6t45otmnmYtcTQxKEYfPlLZKFEom7On1dJx2qY3fR7KSoZRk0BuGyUtsstilAloF8VwR260+Ez/3/5DLRAETFqIHuLqfQTeqhb1qWrtaBVV9F7VUFf6w2VKrsNzi4hd9tAeLf0VoboMkV1DRmPJohrlxTkJr8uCWcUBkL0+NlxkoQvpxCAb2ZCEfatJVinePNPkIhMGSpmJh+VxI4yJlh7v4SRwTlF5MrQu28x2Ja6kwZJ3HkiKYqBa2AgeeP0PixobFJk68NEpdLtniUDchF0yi9JOkLefGZ1dNBkgpkYl17fNeKlYBzwH7wfmDd4kmNX9tsFQpfE120pCMibR1bTZK0LEvZsag9XzfrDyfMlwlDIQJCWHkMo3iE/rfnn0ZefbdGm6MuIW90TdQ5XOedfcEC2x4WrO3wi0+rVZzTz000HWXxE2PI8Mprb7wFDHLsqxm/NrYEWrUSUi0ltm+qdgbFB13R3vg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 09, 2025 at 01:26:14AM +0900, Jeongjun Park wrote: > Uladzislau Rezki wrote: > > > > On Fri, May 09, 2025 at 01:07:59AM +0900, Jeongjun Park wrote: > > > The following data-race was found in show_numa_info(): > > > > > > ================================================================== > > > BUG: KCSAN: data-race in vmalloc_info_show / vmalloc_info_show > > > > > > read to 0xffff88800971fe30 of 4 bytes by task 8289 on cpu 0: > > > show_numa_info mm/vmalloc.c:4936 [inline] > > > vmalloc_info_show+0x5a8/0x7e0 mm/vmalloc.c:5016 > > > seq_read_iter+0x373/0xb40 fs/seq_file.c:230 > > > proc_reg_read_iter+0x11e/0x170 fs/proc/inode.c:299 > > > .... > > > > > > write to 0xffff88800971fe30 of 4 bytes by task 8287 on cpu 1: > > > show_numa_info mm/vmalloc.c:4934 [inline] > > > vmalloc_info_show+0x38f/0x7e0 mm/vmalloc.c:5016 > > > seq_read_iter+0x373/0xb40 fs/seq_file.c:230 > > > proc_reg_read_iter+0x11e/0x170 fs/proc/inode.c:299 > > > .... > > > > > > value changed: 0x0000008f -> 0x00000000 > > > ================================================================== > > > > > > According to this report,there is a read/write data-race because m->private > > > is accessible to multiple CPUs. To fix this, instead of allocating the heap > > > in proc_vmalloc_init() and passing the heap address to m->private, > > > vmalloc_info_show() should allocate the heap. > > > > > > Fixes: a47a126ad5ea ("vmallocinfo: add NUMA information") > > > Suggested-by: Eric Dumazet > > > Suggested-by: Uladzislau Rezki (Sony) > > > Suggested-by: Andrew Morton > > > Signed-off-by: Jeongjun Park > > > --- > > > v5: Change heap to be allocated only when CONFIG_NUMA is enabled > > > - Link to v4: https://lore.kernel.org/all/20250508065558.149091-1-aha310510@gmail.com/ > > > v4: Change the way counters array heap is allocated, per Andrew Morton's suggestion. > > > And fix it to call smp_rmb() in the correct location. > > > - Link to v3: https://lore.kernel.org/all/20250507142552.9446-1-aha310510@gmail.com/ > > > v3: Following Uladzislau Rezki's suggestion, we check v->flags beforehand > > > to avoid printing uninitialized members of vm_struct. > > > - Link to v2: https://lore.kernel.org/all/20250506082520.84153-1-aha310510@gmail.com/ > > > v2: Refactoring some functions and fix patch as per Eric Dumazet suggestion > > > - Link to v1: https://lore.kernel.org/all/20250505171948.24410-1-aha310510@gmail.com/ > > > --- > > > mm/vmalloc.c | 62 ++++++++++++++++++++++++++++------------------------ > > > 1 file changed, 34 insertions(+), 28 deletions(-) > > > > > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > > > index 3ed720a787ec..866f18766dfc 100644 > > > --- a/mm/vmalloc.c > > > +++ b/mm/vmalloc.c > > > @@ -3100,7 +3100,7 @@ static void clear_vm_uninitialized_flag(struct vm_struct *vm) > > > /* > > > * Before removing VM_UNINITIALIZED, > > > * we should make sure that vm has proper values. > > > - * Pair with smp_rmb() in show_numa_info(). > > > + * Pair with smp_rmb() in vread_iter() and vmalloc_info_show(). > > > */ > > > smp_wmb(); > > > vm->flags &= ~VM_UNINITIALIZED; > > > @@ -4914,28 +4914,29 @@ bool vmalloc_dump_obj(void *object) > > > #endif > > > > > > #ifdef CONFIG_PROC_FS > > > -static void show_numa_info(struct seq_file *m, struct vm_struct *v) > > > -{ > > > - if (IS_ENABLED(CONFIG_NUMA)) { > > > - unsigned int nr, *counters = m->private; > > > - unsigned int step = 1U << vm_area_page_order(v); > > > > > > - if (!counters) > > > - return; > > > +/* > > > + * Print number of pages allocated on each memory node. > > > + * > > > + * This function can only be called if CONFIG_NUMA is enabled > > > + * and VM_UNINITIALIZED bit in v->flags is disabled. > > > + */ > > > +static void show_numa_info(struct seq_file *m, struct vm_struct *v, > > > + unsigned int *counters) > > > +{ > > > + unsigned int nr; > > > + unsigned int step = 1U << vm_area_page_order(v); > > > > > > - if (v->flags & VM_UNINITIALIZED) > > > - return; > > > - /* Pair with smp_wmb() in clear_vm_uninitialized_flag() */ > > > - smp_rmb(); > > > + if (!counters) > > > + return; > > > > > > - memset(counters, 0, nr_node_ids * sizeof(unsigned int)); > > > + memset(counters, 0, nr_node_ids * sizeof(unsigned int)); > > > > > > - for (nr = 0; nr < v->nr_pages; nr += step) > > > - counters[page_to_nid(v->pages[nr])] += step; > > > - for_each_node_state(nr, N_HIGH_MEMORY) > > > - if (counters[nr]) > > > - seq_printf(m, " N%u=%u", nr, counters[nr]); > > > - } > > > + for (nr = 0; nr < v->nr_pages; nr += step) > > > + counters[page_to_nid(v->pages[nr])] += step; > > > + for_each_node_state(nr, N_HIGH_MEMORY) > > > + if (counters[nr]) > > > + seq_printf(m, " N%u=%u", nr, counters[nr]); > > > } > > > > > > static void show_purge_info(struct seq_file *m) > > > @@ -4962,8 +4963,12 @@ static int vmalloc_info_show(struct seq_file *m, void *p) > > > struct vmap_node *vn; > > > struct vmap_area *va; > > > struct vm_struct *v; > > > + unsigned int *counters = NULL; > > > int i; > > > > > > + if (IS_ENABLED(CONFIG_NUMA)) > > > + counters = kmalloc(nr_node_ids * sizeof(unsigned int), GFP_KERNEL); > > > + > > > for (i = 0; i < nr_vmap_nodes; i++) { > > > vn = &vmap_nodes[i]; > > > > > > @@ -4979,6 +4984,11 @@ static int vmalloc_info_show(struct seq_file *m, void *p) > > > } > > > > > > v = va->vm; > > > + if (v->flags & VM_UNINITIALIZED) > > > + continue; > > > + > > > + /* Pair with smp_wmb() in clear_vm_uninitialized_flag() */ > > > + smp_rmb(); > > > > > > seq_printf(m, "0x%pK-0x%pK %7ld", > > > v->addr, v->addr + v->size, v->size); > > > @@ -5013,7 +5023,9 @@ static int vmalloc_info_show(struct seq_file *m, void *p) > > > if (is_vmalloc_addr(v->pages)) > > > seq_puts(m, " vpages"); > > > > > > - show_numa_info(m, v); > > > + if (counters) > > > + show_numa_info(m, v, counters); > > > + > > Let's execute it for NUMA only. > > > > > seq_putc(m, '\n'); > > > } > > > spin_unlock(&vn->busy.lock); > > > @@ -5023,19 +5035,13 @@ static int vmalloc_info_show(struct seq_file *m, void *p) > > > * As a final step, dump "unpurged" areas. > > > */ > > > show_purge_info(m); > > > + kfree(counters); > > Let's execute it for NUMA only. > > > > > return 0; > > > } > > > > > > static int __init proc_vmalloc_init(void) > > > { > > > - void *priv_data = NULL; > > > - > > > - if (IS_ENABLED(CONFIG_NUMA)) > > > - priv_data = kmalloc(nr_node_ids * sizeof(unsigned int), GFP_KERNEL); > > > - > > > - proc_create_single_data("vmallocinfo", > > > - 0400, NULL, vmalloc_info_show, priv_data); > > > - > > > + proc_create_single("vmallocinfo", 0400, NULL, vmalloc_info_show); > > > return 0; > > > } > > > module_init(proc_vmalloc_init); > > > -- > > > > You are so fast :) > > > > oops sorry. > > I'm not sure why you'd want to avoid initializing "counters pointer" to > NULL, but it's a simple change so I'll write a patch for it right away > and send it out as a v6 patch. > Because i would like to avoid of having such rule if someone decides to drop your initialization later of after a code refactoring. This is a reason. -- Uladzislau Rezki