From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47E63C3ABC0 for ; Thu, 8 May 2025 16:13:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 670856B0096; Thu, 8 May 2025 12:13:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F9766B0098; Thu, 8 May 2025 12:13:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 473836B0099; Thu, 8 May 2025 12:13:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 22F3C6B0096 for ; Thu, 8 May 2025 12:13:47 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 53D7DCA53E for ; Thu, 8 May 2025 16:13:49 +0000 (UTC) X-FDA: 83420236578.14.E2D6598 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by imf01.hostedemail.com (Postfix) with ESMTP id 4BC314000B for ; Thu, 8 May 2025 16:13:47 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=C2cDkb5F; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.45 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746720827; a=rsa-sha256; cv=none; b=sKW/h32rSISf8Xi2HAItykmW40FyUWIAEtVlDx8bLJn97xUYOpsEB0C/4H9N/YopynHbgj Hrfp/7O/cFvSh6xiZR3iehjRdL5vVhDgFMUCcDOq+3N4aP1cjUUWYuKK6XHDvWjFxSOdgv gEnPA52ZjRqaXE7vc2+XS8QfZ72nNrM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746720827; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GFej/CPQ8o9iXNIiNBt2KYGS35drif/WrqoV7iS2MvI=; b=yUtVFq4CuRBx3POVoBAeAMhSpHaB4C19wIVT9W8PfTTW/FTqHrtJToLaxVUlTjD+UbYc0+ Qu6ZORqpRNPjzVKfgoXitoPBn71uXTrOwQuyKzCwVu8Ev7olT/WXGnKc/ipfBxKydsPbED b511KGz9cObMaWCRR0Ph2oWYRGIclm8= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=C2cDkb5F; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.45 as permitted sender) smtp.mailfrom=urezki@gmail.com Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-548409cd2a8so1459889e87.3 for ; Thu, 08 May 2025 09:13:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746720826; x=1747325626; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=GFej/CPQ8o9iXNIiNBt2KYGS35drif/WrqoV7iS2MvI=; b=C2cDkb5FaafNLwcu9zY9X4ULdIfsJIwbywcM+bw6X2KYhieXilseuL/ftyqYh/CdgO t0WA1DrSS2bVccFaLVmBGjGqPV2I0GH/L2+Eknn3/mw9JgbSj+tfIgkJ0NAMuFQkynDD ixe9ay3j3EhoOEepxMx7gl4iocks+mpUfl6b50NKTGtFtEttieCYkdbU5egqBUvtrg1/ vOQ8ndmDkzt7ZMeUXpprlaGJ4bo/Sov6ZEVzlEGihwMRio5v4ENEWUlHWaJtO6/COND7 1BV5/yZ7aluxgRNm8/gBHS1wGwQpVwF6nOgDu+G5cTEaehi7zYfGoKD7ZnbmFAEnc427 izaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746720826; x=1747325626; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GFej/CPQ8o9iXNIiNBt2KYGS35drif/WrqoV7iS2MvI=; b=SdhpKwsZ27vBbtTrXMFgQ1GHe1Rsvk8pYNMs3rg64NmPH8expdADoh+X1q3oaR3PuU yvepcwmCBZdQGgr5nB82VcMqMua0/ZESJj9rNbN9gtSI8CTHDi1qYwMEMHU6nC3RD0TP Fqjg5zZJX0PeQqMQE7blwh62ak1GyMzMxXfpjruaWQKV/HJod05ZnSVEsX7I3ltSx06+ O4+uORKPHeXwoGw3hVVZHwGWsx7wLXNfTIICBU85n/rm8y00LH8lu/87xkeyFPhR14T1 Qysw6NidySU5JUaMhhOSEt0FldTOQdGa/VDfZHwcEuAkw9kcc+1dUHkqs/2mbp06cMtX hCdQ== X-Forwarded-Encrypted: i=1; AJvYcCXWOQ/l8mREM1kS/X6mpybIO9uDCBlu6gLO0eOPk5MBwVHNwK1spdrtpL6wB029b1i6eSC9W1DsCQ==@kvack.org X-Gm-Message-State: AOJu0Ywan7XBvdUC0FygbEIbPlgAUNlb8SPflIEFsZHsfw2nBeG5Jlzx TXXithx9YKo2zC0j/VLiJAS64yvf438N4Yc+GkY89aHQSCxS/HVWNPsB+A== X-Gm-Gg: ASbGncv35VRUE/wvylAakpSS7tvRH8Q0YTSSW44qW3ccPHZJLTfJgtg7QKjJGdmeveB bbrSpXXj71hB6WcnxtJqwWFICV425wjeOEREDrW3EYhtBuX5B8Xx3cUIZ1cFMFydfS81F2bWzHM jC8Usc+96ROsI5hCAUiigM+mgpX751XJ1Xh+lPOm+Ufe0LgLDepkkqL/S03Wmg042hNDTb35iAi KZO8XQ+OcB03UrjU3LqRxCHtkDEN23pa6qUrTxL3Li5vAN0az26PE9uRfsUAytJArL2MY2/4SRA ms4jMdLoZS5RLSktkAl66a3JLBL0ih3OPQWISF9R6k/YvwuoSmWIWMeW2mj6eqIU/8v3 X-Google-Smtp-Source: AGHT+IGgD65560HzL/6PBv9voSzw0VRFSOIhsSLY/0ISrjJf8HmXevLYzW7ZEZQnDyYOAqLc3LxiHw== X-Received: by 2002:ac2:4e0e:0:b0:545:ea9:1a1f with SMTP id 2adb3069b0e04-54fb95fc290mr2417920e87.25.1746720825317; Thu, 08 May 2025 09:13:45 -0700 (PDT) Received: from pc636 (host-95-203-26-194.mobileonline.telia.com. [95.203.26.194]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54fc644fd0esm9428e87.6.2025.05.08.09.13.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 May 2025 09:13:44 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Thu, 8 May 2025 18:13:42 +0200 To: Jeongjun Park Cc: akpm@linux-foundation.org, urezki@gmail.com, edumazet@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5] mm/vmalloc: fix data race in show_numa_info() Message-ID: References: <20250508160800.12540-1-aha310510@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250508160800.12540-1-aha310510@gmail.com> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 4BC314000B X-Stat-Signature: bthbjx78bj6huooify4f1z53igke37ge X-Rspam-User: X-HE-Tag: 1746720827-358629 X-HE-Meta: U2FsdGVkX18TnnatG0S3fWETSB5PlOp7eGxejzITcJOwoMYHVnVv7MqO2vO9vkJsdydKbCe6wiPgcURkTjDiHYHDMoM89i25dArWMueVkuf7PVD8zZigl0Rx7cvKw8CUXsatKXnKIVrLxwxbX+EnjYOJWYpwHt9kjCyNlEVcn8I6zDcuNCAsQLwGoaXpNtmQgP4MD2Yb9anpimzqaiqXkNnQ/clOk513qvkogwJwx26ctr0XUBnpsGAn1ODEV1oso2/IJiK5OdT27/WtEfQMC5YcLXzuip2/7QdDgKjBUhPSYBjPbWlfEnZIFTjy0vyE2Xa1qLonyFnNkTWHwaugTRip99aI7DG+grJ2B4MeKlmbs0v8R5ZrK2nfgpt9qAUKkRAlNMW9v7eP1XvVBVDSpEkk3bJF+IlsdJ99Rx0+iPdmNe1oBLcO4qTy6SiUnydvNM19+RRLVCQ3/ZJCPuHSqCOsv5mfOBYT6tQrX3ZOfsNzmB5t7m7CS3Zpj8qDksZK03onVXp93F7hVsDz64LSYXeXEfu/faSR99yvta7pg6VvJ5Rs6+hT9XE51j1yyPJgxBLliR4FRezm4D+1zo+tqdkYIiREpoKDX7kKMaEVgnNkrRiG3qKm0hETY86eXNCQcsg/ReAxXrGarnPgN3lneH9xrszhxquXtlY9KM/mCbMjRPsxGryA+YcqkP67omyifp3Iti0pfsgv8PnSfpcy/dFXuragKCl7jqDAYDExYVosgjb7F00W0gV+G7361bGPex4kWS/oDum9oRFwIIeg7i9I24FwhLfbXoRSz5JKb9Zbdb/6OEl7ciohj676KiVi19mAk6pl9R0OuxIkh2vzatU4HRc+kiwxVoJ5PopuReJzujiO+iSeeT19CGVvij5KIYASOT9GzOUNwsaF9dEP6v3JzPLGvuZy7WkQLRXGMXAiz6urKToZHM+ijLE2IY1rnA9XRQHwoHuV7xS+FSS 2/FIXicz CiLRClBNfTUwUL2RXL71zeysvHIxpff4noRru46DGki0dQMccMOuC5oPFGQEgp29JtAVPjJR19zBsIv0nb9gPuYcHfPzjM9hQNBoTSrMcKL49J0Xnh+5XEM+5bbfVTTssMwWsj1X2sTwxQOaHtJ15JIqgUZIUWiSv8VJKj8tznfnqKVYLle5/lDR5fQQo2SJyY1dYG6aNc6oJ8Um8ISuJpp/u1Q+BKMnkmA1bb1rHl/4eRlTr804+bomobedRxO+Z4LDmVjBq/1QwgkOWKo5WbSKGYKjfezSmMmrG/m8ADSFZA20KPxfKEqt0grY37UzZYFXgHhdPQnoV2fP/7TiLN3LBnE+R4pZ8IWAFTSXXNtDDq7pViYC7xcaFjPl5qPrs0Zx/bJOjCvMSEOzavCGYgRyVllNy7rBYacJJoCRv2SVUipj3rQJIfQ5ul8x7P5sXz56tEN6cYM+90rgUyAC/ULi7+MeBb/HUr5HVLBdBWNV1i9tVkoTGW1K6Bo1f9yi60Y+g1x/qQ/FrOZwUbLVfwHPxGA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 09, 2025 at 01:07:59AM +0900, Jeongjun Park wrote: > The following data-race was found in show_numa_info(): > > ================================================================== > BUG: KCSAN: data-race in vmalloc_info_show / vmalloc_info_show > > read to 0xffff88800971fe30 of 4 bytes by task 8289 on cpu 0: > show_numa_info mm/vmalloc.c:4936 [inline] > vmalloc_info_show+0x5a8/0x7e0 mm/vmalloc.c:5016 > seq_read_iter+0x373/0xb40 fs/seq_file.c:230 > proc_reg_read_iter+0x11e/0x170 fs/proc/inode.c:299 > .... > > write to 0xffff88800971fe30 of 4 bytes by task 8287 on cpu 1: > show_numa_info mm/vmalloc.c:4934 [inline] > vmalloc_info_show+0x38f/0x7e0 mm/vmalloc.c:5016 > seq_read_iter+0x373/0xb40 fs/seq_file.c:230 > proc_reg_read_iter+0x11e/0x170 fs/proc/inode.c:299 > .... > > value changed: 0x0000008f -> 0x00000000 > ================================================================== > > According to this report,there is a read/write data-race because m->private > is accessible to multiple CPUs. To fix this, instead of allocating the heap > in proc_vmalloc_init() and passing the heap address to m->private, > vmalloc_info_show() should allocate the heap. > > Fixes: a47a126ad5ea ("vmallocinfo: add NUMA information") > Suggested-by: Eric Dumazet > Suggested-by: Uladzislau Rezki (Sony) > Suggested-by: Andrew Morton > Signed-off-by: Jeongjun Park > --- > v5: Change heap to be allocated only when CONFIG_NUMA is enabled > - Link to v4: https://lore.kernel.org/all/20250508065558.149091-1-aha310510@gmail.com/ > v4: Change the way counters array heap is allocated, per Andrew Morton's suggestion. > And fix it to call smp_rmb() in the correct location. > - Link to v3: https://lore.kernel.org/all/20250507142552.9446-1-aha310510@gmail.com/ > v3: Following Uladzislau Rezki's suggestion, we check v->flags beforehand > to avoid printing uninitialized members of vm_struct. > - Link to v2: https://lore.kernel.org/all/20250506082520.84153-1-aha310510@gmail.com/ > v2: Refactoring some functions and fix patch as per Eric Dumazet suggestion > - Link to v1: https://lore.kernel.org/all/20250505171948.24410-1-aha310510@gmail.com/ > --- > mm/vmalloc.c | 62 ++++++++++++++++++++++++++++------------------------ > 1 file changed, 34 insertions(+), 28 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 3ed720a787ec..866f18766dfc 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -3100,7 +3100,7 @@ static void clear_vm_uninitialized_flag(struct vm_struct *vm) > /* > * Before removing VM_UNINITIALIZED, > * we should make sure that vm has proper values. > - * Pair with smp_rmb() in show_numa_info(). > + * Pair with smp_rmb() in vread_iter() and vmalloc_info_show(). > */ > smp_wmb(); > vm->flags &= ~VM_UNINITIALIZED; > @@ -4914,28 +4914,29 @@ bool vmalloc_dump_obj(void *object) > #endif > > #ifdef CONFIG_PROC_FS > -static void show_numa_info(struct seq_file *m, struct vm_struct *v) > -{ > - if (IS_ENABLED(CONFIG_NUMA)) { > - unsigned int nr, *counters = m->private; > - unsigned int step = 1U << vm_area_page_order(v); > > - if (!counters) > - return; > +/* > + * Print number of pages allocated on each memory node. > + * > + * This function can only be called if CONFIG_NUMA is enabled > + * and VM_UNINITIALIZED bit in v->flags is disabled. > + */ > +static void show_numa_info(struct seq_file *m, struct vm_struct *v, > + unsigned int *counters) > +{ > + unsigned int nr; > + unsigned int step = 1U << vm_area_page_order(v); > > - if (v->flags & VM_UNINITIALIZED) > - return; > - /* Pair with smp_wmb() in clear_vm_uninitialized_flag() */ > - smp_rmb(); > + if (!counters) > + return; > > - memset(counters, 0, nr_node_ids * sizeof(unsigned int)); > + memset(counters, 0, nr_node_ids * sizeof(unsigned int)); > > - for (nr = 0; nr < v->nr_pages; nr += step) > - counters[page_to_nid(v->pages[nr])] += step; > - for_each_node_state(nr, N_HIGH_MEMORY) > - if (counters[nr]) > - seq_printf(m, " N%u=%u", nr, counters[nr]); > - } > + for (nr = 0; nr < v->nr_pages; nr += step) > + counters[page_to_nid(v->pages[nr])] += step; > + for_each_node_state(nr, N_HIGH_MEMORY) > + if (counters[nr]) > + seq_printf(m, " N%u=%u", nr, counters[nr]); > } > > static void show_purge_info(struct seq_file *m) > @@ -4962,8 +4963,12 @@ static int vmalloc_info_show(struct seq_file *m, void *p) > struct vmap_node *vn; > struct vmap_area *va; > struct vm_struct *v; > + unsigned int *counters = NULL; > int i; > > + if (IS_ENABLED(CONFIG_NUMA)) > + counters = kmalloc(nr_node_ids * sizeof(unsigned int), GFP_KERNEL); > + > for (i = 0; i < nr_vmap_nodes; i++) { > vn = &vmap_nodes[i]; > > @@ -4979,6 +4984,11 @@ static int vmalloc_info_show(struct seq_file *m, void *p) > } > > v = va->vm; > + if (v->flags & VM_UNINITIALIZED) > + continue; > + > + /* Pair with smp_wmb() in clear_vm_uninitialized_flag() */ > + smp_rmb(); > > seq_printf(m, "0x%pK-0x%pK %7ld", > v->addr, v->addr + v->size, v->size); > @@ -5013,7 +5023,9 @@ static int vmalloc_info_show(struct seq_file *m, void *p) > if (is_vmalloc_addr(v->pages)) > seq_puts(m, " vpages"); > > - show_numa_info(m, v); > + if (counters) > + show_numa_info(m, v, counters); > + Let's execute it for NUMA only. > seq_putc(m, '\n'); > } > spin_unlock(&vn->busy.lock); > @@ -5023,19 +5035,13 @@ static int vmalloc_info_show(struct seq_file *m, void *p) > * As a final step, dump "unpurged" areas. > */ > show_purge_info(m); > + kfree(counters); Let's execute it for NUMA only. > return 0; > } > > static int __init proc_vmalloc_init(void) > { > - void *priv_data = NULL; > - > - if (IS_ENABLED(CONFIG_NUMA)) > - priv_data = kmalloc(nr_node_ids * sizeof(unsigned int), GFP_KERNEL); > - > - proc_create_single_data("vmallocinfo", > - 0400, NULL, vmalloc_info_show, priv_data); > - > + proc_create_single("vmallocinfo", 0400, NULL, vmalloc_info_show); > return 0; > } > module_init(proc_vmalloc_init); > -- You are so fast :) -- Uladzislau Rezki