From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E5E0C3ABC0 for ; Thu, 8 May 2025 16:09:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD6B66B0088; Thu, 8 May 2025 12:09:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B85A16B008A; Thu, 8 May 2025 12:09:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A02186B008C; Thu, 8 May 2025 12:09:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7D8476B0088 for ; Thu, 8 May 2025 12:09:29 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 1478D1A09DC for ; Thu, 8 May 2025 16:09:31 +0000 (UTC) X-FDA: 83420225742.04.DB19E8A Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by imf11.hostedemail.com (Postfix) with ESMTP id DC32F40003 for ; Thu, 8 May 2025 16:09:28 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Al8noFS8; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.42 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746720569; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8LnwTTCAQRFFQbMJT/nnes2GmWyTLkIS7KSh3yHicFo=; b=8MYsQWvMKzbB+bFmjRi9/pvzVsw1B4oyf7kZdwHBF/Hx9LKPeD4+6QcusACi2wcJMNyLuS 7VzFg7J2cFaeQ+mDmB7VVfUD0xfW3ZKEA/OFbTTNIP9hDQN1PL1rXRf4066L2o2lFUqu4u E0jGfO3t39DcHhLUSlf/Vzg+lYh9tcw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746720569; a=rsa-sha256; cv=none; b=qNlZ5wcLwsbWNMpG08FOlTi6V4RvohQvW6VhJa0f2craauG9aqVSQ2BfayuOjStNNCdpKd hAkhSYVYWc+V8ww5bjX0Bj5a+64vIbIyqrmmYGh8AvUu1Q9udZy5M3lsSrMA6JosKpcbz+ xxhMN80HLngIUdasChZcbz39wTUpnAI= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Al8noFS8; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.42 as permitted sender) smtp.mailfrom=urezki@gmail.com Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-54afb5fcebaso1538316e87.3 for ; Thu, 08 May 2025 09:09:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746720567; x=1747325367; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=8LnwTTCAQRFFQbMJT/nnes2GmWyTLkIS7KSh3yHicFo=; b=Al8noFS85fQn7rUG2HsX7k+Ygw4LCH/bHUJef4rrC3E8eDFu0s4CAP/UWPklh/uDYJ jYpStw8oDelmgbuNRq6d4K2Bc4lw5oH+1PZeXccuVLNZKkRsPNoAE+ePntVEMd3NDuLJ GyVmuaH9amwWf2slTTtn1pTcnGC9rFhgbYqUCGLCmzoCBGaWnX/455Gyo5XaYJhBaEc6 QdpbjXD1LyD3K72RSEbK6eOleyL/cvLLPDX3shWckz2Kid9TwQ55ilO9tVwXJJvlp5z3 aZJ7JCE5+ExoUeZORNH64My/A7PkqoctSG7DlO7eJtr8RVQt2DGr7gTy4KNiUQT/3B0m GMeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746720567; x=1747325367; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8LnwTTCAQRFFQbMJT/nnes2GmWyTLkIS7KSh3yHicFo=; b=rglXW4qcBkQpFynAG48kJQewjmsoWnslhcqRGCgJG0wainIPccaPRjjmuuGKOltbj4 VPwBCwAluFcQTQfnY5QjT7C2pHhkhWv+lYk56yzbOkxoGVZ7V/8DYrwZGWGRNkfUwT2G poY8u1oqv0GHZKMxqT0Pm9M6uYa2JjQHVaH9dEDXeWy7sT6wOrU9q284b8WSBldjKbdY U4Q8gubBRAWQCR6wVrSLe5XB2FwVHIqg4rX4UMV+bC/mrmivtfMZJaNK879DFmFBwdoa SJ4UoqMi6kb78qyI77zM8elgUHz3kTL1rzbQ31MSv0pMQ3cNkUW2tcm2/ofD75uNmE8y VNqg== X-Forwarded-Encrypted: i=1; AJvYcCU4Nz+zK0C+hf4GNbCGgYxjYFH5KnXyEkoXeelbmQkmPdf/cqeEdblQ/UOVx7i8wY/7ygRgrJdjvQ==@kvack.org X-Gm-Message-State: AOJu0YwienmgB9xySwpdGMzZxzzFx7Q44wzAQXFF6flfZwJR+XI30dBc zMHgqtNWKg4RPKinCQHYY/WiSAVnIfECCOQnv5BW3fos/hvIqSvv X-Gm-Gg: ASbGncuhlOprBsnU5PGHPvSqM99SQtVL4Dr3IBDNO5YOocvaj+n2doBlXZK9/3jPzpR GlRZ1RtHPmYc8/T/kaumxMxHTmD+3HlyVyk0u5eierV4PxTr7QwBH+Lh+JePpyLYWZyWaeb8i3j ETM6bCvUF1VOUVtVxPcm8LJblbxm8z+lQGpKybKUJH9t3R4dMTvYhDiGw+EP+vHZJwKq9AOnq/W tctITHdMglp5UKgP+trkPAI5VOSPUbeWZfe36+tWonNB58/BJnTDoegqLordxOCK/mzJhgUjXuk aMS/cXoYoelYCwu6kBGcVFb5QyBsH5pxWaa+mdf6KfgiJUlhrnba05rXXWipaZBpaBuc X-Google-Smtp-Source: AGHT+IE3Bs4L6ztk2NvjDutjeHV0IpdZ0dbBwPVx19un/W2Mp7T80XlS7pmJ7742fYtAMct4/kZahQ== X-Received: by 2002:a05:651c:221b:b0:30d:b49d:7fb7 with SMTP id 38308e7fff4ca-326c458a5f3mr545281fa.16.1746720566588; Thu, 08 May 2025 09:09:26 -0700 (PDT) Received: from pc636 (host-95-203-26-194.mobileonline.telia.com. [95.203.26.194]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-326c339a324sm372141fa.4.2025.05.08.09.09.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 May 2025 09:09:25 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Thu, 8 May 2025 18:09:23 +0200 To: Jeongjun Park Cc: Uladzislau Rezki , akpm@linux-foundation.org, edumazet@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] mm/vmalloc: fix data race in show_numa_info() Message-ID: References: <20250508065558.149091-1-aha310510@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: DC32F40003 X-Rspam-User: X-Stat-Signature: mnxzw5pbw89x3rnfndbz89p99ikk7ytu X-HE-Tag: 1746720568-91847 X-HE-Meta: U2FsdGVkX182lOBz/Lt169TUOWjOv+oKsCZbDAbxCyDefe+qwg7Jdf4snoswADte8mvRgCTHo0dXYDhg/wSs1T+lYoS8TNI9yLaskmAaDnEJ+DOPsEOd8OYoRYUHoO2s9n/dagxdLLtLc+zasHS6CfmPCdku4BGbvnnT5vUZvEWkyX/64x2VxRaR/OaoZTPQImvKGnMS5xlv5+kr5YV/zFv0USSlfMPLuKHLj9WVO+DQQQGKglLir7eSdo6MZrWOzRi+YLwRGjZsoOpqUKEKN3EQ35U1SL/mWxkcSUox/Xf5JEKSYQ/YQsyUTPcdKIdXTArMkDRn0moxlv+tn/zoLhZV/mTRiXYNUHPorKoBUdW7iWg+EXbuk7fFZNsXdF55SmF4vTz8zUbI/lMFOXpRIWkJlVREpcOUTwZZAqzEF6K2YaBG+N1/XYvxWaH6/TEqZuZgRB6kPR1pd3+ZA8WH2/EvpHYp9zDNiC1rEa9N+mJd/jQwhpZ3kDlQeMh4nLRBJYu5xelWQulXQJeuXsug22CT2egmED/skk98rxjd0JWolpyHCEuTijLdl86EjbEvzRkpmq9XovH5J12ibvNFzNHlXFd0DoWd74b9wkJ9TXZ+ncmyvKoJtJp+UPT0uSGgll2kaFLzIevl5o66uRD/3Wnlo+Paerp1wMIUVmZfzOwNc+ZCsbE85oUmT++IfFLhaRzOJDmHsCmSEyi6F7NNhXGCox5Jalzn9T0P9mQHRXdCteGfIzxsvSdex0Z8aCL8lNX722FR/JYzMPIGYvnJVbn/NooGhl4/iKjwWpl460TqLEis8P9NA0lBQeh18AQxUEV1gbvPDkjtv/TZAN2m9kg08vgG3YH4PQMROOVnhyxEeaqJC1c70XCZFfdqXOPiWTV/pX6KNZI4F15romze5cBZg40I8D00Y2xL0F5oO8IfzwNDn/Qvy8kfvBlB+ol70p5B01JdjxyVo2HB3am Y4WpoAPM i2YAs+K9DKIplSOUJ5Lgihoobd6C0boR7oMyw5RcZGvo/lk4Tyek0rbqO9KbGtqm91uxxFuPaisyPYO2EY42r0/F6K3Ak9r7BbP2mO6UsoBwZtnobHHNQoUdbnA3BvywU4s6LyUJj+nE/kcGMB+xQnosqhB4GUmjheSX2B95CFjiicSXmyGFdMXtZnsUM+TKbETcSnjs3yHBhtZF2CQL0vgxdY6tGTax2qwf9l+IIBR92OM2na4JYw18iiJ8x2sOcIhdkcmpxykgTtA0pZjWwWk971dfhMjQEB91wlLsS0jjDdDammqaXumqglX5IZZx/v6xaFtXYyg+YKEsx+6XcPF4qwEQQciBuMiPw7jYA5Gux+Fr7tx8G3pstLfwbyEXxdugzmxymZwDGgnd1vdKjaIJZrVAqjGfnfZJsS/5CI1zneT/zHHQnjVTYclRBytkrNqZPwoa0d9vBvNhEcr2/haNYNUFQSCmzA44MzAyWI9JvpCo/sIznxG6ro9VHXNiC3DoVsWKKXuFEg7/DbFKeoitrOw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 08, 2025 at 10:35:37PM +0900, Jeongjun Park wrote: > Uladzislau Rezki wrote: > > > > On Thu, May 08, 2025 at 03:55:58PM +0900, Jeongjun Park wrote: > > > The following data-race was found in show_numa_info(): > > > > > > ================================================================== > > > BUG: KCSAN: data-race in vmalloc_info_show / vmalloc_info_show > > > > > > read to 0xffff88800971fe30 of 4 bytes by task 8289 on cpu 0: > > > show_numa_info mm/vmalloc.c:4936 [inline] > > > vmalloc_info_show+0x5a8/0x7e0 mm/vmalloc.c:5016 > > > seq_read_iter+0x373/0xb40 fs/seq_file.c:230 > > > proc_reg_read_iter+0x11e/0x170 fs/proc/inode.c:299 > > > .... > > > > > > write to 0xffff88800971fe30 of 4 bytes by task 8287 on cpu 1: > > > show_numa_info mm/vmalloc.c:4934 [inline] > > > vmalloc_info_show+0x38f/0x7e0 mm/vmalloc.c:5016 > > > seq_read_iter+0x373/0xb40 fs/seq_file.c:230 > > > proc_reg_read_iter+0x11e/0x170 fs/proc/inode.c:299 > > > .... > > > > > > value changed: 0x0000008f -> 0x00000000 > > > ================================================================== > > > > > > According to this report,there is a read/write data-race because m->private > > > is accessible to multiple CPUs. To fix this, instead of allocating the heap > > > in proc_vmalloc_init() and passing the heap address to m->private, > > > vmalloc_info_show() should allocate the heap. > > > > > > Fixes: a47a126ad5ea ("vmallocinfo: add NUMA information") > > > Suggested-by: Eric Dumazet > > > Suggested-by: Uladzislau Rezki (Sony) > > > Suggested-by: Andrew Morton > > > Signed-off-by: Jeongjun Park > > > --- > > > v4: Change the way counters array heap is allocated, per Andrew Morton's suggestion. > > > And fix it to call smp_rmb() in the correct location. > > > - Link to v3: https://lore.kernel.org/all/20250507142552.9446-1-aha310510@gmail.com/ > > > v3: Following Uladzislau Rezki's suggestion, we check v->flags beforehand > > > to avoid printing uninitialized members of vm_struct. > > > - Link to v2: https://lore.kernel.org/all/20250506082520.84153-1-aha310510@gmail.com/ > > > v2: Refactoring some functions and fix patch as per Eric Dumazet suggestion > > > - Link to v1: https://lore.kernel.org/all/20250505171948.24410-1-aha310510@gmail.com/ > > > --- > > > mm/vmalloc.c | 61 ++++++++++++++++++++++++++++------------------------ > > > 1 file changed, 33 insertions(+), 28 deletions(-) > > > > > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > > > index 3ed720a787ec..112df5a86106 100644 > > > --- a/mm/vmalloc.c > > > +++ b/mm/vmalloc.c > > > @@ -3100,7 +3100,7 @@ static void clear_vm_uninitialized_flag(struct vm_struct *vm) > > > /* > > > * Before removing VM_UNINITIALIZED, > > > * we should make sure that vm has proper values. > > > - * Pair with smp_rmb() in show_numa_info(). > > > + * Pair with smp_rmb() in vread_iter() and vmalloc_info_show(). > > > */ > > > smp_wmb(); > > > vm->flags &= ~VM_UNINITIALIZED; > > > @@ -4914,28 +4914,29 @@ bool vmalloc_dump_obj(void *object) > > > #endif > > > > > > #ifdef CONFIG_PROC_FS > > > -static void show_numa_info(struct seq_file *m, struct vm_struct *v) > > > -{ > > > - if (IS_ENABLED(CONFIG_NUMA)) { > > > - unsigned int nr, *counters = m->private; > > > - unsigned int step = 1U << vm_area_page_order(v); > > > > > > - if (!counters) > > > - return; > > > +/* > > > + * Print number of pages allocated on each memory node. > > > + * > > > + * This function can only be called if CONFIG_NUMA is enabled > > > + * and VM_UNINITIALIZED bit in v->flags is disabled. > > > + */ > > > +static void show_numa_info(struct seq_file *m, struct vm_struct *v, > > > + unsigned int *counters) > > > +{ > > > + unsigned int nr; > > > + unsigned int step = 1U << vm_area_page_order(v); > > > > > > - if (v->flags & VM_UNINITIALIZED) > > > - return; > > > - /* Pair with smp_wmb() in clear_vm_uninitialized_flag() */ > > > - smp_rmb(); > > > + if (!counters) > > > + return; > > > > > > - memset(counters, 0, nr_node_ids * sizeof(unsigned int)); > > > + memset(counters, 0, nr_node_ids * sizeof(unsigned int)); > > > > > > - for (nr = 0; nr < v->nr_pages; nr += step) > > > - counters[page_to_nid(v->pages[nr])] += step; > > > - for_each_node_state(nr, N_HIGH_MEMORY) > > > - if (counters[nr]) > > > - seq_printf(m, " N%u=%u", nr, counters[nr]); > > > - } > > > + for (nr = 0; nr < v->nr_pages; nr += step) > > > + counters[page_to_nid(v->pages[nr])] += step; > > > + for_each_node_state(nr, N_HIGH_MEMORY) > > > + if (counters[nr]) > > > + seq_printf(m, " N%u=%u", nr, counters[nr]); > > > } > > > > > > static void show_purge_info(struct seq_file *m) > > > @@ -4962,8 +4963,11 @@ static int vmalloc_info_show(struct seq_file *m, void *p) > > > struct vmap_node *vn; > > > struct vmap_area *va; > > > struct vm_struct *v; > > > + unsigned int *counters = NULL; > > > > > Setting NULL can be dropped. > > > > > int i; > > > > > > + counters = kmalloc(nr_node_ids * sizeof(unsigned int), GFP_KERNEL); > > "if (IS_ENABLED(CONFIG_NUMA))"? If no NUMA, allocating and freeing sounds > > like without any reason. > > > > > + > > > for (i = 0; i < nr_vmap_nodes; i++) { > > > vn = &vmap_nodes[i]; > > > > > > @@ -4979,6 +4983,11 @@ static int vmalloc_info_show(struct seq_file *m, void *p) > > > } > > > > > > v = va->vm; > > > + if (v->flags & VM_UNINITIALIZED) > > > + continue; > > > + > > > + /* Pair with smp_wmb() in clear_vm_uninitialized_flag() */ > > > + smp_rmb(); > > > > > > seq_printf(m, "0x%pK-0x%pK %7ld", > > > v->addr, v->addr + v->size, v->size); > > > @@ -5013,7 +5022,9 @@ static int vmalloc_info_show(struct seq_file *m, void *p) > > > if (is_vmalloc_addr(v->pages)) > > > seq_puts(m, " vpages"); > > > > > > - show_numa_info(m, v); > > > + if (IS_ENABLED(CONFIG_NUMA)) > > > + show_numa_info(m, v, counters); > > > + > > > seq_putc(m, '\n'); > > > } > > > spin_unlock(&vn->busy.lock); > > > @@ -5023,19 +5034,13 @@ static int vmalloc_info_show(struct seq_file *m, void *p) > > > * As a final step, dump "unpurged" areas. > > > */ > > > show_purge_info(m); > > > + kfree(counters); > > > > > Maybe check for NULL before and IS_ENABLED(CONFIG_NUMA)? > > > > -- > > Uladzislau Rezki > > Hmm....then I think patching vmalloc_info_show() like this should > work. > > --- > mm/vmalloc.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 3ed720a787ec..b60355256211 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -4962,8 +4962,12 @@ static int vmalloc_info_show(struct seq_file *m, void *p) > struct vmap_node *vn; > struct vmap_area *va; > struct vm_struct *v; > + unsigned int *counters = NULL; > int i; > > + if (IS_ENABLED(CONFIG_NUMA)) > + counters = kmalloc(nr_node_ids * sizeof(unsigned int), GFP_KERNEL); > + > for (i = 0; i < nr_vmap_nodes; i++) { > vn = &vmap_nodes[i]; > > @@ -5013,7 +5017,9 @@ static int vmalloc_info_show(struct seq_file *m, void *p) > if (is_vmalloc_addr(v->pages)) > seq_puts(m, " vpages"); > > - show_numa_info(m, v); > + if (counters) > + show_numa_info(m, v, counters); > + > seq_putc(m, '\n'); > } > spin_unlock(&vn->busy.lock); > @@ -5023,6 +5029,7 @@ static int vmalloc_info_show(struct seq_file *m, void *p) > * As a final step, dump "unpurged" areas. > */ > show_purge_info(m); > + kfree(counters); > return 0; > } > > -- > > This way, we won't allocate heap unnecessarily when > CONFIG_NUMA is disabled, and we only need to check if > counters are NULL or not before calling show_numa_info(). > Yep, makes sense to me! > > However, if you change it like this, counters must always be > initialized to NULL. > or: + unsigned int *counters; ... ... if (IS_ENABLED(CONFIG_NUMA)) kfree(counters); if NUMA, you always do kmalloc() on entry, so it points to NULL or to a real allocated memory. Apart of that, it is probably better to avoid of checking "counters" before invoking the show_numa_info() and replace it also by the IS_ENABLED(). It implies that you bail out if "counters" is NULL in the show_numa_info(). -- Uladzislau Rezki