From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1536AC3ABBE for ; Thu, 8 May 2025 15:23:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 124626B0082; Thu, 8 May 2025 11:23:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D39C6B0083; Thu, 8 May 2025 11:23:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F03486B0085; Thu, 8 May 2025 11:23:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D05056B0082 for ; Thu, 8 May 2025 11:23:51 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1FB231CD177 for ; Thu, 8 May 2025 15:23:52 +0000 (UTC) X-FDA: 83420110704.22.08CD8CF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf27.hostedemail.com (Postfix) with ESMTP id B7AE340005 for ; Thu, 8 May 2025 15:23:49 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Kb+TN+dr; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746717829; a=rsa-sha256; cv=none; b=HGQzneclhYDU2J1tBApoCBbyxGfJwqXmGH5j8gd20WasHcfvDfvr6o8/TBJ6l4DS8QlhKh SCwUW+nBXqwjN1RbCtPMCEf1lloRohFtLz74EDiqckYU03/yzftREbFS3TX6Hct7EqmW47 iqDLs2St17iO3llBxI82sAvitkC4TOw= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Kb+TN+dr; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746717829; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LmtLx7Rand6Q1RhHvZvf339T+gMnpgr8dRSMfTD9lZQ=; b=Xityv2l/zSlM05urdcPRmDKDLdNSxs7WcYNmQ3lx8tL5FOG+KCeckNDgDEKl+LDO2F1pto OdUDLwTFGzGywAEF+ue6/gldAE5xcMjR/qOSQ+iCP+y7+jdU0fr6PEU5x3QfZ6sKxtRNRM aRG2X6crh8MDY8jWW2V/cWmWIhAIgzM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746717829; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LmtLx7Rand6Q1RhHvZvf339T+gMnpgr8dRSMfTD9lZQ=; b=Kb+TN+drfW/T26TmHDBke0+caK76oIUA0P/1ylj2BvZn3ZpYA1mZiyau7KBC5uFZb8hH7R hI8LpmyEJyD0wX+gUcIRNGbI041s0ECd8EPDM+Sx7Gu/f1WGYgeQWszhtXzGRMmWrtP+Za ESDZMYZZnruHh1RHJgR4pDwHEAgJp0Q= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-297-rEa_Qk4xMoeXZ8Fir4GK-Q-1; Thu, 08 May 2025 11:23:48 -0400 X-MC-Unique: rEa_Qk4xMoeXZ8Fir4GK-Q-1 X-Mimecast-MFC-AGG-ID: rEa_Qk4xMoeXZ8Fir4GK-Q_1746717828 Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4769a1db721so23943451cf.3 for ; Thu, 08 May 2025 08:23:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746717827; x=1747322627; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LmtLx7Rand6Q1RhHvZvf339T+gMnpgr8dRSMfTD9lZQ=; b=S7poBJBSBAy2GgWWC+JeWfPqmKN+tPNlRDgfWvrvwyqaiV+tzIzMTZjdAqkMz3Rn56 v4Ofg/YvQiOmlJRJEK/KpWYEE5nETxx2R/YOrVpNj6IC+kqDM23R1eDuUDvYE+v5m2Bw 8ayXAI0X4WrAPrzuVcD6Sp2YaH+UQfmsIiJp4wDRQGV9WElqsbsDUW5AmEV4Rcar1s7Y PqIqhrLR2JxiBTZOl96bzOotspTOHQMfevgqV2z0/sKsQS0IA5QmVcTKLpbXbk4A9J/s EywfdIASqvl0D1PxKQR30DNdzBk9o77s0teovX3dURz4nscMhkqHBg8L1jitQeFYuZCl w3fQ== X-Forwarded-Encrypted: i=1; AJvYcCVBtQrP6t8AkxSrS2H1wr8c2gXGqdWQEXFOPqT5sAq39soalyl1s0GFWakpXRCVkcrS+JKZGmRlrw==@kvack.org X-Gm-Message-State: AOJu0YypKnrAz2MN6UfbifPMvIcF21A9q/MW0V2CwpDic5jFtJbtL0AW Ak4XkReeUChCsRDtAATXgQIKf2ZpTIC4c4fmRpKeSLSDNjiWqREQNjRV+Zmosq/mdNetrRQ1gyL Zp1A1WvLsVVWPFyIwDGaObp7Sg38iDqyplW4LKW3wJ+X6jbaW2AXX3DMp X-Gm-Gg: ASbGnctxRGN9jaNAWe1sCEWilm5XDcB1bXJSga77644iu0ibjOMP8mD23qbtm3cSWmL y4I6QIBOYIWDOktFlRrrInEM1kJOX+qC1TzJxOUXK1Bz4Y9tGNaQstd3e4kIH0FpmHmpnUnQC7q V6SQXoZzMJrYA9xggkG2/59IPkRILsxdBuSAVEigu1fmCrpbnGxGb/bvYYRMw2RAnK8SjQ+CKIU 58EqMaw4SVbhjmi/4nFko8+DkZrbzu9B7p+WZ6+u4mNzPt/sEfE6mBDjDZFur6832WNFt0Ryotu lbE= X-Received: by 2002:ac8:5890:0:b0:48e:9e05:cede with SMTP id d75a77b69052e-4922795d397mr104895401cf.52.1746717827311; Thu, 08 May 2025 08:23:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGwQWKOyxL7yTe7WTS/VAVIG3t1FeqJdgFw+aUKFJf4zGei3LL4swQHmoLoCdwSeBUi1GtY0w== X-Received: by 2002:ac8:5890:0:b0:48e:9e05:cede with SMTP id d75a77b69052e-4922795d397mr104895031cf.52.1746717826831; Thu, 08 May 2025 08:23:46 -0700 (PDT) Received: from x1.local ([85.131.185.92]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-49222d9f706sm35091881cf.53.2025.05.08.08.23.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 May 2025 08:23:46 -0700 (PDT) Date: Thu, 8 May 2025 11:23:43 -0400 From: Peter Xu To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Barry Song , David Hildenbrand , Suren Baghdasaryan , Lokesh Gidra Subject: Re: [PATCH RFC] mm: userfaultfd: correct dirty flags set for both present and swap pte Message-ID: References: <20250508090735.39756-1-21cnbao@gmail.com> MIME-Version: 1.0 In-Reply-To: <20250508090735.39756-1-21cnbao@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: B_xCItfjWgxoPJBkM8vDw92kdYMIrvaIC5AUckZLnJ4_1746717828 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: B7AE340005 X-Stat-Signature: ocj6aoo7wteoud4enfb7msboyjph4nez X-Rspam-User: X-HE-Tag: 1746717829-42470 X-HE-Meta: U2FsdGVkX185A45D3z64j+KaOJiA6+9ny4ufLh0udSmTQWUydyYZjkP1hDXHX5YjOadnzrRgC1nvpz/A5qlmV7nFDY1dFHtwlWSOURov8cLyOUuCq7aq/iltLpj2KHFwYo6xLxi37z2MTm4KVOp4kfOrdHgLeMVP1SHr8khdnQqOql/Y/+1q936T6pepzMt1+OSG+SIAdYFRknob/paXxLCZLh/r4khDpqdmtvPKncYN+9pSBrFYppvIgpm+23flkjlg6oiYpa8qIDWUfRvYBBl6rrEx4UzAsNQDzN/DlVWgaHiG7JgpSw2tHwJKs6rovOtIeh6OZq4Rh+2klQZ4iwKcS+oELsfmK1hPdJrJ7QSjeWigxJ1j0xjGf/bj/hAK9khiiasgcS9zj9ayQ1AqK/cxUaxh7wq39eqvgkojHxG6DIkMVHm/nBUdEH+RbdPU/ztfvdwE5OknRFyDYExTLwf0tbwFABrkWr+h5o1tw1YCrtybXqhJvb//iGzP8k9aeABUhyB9zilvyzF9Fdwn9YFEnS3b51yHS5u5lRDgMe9NYca7jgC71yUiHeQlKRvz7bnmP2rCN8bDY8Uz4tYX0HpNDZUyUnAAUyD/4tVHYej9O3kTGPEHgzyum9aZ1F0FyTy2GRTcmig62iCef4kfElpMk2vIa7OeWpItouzxN17YFYwDcX/qGipkKpspkm0BpYk361Xl+XILlMjsnmKKyw9YRXg49jpc62Bb+3E59pXBNPL7LqkFVOSUYLpv8y3VGiNx0bju98t7eWDc150kNl9YrqoQ5WCb99rGuFQkKOLPb6/u8uXrTNg4geEKntZ5L9NiQw/YEMucK8tTe6lPQjGKaatSJJxeQMZKbqByXlS2FuY+ijr5iOPGXF+pN2xRTTi3PDBM9ueskES7Tt4qhZLfdvPAQIZWnHFq3qDuvIqWrsi9XPbopZ5oJr9W/qne25HHK/XxKSpmJkI7U6c 04LyR+pr ZyDmwxbYSCZu1Bnfljj3Khnzpji6UjyWzRU/NVAiKVfqvCFzAwfBuUOZRISdzxG2Cxv1bVVOldeJFW7eXSnKcwiW2vivYqOGmeKZOmCnwuYsM8ld1u/XViSNE0YAvIcRC8roCMhTcmprCwj9XHVcHT38MGPXAx6KQTAQzFoCRhZM4/+9dj8aLijAX9i/nK9+yGIKicbYqHvjfBY5Ag8fy85CeZ0GznFbdJc1DZMgrdzPHrsfpTmq2F0X5z1xEoD6UFSjDncx0RQhDyGNIKXEWD0LIlDwGgWLgaiylo8w812pShUjAUsyQJfesafgHirvOIBi94MluacbE7I8R7tSwzmMoSpLYLCtRG65ejP8hhpbqBIp/iKPhxihnxRcdwtlg7X5/QXJH9xV47+sYSVG6Sa3RpGKgjeOJXnNLQl7CzaDY1Cg9zFRM5hUX5wXfIwqF0vbAJhc5PMeKFNI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 08, 2025 at 09:07:35PM +1200, Barry Song wrote: > From: Barry Song > > As David pointed out, what truly matters for mremap and userfaultfd > move operations is the soft dirty bit. The current comment and > implementation—which always sets the dirty bit for present PTEs > and fails to set the soft dirty bit for swap PTEs—are incorrect. > This patch updates the behavior to correctly set the soft dirty bit > for both present and swap PTEs in accordance with mremap. > > Reported-by: David Hildenbrand > Closes: https://lore.kernel.org/linux-mm/02f14ee1-923f-47e3-a994-4950afb9afcc@redhat.com/ > Cc: Peter Xu > Cc: Suren Baghdasaryan > Cc: Lokesh Gidra > Signed-off-by: Barry Song Acked-by: Peter Xu -- Peter Xu