From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A049C3ABC0 for ; Thu, 8 May 2025 14:41:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 32ACC6B0082; Thu, 8 May 2025 10:41:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D9416B0083; Thu, 8 May 2025 10:41:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1EE616B0085; Thu, 8 May 2025 10:41:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id F247F6B0082 for ; Thu, 8 May 2025 10:41:52 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3FE535AB40 for ; Thu, 8 May 2025 14:41:54 +0000 (UTC) X-FDA: 83420004948.09.46F0300 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf14.hostedemail.com (Postfix) with ESMTP id 7197F100003 for ; Thu, 8 May 2025 14:41:52 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=mew+Hpya; dmarc=none; spf=none (imf14.hostedemail.com: domain of BATV+b29930b5fa9b2b8daadf+7928+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+b29930b5fa9b2b8daadf+7928+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746715312; a=rsa-sha256; cv=none; b=EYigR++DMTSSlUfDRakgq8luN72CbUwS0il5c9AdauDQLg6QWprDGi2pa58d2o022Em1/e NgFX3gBwfDas6XNNrHTzevyWz7DE+LTnttLl7+0FpVbJ5iPqDjXLVwKFDtKCLGLZkOGxYC 0MMJo6SbahYoRE0qeD4z5UJxpbKb7+A= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=mew+Hpya; dmarc=none; spf=none (imf14.hostedemail.com: domain of BATV+b29930b5fa9b2b8daadf+7928+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+b29930b5fa9b2b8daadf+7928+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746715312; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xksPQr4k+dyXybCdk1b91MfhJYNDr0Joqg+ZhGH0NWI=; b=2js+a232Tzt/R4KcfsetEV0XNfSB0Kzl4isYmkl2jZLQWDiJFMmmpyz7uiCvObOLNayHyQ DBSkeMFsWrj99dbyWn7GUy6sXuk6BUZpneHhoVnEaC9RKxnWLmie+yw5MTU2Hp/T4GNeh5 KE1P7c6g9O8a0v8yjKuPkuCvxYwkQv0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=xksPQr4k+dyXybCdk1b91MfhJYNDr0Joqg+ZhGH0NWI=; b=mew+HpyaaJRhJwh0B3KtXSiI+8 5v05FtzeoiWFzjgRwpQH7/XwVPJElTXTD7nP1bl5HEZnjEPbhRGz4AWhxMeP+a2jx9Cp9JwQqm1PJ ggb0EovbqxWvwVI/puU42TbOTUChW8Amr2IW1zudZGujuvTdYlimf8j4dNKqvQqpnHdzHV1vskysh zR2mq5bNDh4csI7571fGYVivdbLI/dS1AUu229DCHhnQl313dS+0AgEGgBU4uOzTlwoXlqe2NMNGC hM4mCmLtMyLwEtS9Bp10j4kSvlxZOBSno0+zPbfV7E2m9Gu1ZrDgZBb03H/j1q6k/odM/t5s8IPIi od8AcBlg==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uD2Ra-00000000y2p-0HYt; Thu, 08 May 2025 14:41:50 +0000 Date: Thu, 8 May 2025 07:41:50 -0700 From: Christoph Hellwig To: Chris Mason Cc: Christoph Hellwig , Chris Mason , linux-btrfs@vger.kernel.org, Josef Bacik , David Sterba , linux-mm@kvack.org Subject: Re: What is the point of the wbc->for_kupdate check in btree_writepages Message-ID: References: <2d1a8e78-b57a-4726-a566-4d916a36be8f@meta.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2d1a8e78-b57a-4726-a566-4d916a36be8f@meta.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 7197F100003 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: e9yy9pnfy3ym735gmfudigkfq6hwasu4 X-HE-Tag: 1746715312-859294 X-HE-Meta: U2FsdGVkX18zBnhe0bRQsaGc/JxU4/GvfKGc275L4JR7H9DCFmjQGcEiQ5DBx+sM4ifonsLitTY/FUiy5LUDan7IXt1IqRspSeVCgBiDLUSeggKU8wg0fKecthSKjIFn5I4ROa9VsoKiwpiBf5z2ZRfWEB010paDepZ2ON6HfhSIQ5LYnvwKtJl7p5JkuSlfYmGJ0kQFMvj1CsqxC5cMKXlrBGVViL7vT51fhHUOX2GW5tNQ3NPtR/LO7Fk0AjDuRrl+svEwWCVgY601UscLa+Aai0sjwPagBooAz028ZPb4xcLWJ3EKLaUCevPf2/Dw3VGfEWvrcewS12EOXGXz5C7V+KJy7oRbOlRkK3YhqD/LYwQ4R9G3zrh4BpK/WK7T5xtvgba9sMouLs/23WuTj+YG/wwRiMuBydp9eq6A2wqYmSLgIm14R3dCW5qGM6EG36AmMsz5NBW/tzr8g6fwkq+jnhhebSBu4Y46bdAhiZQvmj9QYAtLyR8CK1mnJqSZGdrulH+SjJRn1JhzIdPomDFDOFeipTz4x90klTrCd9TbcF0M7Vw63coRLtKfpWAPjrQ2s6X5UzAHgueRIOuzsrFFKYO8GZ0VTFlEFwXUrwq0cCgn4QJdnqeprn3e2BZ37U0cPnKPSlJJNi38FwDLlpBHGcGahtO8Hm2q4p/WxP8gHVb/FV/OoXpTQmLWp6RIEA1opqTcxhHrHGqyVRoVyT+O/I5W7a8bbBGMnXwZhgbS7eokK3RPR6/arU18MXg24rZ1f6HY+rKenEzIXp1xCeaTugSpYD3R1+DT9AwMnIcC5VkXVHQv0iIplMH7erGnPINxG6URyoEjRVaWMCcGEdmb9ByAl8/usrjUsfJ3aJuoHIhYaCTPQ31CYXQNPJoQLigbNy7djT/WwmYY8th8nhgkImJsUvc4RKjSZ0mmfVw0B8ktvJSrRE6ojEg2NiayBh3PNitBAbFg5iveDra /kfx/OtD ewjL7fkmfEAupRZimJyCABSlq9NKApYS8XMEtcJZ3sTy+uTe1+L96FdY5HL1w7kjMEYRENqsncFANEp/IQVoNN6R+x+h1oWVofmtxqVBVHPcQ4eDS8HjplC90zTh7j5ZgwUMWeHHrTu6a/EJR/GJfD4o6u8p8MyV3hvSk+MJVw0gyjk4AL9iGQ07PdY0xrgsIjbfGPg3oJnAXuP36ioTnXIGXuDzGKYST4kZxqz/+D5GDnbOve1rAYFkY1l+fv9igWEU5HJVIYJCPzpizC8cIlxciIwRGa5JoAgRTs7BzJRbmeR0kpJuOUCLEJw7mPaQ5VmVX2I5gD8Occ+RryIYYkd4s546km7AddgksZxMfVl2DtbvlZswecBoqMDnVwrjca34PextLiOPyo2sN7Q1Y2zofdwzD7XT0a+gGiPzSuEgMxMZu/vGqY3sd6yNoDlYoH1zqHG2ctjtKIlV3f1ZqmpKrjz9yRoE2Siew8U29JwxhLG0Hx6t/+QbP7822WQBgyyOsjcRhTXRsNny+is/CoxgEZdQemuSmjHhp5FV81M+78tU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 08, 2025 at 10:33:24AM -0400, Chris Mason wrote: > btrfs can keep changing dirty tree blocks in memory, but once we write > them, we have to recow. Between transaction writeback kicking in every > 30 seconds and us calling balance_dirty_pages on the btree inode, > kupdate was doing more harm than good (back in 2007). I totally understand why you'd want to avoid background writeback. I just don't understand why it singles out for_kupdate. > Is the goal to get rid of for_kupdate? At least getting rid of exposing it to file systems, yes. > I wonder if we can just flag the > btree inode to exclude from kupdate, or keep it off whatever list > kupdate cares about etc. Not having the VM do writeback on metadata but running it from a fs LRU was a huge win in XFS. I'm not sure we have interfaces that keep data in the pagecache but never do any background writeback. But if you are fine with treating all background writeback equal that would be exactly where I'd like to go to.