From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D56BBC3ABC0 for ; Thu, 8 May 2025 12:52:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1CF6E6B0088; Thu, 8 May 2025 08:52:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1593E6B008A; Thu, 8 May 2025 08:52:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F132B6B008C; Thu, 8 May 2025 08:52:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id CF4876B0088 for ; Thu, 8 May 2025 08:52:01 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9438980260 for ; Thu, 8 May 2025 12:52:02 +0000 (UTC) X-FDA: 83419728084.02.F787B9D Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) by imf28.hostedemail.com (Postfix) with ESMTP id 91D8FC0004 for ; Thu, 8 May 2025 12:52:00 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=G0QOrfq8; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.171 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746708720; a=rsa-sha256; cv=none; b=l5GfN6KMlub44cpCx6y3gQr3h+SdwW0XrQI5xVnuLBvHGqo6enf7aRgcKso41O+QFUSS2a cqWuarnuOIwbShfrD0Id9AXgP6fI5alUUgMu0J28mkthB7CRjPAu9l+9x9sRAuhw0NWvBI yJUhJAA0OU2Ns1lNjzqA5NE8m10aXKY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746708720; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QXefnNocNyDT4tS5Nw3ri7gt0drxJ7YJmnY8ne5PsBs=; b=58jPwdE7NOMLVhTmGh1W1ugW5RqxtcmygJ1AXBkbJW3XexkJe12Fybs866j99mWcWVM66c zfgc3xy3DVfbNhTlGFCb3475mzwXAYB3SS8hzEchI3K44XTXo6UyioUSdcc7xLGjm0vKbg WP5KWt8xF2eXyjIv5NaFYSXBbGvmoyQ= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=G0QOrfq8; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.171 as permitted sender) smtp.mailfrom=urezki@gmail.com Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-30bef9b04adso8387661fa.1 for ; Thu, 08 May 2025 05:52:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746708719; x=1747313519; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=QXefnNocNyDT4tS5Nw3ri7gt0drxJ7YJmnY8ne5PsBs=; b=G0QOrfq8qBrb0ZNjHoYMbdGKV45n7pzJifh4Bwnza/fMT9samAvLa6KGz1eWajQjgN mbEiAMOK7C8SQEDVaw4OJxfyKPl8kldz4DRECJM75XllJmujdB2WINNZ5cbptTnevkvw aB4sf+N/A/l1FGgo8L+hXJfZrxPDcoMD2nocm24E2I7/H0af6SlSaQVOI1L73RzPqn25 lUxipiytb1d9ea/eGVIa+isEXLpBxMOvXSREceIJnd4QGe4qnn3zUty4EEnIjzPfpq9p 7cWGTtVNQTSit541S3fSrNysajGFlwEfmtvwPcgQ7DfgGqTODYztGlmgaD2gbgDJ3dYb /kQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746708719; x=1747313519; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QXefnNocNyDT4tS5Nw3ri7gt0drxJ7YJmnY8ne5PsBs=; b=VkxjuB+SzJoC/Nil4dCfhzOeZ7ZuGOY2Pwwn+ZbwH701u31kl0OgkIczEb4E+jsHOU 8Z3XlHrweXiJQuZTmpQc4OchrPXOj1JjLj3LkDS9wtBLszxyf51i1gMoXcy5DhklgcUZ F+HYo2dwT/fp0rjDZPuCQ/zT2mzNwnei9y//5p2L1OpyTADzpEzAcqokJhViPz8qxTmM 6iEoux1kzvnbHCoiKU/A9o/1cU1dPlkRb77rhBcKf+ntBgufCWADOuEO7zAVXAXy94CF VZVr/pbnMqD9jFE53jH0Zdpd/jRoXE5b3WzaLY2HjdskvrGPwv+GseEw7N2PyxSbMg3T 7blA== X-Forwarded-Encrypted: i=1; AJvYcCVUnhsZ4A5Aa3kSRacdXI6PshBtJTLj9zkdJk88dWV+Nm3BzEKnEy1Hne4BW40WN0PXJ4aCf0lrsQ==@kvack.org X-Gm-Message-State: AOJu0Yz2isQXxpXKM5rwrrsDh9cIdInw4OdzrqEmqkjVkeyXCfXBWZhW cMURDbRPs4Q93NqyTw+L7OtKANp4IvhvU+PurunCIF9OgtQaMdkz X-Gm-Gg: ASbGnctkHWSFkwU+s1w7wg13lgfNZwwwMy1CTap7+O1CnutmwTtO5aiyYtdYVrA6OSL PXUrFxureE9a+xWCX1ziYODIuxwVssDT+I1bowpahMLgAK7XO1iRgfH9sIaOZ8KzGtozRFR33YY zYTJbfIoDZdvOgZFRYXID9RTjCo08Z+9QYHrV3Ew3KZ5mlqlv2X2RBtV49E2WmUSnH4w+h0c/2H LJkOCREj906JWLs8TILu1trLzdNhML9K4yg+E/aBpjtQL0iam8opxcQu/ONSEimBPBW+01OJzrU e4nEwSGJEorF3CqFjRylkeCTYHFa+EECx5XrBzKUeWtpE8gVZ47Elecr642qmYYlwgwW X-Google-Smtp-Source: AGHT+IHsWRESsWBmiaAZR1ixPOXPanFcaeReOQUZMb4KYciPQ/LFJTScYcG69m+8oKvuu5nvXnPyhw== X-Received: by 2002:a05:651c:154b:b0:30d:626e:d031 with SMTP id 38308e7fff4ca-326ad33cf28mr33057001fa.33.1746708718564; Thu, 08 May 2025 05:51:58 -0700 (PDT) Received: from pc636 (host-95-203-26-253.mobileonline.telia.com. [95.203.26.253]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-32128ddfc71sm23334391fa.20.2025.05.08.05.51.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 May 2025 05:51:57 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Thu, 8 May 2025 14:51:55 +0200 To: Jeongjun Park Cc: akpm@linux-foundation.org, urezki@gmail.com, edumazet@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] mm/vmalloc: fix data race in show_numa_info() Message-ID: References: <20250508065558.149091-1-aha310510@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250508065558.149091-1-aha310510@gmail.com> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 91D8FC0004 X-Stat-Signature: k87wcgh8d7cwpaqd1p1afw6bihwrgs57 X-Rspam-User: X-HE-Tag: 1746708720-335496 X-HE-Meta: U2FsdGVkX1+tEcwfpW/hZd3Pm+G3cQC4D5a0NhCtJvYwcgFJJUTv6CQFKqZ26JQlxeDtBzChDTyRyoObFm0aRujz+LDEqr1B9glEEthIKMD7YkCZYzkHm7xfm9hkpUdnZGVPRZ3xvYc9aXacUgJA+/tm2hISyhu7oHumktqVepP6LIfoCbGDJ/CXR48xOioZGt76o6ykej0AKR0/CEzx/HlqHpoFiiSgGOHJ0mg9yGN4TTWYd1cwQbSrymrQWw7+ieZs4IwF14y/9t3S7wyZsGz4mgZRYJs3aEP5M4uhHJHgONmc6Yq783apg6yAHut+SVeSD5w6uhZ+q0cApI5ku0XaG/i3SgtNtnlasTkH8R//tzmqRCGrD2xzLX7cBWawrK/y73A31lIuWDOZJcyYd3iv5jAP2hONpppwPP52Yrs29mqSyQHmHNK+FiaWKLziu30exRb4aBkLEIY2GuLuFEr2UCA+G8qkNHt9NZwouzxYdBPlK+3zmFxHi7nNTrVW13DpYD+ZC6Ntm3H3ddrOACYT10Mj3O4yjDAqFUgiSwYMUvh5+GxdhCTw+xcqJ/bm8vwJOup1QR9lZgQxhpAX3FFZgPEp6DrDSp3+igTxeUQ16lGqIwEEWVF+IboudFcTiNmx2nEaUIjixVN516rMEv6I4sD7dOc7voO/gnOiiKfSGWzMDZfDpIHnEpWyShx7FeodzPFI2xFvdcussJjgbjHKqq5Ab86Jz0jK7qGog8JkN3LGeqqTANZtfO+JocS3weHTctFYaZKBZoDPalSA3dA58WkIdBX0m5K8i4xnT+x3l4hdd7W4VG8O/IVN+XNV5t2yQVSdsLzDMuMLb6uZrSvOPIYmRwpX6hLtE5Us95qf6dU8mPeA0TESTpCreUwVW6fkpaR5qOecn/UcApMSDMonzyc9d6q+75d7Ys3z4vCPQ4MBLq8xdQ5wdp11kYl2neTYhh6PILMakyig7n8 QJiGuCvD q4O86lgXdO04xtqLjHKJX/z7pBBtEEoLJfEkqcIjrsG9EY7sbWAMCU4a/TUWetIfG7OReNcunFdhkVRkDzq8MXz/am4aGjFQeYhXaxAr8V/nc7K2f6qBD/4xYTY3eBUeMp5evjBNSKbrS0OJfyJjijBlYfbEf/9RyOrVtIfiKcudtCySR9rJsXDFKuxYcu1sIi0WWYCP9Hx04an0PS3kfgOXpmhiKerhoj6pApkTq34Fh6uz7CNKWBoTMRIAjB+Sc1pLtsZ+xAuFVE2dnIoMOlVJyAHOjL42u+ue1ivk8uOiVn6VsZkCRcb+gcPqd1ywoWGwKKU23M5W4yfsAz+tQauwXFdW0QbaTxKG+w9H/51PhXSpl2QaoZYfspJttG+ENpdUHeQxQpZTGUJ8Qd1hh9bStzEa93C+N02X1qxaMl/o9iMdIl09al7TpSALDCTlpK9pYUiMGTx2biB08QM56WyyNIlesihVw/p+PeMuMiOwOPZIgda2Pi1eBn72qPJybuElTo4ZQiZs/8r7GPPykJiQfWQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 08, 2025 at 03:55:58PM +0900, Jeongjun Park wrote: > The following data-race was found in show_numa_info(): > > ================================================================== > BUG: KCSAN: data-race in vmalloc_info_show / vmalloc_info_show > > read to 0xffff88800971fe30 of 4 bytes by task 8289 on cpu 0: > show_numa_info mm/vmalloc.c:4936 [inline] > vmalloc_info_show+0x5a8/0x7e0 mm/vmalloc.c:5016 > seq_read_iter+0x373/0xb40 fs/seq_file.c:230 > proc_reg_read_iter+0x11e/0x170 fs/proc/inode.c:299 > .... > > write to 0xffff88800971fe30 of 4 bytes by task 8287 on cpu 1: > show_numa_info mm/vmalloc.c:4934 [inline] > vmalloc_info_show+0x38f/0x7e0 mm/vmalloc.c:5016 > seq_read_iter+0x373/0xb40 fs/seq_file.c:230 > proc_reg_read_iter+0x11e/0x170 fs/proc/inode.c:299 > .... > > value changed: 0x0000008f -> 0x00000000 > ================================================================== > > According to this report,there is a read/write data-race because m->private > is accessible to multiple CPUs. To fix this, instead of allocating the heap > in proc_vmalloc_init() and passing the heap address to m->private, > vmalloc_info_show() should allocate the heap. > > Fixes: a47a126ad5ea ("vmallocinfo: add NUMA information") > Suggested-by: Eric Dumazet > Suggested-by: Uladzislau Rezki (Sony) > Suggested-by: Andrew Morton > Signed-off-by: Jeongjun Park > --- > v4: Change the way counters array heap is allocated, per Andrew Morton's suggestion. > And fix it to call smp_rmb() in the correct location. > - Link to v3: https://lore.kernel.org/all/20250507142552.9446-1-aha310510@gmail.com/ > v3: Following Uladzislau Rezki's suggestion, we check v->flags beforehand > to avoid printing uninitialized members of vm_struct. > - Link to v2: https://lore.kernel.org/all/20250506082520.84153-1-aha310510@gmail.com/ > v2: Refactoring some functions and fix patch as per Eric Dumazet suggestion > - Link to v1: https://lore.kernel.org/all/20250505171948.24410-1-aha310510@gmail.com/ > --- > mm/vmalloc.c | 61 ++++++++++++++++++++++++++++------------------------ > 1 file changed, 33 insertions(+), 28 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 3ed720a787ec..112df5a86106 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -3100,7 +3100,7 @@ static void clear_vm_uninitialized_flag(struct vm_struct *vm) > /* > * Before removing VM_UNINITIALIZED, > * we should make sure that vm has proper values. > - * Pair with smp_rmb() in show_numa_info(). > + * Pair with smp_rmb() in vread_iter() and vmalloc_info_show(). > */ > smp_wmb(); > vm->flags &= ~VM_UNINITIALIZED; > @@ -4914,28 +4914,29 @@ bool vmalloc_dump_obj(void *object) > #endif > > #ifdef CONFIG_PROC_FS > -static void show_numa_info(struct seq_file *m, struct vm_struct *v) > -{ > - if (IS_ENABLED(CONFIG_NUMA)) { > - unsigned int nr, *counters = m->private; > - unsigned int step = 1U << vm_area_page_order(v); > > - if (!counters) > - return; > +/* > + * Print number of pages allocated on each memory node. > + * > + * This function can only be called if CONFIG_NUMA is enabled > + * and VM_UNINITIALIZED bit in v->flags is disabled. > + */ > +static void show_numa_info(struct seq_file *m, struct vm_struct *v, > + unsigned int *counters) > +{ > + unsigned int nr; > + unsigned int step = 1U << vm_area_page_order(v); > > - if (v->flags & VM_UNINITIALIZED) > - return; > - /* Pair with smp_wmb() in clear_vm_uninitialized_flag() */ > - smp_rmb(); > + if (!counters) > + return; > > - memset(counters, 0, nr_node_ids * sizeof(unsigned int)); > + memset(counters, 0, nr_node_ids * sizeof(unsigned int)); > > - for (nr = 0; nr < v->nr_pages; nr += step) > - counters[page_to_nid(v->pages[nr])] += step; > - for_each_node_state(nr, N_HIGH_MEMORY) > - if (counters[nr]) > - seq_printf(m, " N%u=%u", nr, counters[nr]); > - } > + for (nr = 0; nr < v->nr_pages; nr += step) > + counters[page_to_nid(v->pages[nr])] += step; > + for_each_node_state(nr, N_HIGH_MEMORY) > + if (counters[nr]) > + seq_printf(m, " N%u=%u", nr, counters[nr]); > } > > static void show_purge_info(struct seq_file *m) > @@ -4962,8 +4963,11 @@ static int vmalloc_info_show(struct seq_file *m, void *p) > struct vmap_node *vn; > struct vmap_area *va; > struct vm_struct *v; > + unsigned int *counters = NULL; > Setting NULL can be dropped. > int i; > > + counters = kmalloc(nr_node_ids * sizeof(unsigned int), GFP_KERNEL); "if (IS_ENABLED(CONFIG_NUMA))"? If no NUMA, allocating and freeing sounds like without any reason. > + > for (i = 0; i < nr_vmap_nodes; i++) { > vn = &vmap_nodes[i]; > > @@ -4979,6 +4983,11 @@ static int vmalloc_info_show(struct seq_file *m, void *p) > } > > v = va->vm; > + if (v->flags & VM_UNINITIALIZED) > + continue; > + > + /* Pair with smp_wmb() in clear_vm_uninitialized_flag() */ > + smp_rmb(); > > seq_printf(m, "0x%pK-0x%pK %7ld", > v->addr, v->addr + v->size, v->size); > @@ -5013,7 +5022,9 @@ static int vmalloc_info_show(struct seq_file *m, void *p) > if (is_vmalloc_addr(v->pages)) > seq_puts(m, " vpages"); > > - show_numa_info(m, v); > + if (IS_ENABLED(CONFIG_NUMA)) > + show_numa_info(m, v, counters); > + > seq_putc(m, '\n'); > } > spin_unlock(&vn->busy.lock); > @@ -5023,19 +5034,13 @@ static int vmalloc_info_show(struct seq_file *m, void *p) > * As a final step, dump "unpurged" areas. > */ > show_purge_info(m); > + kfree(counters); > Maybe check for NULL before and IS_ENABLED(CONFIG_NUMA)? -- Uladzislau Rezki