From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85986C3ABC0 for ; Thu, 8 May 2025 06:06:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA4836B000A; Thu, 8 May 2025 02:06:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B52106B0082; Thu, 8 May 2025 02:06:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A41D66B0085; Thu, 8 May 2025 02:06:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 87CAD6B000A for ; Thu, 8 May 2025 02:06:44 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6ED8F5C52F for ; Thu, 8 May 2025 06:06:45 +0000 (UTC) X-FDA: 83418706770.08.4C33514 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf04.hostedemail.com (Postfix) with ESMTP id E181140003 for ; Thu, 8 May 2025 06:06:43 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=VV2kA55A; dmarc=none; spf=none (imf04.hostedemail.com: domain of BATV+b29930b5fa9b2b8daadf+7928+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+b29930b5fa9b2b8daadf+7928+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746684403; a=rsa-sha256; cv=none; b=IcFyxQT7r4hLFMoDd0dM9ZgPyhshmluN8wQ2/YwmElKpyUIqQYdrFYQzSc82hJU1PNPZ4z Ic/TJLuWVn7NukVcxThjqY36cIL7QGYm+fAtuAK3EdmX9w3WT/hq5H/dLoeJe2kUOZljRD fIZazAk3SAGPmgcRpjwRLA55Dk+RRR4= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=VV2kA55A; dmarc=none; spf=none (imf04.hostedemail.com: domain of BATV+b29930b5fa9b2b8daadf+7928+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+b29930b5fa9b2b8daadf+7928+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746684403; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=l4SSn4rl9nTY8u1Bl53VbD5p9y903Sc2iTntwD6tkHQ=; b=jKO1OHZvoosr2M8mnomtDV0M8/qhh4qRHko7Jf/LkM/kGYSg1Xigc/mwN9DPOgrQuLMUF7 L5k9tH52k4GEKwaqR95HsIfyazulYLZQ04Ujqv7X6PN/8ktf7u9yo/14Xks6wTuwUMxvSz TX9BTl3WgziXj4TXpVv120XJBF9lzoY= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:In-Reply-To:References; bh=l4SSn4rl9nTY8u1Bl53VbD5p9y903Sc2iTntwD6tkHQ=; b=VV2kA55AUJ08ab0aPvxPBlw4NA hkRmBgCDiFOVzrpKe/2BtVQvgcJRW/G+0IecVyEpSicd5dwihCIQ/mxT7b9KeQOUyxn4V6HVBsuH3 maJN4hEYkrX3DVgtusBGfpmQDR0ZTXNGJNr0bVb/H/GkyjhPb6OKvuxivuspV5RzXEI3hstOvSYmo ZokT4Fc4o4mrpl8EsY/3YHLDLOPCz4v7j5g/1MuebuNyFsNVMuNdn531ZlFx9T5b5Oc4zv+PKlzrT QttCIVhS2v6mQ01dpSOVIOKA/L7abB88z4V+Z3j/grZmjBFlSeTRENfsToghvi7wQ97US+BBTBM2Y d2nwukDQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uCuP4-0000000HQcA-1Bzg; Thu, 08 May 2025 06:06:42 +0000 Date: Wed, 7 May 2025 23:06:42 -0700 From: Christoph Hellwig To: Chris Mason Cc: linux-btrfs@vger.kernel.org, Josef Bacik , David Sterba , linux-mm@kvack.org Subject: What is the point of the wbc->for_kupdate check in btree_writepages Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: E181140003 X-Stat-Signature: c4nxywo8kzqtd97446rsg1437nkrq1dr X-Rspam-User: X-HE-Tag: 1746684403-594739 X-HE-Meta: U2FsdGVkX18j8EXE2X61fVo8ddTbFDKMJ9jSZhzGn+1qp7MiGUdN/SxjNISi/XLc6ufVdxT0Fvv9YF2FtybUaAx8misOh2YSdMHluHDH82tAX4ItKLkBr4fSB4htHFAfieyHezBKqAkLEgTBIZx4efbUO/LrgMv+qc4s5BMu9rFZSVeqewTdfc2tT+bkTzHTOW1e/kQkr1PW23RSP8Unw9dgf1hW+UTrNNoanVsCvXlyU6f1GUkE3hFCJRPfFQ0fl4wbo9St+EqJvNG0CYqiC3W/dQI/jzj1NMOFzkxtB6cLOJJUGOmiL/u/tMKZFOTW3J8wL1zrIPz0bV+IYpcpAb3Jz5IyF6DiapSgZbF3KhdHT9ztANJhvJeK9ujBD/hfhutRtl/nRhX0E3ieVFDx5awTSvjoYknKEYpgYYP33Dz7+NZ7oUipwPl927inFP74NKg1LYj0/ukYKbduYtPwzNKVyAEegLXo9tf2/hw+8o/CVV3+Yzh5RaVLqF3HycvRUlY/JY8pWQtiqtkvcTT1fS2+9YB7G/3VYYkONhpIuhHkmOBIlNh8Zdpb4tbjjSXyYJ4acJflqvUf0rsjIQ3ySXVkMSQ0YwnL/CfwQ1asQQah6n+SeiZFKTpFNEjlk5EfU23PNUx3TrQOtpt9LTaE1v/Jt2YqKPqcHeeTs09kkU6b0FtTz4Xri0+8o+29bL4Vz6lATYGpdtd4WZJ3ZPFdx9cfX5IznvIlr82FMwnQqvDF9iNQyqh4+qpv33ejvBNL4J22pGvGLiPYJ8MSuC2zgILeoKBKZbREr62zL7hKF1x4N9PaHyfC54SCRWQRt4YfgrHnCB8ybogsRAMLkXaF5rau2gvyLhA/fESJbXx8QhZ2OIAvUSFDAsrucZVWQbguWqQColrnGvhryF65e4LL3YoioCTmTnX+q/yZViP3r7RFKqflo8CeXeejE+gBCRUzKzh8CukfBhkZfh3vZ1W K2ghchEG 5kgjTrb41vboUY1hvGWM609xIZKrnylNy3yzOA6qUDXkSM5qIJYmtKFZz9ICjF+SgN/sQ3YxxyMDGXegmsd4phaWdZ/Vo1AWEEDnkc5XI17oTtKx3x1MM4ULptNyhthO3LPFjLomaBmAXlpnPGrWXyqwYklhv801+i9DnODwAoTTDVp5TMGGCsD+j5NRFlaklrde8ZaYLsvgjrZC6SbNv35hMgigvrytUotBH4qmOobI+ZZNKzOlm8zM+4Iy75xZGQRF6SzWI4q4+3whfCHABf2I7/rZpR/Kz1LkLmgVc53WvhY4VBD3EzYyzoaBmk8yPaFTNrU2COyV48420gTAfh92Oe5UzDLg9B+cQrBlvAWplbhP1bkb+tnQzJELjkmghqDzwkqNdEtM5639htne5gYJCnFJo1woy4sKKMdIoiRvbEyq9Z0eg9n0Fhn8zIrIuoaRJNwAIfkHQRt0ebHbrr/YZ3NSQWkZfxxmGs5rxUOlQFchxaW6puphDZJBs83YtwhD6dXqcuZq7Wz4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Chris, you added a wbc->for_kupdate check to btree_writepages that skips the write in this case in commit 448d640b668d ("Btrfs: Fine tune the btree writeback exclusion some more") which is not associated without any information but the subject line. Do you by any chance remember why it was doing that just for kupdate and not any other background writeback? I'm asking because it is one of only two checks for this in file system code, and the other one in nfs at least checks for all background writeback and thus makes some sense to me.