From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6923EC3ABBE for ; Thu, 8 May 2025 05:39:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5D6F26B000A; Thu, 8 May 2025 01:39:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 55D1F6B0082; Thu, 8 May 2025 01:39:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3FCE26B0085; Thu, 8 May 2025 01:39:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1EFA16B000A for ; Thu, 8 May 2025 01:39:01 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id EF17FBB4C5 for ; Thu, 8 May 2025 05:39:00 +0000 (UTC) X-FDA: 83418636840.14.E67927D Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by imf01.hostedemail.com (Postfix) with ESMTP id 05A8340005 for ; Thu, 8 May 2025 05:38:58 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=fUwMIbnI; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf01.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.221.45 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746682739; a=rsa-sha256; cv=none; b=GyG4BwJ74w14IApCuI3RJX8CnfWWfGFln99qP6jSFm+lLC8yQVs2oDZB81qLusbL6Xm53I r0305A3H8185xhIVLPczzKlD0GC79GwqQ2tIrtMCa2BEnbelj+B3QbQzKbvmNY0MBcRCYb N6siBTVph2yvIeaRfrWlB8q98QAeAsU= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=fUwMIbnI; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf01.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.221.45 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746682739; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=U3k4PEhU6worlCKck2U3ds/0NKF9gmmTtGy9MuzRu6o=; b=XMquboHUjYje5149OYp2utPfiqjYC8dIp16dbt5CprZEsaTCEcyE7BKSBHXEyRqor9p85y lr71atExl0I38BhTNo11t0eFN7Y3gvjILvinZwQj4NJnsG6bA7hpf5UIsOTI4BRSfJXj1m vFV8xaMKN4Po+35t05NWZnhJOmWrYnU= Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-39c1ef4ae3aso474132f8f.1 for ; Wed, 07 May 2025 22:38:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746682737; x=1747287537; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=U3k4PEhU6worlCKck2U3ds/0NKF9gmmTtGy9MuzRu6o=; b=fUwMIbnIHkuJVC5rQrp/OY54M59qmcsqYbobYkHnUKY5Rfa0JfPDJbjvv7KzAbdHAE Z8l+mtEooZhCnjoF/RatdjaDUIQUiY3BrDibRZhFXfp+YgOIaN7B1vnL/E1jkgqnvAQk DufAEf2itdVCyni71ZCgwUgwyAv40KTXCz2jSXGQqXBNXXvqRK1QHJsjGz+K3ZPJanjT qp/d2Jf6whOZiZYqifMLdxq6gX5GF8GA23R9hu/s2OOTw1JVEV1LLAd5xZQ+TpHBtzqS 9a5o5oQ8USVBO4AprFydS7L5X36jzvBXd9jIHjtT0/66sbpRsuAexPp1MmyIwwCevcUZ +X6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746682737; x=1747287537; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=U3k4PEhU6worlCKck2U3ds/0NKF9gmmTtGy9MuzRu6o=; b=ly7GjxxocyJcKpK9d67BFr6RGMJQ5oKMqYDmdISRZFXNXVy52HRGPwQTa/XhIjZfg3 waXCV+X4eL4hojQ5uNxSNUC9S7lXvtsspJkdFSp0Esz2U8QALhQpi4nDGN/wa6Vufmon jlHdg7oSWaG9rG4VY8ngHLGBC2+QwiMW0teCnc7ievwQB52Z0BxRI1WJOQ4+AJftB4tj 4LzX9L8pllsZYLP73IMqATif4lkgDVBTT5SMncE2Asjxfpr9wZ0XcQc02EqozZXkR7Hz lAVrY3h9H7071nJ6f6VFfGPzVYJj4xFIAvUoGiEdwu3ByLL1sQbZOExmJ9YWu4QXEneB cr2g== X-Forwarded-Encrypted: i=1; AJvYcCXrBhEMjKM0Aea+hWbZk+RWvETT+bFaMEP3LtswiUEuYUlL2wHcssLxyZeOKKrbOnI9DObvfCJrig==@kvack.org X-Gm-Message-State: AOJu0YyF/XOSn8gf0IVEeOvk8Bwc8iNT1HkWEl43y83LN+fii87DsYPc SejxDMmJytkp1KKz4c9VYQG6KDSDBzwW2vrFJaSzxytyFmjaRUgtgEf8fnxKAXI= X-Gm-Gg: ASbGncuekKe1aDqztUT0BcaL6MO1049IYdYbh+mg2zaQrAuloGrnfi0TXoD1ukB15FH 7tEU9Feqag3c/g/FK56dhjzJtQXMPi0XBnny5hP0qdFneZC7jqeiQO4orxUdnNoxwQM7XmghYoq u3+8ZkOugAaCVGPYUJm/+im7kYhtH7TRC/KZJWj0A4XERhjLjKEQNgR6Uw+fHaGWYIbLxGeTVYv A+01WtZ4XPwus7DPO6qnnRYKdI582ehX5qolkZUzuLw0hZWD1CeFlRGkZsE+ep9bL8FYb1uZKK/ c+CuT7zKf8hHO1eZ79nYoHNMyt/bTdwAPD44Sgi+vJYGfA== X-Google-Smtp-Source: AGHT+IF7VpQhE++cMJ/0vycInQosYNQwdOLJveREj7gdb3HDRxdShvggZtkV4ZOpk2gw61u1hDiO5Q== X-Received: by 2002:a05:6000:2dc4:b0:39f:ec:d4d with SMTP id ffacd0b85a97d-3a0b990e465mr1470004f8f.12.1746682737319; Wed, 07 May 2025 22:38:57 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3a099b0ff8esm19098105f8f.79.2025.05.07.22.38.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 May 2025 22:38:56 -0700 (PDT) Date: Thu, 8 May 2025 08:38:53 +0300 From: Dan Carpenter To: Shivank Garg Cc: oe-kbuild@lists.linux.dev, lkp@intel.com, oe-kbuild-all@lists.linux.dev, Andrew Morton , Linux Memory Management List Subject: Re: [linux-next:master 7893/8235] fs/jfs/jfs_metapage.c:245 __metapage_migrate_folio() error: we previously assumed 'mp' could be null (see line 235) Message-ID: References: <202505071850.XaOkcCkX-lkp@intel.com> <21037c25-b85c-48fa-bdac-27cb3be2ccdb@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <21037c25-b85c-48fa-bdac-27cb3be2ccdb@amd.com> X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 05A8340005 X-Stat-Signature: jqf98o9riskg3shtzi6azf4fss688xfh X-Rspam-User: X-HE-Tag: 1746682738-710042 X-HE-Meta: U2FsdGVkX180H8JPZAOvmW3hO2F3YBbyXEL5aSNYxcwUXd+uqByVDhftcktEBdLeawvlFd9E9vYW8vc3FIP2YNIxFvaZyeq7TEWW4E5vNoepYp+jyYKM5cFYH0rTOn5FNkiFa/q96WZbxrpvj25oNRpXaITgt/OHG9iKSqaBkOCYen5vG0af0ASge6SzygWH9eEfJ3DjQXHVr81pkPzsCsvCXAgNfeMOuHlsk7TAmdAs2lLsyLMw4g5xUSDTnYmWsPKRVFFTzdBDLzTgV5oUEo3/RVtDH3qqrs4g6eOFYMiE7BpTeCgzeEM+k/tGszoKeE+/6Wqe84TPUL/2owgsNvpyqUDQ+KwtggFDqD0GkyjdNn0zU+EQMb0Q/mm75WXvEB2szxaLgArmVyMBQvAbpkyn2wrdezlMlCV6wdmf/Q2vdVItTMSpgiBCgRwE3WgU5s0bbtW1cLu+152gvZMg8uSKBWwQLZylxOLhDRm6+LzeKNQJ4UT402YDe6/Z5ag6hgieM0kWIw4/POBavHpLkz724lWgWqDLfcHUdWHM9XgoVxwIxiULK9oLn5+1z564ActzWbW5E8iAXArbBTBEIXsEn3lrYkAaKgl3WEJqA5yRTGUNTs4AL0wL4kCaOJb290BXgsv4EVvDY+yjoltSGKUYfA15IA7y0MlldvSVHn5eAcPYKi6eUzapyUGrGFtYmDTwrEAruJWbvgg4nF4yfjKtrre++SPMrgharj7L3/5gxgbzJS4084U8n8baKH0lNbi9oNwBThHQz5so1bTly+rYCBOTwGss+lbHwNDI0/D4JJ1Y47VinXWxlB41PV4ir70LRj6sYdn1uM0uREge8mx6N60nBB7odGYu9ISYwdozmMVYwBIpD/in5/IPPg0+OnwG1rFm0D6tZaCG4PmyaNjacEuULsGHoxlkyZI7O26TFP4xbWCeuqFaeQpljJfc2lL6WZJKxNv+VMDY9yn WuA55rrC ZclI0+7AJhQOc5MCHV57xabUlr/kcMk6EdvFRHQLx/e+OSK7ymNmCGXXiMk4UpTXPNRaFjrlO16SoW4042UjrxDmOAoetaM4cjWSy6uipKDgWHWXIs5DHiQs5PTLSayianhoaWbv6XbhZxDivbMCepctTGzzWtU4mXRmYMd1luEbdfsQ8vsip1PwuY2SAsNsE9Vn3sFzIXk+PA99NVFL8MD2vG4xlV/wtPuYhZMkGOfmHSoL4tSssT4veEbA/SOGGpvyhk42bch2yLBQpKtEhIRBNVQQy96JagxpVN+KAX9N/CptLAUVYXYHFCnW00NyRccFN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 07, 2025 at 05:19:52PM +0530, Shivank Garg wrote: > > Hi Dan, > > This is a false positive. > > In metapage_migrate_folio(), it checks if (!src->private) and only calls > __metapage_migrate_folio() if src->private is non-NULL > > static int metapage_migrate_folio(struct address_space *mapping, struct folio *dst, > struct folio *src, enum migrate_mode mode) > { > ... > if (!src->private) > return filemap_migrate_folio(mapping, dst, src, mode); > ... > ... > return __metapage_migrate_folio(mapping, dst, src, mode); > } > > Then __metapage_migrate_folio() calls mp = folio_to_mp(src, 0), which returns src->private. > Which should not be NULL as previously checked. > > I think we can skip the mp != NULL check from > > 39ed4d1a0e03ce Shivank Garg 2025-04-30 @235 if (mp && metapage_locked(mp)) > It seem redundant here. Yep. Just delete the unnecessary NULL check. I only consider these a false positive if the NULL check is required but it doesn't lead to a crash. For example, there could be another condition which is equivalent to checking for NULL. if (p) p->foo = 100; ... if (!p_valid(p)) return; p->foo = 99; In this code, if you have the cross function database then Smatch doesn't print a warning because the NULL check is not required. But the cross function database is way too slow to use in the kbuild-bot. regards, dan carpenter