From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4BA2C3ABBE for ; Thu, 8 May 2025 09:51:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 846F96B0085; Thu, 8 May 2025 05:51:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F7826B0088; Thu, 8 May 2025 05:51:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C1DF6B0089; Thu, 8 May 2025 05:51:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4C1D56B0085 for ; Thu, 8 May 2025 05:51:04 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D19821CFC91 for ; Thu, 8 May 2025 09:51:04 +0000 (UTC) X-FDA: 83419272048.27.A21186B Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) by imf05.hostedemail.com (Postfix) with ESMTP id 0FBC010000E for ; Thu, 8 May 2025 09:51:02 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=3sRgUyKu; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of 3hX4caAkKCDwYjgacpwfjemmejc.amkjglsv-kkitYai.mpe@flex--aliceryhl.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3hX4caAkKCDwYjgacpwfjemmejc.amkjglsv-kkitYai.mpe@flex--aliceryhl.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746697863; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sRYORIdHbCu+v7v6CRkN0ZTKr0/OiODNbHOIpEPqKvI=; b=hhf1Ut4xSyw+xSxWuBvdsLJUbCWYnugDwWNA3IQpZ49F1ob8Mq1r7D7feQqhfYLTDvbLuY 0X/0sThk2cD/VlMFwjlN9HmEoAFXKQqetA/YnFlxp5XSLMoXVtFVlfujnjsM9GTsVvnEf8 h0yUIOhtkx1+0vjdnIY8XYPhLM1W0mM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746697863; a=rsa-sha256; cv=none; b=dmmulWupgrOZwffpIDwSD7XvktJwlcCt1lkjOBU0MtTMJLjVFmFIuRp8MNX7DpVs31hBER sGH51zntq3FPP8glgDqzFWSl6/fFvm44ovLazeIOFZn388rGi8Agu7smGoiyr7zGk/GNF+ M4y3umtYBc16aZZzIfl2Xpfj0QREB3g= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=3sRgUyKu; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of 3hX4caAkKCDwYjgacpwfjemmejc.amkjglsv-kkitYai.mpe@flex--aliceryhl.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3hX4caAkKCDwYjgacpwfjemmejc.amkjglsv-kkitYai.mpe@flex--aliceryhl.bounces.google.com Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-43cf3168b87so3517535e9.2 for ; Thu, 08 May 2025 02:51:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1746697861; x=1747302661; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=sRYORIdHbCu+v7v6CRkN0ZTKr0/OiODNbHOIpEPqKvI=; b=3sRgUyKuMNltULRzv5ZqNAKFiBWa6QX5AqDw6nBWhRXFQrMvzYPLreCR+FAwFWaTz6 ftH0aFU8r0I1I4w6eCgy6xzyMbG+cWR7laHSfOVaogF08YOu9Nzc3/GE6ImC/4di00rH Z67r3msTd99xZFHWfbWEj/2Ymz4VKGfkZ+i1hCpdvTG39KYCixCDECegWA/1SPszqKIr OGt1BUal41PEDqjsE0AXDdslxdccrKXqpxSGrh3QojhPIsLFaJ8yTdHhVJZa0ptaT9za +mF7ZM+5NDtMabFNvBFniLtiDJc/niinmhY4o1Oeg98/+MILh8A7MgVUnOwLZnaPxCUh 9tUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746697861; x=1747302661; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sRYORIdHbCu+v7v6CRkN0ZTKr0/OiODNbHOIpEPqKvI=; b=FPI8ivog2EIi3haBir6ARJkY/WaXVIHt3qCO2Wl8ptPOo2aYxufOTZUvYfAWErK9rI UfzDQ/dB/yur6X9HilF1rwDizZ7p9ZukOaYtOnp7fpvOYRSKUHKz0Oqhz85yCwAWhN0f 8oGDeQbqQOy1dK3/ZfpCWGCxkHCgtvtB2P/+Hjz6o4mWk03dNbUI+Lrpyi3XWG12vLxA DY6xdispk1Pjf/JnEGtUVP3UehJug03mFFbu46G3jhAawFv1LjW5KgJqNNsYgA6YJRV7 Jq/2DC4GFyWpQexHGv4FWcyD8OEA57mrv0nC81JxrRbQJZRYXKhUymlRCnhC1ebxuYfE ZA1Q== X-Forwarded-Encrypted: i=1; AJvYcCX4IxnrP2RMlP/XHxqz1T3kqSuRcGffklgvImxpJ1UaZBjG9TeuTZ1i6aIK/JHe2+vB2bz/kd8aSA==@kvack.org X-Gm-Message-State: AOJu0YwiNmz48iKCwyPkWEFjwfvi8b6dkhmA7AWzrmkt3w+O9H53+NHM 1v1Rm6Kb6klwsqBvCsM9ERYpd4GyRxiK5yBlacxjQ9If3qg5HaaP6ZyBf1tQE+ZolvfZVEFwtBK L1dEWw+bB8z8oeA== X-Google-Smtp-Source: AGHT+IHLXsWRDgG3OD/xhwNN+TKEjftVuGlDJ1UzIgWhHqG8GP2ey/7z74RyCklt2SklhOgBNWfIa0zzBtlpALk= X-Received: from wmbhh5.prod.google.com ([2002:a05:600c:5305:b0:43d:55a1:bffc]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:698e:b0:43c:e478:889 with SMTP id 5b1f17b1804b1-441d448c8a4mr66281965e9.0.1746697861579; Thu, 08 May 2025 02:51:01 -0700 (PDT) Date: Thu, 8 May 2025 09:50:59 +0000 In-Reply-To: Mime-Version: 1.0 References: <20250408-vma-v16-0-d8b446e885d9@google.com> <20250408-vma-v16-8-d8b446e885d9@google.com> Message-ID: Subject: Re: [PATCH v16 8/9] task: rust: rework how current is accessed From: Alice Ryhl To: Boqun Feng Cc: Miguel Ojeda , Matthew Wilcox , Lorenzo Stoakes , Vlastimil Babka , John Hubbard , "Liam R. Howlett" , Andrew Morton , Greg Kroah-Hartman , Arnd Bergmann , Jann Horn , Suren Baghdasaryan , Alex Gaynor , Gary Guo , "=?utf-8?B?QmrDtnJu?= Roy Baron" , Benno Lossin , Andreas Hindborg , Trevor Gross , linux-kernel@vger.kernel.org, linux-mm@kvack.org, rust-for-linux@vger.kernel.org Content-Type: text/plain; charset="utf-8" X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 0FBC010000E X-Rspam-User: X-Stat-Signature: nugbx4kib4miwgs34yorpo9b6siyjk3k X-HE-Tag: 1746697862-113120 X-HE-Meta: U2FsdGVkX1+n2Ag+PDSDVjB9rnPOy0lxavqJxqq7Mpk790stIo5XoR5dxAogmj6ovrwUEBkihbGKCoyyL3NNaGyG1iXbiEOmcaB8yDTylIwNS3TVtI8cFklYxAVr8qs+ND1JXRNY0clbyH8wD5GBiFAu1h4tMQ6WVTr1+q8EYd3fC9bxJiNJxbItc0iBDbc5cRXZh683apmPKbONHVIIgf0JoBvh9AQ5Vkw1kNh6vC+npoQMQ6s3rd+2Rw6ZlR1TQV1RuexgAx7Tw6DpNw+KD/fCLmZSffh3LUGwuYjQHWU/QQLK/WpzAQ8XU60NGRFWH+mwtQ+Cr2D5VWpXVWpnJtaSnIJMl4DQDs4UI7IkV0W6H67pAMeByoGO3v7LULApbPv8XPEy+MjmlVxn+wSNqbx0MkJss0tCo2wO/YJe14VoCAQIkWVhgOS1+FlLqOZR+JGIjoSR/ZOur8RSyC1oTA5SWTQ1NxLEd6nAQ7ddeOvMgDpCskNb9TbACEoff9BHSyYIc56tTAe6VqtyANgXt8KKDc00GTQWILr+DUPVgja2AWQ4E/Ds7JtkDEuVSsPnx1vKWRbC4rndfw4CohdnTuw/tV272rnrSOvpLz+0c8tlCT0aPc9Q4aPWCrc9D7fNtJSQiKjvOMaNjCQ46POrQ3g8y3F+ng5WHnPQ4HojvqBMi4RwceNaTbRJGrDcWijs8TENupWmEwi8E0N+gFB3Q5MgJScIR51c733ZHG6loedWPM2OaBFpc/UOoSxQck9LmkrdSSn5u5qdurT+XVSrM2ZipY1TCGMGPc6F/c81JdmUFotEx8RnMOkZk9QJhsn0GDEZg0PzPy3fDueDhbgWwmFxBx2P8o2+QASD0CaQVMZRmvLWP9UplTAmHHv/mgLjx3VFadMbElIWkVcr0hEu6QsXQtNloXs185OMjN8hxwjOd0PeVRS3q6xs72rUxQgmtRoS8MM5GTlMT8rm/1r ceqYPAr9 2QQGLBaePswP4OlGaZlbtKGdJdP7PfRwIGqyblFGz/mlT8BxG+eOVtDDN0oyAR154ndAi0UNN+RLV+gNHzedRv+CT+VqHtz5lRnUREhVLDQ4vkTykZD5dXRv5LTBG7luc6EE2M8hnOoeKc0gEq9Fcu5AxT4PJK8upLfZUvJPkjqOSOpk/AqomkOFimWezRUFoXC2CeXUiOKkvZMVf1wQ8jtJ3PyRuh8fFuyHrLhIrepmSmc4E8mwyeFxTwIAGd2ATh8FRf6Z8KbPNq2LUhXbyGpsXCMkagLSZArqbS+o8GLWPpjCQHs4KGoBUxIC4TdIh3VHrcDDJ+Zgq6ZGr1yYFyfr4jeCgrmqqoMj+ysNKM2p+mLEJXS2td2hwFk7Nr1sGPZDPSHc/CF/ODMM3sOZWkEaTeq5/dZ8qZ/dUmHbTG3nG19Vs5zVaQO2UwTp+X/Q1IUjMDaZ/ksDl+r+gvDP4NsVX8NM9Twq6pcwTn4jNdQTqoAXjO+ymludpIGi1UKMOql/a6uCRDt97Q+15dzxDFsoycxfgQ5vXvyEZDH7GdK17FyrFx5SpLP9A74/yjQuGxkdsy4UG4mxxkPbGvXbSCEQKbOqjPh2mKmxHkr37W2frx66Kli7y6Bob3GP2jXPd9dNJN3jqUYsGyqyEkpY/9pUJOxY+gjHRPbKDA1aX1o6hCw1PAvSLhxCRMjrZP2/CqaBqWN1GjOeUDKG+DpxbF2voGg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 07, 2025 at 09:55:29AM -0700, Boqun Feng wrote: > On Wed, May 07, 2025 at 09:46:23AM -0700, Boqun Feng wrote: > > On Wed, May 07, 2025 at 09:06:01AM -0700, Boqun Feng wrote: > > > Due to this: > > > > > > https://lore.kernel.org/oe-kbuild-all/202505072116.eSYC8igT-lkp@intel.com/ > > > > > > , I think we should move this impl block into rust/kernel/mm.rs for now, > > > i.e. (in rust/kernel/mm.rs) > > > > > > impl crate::task::CurrentTask { > > > pub fn mm(&self) -> Option<&MmWithUser> { ... } > > > } > > > > > > Thoughts? > > > > > > > Hmm.. this alone won't be enough, because miscdevice also uses mm. Maybe > > you could most of mm defined even when CONFIG_MMU=n but keep > > MmWithUserAsync only available when CONFIG_MMU=y? > > > > Something like this, probably? But your choice ;-) Make CONFIG_RUST > select CONFIG_MMU is fine but the question is who is going to unselect > that at when? Please see: https://lore.kernel.org/r/20250508083540.3832900-1-aliceryhl@google.com Alice