From: Alice Ryhl <aliceryhl@google.com>
To: Boqun Feng <boqun.feng@gmail.com>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Matthew Wilcox" <willy@infradead.org>,
"Lorenzo Stoakes" <lorenzo.stoakes@oracle.com>,
"Vlastimil Babka" <vbabka@suse.cz>,
"John Hubbard" <jhubbard@nvidia.com>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Arnd Bergmann" <arnd@arndb.de>, "Jann Horn" <jannh@google.com>,
"Suren Baghdasaryan" <surenb@google.com>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
rust-for-linux@vger.kernel.org
Subject: Re: [PATCH v16 8/9] task: rust: rework how current is accessed
Date: Thu, 8 May 2025 09:50:59 +0000 [thread overview]
Message-ID: <aBx-g4qapwBc0K8C@google.com> (raw)
In-Reply-To: <aBuQgY4wMv1CsVdo@Mac.home>
On Wed, May 07, 2025 at 09:55:29AM -0700, Boqun Feng wrote:
> On Wed, May 07, 2025 at 09:46:23AM -0700, Boqun Feng wrote:
> > On Wed, May 07, 2025 at 09:06:01AM -0700, Boqun Feng wrote:
> > > Due to this:
> > >
> > > https://lore.kernel.org/oe-kbuild-all/202505072116.eSYC8igT-lkp@intel.com/
> > >
> > > , I think we should move this impl block into rust/kernel/mm.rs for now,
> > > i.e. (in rust/kernel/mm.rs)
> > >
> > > impl crate::task::CurrentTask {
> > > pub fn mm(&self) -> Option<&MmWithUser> { ... }
> > > }
> > >
> > > Thoughts?
> > >
> >
> > Hmm.. this alone won't be enough, because miscdevice also uses mm. Maybe
> > you could most of mm defined even when CONFIG_MMU=n but keep
> > MmWithUserAsync only available when CONFIG_MMU=y?
> >
>
> Something like this, probably? But your choice ;-) Make CONFIG_RUST
> select CONFIG_MMU is fine but the question is who is going to unselect
> that at when?
Please see:
https://lore.kernel.org/r/20250508083540.3832900-1-aliceryhl@google.com
Alice
next prev parent reply other threads:[~2025-05-08 9:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 9:22 [PATCH v16 0/9] Rust support for mm_struct, vm_area_struct, and mmap Alice Ryhl
2025-04-08 9:22 ` [PATCH v16 1/9] mm: rust: add abstraction for struct mm_struct Alice Ryhl
2025-04-08 9:22 ` [PATCH v16 2/9] mm: rust: add vm_area_struct methods that require read access Alice Ryhl
2025-04-08 9:22 ` [PATCH v16 3/9] mm: rust: add vm_insert_page Alice Ryhl
2025-04-08 9:22 ` [PATCH v16 4/9] mm: rust: add lock_vma_under_rcu Alice Ryhl
2025-04-08 9:22 ` [PATCH v16 5/9] mm: rust: add mmput_async support Alice Ryhl
2025-04-08 9:22 ` [PATCH v16 6/9] mm: rust: add VmaNew for f_ops->mmap() Alice Ryhl
2025-04-08 9:22 ` [PATCH v16 7/9] rust: miscdevice: add mmap support Alice Ryhl
2025-04-08 9:22 ` [PATCH v16 8/9] task: rust: rework how current is accessed Alice Ryhl
2025-05-07 16:06 ` Boqun Feng
2025-05-07 16:46 ` Boqun Feng
2025-05-07 16:55 ` Boqun Feng
2025-05-08 9:50 ` Alice Ryhl [this message]
2025-05-08 20:25 ` John Hubbard
2025-04-08 9:22 ` [PATCH v16 9/9] mm: rust: add MEMORY MANAGEMENT [RUST] Alice Ryhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBx-g4qapwBc0K8C@google.com \
--to=aliceryhl@google.com \
--cc=Liam.Howlett@oracle.com \
--cc=a.hindborg@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alex.gaynor@gmail.com \
--cc=arnd@arndb.de \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=jannh@google.com \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=surenb@google.com \
--cc=tmgross@umich.edu \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox