From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D6D1C3ABC0 for ; Wed, 7 May 2025 20:50:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9D14F6B009F; Wed, 7 May 2025 16:50:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 97C0F6B00A0; Wed, 7 May 2025 16:50:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 86BB96B00A1; Wed, 7 May 2025 16:50:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 653136B009F for ; Wed, 7 May 2025 16:50:32 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 02F8D121210 for ; Wed, 7 May 2025 20:50:32 +0000 (UTC) X-FDA: 83417305146.10.E795867 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf03.hostedemail.com (Postfix) with ESMTP id 8EC9620003 for ; Wed, 7 May 2025 20:50:28 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=PYq1NO7q; dmarc=none; spf=none (imf03.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746651031; a=rsa-sha256; cv=none; b=ZoqYpecVT7TRjhdWjPmJOiRQSr71dRjuYd2Q9IHWTTafNpyT93++qf0bNrGGw0O+5ft4vd HN2GC1QHJAhYu3emxc5haha7xechCWUEckfAKpb0rlwHWWwxEAIxNfBpgVvwQq48SM+XI9 bcPP1u0Ds7KT6dlZREDPK6aSPDFAovg= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=PYq1NO7q; dmarc=none; spf=none (imf03.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746651031; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qYOdPumYEeMYOudyZhzEcRSSXRPpswcmBXCu2daOo0g=; b=jPAi0LAe12SvpoTl0SqGhc4svDA0Euwo7r6rhtFjCB+jZmRoZcF1rY4kmwriRZ7qPuEPbf YyyhpZytUPElavc0Gwh/vrmpuObT+iVx71VcEtmZLzhsHExtJzS6Pya59oc5sXTc9TGEre W5NQYF7zV8zLTklUX5QPKVDmcnN1HqU= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=qYOdPumYEeMYOudyZhzEcRSSXRPpswcmBXCu2daOo0g=; b=PYq1NO7qM/+N8y7XpErUKcuvNm /7QheS/dZnPJx9cSFwG1jl37HdRzr4DXTF40HYPeBOkRFF+/tCvDfBjjQiIyz258wJM6QUBj9JqjQ zQFLpWFf903vn6s5PV0N80YBSIMqqF7rx7zpfnxpUrZCZX3evDgRPIGBaFtNCDoXjTWu/exKv9r8N 4RO35cOuo+dFLvGKwmDg1bJf64Wdipj+50/bFwZ0pgiOK9SbupbLXjbh6jQX7XGliNchrFVRZuerA w+PRsgNdjx+0ok5Ft6A/RmjG6lVbZjGqEkzqjB1lKxC5ynJivlWEyaZrDbaexaXg3VbS31Ixz6JbA IqGqPshw==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uCliB-0000000EHqP-0mzI; Wed, 07 May 2025 20:49:51 +0000 Date: Wed, 7 May 2025 21:49:50 +0100 From: Matthew Wilcox To: Andrew Morton Cc: WangYuli , linux-mm@kvack.org, linux-kernel@vger.kernel.org, yuzhao@google.com, stevensd@chromium.org, kaleshsingh@google.com, zhanjun@uniontech.com, niecheng1@uniontech.com, guanwentao@uniontech.com Subject: Re: [PATCH] mm: vmscan: Avoid signedness error for GCC 5.4 Message-ID: References: <85050791B887DC13+20250506160238.799984-1-wangyuli@uniontech.com> <20250506162438.91fffc7ef924d9653ed0f503@linux-foundation.org> <74D5BC8AD7E5511A+13242b55-13e5-463a-9422-f863d58b6af6@uniontech.com> <20250507110701.c2c135d3f4ed594b914da41b@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250507110701.c2c135d3f4ed594b914da41b@linux-foundation.org> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 8EC9620003 X-Stat-Signature: e74f4z6dwo1qr1jnfhm7smf3uborp983 X-HE-Tag: 1746651028-582027 X-HE-Meta: U2FsdGVkX1/tlS5TNbKP0twsf4OuYAZPYyQfLEZQaBfExqd49OpQZQn1swqm+UJJjv5f5kwc6Jo2a0gA9uviKNn6l3oE4KKPAZTmZfdPMUVvraSH+DfxTQ5kB5JF16kjpoz+Mnkndr9pvoHE/Azuyniln4lnMXi3qcVUxIJk6Mp4ImAeMCB2lzmGQljAM+eoAmN/6ngQO6j3bXtNB4ttY0zC5HgvCfymu2G7SHveSXaXmRhNGwXeO6JkeTM4YBC8pc7ccCxTMZxdfLhp02r+CMfcBVo4EwJXB8grS/6twIbvPgA0B90zHouss9lYLFm2vCCr61IZBc0MqdZIJMkBSuUIhpCBhWjADVJslp2sDQJ5xnhoIOWllMCvys7DWU44a5Ga59lxLPgTJjcwR4EoLBIYWGVnwuOCn0jblBswR6bpQT/xd9uIaYuN1ngWudJ7RmzcmevktpODz4K8wDvdD+yFemY15m9cjJWD1MNyGyW38Hml0RSxeDkrEwNAhy33canSyCAwh4B41un/yVOB0LisE7PSPGa5DOghDFTMiV47c6Y8DvWX+FfEOlDnaUcoqc9IAxdDmP2sUhOf1ah/CH1/j0BVvn/1NUn3NbyXphVDF/qHddT+xehW/HCn10VAyFxtp06Ri49dKREUwQTr6IdipPkoghDJMrJLIwZKlmCxmhV6S16fab9pXnV7hTCK3/+lFqX6+SCh85qYA249qk4Vux8qPS8wxXKJ8sjYcBqvD+Hu42mmy+V8QRbTvV+al1uJBZucsrke/n0/IyNbulgVIZW1OdxbVqJL0ahNNc1ojc7qHjS2di98kSHJosKamny7bCHY+HVOCOxERGWgfL3jiIiqUDKBjXSiMjDKKbJHl9aLf1YwKM8U0FKr2lzF98xwqZ6/IIgEETTKU2Vhsis+pYoNAyZ1q3lw76Aq8K4xHPVEJuDGhRc7t71S/YZTYRYd+SVBokcVDkkJ+5D FZXucGwT adat7hhnmTwd/lrS9TOHSBKhcMIjfoBGqQIJ96yBwQVSO5KYUfiww/5fgEU5b4ayrlS280JOnHkqSFkLGc6eipSNo7eY7J71SLqrdKJqRlf/N8ITAq+5ykCFBTYidn7WgQOHxm9jbk5KLREzyTYnne2NY7WG5uc/V7leTF3SrJRBuI2ouXATJdnjpHrkwWotM9rCaTzuCamMLeO+rNnE3IgL7vdEDrPgfdz1aNehO6Md4lno= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 07, 2025 at 11:07:01AM -0700, Andrew Morton wrote: > `int' is a curse. Yes, we do this very frequently - we unthinkingly > use a signed type for a naturally unsigned concept. Ths signed type > spreads and spreads and the incorrect signage causes (small) problems > in various places. By then it's a big mess trying to switch to an > unsigned type. > > Oh well, we just battle on. We should at least be more vigilant about > this when adding new things. > > > hp2:/usr/src/25> grep "int nid" mm/*.c | wc -l > 316 $ git grep def.*NUMA_NO_NODE include include/linux/nodemask_types.h:#define NUMA_NO_NODE (-1) I bet if you change all of those to unsigned, you'll get a non-functional kernel. C is awful, we need to dump it.