From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38CFEC3ABC0 for ; Wed, 7 May 2025 12:54:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A405E6B0085; Wed, 7 May 2025 08:54:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A16826B0089; Wed, 7 May 2025 08:54:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8DE3E6B008A; Wed, 7 May 2025 08:54:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 70A246B0085 for ; Wed, 7 May 2025 08:54:42 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2C02F804AE for ; Wed, 7 May 2025 12:54:42 +0000 (UTC) X-FDA: 83416106004.24.BCEE6D7 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) by imf15.hostedemail.com (Postfix) with ESMTP id 27C11A000D for ; Wed, 7 May 2025 12:54:39 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=PHzv0A1o; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf15.hostedemail.com: domain of pmladek@suse.com designates 209.85.208.41 as permitted sender) smtp.mailfrom=pmladek@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746622480; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ypa3PBqDtPswGp9XxxvAriQxh6M+XVug4d/DpMvuJqc=; b=EojyT7xU5mHHV7BckyzW8SwwtHyTmX1EXthnIvOXqVeqMJyRNlhMHE0Dn62KCyVgHhKx7s EzszIFPcoBo766cps4hvaaaTzoMIMG6xTWuatRvddhz0AIVqUYXeJkgUlCfpRLsB7ajMI+ hLlTc0br2uOeGWisI3AnDJb9QPfU4Og= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=PHzv0A1o; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf15.hostedemail.com: domain of pmladek@suse.com designates 209.85.208.41 as permitted sender) smtp.mailfrom=pmladek@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746622480; a=rsa-sha256; cv=none; b=nzt0n319xvm9gaxKbpK6nbZSFGxFGxKRqzDbHYD9F1hHSlOE9zy3zok651QnAam1vutSUJ llCZTUi7+gpvyxcSQd9vMv9Lydew3QoDsblxqNF0LEOZULBR/7YMgfoHHSgGca6h4WRa8d uPVJJRpR/3/1Q8NHRjqoYvwjqN3mozY= Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-5fbf29d0ff1so962932a12.0 for ; Wed, 07 May 2025 05:54:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1746622478; x=1747227278; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Ypa3PBqDtPswGp9XxxvAriQxh6M+XVug4d/DpMvuJqc=; b=PHzv0A1oyRknH+9eEJ/Kxpy0CuxYQPj3KhniJK3BJMPTt9l6Jkr8AIsvPcggBOaEhx DBnUQQ1C6StYQAapzZrfs9FSdGSAiDj0g5v5XweAtZ3iOLuldtvcetS/pHprch4lFdAv RKciT31uF4T3pFyPdzGRR6Ig3c9PWoztvc8ucijCepvQrTO7J9uO+ISfFxjzBld/Mzad T1OwcrpY65GQniz1++/PQKhydtiJAzjpTAZRTSyMtgGAoT2yLQeydQYRmy4GEZgnBQdk HXkG6Ee0dooD6l4WQKJFsbCDngwJtgrXncaLAIQ9R3ML72EYyq2foNEpFHxqB2fOFz3t aKgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746622478; x=1747227278; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ypa3PBqDtPswGp9XxxvAriQxh6M+XVug4d/DpMvuJqc=; b=k5XwYxesZBuolP9LMgJhUF/DSdbtGVoLWcu4QD89d8xnfJHhiA4g5w9+i+yX4ruLus 9SL91wGFXFQLIpsHiI9zvDFCEX0k7agqI1D6FJfniePsGAqweK7fUq2KZPSqnLFbJT4D nMBn67ez0nMrek2l7/g47UoubH4A6s4SMujZVSMwIBVYRwVUNgtGB2ODBDN7OHuRH7Ic 3UQuFy7IdR+VZufaXPXA6neJHK3HE89D0Vo8eCDREEoQ+ODwWModUYCZiiAoPSmUVOzI qkhCy4oyeiX4IMDkiZWN722ZeJx72cfn2MlpDkHHQQdEP1ZfRsTEw5izAnefKmN0EeKM +iiw== X-Forwarded-Encrypted: i=1; AJvYcCVsm3m3eI5PlNChok724o+BUV9oaRKgOPQRVCB6jfu5Hq8OqEbqQZ/h0yaRxrYxnZ9cJ401pdWs2g==@kvack.org X-Gm-Message-State: AOJu0YwIpV/Yvp19AYJolY7crluqC2ah483RYrWEnSrrui37mPseWAJV dHn0qNcKxL4KDtQNtI3Rr1Hjfw1Sl1fhehUPdzmQUwo7KGyhMlUWwpV1dXgLhWI= X-Gm-Gg: ASbGnctkuwOMvL5A/2y09Ba5FX2L3oc9U9uggVj0Vq44lhksrhupS+xqhnrTrVFslcH lB2c90JkOpz3ZezDp9SJsk6EDePVev1iQsc2Uppun41U68mkvycRgryuo5VARr2FQgk0mXDo5D1 GaI1v2XWh/dazDDUXxTrstfUOwzPAIC2XClDwnBsZIkUATFzkBETrzAKv8Qa0yVCXjJQzPPXwoZ EULUGLwN9IFCYOhI/TGa4ihJ9Njz9YSsv1WznWyPB6gbI/AcolyNlAkK+vxq5xRS7CAYF8WpawO fJ1tkDVCZwcQjUqV9gqtSDIQWnVBJ1IIvmUrTY0oGS3CbNWRjkA= X-Google-Smtp-Source: AGHT+IEEHI/oSTREUk8HTc9X/nZpZu+JH0JNL8Ix0W8ZxxBaMoWEfgZFH93pE+NmBTNHIMjXerli4Q== X-Received: by 2002:a05:6402:2547:b0:5f6:252b:f361 with SMTP id 4fb4d7f45d1cf-5fbe9dbbe1amr2731807a12.11.1746622478474; Wed, 07 May 2025 05:54:38 -0700 (PDT) Received: from pathway.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5fa77b914b4sm9354161a12.51.2025.05.07.05.54.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 May 2025 05:54:38 -0700 (PDT) Date: Wed, 7 May 2025 14:54:36 +0200 From: Petr Mladek To: Bhupesh Cc: akpm@linux-foundation.org, kernel-dev@igalia.com, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, oliver.sang@intel.com, lkp@intel.com, laoar.shao@gmail.com, rostedt@goodmis.org, mathieu.desnoyers@efficios.com, arnaldo.melo@gmail.com, alexei.starovoitov@gmail.com, andrii.nakryiko@gmail.com, mirq-linux@rere.qmqm.pl, peterz@infradead.org, willy@infradead.org, david@redhat.com, viro@zeniv.linux.org.uk, keescook@chromium.org, ebiederm@xmission.com, brauner@kernel.org, jack@suse.cz, mingo@redhat.com, juri.lelli@redhat.com, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com Subject: Re: [PATCH v3 3/3] exec: Add support for 64 byte 'tsk->real_comm' Message-ID: References: <20250507110444.963779-1-bhupesh@igalia.com> <20250507110444.963779-4-bhupesh@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250507110444.963779-4-bhupesh@igalia.com> X-Stat-Signature: jqwa76xifwxoohgy1ha4hcdfi76zpwak X-Rspamd-Queue-Id: 27C11A000D X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1746622479-188969 X-HE-Meta: U2FsdGVkX1996wvWMUH/JjylncXEIcFChb+aOZYwYJsgpXWtPclUsKRy3LN27bx+v/H3I8T+2IOviXoXyD+qedo4bQgLd/6e5cnsqnVR/ewZMtAr8SiU2/HcSmLvvojM7x1JydB6+FLIxyjh1huAiQkgQySg48W/s/1vdrvcJ2yM4INqxzur68W/rzAf8csCOftg1IpGe3i3wfz4Ha98BvXfGqzakewS44469fA53mV6RXN8WdWvrk/ZrLeyugkm4t1FXToBi52foJYVWvd32UQ9ul5W7IyD2NtVoDOi9jIoUcPSVBCcv+kOUUciX4X6RblBiCELGzJ5AkdvoOMyghsGRD+aUiFz2g+2HtQlvf/fd2DJaIgkNJd7pGFmwcQWMVkHrBnbUj8BdVEnMIYPn0zCCqVhc7zBPUL2lzUbzvKcJJdI62xPDj1Vk3gwt+02dRlCD6Su7BU1Ta2GLzmcoYQAp/B/+owxDOdqigm3ecrpDo+gCyv0FlxDvmfEZywSsjVND1vIaP0hVSeQMMoyh5ZZFGoDgxIFV2C2G4KtHKWCVgWYILZh9i7D4fW0IfwlzMT11Nn27BouSyM5S3oN0fLcB6JzxDp7HfzwD7Pqu7KMoy1aaKSNG8zvjQaDtamsG9uxv3sUhSaLfWeT0Ao0I9bq83H+F7jE+Gc+l3OhGWf/nLJY0NxFdv7+60I0nBOX93fQBLcSwIBK5T7lOMM+zlGAhz4QpSJbIgB7B94i2+c5FqYyL27qj7Zaawmy6Yl+avTAMoS2eklc/utTCUJrXK/kBXv436F5i+QZEDiAPM5qWldo19N/IHaxGRD6g5LpBxE+27EQcloCDIuuFhoWNEgRJNPaDnWahhGHd19Vu9y+pW8TICVYTsT7WMwMH1oXV3RoSOsB2/RZz4JWZYJKm52bdswd3EEeh+697PGSXcY/v6FWk3uciqN0rNe2e4JWd72/nEUBzq9gTlE54Zy bqUuOnrX eGko2BB3iMGI0idxrughYrirt0Mo3uuJ2dSgnqjrrublHYOpYByO4l3MYfxGuznpd37t0u/g0f43y6ISdcl7RtmL7aQlCynbOXLHir+3ORXmyIQ5CchbPFbx/3v3GYx81GMKanmOjspv7N7N4fUwtJJcrystyIeSR1I2ZhRCDbUuqA67hsyOB+YnR5MB7RgGfdvWc7K8KpCYJfrYMhJLAX+h5b0B3+LnS7Hqwo2JzE7AGpDLVA7sau27tLgmJIfm4zW4a71P2a7b+K+Hfd0WJmcguVNp4AWDbsQ5vA/iI6OoxBDQkg8+lr39+P7Lv5VaI/rF6pPOKG4gdjQw1+3H6jGrWjbsOtuYDqe2Se6LJlNyEj/CDaVWrLwjWlnqU543iyXWVSr3o7uCHAg5S+ucs2zzYvB/8Ipzl1x2i X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 2025-05-07 16:34:44, Bhupesh wrote: > Historically due to the 16-byte length of TASK_COMM_LEN, the > users of 'tsk->comm' are restricted to use a fixed-size target > buffer also of TASK_COMM_LEN for 'memcpy()' like use-cases. > > To fix the same, Linus suggested in [1] that we can add the > following union inside 'task_struct': > union { > char comm[TASK_COMM_LEN]; > char real_comm[REAL_TASK_COMM_LEN]; > }; Nit: IMHO, the prefix "real_" is misleading. The buffer size is still limited and the name might be shrinked. I would suggest something like: char comm_ext[TASK_COMM_EXT_LEN]; or char comm_64[TASK_COMM_64_LEN] > and then modify '__set_task_comm()' to pass 'tsk->real_comm' > to the existing users. Best Regards, Petr