From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55AD5C3ABC0 for ; Wed, 7 May 2025 12:05:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 65C6B6B0089; Wed, 7 May 2025 08:05:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 60AF76B008A; Wed, 7 May 2025 08:05:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51FDF6B008C; Wed, 7 May 2025 08:05:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 350A76B0089 for ; Wed, 7 May 2025 08:05:57 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1573B140318 for ; Wed, 7 May 2025 12:05:58 +0000 (UTC) X-FDA: 83415983196.18.CB3E8B0 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf21.hostedemail.com (Postfix) with ESMTP id BC3101C0007 for ; Wed, 7 May 2025 12:05:53 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=TEovlvPC; dmarc=none; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746619556; a=rsa-sha256; cv=none; b=xX6fWdWpT1Os5unDJqJVrHNrTJcXOYYdEw0qXjNO2BtXUT/CXhFQAJ0cx52gxg9Iamr96y sBbcA8GM0HRIMq2fNx/JZLpBGHDgFgoGoDwnK/6oW+KuLBlNNqZeh5AwdtWpTgkg9iHtbv 9hOvo+DAttnyNMMqNB2BLM9e/EsTC6U= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=TEovlvPC; dmarc=none; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746619556; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Wfi8zDqJeKm+TpJFOzJJcwP0H7sHmszS6OiiTXY8kN4=; b=VtLpgouEmDRyEuFXPEUaDFkpIukT9/+LpvCYQ9dSKIYPzeAjbG/Y09M5MoL2mCqd++0jRi pN7xOD5LfeDCZ8KKi9JZ1g9wdVakuzMKJjJkyV2jBXrTER9VStutXQq/rymneY/5paFH1o UX90I9oL5pqMByxOzRHmxRfRUI+Ultw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Wfi8zDqJeKm+TpJFOzJJcwP0H7sHmszS6OiiTXY8kN4=; b=TEovlvPCjbkfdh/+tLVWTQwbRY kQ6i1GdRE7WE6IewFS72g+H4B6BNlD7y0NAtdrnPJTTc5ZC0JeXYgBzdcJXsu1brvVcCaRQpr8Ri9 Z+eEaStCh/OvbXKsJJE7JhVPrYqcZoKZVOoA7H4GzalUQ7uafP8Ia0LUSc+4I7UjViQji14tKVHus 52KOSEJqfrSe2fkVh6S53jeJYufx7iZHL1VfENbpAGg06W1m5hh7wpdnt0IKenKXK0eQjCFq8H8H/ 1b/pcJ0av3AfPF0g3odG8hHVmDIqVLdm2WBy97VwqMDICugvPaxouA63S3NkewiwtWsVp7iOoiwyY +nhSvoiw==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uCdW4-00000004E8Y-2h7R; Wed, 07 May 2025 12:04:48 +0000 Date: Wed, 7 May 2025 13:04:48 +0100 From: Matthew Wilcox To: Baolin Wang Cc: akpm@linux-foundation.org, david@redhat.com, hannes@cmpxchg.org, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, ziy@nvidia.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mm: khugepaged: convert set_huge_pmd() to take a folio Message-ID: References: <8e33c8a65b46170dfd8ba6715d2115856a55b8f6.1746609191.git.baolin.wang@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8e33c8a65b46170dfd8ba6715d2115856a55b8f6.1746609191.git.baolin.wang@linux.alibaba.com> X-Rspamd-Queue-Id: BC3101C0007 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: xhcs1aweuufrbjg9735gc3nq8un8fnjy X-HE-Tag: 1746619553-709784 X-HE-Meta: U2FsdGVkX183+JcxtrYsadn/W8QUCzs6JFZf8r7pv3XQr+zLDqM58ul68+4c4/lWT9jmIBGZgBYugHmiz/BV47XUmeNhgoI3BIv7pHCw3yyuV5HLLzjWyetFZJ1RQGM8FOc27qwGFBUwERueNv+wTE7fcBP26d9S7KBM/2qcDmywvUPTgu3hnXTfBc8jUd6RgwV0WfXJ0RC7SSeISS8OExaVBb8bT14i+1dKSxP5Wb6sj68CXGuPxLSxBQSdDaZ9o/RtZkzdlpo24o9VTb0SYco+JY/fUIg1HFqXGcud60YewZqwBA6h81d2n828RZr++CgD7pWgOwBF5vCry7VmsJ+ZTVUwTmXp5lfucxbUPJ1b/HufBG3xf40Envk9jgXcIT/jnaTOsrTdNlfbokslxS9UhpjKt9CPlCVf0qSBQGhUaYjdtDmUYZf1XOPDDfrg5Pnn0mAdsJ6UOSPFDC4Gavlrq1fbf6IEXomJkVwLfCfpfl8OlKsDoUVs4XOmb4cbR2EKyd6zaMIJI3TnIDtMDTR0ARs/LSi+tYLywTLDLjz/lw5oBU9c6iJSS3XXXllwu2SStYDs139PfenhbdJRWIuP8DNidWSuxjAPKYKYedc24X5UydFpXGnihJnBaj6oF2/BshfJpw4nc+1TAo2bQYIUuNKp/krCnwX3FTWAzGzk0Hv6S06H/S5i2rdp+vnFo2R/TmVdgIFbKHkfl+R+2gGk99sFz48Qh49WTQx2ftCQirFojcxAnIEBdqjD0WbLkJjKg+po03cxGG91Bo3ILE5dqbvcEuw1ohQGjfAv0DWwg0Oe21VCEsah6qqn4cRiiVIWMr751U3QxMmOS3ndlu4Vn8tPjcOI4EKGKYcebzMxa/SDpwPpt2TPsE08NLsZ/FZF4GnO9l8ugQwUnd76vXm+JExcoXx/pAGr9GX2FkwUe2SF7yHar9mN8bC086SZIhd1zk/MwBgdBSQAiZ3 oOJqSdYe +Qcye39CGo2Y8IIZlfMCJJq+/0cQBnKfvYPHovrYeBP+tBqvsa63sTSdY+M/L6sdmDB/dTFLdrRDzBpUl8ueaOTNTlZ41tG4kFSr8qcbb7kgi4DD8VHz9CFH6fSy6eRlu+igOsUe04/tzu91bIfbNacpQsJt5V0dTpKntYiaR0WXfxVkl5XhaPgBoxXYv+mEZJ4nUxU2WZUUE/Sm2qj04NTRoM8Qx4irmbLjNiBJOx7PGWjTMaXOhZEi9e17I9i9R8tujhDfnw/w3hba2pE/OZ92FVdFOekWp5OclNJQ18VXTlgE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 07, 2025 at 05:26:12PM +0800, Baolin Wang wrote: > @@ -1476,13 +1476,13 @@ static int set_huge_pmd(struct vm_area_struct *vma, unsigned long addr, > .pmd = pmdp, > }; > > - VM_BUG_ON(!PageTransHuge(hpage)); > + VM_BUG_ON(!folio_test_large(folio)); I don't think this is aterribly useful assertion to keep in a static function with one caller, do you?