From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05037C3ABC0 for ; Wed, 7 May 2025 15:21:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CA9246B009B; Wed, 7 May 2025 11:20:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C58546B009C; Wed, 7 May 2025 11:20:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B1ED36B009D; Wed, 7 May 2025 11:20:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 92D116B009B for ; Wed, 7 May 2025 11:20:58 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id BACCEBA47B for ; Wed, 7 May 2025 15:20:59 +0000 (UTC) X-FDA: 83416474638.05.C952A0A Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf13.hostedemail.com (Postfix) with ESMTP id ADD0020020 for ; Wed, 7 May 2025 15:20:57 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=XtWCiZBB; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf13.hostedemail.com: domain of rppt@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746631257; a=rsa-sha256; cv=none; b=fPSHreBs7G5LSrilRoKCiP7jAFSqsxsc7FvM2R+6TSf51c6E3ckF+2wB+X2X9bzO9wWLAx h75DV9lIcAAvv+brdpbX6fw7gBnq9Z/oHhNBZqKdrJDQj6pT0h+QMVkgyiAJGu1GI1wjQ5 JLOVoS2dvcysNc0IVlRt+6aa+lh++sw= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=XtWCiZBB; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf13.hostedemail.com: domain of rppt@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746631257; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mdDipM8kKjrUgR7x7yI5UVn0YeKojNvpiOlZiqSBvbE=; b=eBO3bRFzBlsTw2RxTRBZJ7BCVW4QfnqUSz3kkadZzDRCoTzkSsrY0cI+f7JYm5+F//Q+du Jru4xUkH3KxleizKVw1g/urrJ/O4iJLI3CVgMjwX6OvQPAyDcHpPpLYq2+8hHPLXHUPx0e KQdKXARpVrdu9ZAlm55AJZp0AC7i/4Y= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 4A0344AA7F; Wed, 7 May 2025 15:20:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B24D4C4CEE2; Wed, 7 May 2025 15:20:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746631256; bh=DMuRy3vH/9HB8MP/eHAh3lYTSsXJDYIcI3IY1DjMl9w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XtWCiZBBDcigCs9rAvAR90ZGDu/yeCGV3FKIg+lWgQE5tggI55fQ1EThnEsOeZK6q DMgxmlLMOatvtvVSXCn/BryaK7YoFbb2M/POZrcgkS6EZYv7YUBvmZil/SK50Hh4lr 5WjXKMjsXaXd4xa42SXkRvSxdbQSR/XvJWhUymwiON2nv7AERNtl3vpyW0LoQK7YAy cxJpPfw1+r6CRqcco+5MVQkED2iX9uAWZ9Qy4qG4xvssMDOKQ/FfnL7O6xphMDJEUB irILuNpPN/+Wv1FrkUGgMyxd+d/QABeUU6LhMKNH4yRpDpoYG7R4C5hZcdsme1/nqV Qyvq/zT/vj8NA== Date: Wed, 7 May 2025 18:20:47 +0300 From: Mike Rapoport To: Yuquan Wang Cc: Jonathan.Cameron@huawei.com, dan.j.williams@intel.com, rafael@kernel.org, lenb@kernel.org, akpm@linux-foundation.org, alison.schofield@intel.com, rrichter@amd.com, bfaccini@nvidia.com, haibo1.xu@intel.com, david@redhat.com, chenhuacai@kernel.org, linux-cxl@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, chenbaozi@phytium.com.cn, loongarch@lists.linux.dev Subject: Re: [PATCH v2] mm: numa_memblks: introduce numa_add_reserved_memblk Message-ID: References: <20250506062245.3816791-1-wangyuquan1236@phytium.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250506062245.3816791-1-wangyuquan1236@phytium.com.cn> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: ADD0020020 X-Stat-Signature: h9arh4gnb3my8cdu11z3bwoywjfsdxom X-HE-Tag: 1746631257-124063 X-HE-Meta: U2FsdGVkX1+bRi7zKzG4rUxDXcJC0vImwx7Z2d2ZpdAVJhfqJ1pdMMYm0Pi1cJyzMVfM9+zKTVcFnHGhYiBiS2BCW5F3YXsES0HQ/39WBmLHC6I1A6NpmVWbufMptTVEh3DPsTVWxALxkBBdN7EQUBE6euJ4irRj+1dAjNoWvw7QnwN6dxKVv9ktAfPW8HzspzWqbG0g9VS/DWH33LtOTuTZ/OIei3DCpCYr+V4WB1mUEPte5oeI6cnNPzMU+uWXUeZ2m7ewcGpVYXP9HIH1rA8NVd3TA6dAHqsINXj12z9gj7mCqGA3VcZvlHll2F4J++bVw4KZSat3fortpi9K3n/oUC6RbzqaVj9cdzFn4/IhUtKwAvnu4FMRilF8e2ymPKU0lMxZGZVogd4GbBBn37v7sv56eZO57S2PsnUuX6nVxcHsIdTlmBy8IwOWybwNDKyZ99hur0OFFOLrzEh2eBzO00GwXS0r3ocDBVJfi1UmpyWSyuvNRylZ0VavcbQUJhp7qp5m/r/G7X4O0lvjIw5LQTsIuEue9eP18bzUj+EyrsNCwCj2h9MV0vvKl113/+fDQ/nQ3BUZ4Lt/Nf+JthZ1dR5et/vm849MB+owOhS3VTJnNYgeIVniFtXjrrt1O62IYbAD2qLD2VOtiI+gRq067cWqGH6CNVXFyECFB9jzluUK4Hro6Jp1bhqtQTlS7PTAhecJWM4lTujkUITGo/5K8H+WtzmQZi1pymLhXgnx1kXAW1GjhyCJzH7JcKqlsnuOqj7wjVx0vFtynHpA1G8S6YFGtnZUF5+nCC5bPFHGJ2XllcZlo52a4HpgElIMFG150rIXFdwTFTFa2WeeqoaRUvZK1ikCngcwgTjreLiCLp6IQHfD+cp+R7wdg9yNVFwRmsO58Nkie2gy3pnT0JlM1ojOjpFjC9pWyQYU1sJJ5RGbq9DhBBmlOzZU6pOJliuxBamsxb+Tg/2sJnm 7UMts9S+ S24ZWlaeQmLeZfftJ3h7Di67DtpjFU+v6da1RNcHU1nnuJ30+WwaxjVMDQVhLK5xfPrsk9N9zl4rSWQkKoSuNUTcRGPXtBdbqEb/3HhKOc9dMNYdJLHVvt68vU2MzgN9vgtyEk7A1bxzpneXRjgSuzXKCeM7Eke6LCwcD/wFRu3SHy6btnlBhlWBttfEgp5IC9VbrzRhZxKDpJb4XTeeEELCqQD4FOEUgLpznXLeRQG2X9w06yZUaaMkjwzqJJtbiOw8dd1Q/XchKfwXb5XxBF//JjOp0NRw/CBaYvIHhKjktOMENB/ll4SeZWBkkY9fFwMhDy8L1Zp8WulSUIFpDC2MFthjsyPzbSaitU+WAPlIYJwbyd6z/N7HVm+turkrQ1+Yf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 06, 2025 at 02:22:45PM +0800, Yuquan Wang wrote: > acpi_parse_cfmws() currently adds empty CFMWS ranges to numa_meminfo > with the expectation that numa_cleanup_meminfo moves them to > numa_reserved_meminfo. There is no need for that indirection when it is > known in advance that these unpopulated ranges are meant for > numa_reserved_meminfo in support of future hotplug / CXL provisioning. > > Introduce and use numa_add_reserved_memblk() to add the empty CFMWS > ranges directly. > > Signed-off-by: Yuquan Wang Acked-by: Mike Rapoport (Microsoft) > --- > > Changes in v2 (Thanks to Dan & Alison): > - Use numa_add_reserved_memblk() to replace numa_add_memblk() in acpi_parse_cfmws() > - Add comments to describe the usage of numa_add_reserved_memblk() > - Updating the commit message to clarify the purpose of the patch > > By the way, "LoongArch: Introduce the numa_memblks conversion" is in linux-next. > > drivers/acpi/numa/srat.c | 2 +- > include/linux/numa_memblks.h | 1 + > mm/numa_memblks.c | 22 ++++++++++++++++++++++ > 3 files changed, 24 insertions(+), 1 deletion(-) > > diff --git a/drivers/acpi/numa/srat.c b/drivers/acpi/numa/srat.c > index 0a725e46d017..751774f0b4e5 100644 > --- a/drivers/acpi/numa/srat.c > +++ b/drivers/acpi/numa/srat.c > @@ -453,7 +453,7 @@ static int __init acpi_parse_cfmws(union acpi_subtable_headers *header, > return -EINVAL; > } > > - if (numa_add_memblk(node, start, end) < 0) { > + if (numa_add_reserved_memblk(node, start, end) < 0) { > /* CXL driver must handle the NUMA_NO_NODE case */ > pr_warn("ACPI NUMA: Failed to add memblk for CFMWS node %d [mem %#llx-%#llx]\n", > node, start, end); > diff --git a/include/linux/numa_memblks.h b/include/linux/numa_memblks.h > index dd85613cdd86..991076cba7c5 100644 > --- a/include/linux/numa_memblks.h > +++ b/include/linux/numa_memblks.h > @@ -22,6 +22,7 @@ struct numa_meminfo { > }; > > int __init numa_add_memblk(int nodeid, u64 start, u64 end); > +int __init numa_add_reserved_memblk(int nid, u64 start, u64 end); > void __init numa_remove_memblk_from(int idx, struct numa_meminfo *mi); > > int __init numa_cleanup_meminfo(struct numa_meminfo *mi); > diff --git a/mm/numa_memblks.c b/mm/numa_memblks.c > index ff4054f4334d..541a99c4071a 100644 > --- a/mm/numa_memblks.c > +++ b/mm/numa_memblks.c > @@ -200,6 +200,28 @@ int __init numa_add_memblk(int nid, u64 start, u64 end) > return numa_add_memblk_to(nid, start, end, &numa_meminfo); > } > > +/** > + * numa_add_reserved_memblk - Add one numa_memblk to numa_reserved_meminfo > + * @nid: NUMA node ID of the new memblk > + * @start: Start address of the new memblk > + * @end: End address of the new memblk > + * > + * Add a new memblk to the numa_reserved_meminfo. > + * > + * Usage Case: numa_cleanup_meminfo() reconciles all numa_memblk instances > + * against memblock_type information and moves any that intersect reserved > + * ranges to numa_reserved_meminfo. However, when that information is known > + * ahead of time, we use numa_add_reserved_memblk() to add the numa_memblk > + * to numa_reserved_meminfo directly. > + * > + * RETURNS: > + * 0 on success, -errno on failure. > + */ > +int __init numa_add_reserved_memblk(int nid, u64 start, u64 end) > +{ > + return numa_add_memblk_to(nid, start, end, &numa_reserved_meminfo); > +} > + > /** > * numa_cleanup_meminfo - Cleanup a numa_meminfo > * @mi: numa_meminfo to clean up > -- > 2.34.1 > -- Sincerely yours, Mike.