From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D6BCC3ABBF for ; Wed, 7 May 2025 09:38:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C63436B0085; Wed, 7 May 2025 05:38:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C11D26B0088; Wed, 7 May 2025 05:38:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B292F6B0089; Wed, 7 May 2025 05:38:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 95AA36B0085 for ; Wed, 7 May 2025 05:38:47 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 42CC7CC4CC for ; Wed, 7 May 2025 09:38:48 +0000 (UTC) X-FDA: 83415612336.11.8922DAF Received: from out-183.mta0.migadu.com (out-183.mta0.migadu.com [91.218.175.183]) by imf02.hostedemail.com (Postfix) with ESMTP id 6C1EF80013 for ; Wed, 7 May 2025 09:38:46 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=HYHZgKr6; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf02.hostedemail.com: domain of yosry.ahmed@linux.dev designates 91.218.175.183 as permitted sender) smtp.mailfrom=yosry.ahmed@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746610726; a=rsa-sha256; cv=none; b=uUbFPVvgKyv25vp3acnkI476Hk10VEb8X3GkPQAdsKCU5e/n4xYRfNslgn1VMTknlLgpuI ax00Tu2yRDc6MTlnWNT7bSwlqwaFQxg1mfUjyf79CzSAf8FNXObS2JbjP8qzHT2G4aAn+Y wRYS++l4HaTNafW7BjruG82Tg4x6ePw= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=HYHZgKr6; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf02.hostedemail.com: domain of yosry.ahmed@linux.dev designates 91.218.175.183 as permitted sender) smtp.mailfrom=yosry.ahmed@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746610726; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NFJGp1RVClSap0AYnwWSAeFb8sS4M8MlcNAXXd2fIRw=; b=DpuCHy3lRldPBGRnPb96wcomCzztRKwbAuzfdF3K9JnNqwQQhDRwUJnEUZAvJ8KQCTTgXx b3Y2u4TV3MDnILsfE+SzI0Z0h8xFJix1qR+V6KKQVmEe6PID3xHGXeHpoRf2RNQeR5yBSX 46hVLHj4ab5O5O2HoiwlNLtOvQ/E/y4= Date: Wed, 7 May 2025 09:38:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1746610724; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NFJGp1RVClSap0AYnwWSAeFb8sS4M8MlcNAXXd2fIRw=; b=HYHZgKr6fw2U7WWF8/GIHd7+PmX+DNR8Q+7Gj1KhiyGsEl349NvOrqHaVTFqCP4Cc2jq3D 2ue5UHAsGEhuonEqMjkPSAeDU6ergJDIETm0YnQFN+MoMCjqkB5rJVFOFu9bO79TlyHu5r DAidx/TT6gD3KJpPBtl7bJRKmKpvEFQ= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yosry Ahmed To: JP Kobryn Cc: tj@kernel.org, shakeel.butt@linux.dev, mkoutny@suse.com, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH v5 4/5] cgroup: helper for checking rstat participation of css Message-ID: References: <20250503001222.146355-1-inwardvessel@gmail.com> <20250503001222.146355-5-inwardvessel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250503001222.146355-5-inwardvessel@gmail.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 6C1EF80013 X-Stat-Signature: yry6djopxwf36h7d91wuwcabcg9fawd8 X-Rspam-User: X-HE-Tag: 1746610726-87851 X-HE-Meta: U2FsdGVkX1+rY/G7ChKTMqr2CzsjmbPRRazKswg2psfqMK0Fj8Due/Y5WdmKcVLjDSxDOlmvqU5MAz+2DwU6GmfVoXNM/uQcEDAenqd8d0YqTzTb6UDaiT3xNdkaBiD2JGnPCeBommbQ8cziwvjFVCSlGKgFGEf5gMW4BBBI7NfzO3eBiMpzzrDz6SUyzh/kT+ztAJ09C4zF4IFW6hd9lUq9BryWNDWJ3Sf6OBLJZOkkqDi8QheiUZ6z0+A1OycH54hLS3cWCTC08psaWXo/q3qdwomcrBJC5o8tFlQzRIr6MICIV+xYK2xEI8zi3qRJVWbhN0uT4kYBRDJNHYE52QLqwBPnsuQMO/TxmIx1gtxCtbCGZoJH+A9VaLvWYQJ+eP7veKg/EMvnCCPDKV0OHvg64osjul2q0DBBkLfMd8j54gWCuQ3/MbJ11yacsqEZ4ODX0n96YNSfUEXV9B98/lxj4LJrnkXnzml7A0o23u8bdJJvgco5XovrVT9WxOAedAd2xKj/xI7Z79KfUG/yw/faw037fKZ/mV6PTY+6MNqaNTe06+bvHkvU2H4Gg0EVCoilEpjHzCukfHcE8jUsowEBsDE4SMTex1ZVQGYaJhudSgoG87Q7xQYAZ5GyTlDbi1J87lnjKqkoLFYFwtYLQY8OYwP5e49py1iijYPcKJdCVv5gef8EBsadV1JJQNgXce/Wt+/RMoRPlwXdRdi1sUXmJiuPLJU1bCFiFmn1Nvz18v1ZoCVZcIKttuNC+FK5/FR5ypgmV8kA0SBV6pA3Vn3fUSR381+kFrCE/8s18HhNIn+o21Ne4yX16cFwZ61fcNsmZr0VWkiob8cxuVPG+/WiNcUwkE2IGbx3Qn6o/2eKVoWAiDVUZIaMXo3qnOkHwVLshKLR3c+q4rA5iBiSxFOc5Hs3mCyMEchKn35bjl4d/5JaEjDA8j8LgjlkrAmv52/BOd9mxrVFbrRUmjc ddWTddX4 kMh/k9kNDYxby6ukNV12YTbXTVsOEiA0sb5BV/edtwYbFLTRkalZV8FSJJ9KdOP1mRmqpdQvOiRASHvn7bw3iQP3G7AtHTt9ey3JwHuI1PJNHz34DCIyTPIzxAcsjr4WOz0szJH6PdyTMNulIwSP6CiPNcp4Ipz19M8F3yY0Co19OyeSOpOcQs7ZmqYhIQ7I6tUwRWfixzKTOuNNZJVzI1wen2sS/BHJT4GldLqTBqOODI4E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 02, 2025 at 05:12:21PM -0700, JP Kobryn wrote: > There are a few places where a conditional check is performed to validate a > given css on its rstat participation. This new helper tries to make the > code more readable where this check is performed. > > Signed-off-by: JP Kobryn > --- > kernel/cgroup/rstat.c | 17 ++++++++++++++--- > 1 file changed, 14 insertions(+), 3 deletions(-) > > diff --git a/kernel/cgroup/rstat.c b/kernel/cgroup/rstat.c > index e1e9dd7de705..15bc7ab458dc 100644 > --- a/kernel/cgroup/rstat.c > +++ b/kernel/cgroup/rstat.c > @@ -14,6 +14,17 @@ static DEFINE_PER_CPU(raw_spinlock_t, rstat_base_cpu_lock); > > static void cgroup_base_stat_flush(struct cgroup *cgrp, int cpu); > > +/* > + * Determines whether a given css can participate in rstat. > + * css's that are cgroup::self use rstat for base stats. > + * Other css's associated with a subsystem use rstat when they > + * define the ss->css_rstat_flush callback. > + */ > +static inline bool is_rstat_css(struct cgroup_subsys_state *css) css_uses_rstat() is probably a better name.