From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA025C3ABC0 for ; Wed, 7 May 2025 09:03:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F8226B000A; Wed, 7 May 2025 05:03:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A70F6B0083; Wed, 7 May 2025 05:03:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 396006B0085; Wed, 7 May 2025 05:03:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1A9196B000A for ; Wed, 7 May 2025 05:03:02 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id BA0F616170E for ; Wed, 7 May 2025 09:03:02 +0000 (UTC) X-FDA: 83415522204.22.63C6094 Received: from out-172.mta1.migadu.com (out-172.mta1.migadu.com [95.215.58.172]) by imf28.hostedemail.com (Postfix) with ESMTP id A27B0C0005 for ; Wed, 7 May 2025 09:03:00 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Dljyweor; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf28.hostedemail.com: domain of yosry.ahmed@linux.dev designates 95.215.58.172 as permitted sender) smtp.mailfrom=yosry.ahmed@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746608581; a=rsa-sha256; cv=none; b=sPNu5jNd/NYg6U39DUB+z7mXErHxzzDrmQeeH09h9EoXy3GrCq+171DktADPNyXHfGQitT 9o4o4w5o1cteWRxeYUql9mY0uHwwYP7LTlBd0qvUWuK79GEBHkVAC4iWl76lRZ1HPUBslU w2nmuADkBOTtPqfN5q71YSZNGawUuDw= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Dljyweor; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf28.hostedemail.com: domain of yosry.ahmed@linux.dev designates 95.215.58.172 as permitted sender) smtp.mailfrom=yosry.ahmed@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746608581; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+y1XaeJDOit7AyGV+nMns1m2raZLQt+o4kfDqKhM/eU=; b=79d4Ek6idiTk4+YMnWoDIFQje2hCBYUNEf1r/Mj4JLl7qpROpG5FdcAWjSb7WU8yQy+ev6 P49EyApLqXbxvhPfL+nAuvArJz3Ea15UGNcNYa03Qkujh280z4f0zYKcPVWK+WlPvuSihR mkA3zBHmCEURh29+UGD8B27Ri3pp2fg= Date: Wed, 7 May 2025 09:02:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1746608578; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+y1XaeJDOit7AyGV+nMns1m2raZLQt+o4kfDqKhM/eU=; b=DljyweoroIotsDR8lGb4KqsS2vdmPe9ZIuETt6fV/1dHx+3oAufPawn3ifZnYgwCpGvPbr 8fzJ9mdtt/PJzXCx/TERsm8rbmic8FdXi/P9udLSfl9vFaWzfbT8P5XJgI2mxuqf5Xhigt oUlo/eNfPBat3chJsDP9P0CGx3XAd9Y= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yosry Ahmed To: JP Kobryn Cc: tj@kernel.org, shakeel.butt@linux.dev, mkoutny@suse.com, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH v5 1/5] cgroup: use helper for distingushing css in callbacks Message-ID: References: <20250503001222.146355-1-inwardvessel@gmail.com> <20250503001222.146355-2-inwardvessel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250503001222.146355-2-inwardvessel@gmail.com> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Queue-Id: A27B0C0005 X-Rspamd-Server: rspam04 X-Stat-Signature: asmnot4yqonz89zkz4ryhs9cupdjzdby X-HE-Tag: 1746608580-424874 X-HE-Meta: U2FsdGVkX1+wz/mU3ai2HGlvTfqEjt1TCYwodi2dPdQ8urRpqNyAa5ywKzaB+iC3fQ5SS8OmU+rRAjLc8nBwbrlhI2kUKaW95uGA/Yb/i6XIhNsHzz0yDa7OqDUul1trasTAlW468TRFnIRrBf+6psMVaV7vsGY0fbJBOsSSELevvM9u2TS2luqJeVJgQZjlRezWvu8NjXUYdfL3t/LBL7MmT5abQptfCsPIs//24dCMCj8echsKPy+Eaxujz8jRTZSG7eXea2U7/AWf/uVFMx+/ChPvPXaBG0vA6dRbdcYT2Yi5FwwrfiMks3rd+3XgzdO7QApMaJSU5/kyyI1C1aMMo6zbIwSzcqLuDsfuKNbRPtm5pBYbs3TF2Tn6SJfWrbFP4mmFtrPBCxmfwjuZFGOh517rDRmv1wj0iZmXXrzIneLlb9qTzT+1lXr6DcqfHgch8XaQ800nbnhWdmbSU7J6/JnwcPVEUDmpjs22LUHc61V4Iw4UHHyQYgEQPThvqgxNhKbVdp8iAblZIV+D/IZXKaNjs2le21LbNVkM2fJqqFEctqDU3VJZsNtqey1AaliNQtCe0HFxL2iybXlsTA9MLRvhc95uQwJUP+/8me00sB6XzCh5vFtpVMgTdxPU73ZYDsI1vaa30AGQhqrmugRW0fdsytX1NQgiOcMTsSjJ2m4b2uHKixyqmhrMbLfHxLcr6n/QkwiVbxSxFvsgoXESqGdhmEfORH7Ruzag52decdlj+ZsE+zkSByMJ+yRutH5inCkXw1Bm7yFyZjRco554tB9Stb6zKa4RpAHBZz1KLsBb5zDSvZfYLTc4CiLbeoJu46VOuRRmBYdUW6kzzvyi0738hnsveCFgOizJ8aK050GJxvILql1tWz9AlUU7/P95K0Wiat5+pqO5LZEABkNfjVsV6PJ9C1y91EM3cD7Q9qtOWVYJfkx1DKy5P/nkY3+zCnhezgaYf7+6AFO pcEFCtBd fxznYKFk9JtzfFoSs5anRIfvFDx/PB9ljL7+bY4Wu/4beb5WKZP3CmTKPUD/dq/aDMrtyiabGD3FFn7pVzDeCytYS/5+4rm5vVQMr57vbVbCvYNsheay9oBSUTFxpRbEXw/xaAVETWHTwDoIVXmnN+0ov9WDbUKuRzpjSmPjyigLiRMbnwMMXsAjbeIoL8wzP+FoRRjxfZtaYUwlaYVkpD2ut4b6Dj6wckgRsVwkDwg3mccc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 02, 2025 at 05:12:18PM -0700, JP Kobryn wrote: > The callbacks used for cleaning up css's check whether the css is > associated with a subsystem or not. Instead of just checking the ss > pointer, use the helper functions to better show the intention. > > Signed-off-by: JP Kobryn I still think this should be renamed and potentially reimplemented to (also?) check css->cgroup->self, but anyway: Reviewed-by: Yosry Ahmed > --- > kernel/cgroup/cgroup.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c > index 7471811a00de..125240f8318c 100644 > --- a/kernel/cgroup/cgroup.c > +++ b/kernel/cgroup/cgroup.c > @@ -5406,7 +5406,7 @@ static void css_free_rwork_fn(struct work_struct *work) > > percpu_ref_exit(&css->refcnt); > > - if (ss) { > + if (!css_is_cgroup(css)) { > /* css free path */ > struct cgroup_subsys_state *parent = css->parent; > int id = css->id; > @@ -5460,7 +5460,7 @@ static void css_release_work_fn(struct work_struct *work) > css->flags |= CSS_RELEASED; > list_del_rcu(&css->sibling); > > - if (ss) { > + if (!css_is_cgroup(css)) { > struct cgroup *parent_cgrp; > > /* css release path */ > -- > 2.47.1 > >