From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F0A0C3ABBE for ; Tue, 6 May 2025 19:36:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1679B6B0085; Tue, 6 May 2025 15:36:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 119BA6B0088; Tue, 6 May 2025 15:36:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F20966B0089; Tue, 6 May 2025 15:36:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D17656B0085 for ; Tue, 6 May 2025 15:36:40 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3ED1056DFB for ; Tue, 6 May 2025 19:36:42 +0000 (UTC) X-FDA: 83413490244.27.6C349AF Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf26.hostedemail.com (Postfix) with ESMTP id 43F30140014 for ; Tue, 6 May 2025 19:36:38 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Tby9ETG8; dmarc=none; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746560200; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uZd/E8aqEp6rcmE1csr2nKssU+4+ZJwoZz4uwg8GaWA=; b=PaAhyJGC1BpxaeJDG08Tf1AkyBsJ+lnWh8kdaxQNB5bD1q5nTgd4oSCDmT2FCaNx3ZzMSZ ASUfRtUHuA2UXXFLPPd1GGtnfyoVIhe1keKFvkJ+YL75SvCuUC1BlwsWtW2zW7ZrgY/qe/ d1IAnQmM6c5CS3yxynBGk6KHgYHj3cw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746560200; a=rsa-sha256; cv=none; b=8V9rpVY8nwXR9is7B7bZ3jo1xUXdPHKwjnbh5MzfhiDYlA9XuxZRrGPInQZCAhm7c3XGEd xyxhWeR9gktsFJMZ3xWRrM8aDteP+F0ofQV1JVwMpivsMt58fZe1YCy7P8+k0k+yDImCIM foN2oDSki7uVCHaERU5l9ZNnDP1clMI= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Tby9ETG8; dmarc=none; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=uZd/E8aqEp6rcmE1csr2nKssU+4+ZJwoZz4uwg8GaWA=; b=Tby9ETG8OfXXSnMJRqXdSPxyEV wHNau/XLfsERq/UfOPVVCI1jWTAzztcbOkZzJsKm55yaW0R6S+MKj6991QLiLb9JdSw7djIksjlFe vGuDpOopwCUiAQIkqaSz/gRMlUiKq/tFkS6nepD1sQsNYOwlB5Yw6jlfLe9dxRfhL52jIS2Vu0C3M WLsMlRSBvQ1HVg6qlR44Ff3m6vRef70Kyhwn29jgU4/FURRaozGw59/v5kDuJkHdo2WgqiDzrNUf5 pLnxmsBKNB+AIpnrw/DtALSU3Nz8nGOZeQsgLp5R5KzLhRn0gIa0nvT6Gc/fwD6A7U6duK3EvvERU bpv+/sKA==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uCO4i-0000000ADJ5-1QO8; Tue, 06 May 2025 19:35:32 +0000 Date: Tue, 6 May 2025 20:35:32 +0100 From: Matthew Wilcox To: Fan Ni Cc: muchun.song@linux.dev, osalvador@suse.de, mcgrof@kernel.org, a.manzanares@samsung.com, dave@stgolabs.net, akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC 0/1] Convert is_migrate_isolate_page() to is_migrate_isolate_folio() Message-ID: References: <20250506184155.587070-1-nifan.cxl@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 43F30140014 X-Rspam-User: X-Stat-Signature: tgih7bnbziwr449ozpzxsbs4jhf19ena X-HE-Tag: 1746560198-430918 X-HE-Meta: U2FsdGVkX1/STWMNPdQpecbDZucr7iYmtigD0Be5Q93snjDIRGk/4HMx16d2UotJZ5P947lPu3QEgoq27AhGHAHgtSc9XZufOmNBJnyPz0A48fgrQn1ZuaEbBeSC3gKISTIZigaY1YAHWLjWvmDnTAzGjn0NXm9Yux2jPgzM+30wkH8kHoJ8RmuMAIM9QzD2clTcg4n+cxtwWsndr6aA8J/dlf7VXhgv8xhCJwgM0mXkRpVdzyIVvAM/ES5ATVJRtW9lf1L+ZY4WPXrFp0zKmqMjVpqAvf2H5ClhV6T5lpk6g756DnSd0WW0ijvfvK/V/3vPzuwWalsymBdQMqSY/OPdSbqf1mstLIwvQSsLR195OlTImJBQU2IvzCwPjyjGAM5cfCDR71ilj6gmULF9Eq242TlHJZGwWqF85Awcw0HwJSqQLvTnsYhLVBD/BJ/ARS12dZHOzVf8/c87tT0wDZu/mkZHZWveWcZ7dikY/WtFDEPj4wxAyBYdCeYZ+0BCezAPeoO4qBuvrRXPorTrvaa9oxgSqI4CvnbLpLOGglM0cC6SVS6jAGpICamOePK8j/l3/1t95u5CxJsS2P4LhLMohB8ZdELUJtzNcTwqFLhufa0VvYfnC5+IhcYl/M2TE4k6ogXNqHcDwUpVXVdubNzs5/c+PTquEmsJQUjDrOgQ8vuSXjgVay3pYxPtGhhWiQuxPQx4uRS/amKMzM6cQByJc6CdNVcRl4uyczM5o7skcr168JwYuhAfCkLprY2qj0FA8MBYFIJAv7D3/HHuD8CLBPvr7goPtN8okIXRO8ZVoWCRWgEfghQFv7gqkY+v4YOAKLLxAl7MGSAPlCHRot2WkMonUWCFtDyuCanOsBTkNQH+AzHQPzeY9js/BUzkeUFIUAYEqDUCG05BKtqZZrWeqn1Zn7IfBFavBXml1E+qM2DE++V98+Sc0sWGoTun/6h8d1ZibXT7aewrH1w vbp+VDtD bTzNErNZuslRJtVoOe/XCWbIPNIvqMT+KWONqAGETho9ckz7/Pr01TLSI02EA/AJ0GgygOEhFIQA6b5Z4sgLgOGPq+3aWHmSfllq3rvcO0Hdve5x3wcn6AyUfEEdwyDT56HrxsX+GaotDoPMhGIxi5ip66Posn0wVtiLc5D7xzgAK3f6QUo0QPd7hzU8AgUuAzF45Gi4JClQTSRTeNIt3UX6BSYWJMLuTOkNigsv4wqC97gqLHEjmyI43DY7ThaOvubjqUqftzQL7ru9Kn84wGE6DVOsgTEhGfSfrgdc5rDcixzPfJxuqkxCJgD/5aVVqre1XMCShcoe3A1+KP9jsVFtkgCXoCsNciqpu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 06, 2025 at 12:23:15PM -0700, Fan Ni wrote: > We have a free_frozen_pages(page, order), which have two types of users > 1) head page and order directly from a struct folio; or > 2) page pointer that does not neccesarily be the head page of a > folio and order that may not be directly related to a folio; > > Does it make sense to introduce a dedicate function like > free_frozen_folio(struct folio *folio) to handle case 1)? No. free_frozen_pages() will eventually be just free_pages() when struct page has lost its refcount (as the refcount will have moved into the memdescs which need it). It's premature to do anything to it now, we have many steps to go.