From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A5C6C3ABBE for ; Tue, 6 May 2025 19:23:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 85ECD6B008C; Tue, 6 May 2025 15:23:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8381D6B0092; Tue, 6 May 2025 15:23:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D7086B0093; Tue, 6 May 2025 15:23:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4C2C46B008C for ; Tue, 6 May 2025 15:23:19 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2902480164 for ; Tue, 6 May 2025 19:23:21 +0000 (UTC) X-FDA: 83413456602.05.52075FF Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by imf21.hostedemail.com (Postfix) with ESMTP id 397CE1C0002 for ; Tue, 6 May 2025 19:23:19 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=cukpdCnA; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of nifan.cxl@gmail.com designates 209.85.210.182 as permitted sender) smtp.mailfrom=nifan.cxl@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746559399; a=rsa-sha256; cv=none; b=1OYqGN3cI9eIx2kX+fitIJvkl1coCkHN2Pr/hXW8lcnfsDS11HeU8xsC13TsaQm3wVHkou FFWZQhCtIcINV3HVcTk+nFo6HUeglgaq7IR8PoftYgCFOZgimfGaOjDdJcFIBIl66Pcscv uYRJYxFtLHuzqr9u+1J7LXP7S8zoxPg= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=cukpdCnA; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of nifan.cxl@gmail.com designates 209.85.210.182 as permitted sender) smtp.mailfrom=nifan.cxl@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746559399; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1C8SA1mk9A5OP3mj+vvhNYYeMx2fYijbXtLOmpd6G8U=; b=0CBklqdYNqjPatbtq+yrwWZDkV12prZkmbI1++fxkuVovXRuZr+QIht28QkyWpVuGljDxl vH30Tq1ZCEWL4sdsxbzekTCjATYrrJkMd8Km/6uFcegtvm7VjKYiXSe4niLClLwwDfVB4U 1VyJ7BdTKbjS/eMpMfX4MT/SRgfb4Bo= Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-72d3b48d2ffso6550111b3a.2 for ; Tue, 06 May 2025 12:23:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746559398; x=1747164198; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=1C8SA1mk9A5OP3mj+vvhNYYeMx2fYijbXtLOmpd6G8U=; b=cukpdCnAUJfadWz8+NlnGHTeW2kcGewKYnxrVYhKLfkZmZB6PGTySdaV3bFRwf/+nq bmlLEPVGzY/CtlFHUxkC9sBCVph7TYkuUl4WSX9dxQeX5NERclgNLQBeTzDWdb3gGdyf tRnGoAerJ/r5U/mXwyldXD8nno4mOpiq5e7TWLsigdqUq4OPR1M797uWqn/7rw/QY94X /dbi8tQ//LrcqRQKMR/hUEOrevGCatp07oZHtC4cNd8I3+KFzYzn1g+zSxDF3bqWLy0W SS4ZlnEoACENHRB8R1+x7rI5feVZaXjltnppt2URDtuKTZLxh+V1dtYC5Wpz0DJSC9pp sTyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746559398; x=1747164198; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1C8SA1mk9A5OP3mj+vvhNYYeMx2fYijbXtLOmpd6G8U=; b=qcBLVBzGeVJnGs2T0ZazJh2RuKUHtD8asZPQoWuDMOeU8VTHHq9pZx1FGVNqEGkOKW cDm3RB9YGmwuC3uJb52kfHPA9d4l1a5noyUDbowU28dIPRqgZg2dejUcMZhd9F/yWQ69 NgMpucdoQ9joEcKtmclpgBzZsh3qa5JHei+x5mGFPPowNqDwWEw5hNeEJcSEsUhDDA8/ 8Pjp32wcJ8Mgwq1R3y2Iqn0HoeKUH8Kd6IlUS3He4yzpLSrfcKmxfDwMGRO0r0qNek6g YGX+e3p5J90W4yKbV4d7GgaPdDAjHYVshr/HbZKcPaeRR8reMtRcTsy6/Ya96cqyVFob Ejeg== X-Forwarded-Encrypted: i=1; AJvYcCWBSz1DolHi8awTH3s5C1xLKAyj7Lb9Ofzlpc7iOggs+8Y2nUjIgt1oowMbN8sJAfQqgVe2qhPPNw==@kvack.org X-Gm-Message-State: AOJu0YzJlkgVKFiKfOy01v3WRe136EbLJJi2rlIQVJxXhhJNIKma4Z4t 96OT6aWraGnxewcACOGG6eVtY9Oy6k2lX2M0b3jPbqOHzk2R6AMObzM5Ag== X-Gm-Gg: ASbGncspvaRnKUYyiEkM9itMWqEjZPIYFRkO/h/XX+wDsSWfL8tisB4OGY5+9sYTFRn Zd0RbwGiLj3ruXo+MElAAF2Hw/VUcMQEVcPa6UXcn0bjO5f8S4EoPFl27iiSiK5YItClXzIwGZR nL3YVrVihlnEuibWh1AbaUo2NZd2ABjogrqCh4SyR7FAaHpt/oWxM4AYvENflHFXg4H2cVXh6y2 Fxa8SqhWleB5FES+ApumkpMi8asKCpMQpU8tv9OXPi/plDyIhjEXLSg5p3HNAVsrT/tFPlxyzVd sfuGKC+zd6rYab+BA1jSfsXED0FUMx4= X-Google-Smtp-Source: AGHT+IGslbzQxQPOsnF7iVmmTW83x3b8B6TmcHa49T+CWfLk80V9sI8dKCWCYWqY9ayQbfuJ6snOHQ== X-Received: by 2002:a05:6a20:3941:b0:1f5:6e00:14c4 with SMTP id adf61e73a8af0-2148d891a92mr492719637.42.1746559398069; Tue, 06 May 2025 12:23:18 -0700 (PDT) Received: from lg ([2601:646:8f03:9fee:3afe:d39d:8565:ed44]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7405905d0desm9647634b3a.137.2025.05.06.12.23.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 May 2025 12:23:17 -0700 (PDT) From: Fan Ni X-Google-Original-From: Fan Ni Date: Tue, 6 May 2025 12:23:15 -0700 To: Matthew Wilcox Cc: nifan.cxl@gmail.com, muchun.song@linux.dev, osalvador@suse.de, mcgrof@kernel.org, a.manzanares@samsung.com, dave@stgolabs.net, akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC 0/1] Convert is_migrate_isolate_page() to is_migrate_isolate_folio() Message-ID: References: <20250506184155.587070-1-nifan.cxl@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 397CE1C0002 X-Stat-Signature: g8mwobhy8pmfi1b7rcwocrzhkakfi4zz X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1746559399-103584 X-HE-Meta: U2FsdGVkX19f0peT/2Fo/dDuF17BaugH8sHjz3/SsDeOg2V+aYYbFmJaS6iVJ3mVBVrojWT7X6bo92j6N0NTF502gbq5CYiekIIyZIAcudojl3mVXHWwlKypIEq3LryhmfkSKNBpEPPyninUmTdUlpLmx8YGCfDQ7GHQn+tyePXb+a2bZt6IfM6hICtZOTwRSMaZk+uM+/KNaWv2ysuL/maOoksC4HOwsrtuYKjOIaL10SLcEbLOKZlv0uvZjhTwDIqZvDypc5COGpWDxfDl0kIuhcdMuDfW2svyQE1GhIE3cY7iY87u0cD426W29JkVUlzxPQgHVmmUCzGPAv461vm9Io7jtcPsQ6O6FwD4SCgivHErfB045w0ICIgl3oP1BReFdEFE7ojnKx91mRRvEKOU7qm+fK19s9p1hUzXyOD7/dv6nM98vwQ7vDhW5Rm/WRdYOviAi3clFWa6BZMAJS6hUq9HcRgyXp0q+CkA+9jSOQs5MRBvejHIBWFCtAMy8CvZFOwjfMIVC0UBw1/zVka8A114rXlqJuIdqeU7CDW4cRP4Qhojf7+bBH0LBeUwB+2W/Yrk+oxapQGsya1SVFNASShaT8L+tUo2Le11uzDoZW7Hv3mzS/9IAXM4ZYZpJXrqeZFb420I5r1VPuUxwhFW7S2Lpn5ykqK8f8PEB49h7eou6MruYYzGXPFBNdz/HEGOc2ahGC7nye+mGbxMdwqx3adUXy7cj7YCyF+V83mFjap82N+mIZ5ZIfTDFxlky4h0Dv1Y4seE25mp29mqqRHAqIhHxN/9QIGgPt9YIEpMVBHbQuqqIU3/26MmcsScrWpSxKEHIlB0vH9s+9zYEbQ+R/23r2S6rrO71gDfnB1iIC4TnLGoRSET3jgwV2iWltag1EnIizIyBgF1mQA+q3Xyq+or1uc/kYch8thn6aVwbH7E5vivCeT9SdO/tMbY+Qg7XqkHlXrSV6b7vg7 a46uqZ5x WCTF/6v/jg0e20JfuqPegsOKLsg1f/6Kf/qWwkJugLFl89CrhQp+i1T8ZT3KP8DDJ5oFJWKkiqnI9GDWYlaRUxX1lOGXE89OwLcOShik/mmZOStk7svZPme+f/b1gO2HmjqVQjOkyxC00zv4w89R7RaBejn+6QBV3hwbZLATOFNy4XlFWGOugxb4e4Q18Y0YHCj9QDaFQNs1zHrv5LGRBct1ig4NgyS56J6rDXMjwe2W+hWyzW1sCMD/UWxifP/yUv+bhl/FjKPv894I/ewijCS6R5kkQsjJRPmKrk7MillMGGLg9KcZJf5Qk9/pF+1BmIG3epC0e+Ysfu0kNQUQql9XPwY4ws8gFRVuSMEF47VnXF7ThUAvE5EXPktUXFwSALJlmw6VvvkIsrahf1NkFcksV/Z8BqWxEuHebnKZLIygA9OTes8Kbj6Popd8vk1ycqseREUkXD3BQ2uJE6eCUXPgnmQ4Q0mpYqS0OpFn792ImcxvuSiDay+B1+slODCWFU9aL41x/X1zwezuh1AXcV12tQTI/6yxHuG7JwkDGDBuw2ZDC5AykPIgVYe+KUrnAW8PnGd+UU2OMgC7lv1Q6Ppck8BpQEVR7sFcx+uR2H6VAI2vFs5ST1sJp0xcDkvks/D3y/e2MvnKjlByFABDJMVeIj1XJVPoOwaxRIgAh0P4PfnI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 06, 2025 at 08:08:55PM +0100, Matthew Wilcox wrote: > On Tue, May 06, 2025 at 11:38:28AM -0700, nifan.cxl@gmail.com wrote: > > From: Fan Ni > > > > Sending out this patch per Matthew Wilcox's suggestion > > that we need to convert is_migrate_isolate_page() to use folio > > https://lore.kernel.org/linux-mm/Z_XmUrbxKtYmzmJ6@casper.infradead.org/ > > That's not what I said! > > This is what I said: > > > > > > - if (is_migrate_isolate_page(&folio->page)) > > > + if (is_migrate_isolate_page(folio_page(folio, 0))) > > > continue; > > > > I think we need an is_migrate_isolate_folio() instead of this. > > > However, when looking into the code, I have noticed that among the uers > > of is_migrate_isolate_page(), in most cases the page passed in is from a > > a pageblock. > > I am not sure how we should proceed with these cases. > > Should we deal with pageblock or just leave it as it is and only do the page > > to folio conversion for the pages within? > > Neither. Add a folio_test_migrate_isolate() in addition to > is_migrate_isolate_page(). Don't force a conversion as it's a > legitimate question to ask of pages as well as of folios. > And some of the pages you want to ask it of may well not be part of > folios (they may be part of a slab or some other memdesc). Oh. I misunderstood "we need ... instead of .." :-(. Thanks for the the clarification. Another separate question. We have a free_frozen_pages(page, order), which have two types of users 1) head page and order directly from a struct folio; or 2) page pointer that does not neccesarily be the head page of a folio and order that may not be directly related to a folio; Does it make sense to introduce a dedicate function like free_frozen_folio(struct folio *folio) to handle case 1)? Fan -- Fan Ni