From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60081C3ABBC for ; Tue, 6 May 2025 19:10:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D90176B0085; Tue, 6 May 2025 15:10:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D3C4E6B0088; Tue, 6 May 2025 15:10:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C02F16B0089; Tue, 6 May 2025 15:10:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9EA916B0085 for ; Tue, 6 May 2025 15:10:00 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 14457BD1E0 for ; Tue, 6 May 2025 19:10:01 +0000 (UTC) X-FDA: 83413423002.04.58AC280 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf18.hostedemail.com (Postfix) with ESMTP id A79491C0004 for ; Tue, 6 May 2025 19:09:55 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=rb5LWJyy; dmarc=none; spf=none (imf18.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746558599; a=rsa-sha256; cv=none; b=b2/r4R+NnVJN59Ad+bbuxz2a/muKgaD6DEj0pCjXlU4GEhhOEBAqT7qUSQ+GWrKaegqFbL Wl6nefVdm49vv7PXtkaR8kBAYCXLeWaUKp8blxDvYLfv2d26vzkUfQXwD8X/Wo43id8s36 R/+m500egHlbsihB9vtRq7/ZZLA+Tic= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746558599; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Cv9t2nkiOZ/C9O6X5BLHLPxC2u6g2ujAp/9JLD+z1W8=; b=FTLRF+Ticz0P1zVx3iRsqfHSl3caGyTNsRuRBFguj1Ea+cbcSHGmXjBikv2Go7kGqjsZ+G Zj124PyTNHKFdIagRuSv2oKxM4WVsgG5mhySdu+pTe7UKFTuJ1zaKe8T6NUKiw3OjVj6gj 3u82oIUF74WhzhqF+zvz+20shiUj988= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=rb5LWJyy; dmarc=none; spf=none (imf18.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Cv9t2nkiOZ/C9O6X5BLHLPxC2u6g2ujAp/9JLD+z1W8=; b=rb5LWJyy0B3NTyyMjI2TAecWxx yU5LTtjU5LeixJbuXVwZfORNexR/eEFsILkG6WbuiJ79+WcaqxgeU9dIgFavrtKk2/9qlcBY1hmt6 4ZOjNiCjRutGizruYrNkvBWRnLEBQu0HY6INJEl9vZrSsBZRgQrDMUqSg4dZ1aQoBUZUHT7esdUGN UfqvbLfrKiunxYpHF5fTj0es5ra3AbKc1DdabL2bCQAnd8aTdcC51saCpCOHIeOMdcPbniD0MgaKg rpuRrURi3ZBxbYaOdnHfRXvuSOmqELrrOvmGnSyMs1a8OotHCwH5jsvVG3EZp9woXjw84n4viG+78 fh61sMng==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uCNey-00000009vG1-0hdC; Tue, 06 May 2025 19:08:56 +0000 Date: Tue, 6 May 2025 20:08:55 +0100 From: Matthew Wilcox To: nifan.cxl@gmail.com Cc: muchun.song@linux.dev, osalvador@suse.de, mcgrof@kernel.org, a.manzanares@samsung.com, dave@stgolabs.net, akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Fan Ni Subject: Re: [RFC 0/1] Convert is_migrate_isolate_page() to is_migrate_isolate_folio() Message-ID: References: <20250506184155.587070-1-nifan.cxl@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250506184155.587070-1-nifan.cxl@gmail.com> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: A79491C0004 X-Stat-Signature: drannuw3teueha819huopg876ko1upby X-Rspam-User: X-HE-Tag: 1746558595-461307 X-HE-Meta: U2FsdGVkX1/bcf4L95nE3VMe8mufa2sOyc/jvj6Kgb6C4PuEIGUEu8v9ttGGxG3K3GNSErZ08izuiS2Ea60gSpPBrL7Bqf3HBnnxrd/snaLosRjn03Y2MZ1O3uCpWtPsZXYhMYmGiCWJjFu0DR1W/Y0mlDdORvB9/+wbzMKGWpPxfRMOGssJ6nczd2rDUiviJEuv7a1A1cIkUIqY4PEJdZ7uwAmi7F09ItpARQRIF3hvPGPsVK6syOie1V/8DokPWCVhXh3FhqPkIcd6DqVmALZD3OXxDBHCaTLpPAzHQQCa/dTa9M+demhVnLUxDwm+aPbpplF8Ry7UznzlhWSazEhrWJZPjVZe9gPfcWTLFYlIkqEyeNRkFT3s00R3kstO+ysBlhpZUvdau0JwM65hIu3l9D/X2WkBUNLoYoN1xiSXEMrvPDmBYQ6Kqjsa+00v+9RX1Oe5n7aj0T8awfCYAhSHtUs71AGTeWA2QB8Xf0x8VJrGdkCbWgEvpOU9caQ5zmAO9695tH+7ZPZAZ35r+peRocp+Dc18WnX3Al0oAW3XZ7coNv73Vqmt5sVJJcUie5wd2M5HZnNs9Vkcs/RvwlRpPWF1lLIVlzw2nWFwZuiIqF6bDwA2Tc6g4HVCqsq2tRx5jVcAQd+8DoYoHB5EnPZ1asakd8qAMRWexvnq00TqoWVXdLGoyjkYmI4q2OmWG1XBW8Nsj8cGCpI5ZWiuRWczG9w7RhQjQk7+0kqdsEeJcAV/Bfjby/4rNLwiL+ae52GVENOygjyzJV56F2m+i8ajD6Yc9fXZKrPq/wjFVIA4/I85J+ZwCXht/4NsX+xIeYDBFn+ipIPUEwon1VeYSzZmEAndFzphDQZHWi4sQBqoCpZrLSXb+aOo9exPJa9xu+8IfF2wOk/muLzIFyzAP+rYdqc1MbH91czlkHy6pIUqElNYv4AuIHJ36m+7QZlzn8wq3x1jxcR3ocN1N3J FuQ0rBXQ IVe1ZYKoADseYtmc+sWtntbwOm0RTZQV2CHTsRo3hJJczBAadlNBZzKaNdZ/FInvC2NPOKHabSeuzfAXZkxhC4dy+8Jije8LH3dW4Df1d40o4jJhL04k9iO2STF7QNnzqkpJe6DNrxV1OzSATAhWDMZogXNQAZwYpNhQAdpH0CjMPi79XpbxvAW8P9C9W6BHfK1nDoXtP5bYge/my96SDcdfX0N+k0ChL6gzGHEPnp9bnC6qHn0pmJ5bHXiRCLMYEjdnQk49W+2g6lNeWxbly0HZJIgelTnbqq9x5oEOZTLoG6w4K5NKhFWf8bADCUDjV2vT31yLcRzdoiZQNUP4HYGE8rGIwr6GQMlNQvJCQ/1dbUoQTz5hWt7q4pEiuZu4T2GAchCKUqkOYfR1hGDh0NpazwP7O9xII5uGSSL2xH8e26BBV/OWAA4t3Lt+IK7DYUWYRPaZQaqzk4ADwdQN2v8tgRVt0dShMInbP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 06, 2025 at 11:38:28AM -0700, nifan.cxl@gmail.com wrote: > From: Fan Ni > > Sending out this patch per Matthew Wilcox's suggestion > that we need to convert is_migrate_isolate_page() to use folio > https://lore.kernel.org/linux-mm/Z_XmUrbxKtYmzmJ6@casper.infradead.org/ That's not what I said! This is what I said: > > > > - if (is_migrate_isolate_page(&folio->page)) > > + if (is_migrate_isolate_page(folio_page(folio, 0))) > > continue; > > I think we need an is_migrate_isolate_folio() instead of this. > However, when looking into the code, I have noticed that among the uers > of is_migrate_isolate_page(), in most cases the page passed in is from a > a pageblock. > I am not sure how we should proceed with these cases. > Should we deal with pageblock or just leave it as it is and only do the page > to folio conversion for the pages within? Neither. Add a folio_test_migrate_isolate() in addition to is_migrate_isolate_page(). Don't force a conversion as it's a legitimate question to ask of pages as well as of folios. And some of the pages you want to ask it of may well not be part of folios (they may be part of a slab or some other memdesc).