From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87CB4C3ABAC for ; Tue, 6 May 2025 15:47:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4555F6B000A; Tue, 6 May 2025 11:47:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4049B6B0082; Tue, 6 May 2025 11:47:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F2DF6B0085; Tue, 6 May 2025 11:47:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0FBD26B000A for ; Tue, 6 May 2025 11:47:00 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 046B059856 for ; Tue, 6 May 2025 15:47:00 +0000 (UTC) X-FDA: 83412911442.20.A780932 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf27.hostedemail.com (Postfix) with ESMTP id 7E2F940005 for ; Tue, 6 May 2025 15:46:58 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=m6jASJtV; dmarc=none; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746546419; a=rsa-sha256; cv=none; b=OmZbuh0exyUcu5M1mQRaiYt9e9BjQucdP9fHfIimnuu1poWIoKtQfod+hrjD3RVWQSxGig /Rz0QctNL/EfkSPQjbcaftNUcohD4wWgTxeGFE//ewGcJ8pKzLQioXQ8+dnkzrlLh9Z5w4 nOSRk/PGdEoAUH36x0FwZTHbZt8W16g= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=m6jASJtV; dmarc=none; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746546419; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3HBGcSU1ag8kdhmbzKBu+ZaOAcgBI9VSpgvysRkMghw=; b=GXNyQg5QHus1Lt8BFtb0GtL+PnrY33uxx538O2T8X0O4TMXXKvL1qoDcgYjpAFpnip3Z+M 7UC28vt+kgV1kmUqEzzIAqgtYP4wgdGbecLXfWexO1sxzv1cPafbvx6glAPqa8QGEJxL9e 5qsACZ1Y3gn6YAabFwPQVkEa5wS1PR8= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=3HBGcSU1ag8kdhmbzKBu+ZaOAcgBI9VSpgvysRkMghw=; b=m6jASJtVPwIQsM9PpXilPbY/Qf TN3LXuNIpar9SAPINGO84PBgldOKuGcrlb0WpiokVF6OIkI7d8CJ97uvNI1nnA/eo1tK9GRG+lu4J XSbzTDCqpjSkrHOORxGwihokgkUJobXOfX/LGD6AsJM7yTcKNstBGarYXkndhA91ApkyhhibF54F9 OkRiS1l0Nfu59uNlPnShs02k4DDVXiIBndejRjpjIqyt60BENfO+pUwaS6DQwNTGOXLiWfkaW/g+l xsdCX+zPqTE5gccXYIPa6pAR7nX2atuWGMcP40O9kXJdjF+oWbqECoe8Niya4ybs9JCEvKhKeIpQ8 nUEhEFvQ==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uCKVK-00000005RYW-3lJC; Tue, 06 May 2025 15:46:46 +0000 Date: Tue, 6 May 2025 16:46:46 +0100 From: Matthew Wilcox To: Dev Jain Cc: akpm@linux-foundation.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, pfalcato@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, david@redhat.com, peterx@redhat.com, ryan.roberts@arm.com, mingo@kernel.org, libang.li@antgroup.com, maobibo@loongson.cn, zhengqi.arch@bytedance.com, baohua@kernel.org, anshuman.khandual@arm.com, ioworker0@gmail.com, yang@os.amperecomputing.com Subject: Re: [PATCH 2/3] mm: Add generic helper to hint a large folio Message-ID: References: <20250506050056.59250-1-dev.jain@arm.com> <20250506050056.59250-3-dev.jain@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250506050056.59250-3-dev.jain@arm.com> X-Rspamd-Queue-Id: 7E2F940005 X-Stat-Signature: d8qwjcnfn7pw1yqcew71imcwgyw34cjo X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1746546418-944620 X-HE-Meta: U2FsdGVkX1/OxnHkSwtQS+b0LsDAe01yyxg4NP0u+WV68ceyMVH/XW/N1cENurcWnPmc6ZRy62pVoWH+4Gs/4q59Q5e/iF9lWMo4Dv5hKqLrXip8EJvi8EaYMBkGU9Ago/sN4u7nuPih8wuMpmLZ59kFnlm6mOoD1Zw9m9hGeukjF6MeoZu/VVPJOOPeOjemU9G1xDaVI+xHKBXSa757bX3gvY5qjJeQ6pfuV3+wGGRKsdabVk6beHq3WOq9xlQoLHoXYJ6U7ahrV4yXSb8iYwT+HyyNZgnYkUrlkGt72Gk9MDJGMqDU+hQLYmVHttLWX/gQoZ/9WsMegI0CQE9jscxvFlJ6iANcNVPayfmiUy71rzwLUuOE8QP/WvcKvl/gzOA9I3Ee3u7EDmEUE6efUjLOXu0W7AbkpDqGIQOh5dWiq7wIA1phQoDcnQuvItoz+Ugw4BcxxlIbgecM6AcAPIc7NEpl0osckq1zi8fafpPmCFXTKjmND0DQU5bd537JUVaO/bhTRESKw08PoV8rpsNDA1L4rD0bg2HIJsaLST1vp2J8goVn1jKhvnkWQPC52MAm72eMU7vRlA75JbG74i1N79R963wIaNYo2gGBHqIGx8FbzBGzcPsXJVdscJPrG4dBmVJ0HmLk9yQkoJB70TkEsBgkEVQkxJfGdQ/5Hzo6AjOE2fqAf9b3MHbeVnG67V86HX2KkcrpJm5wT2cqCICwOUXDp39JmJOKZpTLDlGzeOOgpwB3qjwLpu2JaszIvfz6NHE3BisRHIImVVYMgw1+KpiZtPdhViymFKikwRjPTzzUumDgrvtrbYjEhYceg1wC1KVzqnJHkR1B7N2q1dlQVluQ1q1up0VN/FiukU5fWvaLfxKQJcNJL0p35CVoWxNDLnmaCxKv8Vutm/JGOdXU0y/0uh+AT1tbfxXnyotSNXN1I0f1TDYawMQpfovQVihK1XQLwqX8oGTSCIN JFKOZY6h 8XwpMT/iuR0t0zFApb8g1i/HCAj2ZMn19Cnjk+tgJ+b2jo1zHVQsNzshuyqDfwfwFJT5hJz86B5s4bVvR85ywy0hd1XR0AHVvLUkJcHz4eey019TNZMTDNbb2wXad7qKw/8mRMwqF3E24lMRd1p2f8ogHYyZZOxi+mpkcL0a+ieyi5JlArmHh2UUOq5DVKn5IYGTmqVY5bVkIubQ3WdFRlrxPbtCyNUhhuIalkelS+nX0cJo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 06, 2025 at 10:30:55AM +0530, Dev Jain wrote: > + return unlikely(pte_pfn(next_pte) - pte_pfn(pte) == PAGE_SIZE); umm ... PFN is in units of PAGE_SIZE. Did you mean == 1?