From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EBC1C3ABBC for ; Tue, 6 May 2025 16:23:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 889346B000A; Tue, 6 May 2025 12:23:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8389A6B0082; Tue, 6 May 2025 12:23:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 727306B0085; Tue, 6 May 2025 12:23:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 58B546B000A for ; Tue, 6 May 2025 12:23:39 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 80001160438 for ; Tue, 6 May 2025 16:23:39 +0000 (UTC) X-FDA: 83413003758.25.96A072E Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf30.hostedemail.com (Postfix) with ESMTP id 7177980007 for ; Tue, 6 May 2025 16:23:34 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=CGcmUjZz; dmarc=none; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746548617; a=rsa-sha256; cv=none; b=PusixpQSp1K/qmTtqtCttL5Kf+2OW4rKYWr1hQSaON23ovrxOUCSyuOJD9kwuRkJbMtGIH Ql0VC7FlWYE05F7E6nhwLvLMKliXoCkglbauz8wfowBmdQdl+6N+CX2yeZqThrC9wdOCO7 d8KskMxE92Au+lgmX7dHdeoUJIykAHw= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=CGcmUjZz; dmarc=none; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746548617; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=btB7v32iOtkPnjE82G1pR3gHE5orNYbXznqK0OzF1Tk=; b=c72wwUEZ2o2aEoKcGDTVedCefDtkKIkdyOJmSDKZUOGt3Bw/pIw8Xb604m1OwYiUN706QE bIIMlcy66iLxQbNkD/N3fNl7JkuuGS052kajDYa31SMYCCMaEyIjLGyC6f+bAIPBk47dtZ Lrp0Du9+SGJeXRDIWDHgrK4ivQ2Tn8Q= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=btB7v32iOtkPnjE82G1pR3gHE5orNYbXznqK0OzF1Tk=; b=CGcmUjZz4iKAFYVIoj/eD2mJpL vvNG+xtJ1NIHDZLBjQXkDzN2K21pIJ/EeB5lM/IYnUEu/5+T+vcDY4+XvJ1gLD/uOcxOnF4tBdZ7J MhhM90EQ9VL7Y+cspNK6tvPc5KkdSU4P2yC3gBq6bCqXC1/z0XtjKUNQFbtXnopq3Oa5QnZMD8UI7 AlEMjBTVaHEJS4OQJuQv18tPsTMCtv4QKdz453+KSmAphCh647WUs8sRP3yeCDlniHGCOhBhH2/sr DnGc5vC89wAomqBPRFc7zuKPLpeN/zbRv6SW+cHZC31Sx1WD+b9uPGmujCrsZ1TLYif89mGqPw67C 056b79tg==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uCL4F-00000006KQn-1RbP; Tue, 06 May 2025 16:22:51 +0000 Date: Tue, 6 May 2025 17:22:51 +0100 From: Matthew Wilcox To: WangYuli Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, yuzhao@google.com, stevensd@chromium.org, kaleshsingh@google.com, zhanjun@uniontech.com, niecheng1@uniontech.com, guanwentao@uniontech.com Subject: Re: [PATCH] mm: vmscan: Avoid signedness error for GCC 5.4 Message-ID: References: <85050791B887DC13+20250506160238.799984-1-wangyuli@uniontech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <85050791B887DC13+20250506160238.799984-1-wangyuli@uniontech.com> X-Rspamd-Queue-Id: 7177980007 X-Stat-Signature: 3kk4aaz5qj33w9bsdobni813gbtom48o X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1746548614-665409 X-HE-Meta: U2FsdGVkX18/nI55k3/QIj4tqstAjRYKUNLjTFC2UKQHa4XflnEwb1sJzNlSDkJLg1tHL2RfHDeMLlJxQzT4Wbw/AslKoIDrl3Q39eeSuoCI4ZjDZh86lynQs3KM9M7JohyQghffh/opEhstH3F0J9vP7ThWl4Ca02tYt9ipEGoIHKQOOTrCxnUapuO+IO8ZurreeczibBrq61JTzKL81+L7gx91a2kCvWudJxrS2ZmPolTwLm0DM15KffQU3gcgThxYQHMCxBfY/Dd3TKcgGbsThQ/gx92cAJMgg9Ab6YgfpM2PFA6KRvdvf3TeD2ST5h6dzdhCAWKKY9EaO1XG1BLRhxiZbKhP06zHcc8tMoTbHCeUJpGo/NYmf8Dgc0xcCuLXxAOR8cevOu3LOQpAtUdtWmMEjHLfZ4cf+CQs1bvKT+bk/wEitCEpJp3Gf6HgqkTfPqOlJEkjLGCVzbDzqpKoueZCGP/46PU7r/B5QZEwsbxDjAxfuQiLHXjSDmQZfhAOTRsk4Y6VlXewI8Dg9uIfVK/ww0CXxC+DoKcsHYArxACWkMwbeeNZID2hL7v2wufQjJ8pHa9ZFoPFnBXA6cwoSeGHl+MOpz+mdp/B7wOxEz+MPdD2QgF6DehtbqqpduJorxctbFKumWh2Hb/fkJ9+wZYBXZ0ClaOcUPifDAfDFmRiO8/t3bDA63s26XoMq5DkiEYIEM2An4zRsW3Q8CpAep2q2oCmTchxr4Avz5+3xZt1uFT7ZHvCpF932JWNJa7NDKJ2PuJ1KbA+z9+Y1WjMa4mSiy8Qy/WOeF7Fx8acoRCu9sFQpzK/H0LBbffxt46QILw9jeWY3ofAY+KehVL19vFlTVWa4ZwWCMVMrXKy51Cf4u9hWy992izU+Gy7Ul3Q6uy5L77SVmqxKar9yUeUb0GJsdSbpiTN3pCCqq47cHsf7vs2vPh0ivqUOW1nwml4aQJoZLMsvv82v76 14q+le9a h+PT+wbhTEZGfOe4YY/nIgy2noLf7x6k5OHZLPvx3CrcP6MnFIqbG7dW0nF3c2uMjIiJKUcppEwR6h1BILrOHhstEYRwl16ItiApJpSGDUoGe5b8xAf9D55WnUycXsx7LdVRpxDDSek5xeG9ukojeSQvIcYqr5E0kWDT0tlJGfqQVV6RyHKG/d9D0FvdnYLhh3aMHtDUSP/2yVXL3VjEqO9Q2DArdzn4aXuHiCiD/4uu6LbBjuWITQ9lP1PY0Nq4fVosj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 07, 2025 at 12:02:38AM +0800, WangYuli wrote: > To the compiler, (MAX_NR_TIERS - 1) (i.e., (4U - 1)) is unsigned, > whereas tier is a signed integer. > > GCC 5.4 does not permit the minimum operation on such > type-inconsistent operands. 1. This has nothing to do with the compiler version; the type-checking is built into min(). 2. We have min_t for a reason 3. Why is a signed min the right answer instead of an unsigned min?