From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68BEBC3ABAA for ; Mon, 5 May 2025 19:55:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C73B26B008A; Mon, 5 May 2025 15:55:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BFB7B6B0095; Mon, 5 May 2025 15:55:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A9D5D6B0099; Mon, 5 May 2025 15:55:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8A8AB6B008A for ; Mon, 5 May 2025 15:55:48 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id BC7801A081F for ; Mon, 5 May 2025 19:55:48 +0000 (UTC) X-FDA: 83409909576.29.3B22EFF Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf27.hostedemail.com (Postfix) with ESMTP id 0A8A44000B for ; Mon, 5 May 2025 19:55:45 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=W4m1nZTj; dmarc=none; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746474947; a=rsa-sha256; cv=none; b=rTN7fwMnq0Q+Tfe+BQeVFrSBlVFMGd5zDm+xn/oDGiG8IFyS91qt5/XRG5Zago/R4bSPET aKx/SLikdWwcQC4j6oLRBf7+9Qy7ECKzv9jKlvY8t9sIs6eYf5Rw94kXCbK8vKukgAMbTO hGlW2BG7M/tCKATmsNxHrIKAK0k2edw= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=W4m1nZTj; dmarc=none; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746474947; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j2SQb8hZ6DGcQpl9C/t6T558dF/akXvjLFqV7DWs3n4=; b=iXZQKG2JO30q3Ls4rsVhuu7Apjt2zhGaD4LaziIu3uzSw2HqX247/FuhLPRDy9r9isK08H YYF8uPER5/7xrx6Sm623V9xCjCOWh2S4x1yb27/NYtC40b67f7TtLVXQER288HfX54DtM9 lEOU1FwRRR7ep7fDyFtvwLTdce0k7j8= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=j2SQb8hZ6DGcQpl9C/t6T558dF/akXvjLFqV7DWs3n4=; b=W4m1nZTjTijhwcW+7mKbAmy8Lq bEbGdVTnv5ReeahvpTxU/dnh2ZodkVkQC5l/onTpn7LL8rgDkDgsdCJzuhFEydPNc5rvKm10pZKZr 5D9PK+M9WaCL1CZzAZYlLyOKY/Ism0gYyj+YtN9LT9IocgPPSiLrVi8sySHu9nsEyo7DHVfXDKfDm WGL8v6BOttamPOIkvFg+PLB4o+yWi7Kukrk53OXS0jXEApz6KMpiZHrbgLveXtexrnPSW6/6+INDp U/wa5krBqIdxXrwNBKpEnLEGama4gyoQOjFajZuWBZPxDRVv/llB6NtH/z/zFVyx4pYmdudUEvcyx rQvFjHxw==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uC1ue-0000000Gwtg-33nY; Mon, 05 May 2025 19:55:40 +0000 Date: Mon, 5 May 2025 20:55:40 +0100 From: Matthew Wilcox To: Juan Yescas Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, tjmercier@google.com, isaacmanjarres@google.com, surenb@google.com, kaleshsingh@google.com, Vlastimil Babka , "Liam R. Howlett" , Lorenzo Stoakes , David Hildenbrand , Mike Rapoport , Zi Yan , Minchan Kim Subject: Re: [PATCH v2] mm: Add ARCH_FORCE_PAGE_BLOCK_ORDER to select page block order Message-ID: References: <20250505185642.2377724-1-jyescas@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250505185642.2377724-1-jyescas@google.com> X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 0A8A44000B X-Stat-Signature: 4djh1m9c9t94nbcud41fw95qzjwbrt4w X-Rspam-User: X-HE-Tag: 1746474945-736279 X-HE-Meta: U2FsdGVkX1+CwW2g4HtsvLS9VFvkDipD0HVA156j81t+hLljYg4EdYe9+FvFS2pfFOHxwN6oZo1/qWkix6Tq01yF0wjSnMfjreJ25+np6v5KEuLLQJPEdY5fqXZjYsSP2M8ljwq9jKhZiiFabSQXDIP5bgBAl938wMleiHZ8w2rgeCOgdsRkxxVat/WPCe5C9N0y/r2IYDFBJljWeB0LchXwlvG/W2kBcWTTTntJ9UT7eb/ZNJaHLyadTTn0vO2UPKLv716Xj4h18gbTUXX7UQ5sPpscwqGm0egeuPUPOufp/FU4jTH+nofS2MMJGs9bPj08IikG2Fb9sNjGaFxrWj/GaLSoZ/retSalwpH1UMl61b0HGVUVMI82dORMNoyOpLT3kQFGu8zZVaB1MUb0Z9fbsEYj5aKJJ5pBsjadOmoCH2MzSEJrdUgDFBrQmFdhUPBoFtVMh5IAC44Pv8zlWfyirRcCicVLNVto5isd2xV/9xj7mmuITnjMb5Ui6RCU5lLO9eCcvp0xVsV+abTdoZrwQgdZXD9suhJrN0qGf1yE2OWVxXjVgLtyNnm2DUw1Oqv2CJSlu67Ph+5f4PhvTAsWjpx/B37B3FFrzn0nSp8NMMF9/Pw8WoWg+s3C7ZlakHyMJHVdMbG42G1gD8rIXq8JeNEEeRLkbFYJjXyfB5KXacODOGEz3u8lMhH9pGxufxcnkHq6g6mQVd59Vi+D54UfX30FiPUBiDecpKVU+qozxOkR0bKcGENI314UuRf1HaWkv+v0DCMRFoYANDJ/cw/gBPwXiXGu6RDo4YEcLkdgLzNn4iuT4lkt0jctikq50ELrGKQWvfRBA7EXXQCvdb3F0gNiBjcUtlQdpGDuqsN/PyasbNQ0AyVrsD3i7uEKxK/WrXwztguD9YsCticM79GolWZ6HMYxzEVYN+RddkKPqc+XJrfPOe5EfdOhaI4Z+FIQozi0Ea4Kb+bMNBe MuVEEme5 f8wPGjNRI03EgT86HhASXpz5P8GS5WVKYWWuARghWkTscM5bFxJJLy60/aT07bw2q1F/cWBXKKRdZzbRxpRARAiUFsc21tV0q9UFgDSUOoMnuu5hgUYtsQjZF7gv93QaUAX2W52Riik507DZxUU7NjLc5DMgPRszPaAav+2VO2PkV+dJFksScRGE1XjUHwyImKWoMWyEoBamM1KIaKl1lg/s8xlUqe0QrwWooDotwu1Z/1q5cmo1nhe4k2wFCFrhGetaiELZvbXO/qTEcuMpG2Aeoog== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, May 05, 2025 at 11:56:21AM -0700, Juan Yescas wrote: > Solution: Add a new config ARCH_FORCE_PAGE_BLOCK_ORDER that > allows to set the page block order in all the architectures. ... but it's no longer per-ARCH, so this should not be in the ARCH_ namespace. > /* If huge pages are not used, group by MAX_ORDER_NR_PAGES */ > -#define pageblock_order MAX_PAGE_ORDER > +#define pageblock_order PAGE_BLOCK_ORDER You need to update the comment too.